|
»
»
Review Request: Add support for X- parameters in ICal entries
|
View:
New views
12 Messages
—
Rating Filter:
Alert me
|
 |
Review Request: Add support for X- parameters in ICal entries
by Grégory Oestreicher
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/ ----------------------------------------------------------- Review request for KDE PIM. Summary ------- This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. Diffs ----- /trunk/KDE/kdepimlibs/kcal/attendee.h 1046353 /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046353 /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046353 Diff: http://reviewboard.kde.org/r/2093/diff Testing ------- Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. Thanks, Grégory _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Bugzilla from djarvie@kde.org
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/#review2987 ----------------------------------------------------------- Couldn't this be done as in other libkcal classes, by deriving from CustomProperties? IncidenceBase, Alarm and Calendar classes all handle X- properties this way - it would be better to follow the same method for consistency, unless there's a good reason to do it some other way. - David On 2009-11-08 13:24:04, Grégory Oestreicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2093/ > ----------------------------------------------------------- > > (Updated 2009-11-08 13:24:04) > > > Review request for KDE PIM. > > > Summary > ------- > > This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. > These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. > > > Diffs > ----- > > /trunk/KDE/kdepimlibs/kcal/attendee.h 1046353 > /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046353 > /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046353 > > Diff: http://reviewboard.kde.org/r/2093/diff > > > Testing > ------- > > Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. > > > Thanks, > > Grégory > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Bugzilla from kevin.krammer@gmx.at
::
Rate this Message:
> On 2009-11-08 22:36:19, David Jarvie wrote: > > Couldn't this be done as in other libkcal classes, by deriving from CustomProperties? IncidenceBase, Alarm and Calendar classes all handle X- properties this way - it would be better to follow the same method for consistency, unless there's a good reason to do it some other way. Can't change the inheritance hierachy during KDE4 (BIC). Also, I am not sure the inheritance is good style, looks like convenience inheritance to me (not really an is-a relationship). For KDE5 we might want to have CustomProperties as composition, which would also get rid of the @warning on assignment and equality operator - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/#review2987 ----------------------------------------------------------- On 2009-11-08 13:24:04, Grégory Oestreicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2093/ > ----------------------------------------------------------- > > (Updated 2009-11-08 13:24:04) > > > Review request for KDE PIM. > > > Summary > ------- > > This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. > These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. > > > Diffs > ----- > > /trunk/KDE/kdepimlibs/kcal/attendee.h 1046353 > /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046353 > /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046353 > > Diff: http://reviewboard.kde.org/r/2093/diff > > > Testing > ------- > > Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. > > > Thanks, > > Grégory > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Bugzilla from djarvie@kde.org
::
Rate this Message:
> On 2009-11-08 22:36:19, David Jarvie wrote: > > Couldn't this be done as in other libkcal classes, by deriving from CustomProperties? IncidenceBase, Alarm and Calendar classes all handle X- properties this way - it would be better to follow the same method for consistency, unless there's a good reason to do it some other way. > > Kevin Krammer wrote: > Can't change the inheritance hierachy during KDE4 (BIC). > > Also, I am not sure the inheritance is good style, looks like convenience inheritance to me (not really an is-a relationship). > For KDE5 we might want to have CustomProperties as composition, which would also get rid of the @warning on assignment and equality operator Of course, you're right about BIC. Perhaps it would be a good idea, rather than implementing code specific to the Attendee class, to create a new generic way to do this. In KDE4, this can only be used for Attendee, but would replace CustomProperties for IncidenceBase, Alarm and Calendar in KDE5. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/#review2987 ----------------------------------------------------------- On 2009-11-08 13:24:04, Grégory Oestreicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2093/ > ----------------------------------------------------------- > > (Updated 2009-11-08 13:24:04) > > > Review request for KDE PIM. > > > Summary > ------- > > This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. > These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. > > > Diffs > ----- > > /trunk/KDE/kdepimlibs/kcal/attendee.h 1046353 > /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046353 > /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046353 > > Diff: http://reviewboard.kde.org/r/2093/diff > > > Testing > ------- > > Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. > > > Thanks, > > Grégory > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Bugzilla from kevin.krammer@gmx.at
::
Rate this Message:
> On 2009-11-08 22:36:19, David Jarvie wrote: > > Couldn't this be done as in other libkcal classes, by deriving from CustomProperties? IncidenceBase, Alarm and Calendar classes all handle X- properties this way - it would be better to follow the same method for consistency, unless there's a good reason to do it some other way. > > Kevin Krammer wrote: > Can't change the inheritance hierachy during KDE4 (BIC). > > Also, I am not sure the inheritance is good style, looks like convenience inheritance to me (not really an is-a relationship). > For KDE5 we might want to have CustomProperties as composition, which would also get rid of the @warning on assignment and equality operator > > David Jarvie wrote: > Of course, you're right about BIC. > > Perhaps it would be a good idea, rather than implementing code specific to the Attendee class, to create a new generic way to do this. In KDE4, this can only be used for Attendee, but would replace CustomProperties for IncidenceBase, Alarm and Calendar in KDE5. KABC probably has similar needs as well, i.e. for VCard custom properties. Probably something like ExtensionAttributes, with a change observer instead of the virtual method. Hmm, I wonder whether this could be done in KDE4 and CustomProperties internally "rebased" - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/#review2987 ----------------------------------------------------------- On 2009-11-08 13:24:04, Grégory Oestreicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2093/ > ----------------------------------------------------------- > > (Updated 2009-11-08 13:24:04) > > > Review request for KDE PIM. > > > Summary > ------- > > This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. > These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. > > > Diffs > ----- > > /trunk/KDE/kdepimlibs/kcal/attendee.h 1046353 > /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046353 > /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046353 > > Diff: http://reviewboard.kde.org/r/2093/diff > > > Testing > ------- > > Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. > > > Thanks, > > Grégory > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Grégory Oestreicher
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/ ----------------------------------------------------------- (Updated 2009-11-09 19:30:31.216849) Review request for KDE PIM. Changes ------- Uploaded a new patch that uses CustomProperties in Attendee::Private. Summary ------- This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. Diffs (updated) ----- /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046599 /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046599 /trunk/KDE/kdepimlibs/kcal/attendee.h 1046599 Diff: http://reviewboard.kde.org/r/2093/diff Testing ------- Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. Thanks, Grégory _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Bugzilla from winter@kde.org
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/#review2993 ----------------------------------------------------------- Ship it! much nicer. please make the few minor changes I noted and then feel free to commit it /trunk/KDE/kdepimlibs/kcal/attendee.h <http://reviewboard.kde.org/r/2093/#comment2443> @since 4.4 /trunk/KDE/kdepimlibs/kcal/attendee.h <http://reviewboard.kde.org/r/2093/#comment2444> @since 4.4 /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp <http://reviewboard.kde.org/r/2093/#comment2445> move the else up 1 line with the closing if-brace - Allen On 2009-11-09 19:30:31, Grégory Oestreicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2093/ > ----------------------------------------------------------- > > (Updated 2009-11-09 19:30:31) > > > Review request for KDE PIM. > > > Summary > ------- > > This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. > These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. > > > Diffs > ----- > > /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046599 > /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046599 > /trunk/KDE/kdepimlibs/kcal/attendee.h 1046599 > > Diff: http://reviewboard.kde.org/r/2093/diff > > > Testing > ------- > > Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. > > > Thanks, > > Grégory > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Grégory Oestreicher
::
Rate this Message:
> On 2009-11-09 21:45:48, Allen Winter wrote: > > much nicer. please make the few minor changes I noted and then feel free to commit it Thanks, committed with the modifications. - Grégory ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/#review2993 ----------------------------------------------------------- On 2009-11-09 19:30:31, Grégory Oestreicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2093/ > ----------------------------------------------------------- > > (Updated 2009-11-09 19:30:31) > > > Review request for KDE PIM. > > > Summary > ------- > > This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. > These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. > > > Diffs > ----- > > /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046599 > /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046599 > /trunk/KDE/kdepimlibs/kcal/attendee.h 1046599 > > Diff: http://reviewboard.kde.org/r/2093/diff > > > Testing > ------- > > Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. > > > Thanks, > > Grégory > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Bugzilla from kevin.krammer@gmx.at
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/#review3000 ----------------------------------------------------------- /trunk/KDE/kdepimlibs/kcal/attendee.h <http://reviewboard.kde.org/r/2093/#comment2449> A const variant might be nice for code that gets a const Attendee& and just wants read access to the custom properties /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp <http://reviewboard.kde.org/r/2093/#comment2450> should be a const QMap<QByteArray, QString> or using constBegin() constEnd() in the for loop to avoid detaching of implicitly shared data see ICalFormatImpl::Private::writeCustomProperties in the same file - Kevin On 2009-11-09 19:30:31, Grégory Oestreicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2093/ > ----------------------------------------------------------- > > (Updated 2009-11-09 19:30:31) > > > Review request for KDE PIM. > > > Summary > ------- > > This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. > These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. > > > Diffs > ----- > > /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046599 > /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046599 > /trunk/KDE/kdepimlibs/kcal/attendee.h 1046599 > > Diff: http://reviewboard.kde.org/r/2093/diff > > > Testing > ------- > > Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. > > > Thanks, > > Grégory > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Grégory Oestreicher
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/ ----------------------------------------------------------- (Updated 2009-11-10 19:18:24.630923) Review request for KDE PIM. Changes ------- A new diff (that doesn't include the first one) that takes into account the latest remarks. Summary ------- This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. Diffs (updated) ----- /trunk/KDE/kdepimlibs/kcal/attendee.h 1046889 /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046889 /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046889 Diff: http://reviewboard.kde.org/r/2093/diff Testing ------- Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. Thanks, Grégory _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Bugzilla from djarvie@kde.org
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/#review3073 ----------------------------------------------------------- Ship it! - David On 2009-11-10 19:18:24, Grégory Oestreicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2093/ > ----------------------------------------------------------- > > (Updated 2009-11-10 19:18:24) > > > Review request for KDE PIM. > > > Summary > ------- > > This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. > These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. > > > Diffs > ----- > > /trunk/KDE/kdepimlibs/kcal/attendee.h 1046889 > /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046889 > /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046889 > > Diff: http://reviewboard.kde.org/r/2093/diff > > > Testing > ------- > > Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. > > > Thanks, > > Grégory > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: Add support for X- parameters in ICal entries
by Grégory Oestreicher
::
Rate this Message:
> On 2009-11-12 23:34:45, David Jarvie wrote: > > Thanks, committed - Grégory ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2093/#review3073 ----------------------------------------------------------- On 2009-11-10 19:18:24, Grégory Oestreicher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2093/ > ----------------------------------------------------------- > > (Updated 2009-11-10 19:18:24) > > > Review request for KDE PIM. > > > Summary > ------- > > This patch adds support to load and save X- parameters for ICal as defined in RFC2445, §4.8.8.1. > These parameters are not processed by KCal and should be loaded and saved as-is, without further processing. > > > Diffs > ----- > > /trunk/KDE/kdepimlibs/kcal/attendee.h 1046889 > /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046889 > /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046889 > > Diff: http://reviewboard.kde.org/r/2093/diff > > > Testing > ------- > > Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved when saving the entry. > > > Thanks, > > Grégory > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
| Free embeddable forum powered by Nabble | Forum Help |
