|
»
Review Request: Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings
|
View:
New views
7 Messages
—
Rating Filter:
Alert me
|
 |
Review Request: Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings
by Bugzilla from michel.ludwig@kdemail.net
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2137/ ----------------------------------------------------------- Review request for Kate. Summary ------- Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings. As Kile saves specific session values on its own already, undesired interference can occur from the SessionConfigInterface. An extended interface is hence proposed which allows for more fine-grained control over the settings that are to be saved or restored. Diffs ----- /trunk/KDE/kdelibs/kate/document/katedocument.h 1047570 /trunk/KDE/kdelibs/kate/document/katedocument.cpp 1047570 /trunk/KDE/kdelibs/includes/KTextEditor/SessionConfigInterface2 PRE-CREATION /trunk/KDE/kdelibs/interfaces/ktexteditor/ktexteditor.cpp 1047570 /trunk/KDE/kdelibs/interfaces/ktexteditor/sessionconfiginterface.h 1047570 /trunk/KDE/kdelibs/includes/CMakeLists.txt 1047570 Diff: http://reviewboard.kde.org/r/2137/diff Testing ------- Thanks, Michel _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: Review Request: Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings
by Bugzilla from ehamberg@gmail.com
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2137/#review3057 ----------------------------------------------------------- could you come up with a better name? anything is more descriptive than "foo2". :P - Erlend On 2009-11-11 17:47:21, Michel Ludwig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2137/ > ----------------------------------------------------------- > > (Updated 2009-11-11 17:47:21) > > > Review request for Kate. > > > Summary > ------- > > Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings. > > As Kile saves specific session values on its own already, undesired interference can occur from the SessionConfigInterface. An extended interface is hence proposed which allows for more fine-grained control over the settings that are to be saved or restored. > > > Diffs > ----- > > /trunk/KDE/kdelibs/kate/document/katedocument.h 1047570 > /trunk/KDE/kdelibs/kate/document/katedocument.cpp 1047570 > /trunk/KDE/kdelibs/includes/KTextEditor/SessionConfigInterface2 PRE-CREATION > /trunk/KDE/kdelibs/interfaces/ktexteditor/ktexteditor.cpp 1047570 > /trunk/KDE/kdelibs/interfaces/ktexteditor/sessionconfiginterface.h 1047570 > /trunk/KDE/kdelibs/includes/CMakeLists.txt 1047570 > > Diff: http://reviewboard.kde.org/r/2137/diff > > > Testing > ------- > > > Thanks, > > Michel > > _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: Review Request: Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings
by Bugzilla from michel.ludwig@kdemail.net
::
Rate this Message:
> On 2009-11-12 18:17:41, Erlend Hamberg wrote: > > could you come up with a better name? anything is more descriptive than "foo2". :P Being an extension of "SessionConfigInterface", its name is in line with "CodeCompletionModel2" or "CodeCompletionModelControllerInterface2". It should also be a strong indication that it might be a good idea to merge the new methods with the old ones for KDE5. But if someone should have a naming suggestion, I'm all ears! :-) - Michel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2137/#review3057 ----------------------------------------------------------- On 2009-11-11 17:47:21, Michel Ludwig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2137/ > ----------------------------------------------------------- > > (Updated 2009-11-11 17:47:21) > > > Review request for Kate. > > > Summary > ------- > > Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings. > > As Kile saves specific session values on its own already, undesired interference can occur from the SessionConfigInterface. An extended interface is hence proposed which allows for more fine-grained control over the settings that are to be saved or restored. > > > Diffs > ----- > > /trunk/KDE/kdelibs/kate/document/katedocument.h 1047570 > /trunk/KDE/kdelibs/kate/document/katedocument.cpp 1047570 > /trunk/KDE/kdelibs/includes/KTextEditor/SessionConfigInterface2 PRE-CREATION > /trunk/KDE/kdelibs/interfaces/ktexteditor/ktexteditor.cpp 1047570 > /trunk/KDE/kdelibs/interfaces/ktexteditor/sessionconfiginterface.h 1047570 > /trunk/KDE/kdelibs/includes/CMakeLists.txt 1047570 > > Diff: http://reviewboard.kde.org/r/2137/diff > > > Testing > ------- > > > Thanks, > > Michel > > _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: Review Request: Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings
by Dominik Haumann-2
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2137/#review3071 ----------------------------------------------------------- /trunk/KDE/kdelibs/interfaces/ktexteditor/sessionconfiginterface.h <http://reviewboard.kde.org/r/2137/#comment2507> can be removed, as it is already in the SessionConfigInterface. /trunk/KDE/kdelibs/kate/document/katedocument.h <http://reviewboard.kde.org/r/2137/#comment2506> mh, now a qobject_cast<KTE::SessionConfigInterface>(doc) will fail, or? /trunk/KDE/kdelibs/kate/document/katedocument.cpp <http://reviewboard.kde.org/r/2137/#comment2508> i have no idea about the completed stuff. cullmann? - Dominik On 2009-11-11 17:47:21, Michel Ludwig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2137/ > ----------------------------------------------------------- > > (Updated 2009-11-11 17:47:21) > > > Review request for Kate. > > > Summary > ------- > > Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings. > > As Kile saves specific session values on its own already, undesired interference can occur from the SessionConfigInterface. An extended interface is hence proposed which allows for more fine-grained control over the settings that are to be saved or restored. > > > Diffs > ----- > > /trunk/KDE/kdelibs/kate/document/katedocument.h 1047570 > /trunk/KDE/kdelibs/kate/document/katedocument.cpp 1047570 > /trunk/KDE/kdelibs/includes/KTextEditor/SessionConfigInterface2 PRE-CREATION > /trunk/KDE/kdelibs/interfaces/ktexteditor/ktexteditor.cpp 1047570 > /trunk/KDE/kdelibs/interfaces/ktexteditor/sessionconfiginterface.h 1047570 > /trunk/KDE/kdelibs/includes/CMakeLists.txt 1047570 > > Diff: http://reviewboard.kde.org/r/2137/diff > > > Testing > ------- > > > Thanks, > > Michel > > _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: Review Request: Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings
by Bugzilla from michel.ludwig@kdemail.net
::
Rate this Message:
> On 2009-11-12 22:43:36, Dominik Haumann wrote: > > /trunk/KDE/kdelibs/interfaces/ktexteditor/sessionconfiginterface.h, line 191 > > <http://reviewboard.kde.org/r/2137/diff/1/?file=14350#file14350line191> > > > > can be removed, as it is already in the SessionConfigInterface. Actually, this is necessary as therwise the compiler will warn about hidden methods. > On 2009-11-12 22:43:36, Dominik Haumann wrote: > > /trunk/KDE/kdelibs/kate/document/katedocument.h, line 72 > > <http://reviewboard.kde.org/r/2137/diff/1/?file=14351#file14351line72> > > > > mh, now a qobject_cast<KTE::SessionConfigInterface>(doc) will fail, or? I've just tried it out, and, yes, "qobject_cast" fails to recognise that "SessionConfigInterface2" derives from "SessionConfigInterface". Don't tell it to anyone but Qt can sometimes be very annoying! ;-) And, judging from the documentation of "qobject_cast", the use case of converting documents to interfaces seems to fall within unspecified behaviour as none of the interfaces derives from "QObject": http://doc.trolltech.com/4.5/qobject.html#qobject_cast So, I guess the only way to save this is to use different names for everything... - Michel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2137/#review3071 ----------------------------------------------------------- On 2009-11-11 17:47:21, Michel Ludwig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2137/ > ----------------------------------------------------------- > > (Updated 2009-11-11 17:47:21) > > > Review request for Kate. > > > Summary > ------- > > Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings. > > As Kile saves specific session values on its own already, undesired interference can occur from the SessionConfigInterface. An extended interface is hence proposed which allows for more fine-grained control over the settings that are to be saved or restored. > > > Diffs > ----- > > /trunk/KDE/kdelibs/kate/document/katedocument.h 1047570 > /trunk/KDE/kdelibs/kate/document/katedocument.cpp 1047570 > /trunk/KDE/kdelibs/includes/KTextEditor/SessionConfigInterface2 PRE-CREATION > /trunk/KDE/kdelibs/interfaces/ktexteditor/ktexteditor.cpp 1047570 > /trunk/KDE/kdelibs/interfaces/ktexteditor/sessionconfiginterface.h 1047570 > /trunk/KDE/kdelibs/includes/CMakeLists.txt 1047570 > > Diff: http://reviewboard.kde.org/r/2137/diff > > > Testing > ------- > > > Thanks, > > Michel > > _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: Review Request: Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings
by Bugzilla from michel.ludwig@kdemail.net
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2137/ ----------------------------------------------------------- (Updated 2009-11-13 16:36:35.844674) Review request for Kate. Changes ------- Renamed the interface to "ParameterizedSessionConfigInterface" and the methods to "read/writeParameterizedSessionConfig" in order to keep them separately from "SessionConfigInterface". Summary ------- Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings. As Kile saves specific session values on its own already, undesired interference can occur from the SessionConfigInterface. An extended interface is hence proposed which allows for more fine-grained control over the settings that are to be saved or restored. Diffs (updated) ----- /trunk/KDE/kdelibs/includes/CMakeLists.txt 1048480 /trunk/KDE/kdelibs/interfaces/ktexteditor/ktexteditor.cpp 1048480 /trunk/KDE/kdelibs/interfaces/ktexteditor/sessionconfiginterface.h 1048480 /trunk/KDE/kdelibs/kate/document/katedocument.h 1048480 /trunk/KDE/kdelibs/kate/document/katedocument.cpp 1048480 Diff: http://reviewboard.kde.org/r/2137/diff Testing ------- Thanks, Michel _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
|
|
Re: Review Request: Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings
by Bugzilla from cullmann@kde.org
::
Rate this Message:
> On 2009-11-12 22:43:36, Dominik Haumann wrote: > > /trunk/KDE/kdelibs/kate/document/katedocument.cpp, line 1698 > > <http://reviewboard.kde.org/r/2137/diff/1/?file=14352#file14352line1698> > > > > i have no idea about the completed stuff. cullmann? I guess it could be ok, as no job is triggered here, too. And it would have been emitted there anyways. If we can move that to function end I don't know. Otherwise, looks ok for me, the problem with the qobject_cast is fixed I see. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2137/#review3071 ----------------------------------------------------------- On 2009-11-13 16:36:35, Michel Ludwig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2137/ > ----------------------------------------------------------- > > (Updated 2009-11-13 16:36:35) > > > Review request for Kate. > > > Summary > ------- > > Add the document extension interface 'SessionConfigInterface2' which allows for more fine-grained control over the manipulated settings. > > As Kile saves specific session values on its own already, undesired interference can occur from the SessionConfigInterface. An extended interface is hence proposed which allows for more fine-grained control over the settings that are to be saved or restored. > > > Diffs > ----- > > /trunk/KDE/kdelibs/includes/CMakeLists.txt 1048480 > /trunk/KDE/kdelibs/interfaces/ktexteditor/ktexteditor.cpp 1048480 > /trunk/KDE/kdelibs/interfaces/ktexteditor/sessionconfiginterface.h 1048480 > /trunk/KDE/kdelibs/kate/document/katedocument.h 1048480 > /trunk/KDE/kdelibs/kate/document/katedocument.cpp 1048480 > > Diff: http://reviewboard.kde.org/r/2137/diff > > > Testing > ------- > > > Thanks, > > Michel > > _______________________________________________ KWrite-Devel mailing list KWrite-Devel@... https://mail.kde.org/mailman/listinfo/kwrite-devel |
| Free embeddable forum powered by Nabble | Forum Help |
