Review Request: Fix Qt-4.6 regressions in Konquest

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2079/
-----------------------------------------------------------

Review request for KDE Games.


Summary
-------

This patch fixes the following regressions which I discovered when running Konquest with 4.6:

1. Calling QGS::width() or QGS::height() from some QGraphicsItem::boundingRect() reimplementation will cause an endless loop.
This happens because QGS::width() calls QGS::itemsBoundingRect() which again calls QGraphicsItem::boudnignRect() => voila :)
Solution: cache scene width and height in local variables.

2. Somehow having QGV with enabled CacheBackground flag causes the background to be drawn as a black pixmap.
I didn't find the proper solution yet, but I think it makes sense to commit the temporary solution until the bug will be isolated and fixed.
I'm not even sure if this is a Qt bug or Konquest one.


Diffs
-----

  trunk/KDE/kdegames/konquest/mapscene.h 978893
  trunk/KDE/kdegames/konquest/mapscene.cc 978893
  trunk/KDE/kdegames/konquest/mapview.cc 978893

Diff: http://reviewboard.kde.org/r/2079/diff


Testing
-------

Locally tested - Konquest doesn't crash at startup with Qt-4.6 and displays background correctly


Thanks,

Dmitry

_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

[Pierre Ducroquet]

On Thursday 05 November 2009 16:47:28 Dmitry Suzdalev wrote:

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2079/
> -----------------------------------------------------------
>
> Review request for KDE Games.
>
>
> Summary
> -------
>
> This patch fixes the following regressions which I discovered when running
>  Konquest with 4.6:
>
> 1. Calling QGS::width() or QGS::height() from some
>  QGraphicsItem::boundingRect() reimplementation will cause an endless loop.
>  This happens because QGS::width() calls QGS::itemsBoundingRect() which
>  again calls QGraphicsItem::boudnignRect() => voila :) Solution: cache
>  scene width and height in local variables.

I think you broke resizing of the window… I'm gonna check.

_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

[Pierre Ducroquet]

On Thursday 05 November 2009 21:46:24 Pierre wrote:

> On Thursday 05 November 2009 16:47:28 Dmitry Suzdalev wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/2079/
> > -----------------------------------------------------------
> >
> > Review request for KDE Games.
> >
> >
> > Summary
> > -------
> >
> > This patch fixes the following regressions which I discovered when
> > running Konquest with 4.6:
> >
> > 1. Calling QGS::width() or QGS::height() from some
> >  QGraphicsItem::boundingRect() reimplementation will cause an endless
> > loop. This happens because QGS::width() calls QGS::itemsBoundingRect()
> > which again calls QGraphicsItem::boudnignRect() => voila :) Solution:
> > cache scene width and height in local variables.
>
> I think you broke resizing of the window… I'm gonna check.
>

OOps, sorry, I should have read more carefully.

For me, it's ok to commit.


_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

On Thursday 05 November 2009 23:51:29 Pierre wrote:
> OOps, sorry, I should have read more carefully.
> For me, it's ok to commit.

Yeah, I just was typing the reply that I checked that and it worked ok :)

I'll double check before commit though.

Dmitry.
_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2079/
-----------------------------------------------------------

(Updated 2009-11-05 22:24:12.388708)


Review request for KDE Games.


Summary (updated)
-------

This patch fixes the following regressions which I discovered when running Konquest with 4.6:

1. Calling QGS::width() or QGS::height() from some QGraphicsItem::boundingRect() reimplementation will cause an endless loop.
This happens because QGS::width() calls QGS::itemsBoundingRect() which again calls QGraphicsItem::boudnignRect() => voila :)
Solution: cache scene width and height in local variables.

2. Somehow having QGV with enabled CacheBackground flag causes the background to be drawn as a black pixmap.
Use a workaround found by Parker for that.


Diffs (updated)
-----

  trunk/KDE/kdegames/konquest/mapscene.h 978893
  trunk/KDE/kdegames/konquest/mapscene.cc 978893
  trunk/KDE/kdegames/konquest/mapview.cc 978893

Diff: http://reviewboard.kde.org/r/2079/diff


Testing
-------

Locally tested - Konquest doesn't crash at startup with Qt-4.6 and displays background correctly


Thanks,

Dmitry

_______________________________________________
kde-games-devel mailing list
kde-games-devel@...
https://mail.kde.org/mailman/listinfo/kde-games-devel