Forwarded this from a reviewboard post i made (maybe kaffeine should have a
group?):
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
>
http://reviewboard.kde.org/r/1263/> -----------------------------------------------------------
>
> Review request for Travis McHenry.
>
>
> Summary
> -------
>
> This fixes the 5 krazy2 issues found on EBN in kaffeine.
>
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/kaffeine/
> Four of them are to avoid crashing with the dialogs (discussed here:
>
http://www.kdedevelopers.org/node/3919 ) and the last one is to add the
> Q_OBJECT macro to dvbdevice_linux.h
>
> I'm putting it up here instead of committing it because I don't want to
> step on anybody's toes. :)
>
> I put just myself as the reviewer because there isn't a kaffeine group and
> I didn't want to send it to the wrong people. :-/ I'll be forwarding
> whatever mail I get to kaffeine-devel.
>
>
> Diffs
> -----
>
> /trunk/extragear/multimedia/kaffeine/src/dvb/dvbchannelui.cpp 1009874
> /trunk/extragear/multimedia/kaffeine/src/dvb/dvbdevice_linux.h 1009874
> /trunk/extragear/multimedia/kaffeine/src/dvb/dvbrecording.cpp 1009874
> /trunk/extragear/multimedia/kaffeine/src/mediawidget.cpp 1009874
>
> Diff:
http://reviewboard.kde.org/r/1263/diff>
>
> Testing
> -------
>
> It builds and I tested what dialogs I could. I'm not sure how to get to all
> of them without having a dvb setup.
>
>
> Thanks,
>
> Travis
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.
http://p.sf.net/sfu/bobj-july_______________________________________________
kaffeine-devel mailing list
kaffeine-devel@...
https://lists.sourceforge.net/lists/listinfo/kaffeine-devel
