Review Request: KMail: Clicking the HTML status bar switches display mode

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.


Diffs
-----

  /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445
  /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445
  /trunk/KDE/kdepim/kmail/kmail_part.rc 1042445
  /trunk/KDE/kdepim/kmail/kmmainwin.rc 1042445
  /trunk/KDE/kdepim/kmail/kmreadermainwin.rc 1042445
  /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445
  /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445

Diff: http://reviewboard.kde.org/r/2017/diff


Testing
-------


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review2869
-----------------------------------------------------------


Thanks for the patch.
Two things: First, I think the action should be disabled if the current mail is not a HTML mail, as the action isn't useful for plaintext-only mails.
Secondly, I am not sure if the actions should be added to the menu, there is so much stuff in it, already.
I also think that maybe showing a tooltip for the HTML status bar that says that clicking it changes the mode would be nice.


/trunk/KDE/kdepim/kmail/htmlstatusbar.h
<http://reviewboard.kde.org/r/2017/#comment2249>

    reimplemented protected methods are usually put in the protected section, not private.



/trunk/KDE/kdepim/kmail/htmlstatusbar.cpp
<http://reviewboard.kde.org/r/2017/#comment2248>

    put the opening { bracket in a new line


- Thomas


On 2009-10-29 20:55:10, James Bendig wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
>
> (Updated 2009-10-29 20:55:10)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445
>   /trunk/KDE/kdepim/kmail/kmail_part.rc 1042445
>   /trunk/KDE/kdepim/kmail/kmmainwin.rc 1042445
>   /trunk/KDE/kdepim/kmail/kmreadermainwin.rc 1042445
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445
>
> Diff: http://reviewboard.kde.org/r/2017/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> James
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/
-----------------------------------------------------------

(Updated 2009-10-30 19:09:31.643228)


Review request for KDE PIM.


Changes
-------

Fixed code formatting.
Removed "HTML Display Mode" toggle action from menus.
Changed HTML Display Mode toggle action to only work on HTML and multipart/alternative messages.
Added tooltip to HTML status bar when HTML or multipart/alternative message is being viewed that says it can be clicked to toggle between HTML and plain text.
Added two new states to HTML status bar: multipart/alternative message viewed as HTML and multipart/alternative message viewed as plain text.


The text for the two new HTML status bar states seem a little awkward to me but I'm not sure what would sound better. The text in the patch are "HTML Message Part" and "No HTML Message Part." They are consistent with the existing text: "HTML Message" and "No HTML Message" though.


Summary
-------

Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445
  /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445
  /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445
  /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445

Diff: http://reviewboard.kde.org/r/2017/diff


Testing
-------


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review3020
-----------------------------------------------------------


Thanks for the update.

I find it a bit confusing that it says "No HTML message part", even though the message does have an HTML part.
I also think that the string is too long, with my layout, I can not see it fully.

Maybe just display the information that it is a mail which has both a plain text part and a HTML part in the tooltip and let the sidebar simpy display "HTML message" and "plain message"?

The main point that needs improvement is that place where it detects the type of the message, see the inline comment below.

Again, I'm very sorry for the late review, I was ill in the last days and couldn't be motivated to do anything.


/trunk/KDE/kdepim/kmail/htmlstatusbar.h
<http://reviewboard.kde.org/r/2017/#comment2468>

    I think MultipartPlain would be a clearer meaning here.



/trunk/KDE/kdepim/kmail/kmreaderwin.cpp
<http://reviewboard.kde.org/r/2017/#comment2471>

    I'm afraid this is not that easy.
    What if the message has attachments? Then the top-level mimetype is multipart/mixed. What if the HTML has embedded images? What if the message is signed or encrypted?
   
    They way this was done previously was that ObjectTreeParser set the mode of the color bar directly, for example in processTextHtmlSubtype(), the ObjectTreeParser has the best knowledge about the message structure.
   
    (ObjectTreeParser is a friend of KMReaderWin and accesses mColorBar directly...)



/trunk/KDE/kdepim/kmail/kmreaderwin.cpp
<http://reviewboard.kde.org/r/2017/#comment2469>

    slotToggleHtmlMode() might be better here, it is not clear what "display" means here.


- Thomas


On 2009-10-30 19:09:31, James Bendig wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
>
> (Updated 2009-10-30 19:09:31)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445
>
> Diff: http://reviewboard.kde.org/r/2017/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> James
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review3025
-----------------------------------------------------------


Thanks for the update.

I find it a bit confusing that it says "No HTML message part", even though the message does have an HTML part.
I also think that the string is too long, with my layout, I can not see it fully.

Maybe just display the information that it is a mail which has both a plain text part and a HTML part in the tooltip and let the sidebar simpy display "HTML message" and "plain message"?

The main point that needs improvement is that place where it detects the type of the message, see the inline comment below.

Again, I'm very sorry for the late review, I was ill in the last days and couldn't be motivated to do anything.


/trunk/KDE/kdepim/kmail/kmreaderwin.cpp
<http://reviewboard.kde.org/r/2017/#comment2472>

    I'm afraid this is not that easy.
    What if the message has attachments? Then the top-level mimetype is multipart/mixed. What if the HTML has embedded images? What if the message is signed or encrypted?
   
    They way this was done previously was that ObjectTreeParser set the mode of the color bar directly, for example in processTextHtmlSubtype(), the ObjectTreeParser has the best knowledge about the message structure.
   
    (ObjectTreeParser is a friend of KMReaderWin and accesses mColorBar directly...)


- Thomas


On 2009-10-30 19:09:31, James Bendig wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
>
> (Updated 2009-10-30 19:09:31)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445
>
> Diff: http://reviewboard.kde.org/r/2017/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> James
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/
-----------------------------------------------------------

(Updated 2009-11-11 20:19:41.478090)


Review request for KDE PIM.


Changes
-------

Renamed MultipartNormal to MultipartPlain in htmlstatusbar.h and htmlstatusbar.cpp.
Renamed setToggleDisplayMode to setToggleHtmlMode in kmreaderwin.h and kmreaderwin.cpp.
Changed status bar text for multi-part messages to more appropriately say "HTML Message" and "Plain Message" instead of "HTML Message Part" and "No HTML Message Part."
Changed where HTML status bar mode is set from kmreaderwin to ObjectTreeParser in order to work with multi-part messages of different message structures.

Tested with messages of types:
plain text
html
plain text and html
plain text and html with embedded images
plain text with attachments
plain text and html with attachments
encrypted plain text and html


Summary
-------

Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445
  /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445
  /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1042445
  /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445
  /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445

Diff: http://reviewboard.kde.org/r/2017/diff


Testing
-------


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review3083
-----------------------------------------------------------



/trunk/KDE/kdepim/kmail/htmlstatusbar.cpp
<http://reviewboard.kde.org/r/2017/#comment2512>

    That's the same as in the HTML case, right?
    Then you can do:
    case Html:
    case MultipartHtml:
      bla
   
    To save some code duplication.



/trunk/KDE/kdepim/kmail/objecttreeparser.cpp
<http://reviewboard.kde.org/r/2017/#comment2514>

    Just because we're in processTextPlainSubtype() doesn't mean the entire mail is a plain text mail, unfortunatley.
   
    Just imagine the following mail structure:
   
    |-multipart/alternative
    | |-text/html
    | \-text/plain
    |-text/plain
   
    This structure happens, for example, when someone writes a HTML mail and the mailing list adds a plain text footer to it.
   
    The footer is processed last, so the colorbar would indicate a plain text message here, even though it is a HTML one.


- Thomas


On 2009-11-11 20:19:41, James Bendig wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
>
> (Updated 2009-11-11 20:19:41)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445
>   /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1042445
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445
>
> Diff: http://reviewboard.kde.org/r/2017/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> James
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[James Bendig]

> On 2009-11-11 13:40:59, Thomas McGuire wrote:
> > Thanks for the update.
> >
> > I find it a bit confusing that it says "No HTML message part", even though the message does have an HTML part.
> > I also think that the string is too long, with my layout, I can not see it fully.
> >
> > Maybe just display the information that it is a mail which has both a plain text part and a HTML part in the tooltip and let the sidebar simpy display "HTML message" and "plain message"?
> >
> > The main point that needs improvement is that place where it detects the type of the message, see the inline comment below.
> >
> > Again, I'm very sorry for the late review, I was ill in the last days and couldn't be motivated to do anything.

I hope you're feeling better now. I was getting worried considering how fast you usually respond to reviews. :)

I tried to address your points in the third revision of the patch. Using ObjectTreeParser does feel less like a hack than the way I was checking message mime type before. I really should have found it originally.

LATE EDIT: I forgot to hit the "Publish" button when I wrote this almost five days ago. ...


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review3020
-----------------------------------------------------------


On 2009-11-11 20:19:41, James Bendig wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
>
> (Updated 2009-11-11 20:19:41)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445
>   /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1042445
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445
>
> Diff: http://reviewboard.kde.org/r/2017/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> James
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[James Bendig]

> On 2009-11-14 18:38:55, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp, line 114
> > <http://reviewboard.kde.org/r/2017/diff/3/?file=14361#file14361line114>
> >
> >     That's the same as in the HTML case, right?
> >     Then you can do:
> >     case Html:
> >     case MultipartHtml:
> >       bla
> >    
> >     To save some code duplication.

Thanks, I really should have caught this.

> On 2009-11-14 18:38:55, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/objecttreeparser.cpp, line 1269
> > <http://reviewboard.kde.org/r/2017/diff/3/?file=14364#file14364line1269>
> >
> >     Just because we're in processTextPlainSubtype() doesn't mean the entire mail is a plain text mail, unfortunatley.
> >    
> >     Just imagine the following mail structure:
> >    
> >     |-multipart/alternative
> >     | |-text/html
> >     | \-text/plain
> >     |-text/plain
> >    
> >     This structure happens, for example, when someone writes a HTML mail and the mailing list adds a plain text footer to it.
> >    
> >     The footer is processed last, so the colorbar would indicate a plain text message here, even though it is a HTML one.

I'm thinking this line is redundant anyways. Originally, the status bar was set to a neutral mode before a message was ever processed. If the the status bar was set to neutral after the message was processed, it was set to normal mode. I changed it to just assume normal mode and have it change appropriately when the message is processed. Do you think that would work okay?

I'm trying to craft a message with a message structure like you described to confirm it works as intended.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review3083
-----------------------------------------------------------


On 2009-11-11 20:19:41, James Bendig wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
>
> (Updated 2009-11-11 20:19:41)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445
>   /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1042445
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445
>
> Diff: http://reviewboard.kde.org/r/2017/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> James
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/
-----------------------------------------------------------

(Updated 2009-11-16 21:15:53.604513)


Review request for KDE PIM.


Changes
-------

Fixed code duplication in HtmlStatusBar::message() where Html and MultipartHtml were individually using the same message instead of sharing.
Removed line in ObjectTreeParser::processTextPlainSubType() causing multi-part messages with plain text part(s) at the end to be displayed on the html status bar as "No HTML Message."


Summary
-------

Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1048255
  /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1048255
  /trunk/KDE/kdepim/kmail/kmreaderwin.h 1048255
  /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1048255
  /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1048255

Diff: http://reviewboard.kde.org/r/2017/diff


Testing
-------


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review3126
-----------------------------------------------------------

Ship it!


Looks good, please commit.
Thanks for the patch :)

- Thomas


On 2009-11-16 21:15:53, James Bendig wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
>
> (Updated 2009-11-16 21:15:53)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1048255
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1048255
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1048255
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1048255
>   /trunk/KDE/kdepim/kmail/objecttreeparser.cpp 1048255
>
> Diff: http://reviewboard.kde.org/r/2017/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> James
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/