-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2036/-----------------------------------------------------------
Review request for KOffice.
Summary
-------
This patch adds support for the following text styles to KPresenter: position, shadow, emboss,underline and alignment.
Styles to texts are applied from master style if there is no specific style set for the text. There is a master style for each type of text (body, title,...) as specified in section 2.9.35 of [MS-PPT].pdf document. What is also fixed is to fetch the proper master style based on the texts type instead of a hardcoded one as was done before.
As I've mentioned in a TODO, I have found documents that have body's text as "Center body placeholder shape text" (Tx_TYPE_CENTERBODY) type, but some of their proper styles were in regular body style. As I've yet to find out the logic behind this, I've added some code to check text style values from both for the time being.
AStyle also ran on changed files.
Diffs
-----
trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1043798
trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1043798
trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.h 1043798
trunk/koffice/filters/kpresenter/powerpoint/libppt/powerpoint.cpp 1043798
Diff:
http://reviewboard.kde.org/r/2036/diffTesting
-------
Tested on a dozen of .ppt files with varying text styles and compared with MS Powerpoint.
Thanks,
Vesa
_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel
