|
»
Review Request: Nepomuk desktop query API
|
View:
New views
10 Messages
—
Rating Filter:
Alert me
|
 |
Review Request: Nepomuk desktop query API
by Sebastian Trueg
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/ ----------------------------------------------------------- Review request for kdelibs. Summary ------- One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. It makes perfect sense to include this API in KDE 4.4. Diffs ----- trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dateparser.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/querybuilderdata.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/2061/diff Testing ------- Thanks, Sebastian |
|
|
Re: Review Request: Nepomuk desktop query API
by Bugzilla from vkrause@kde.org
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/#review2935 ----------------------------------------------------------- Ship it! Looks good, just a few minor details. trunk/KDE/kdelibs/nepomuk/query/dateparser.h <http://reviewboard.kde.org/r/2061/#comment2324> missing explicit? trunk/KDE/kdelibs/nepomuk/query/dateparser.h <http://reviewboard.kde.org/r/2061/#comment2325> missing const? trunk/KDE/kdelibs/nepomuk/query/dateparser.h <http://reviewboard.kde.org/r/2061/#comment2326> missing const? getDate() -> date()? trunk/KDE/kdelibs/nepomuk/query/dateparser.h <http://reviewboard.kde.org/r/2061/#comment2327> missing explicit? trunk/KDE/kdelibs/nepomuk/query/dateparser.h <http://reviewboard.kde.org/r/2061/#comment2328> missing const? trunk/KDE/kdelibs/nepomuk/query/literalterm.h <http://reviewboard.kde.org/r/2061/#comment2329> missing explicit? trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h <http://reviewboard.kde.org/r/2061/#comment2330> missing explicit? trunk/KDE/kdelibs/nepomuk/query/resourceterm.h <http://reviewboard.kde.org/r/2061/#comment2331> missing explicit? trunk/KDE/kdelibs/nepomuk/query/resourceterm.h <http://reviewboard.kde.org/r/2061/#comment2332> missing explicit? trunk/KDE/kdelibs/nepomuk/query/result.h <http://reviewboard.kde.org/r/2061/#comment2333> missing explicit? - Volker On 2009-11-04 14:54:51, Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2061/ > ----------------------------------------------------------- > > (Updated 2009-11-04 14:54:51) > > > Review request for kdelibs. > > > Summary > ------- > > One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. > This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. > > It makes perfect sense to include this API in KDE 4.4. > > > Diffs > ----- > > trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION > trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/querybuilderdata.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/2061/diff > > > Testing > ------- > > > Thanks, > > Sebastian > > |
|
|
Re: Review Request: Nepomuk desktop query API
by Bugzilla from tokoe@kde.org
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/#review2948 ----------------------------------------------------------- trunk/KDE/kdelibs/nepomuk/query/dateparser.h <http://reviewboard.kde.org/r/2061/#comment2357> Should be hidden in private class trunk/KDE/kdelibs/nepomuk/query/dateparser.h <http://reviewboard.kde.org/r/2061/#comment2358> Why not using enum with QFLAGS here? trunk/KDE/kdelibs/nepomuk/query/query.h <http://reviewboard.kde.org/r/2061/#comment2359> All implementations of this class should got to the .cpp file. And a d-pointer is missing. trunk/KDE/kdelibs/nepomuk/query/query.h <http://reviewboard.kde.org/r/2061/#comment2360> Does it make sense to have these 'search file' specific methods in the general query object? Shouldn't there be a FileQuery class instead that inherits from Query? trunk/KDE/kdelibs/nepomuk/query/query.h <http://reviewboard.kde.org/r/2061/#comment2361> As it doesn't change the 'this' object but returns a new one, the method should be renamed to 'optimized', like QString::trimmed() trunk/KDE/kdelibs/nepomuk/query/querybuilderdata.h <http://reviewboard.kde.org/r/2061/#comment2362> If this class is only used internally, rename it to querybuilderdata_p.h? trunk/KDE/kdelibs/nepomuk/query/queryparser.h <http://reviewboard.kde.org/r/2061/#comment2363> Can be made const as well, or? - Tobias On 2009-11-04 14:54:51, Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2061/ > ----------------------------------------------------------- > > (Updated 2009-11-04 14:54:51) > > > Review request for kdelibs. > > > Summary > ------- > > One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. > This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. > > It makes perfect sense to include this API in KDE 4.4. > > > Diffs > ----- > > trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION > trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/querybuilderdata.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/2061/diff > > > Testing > ------- > > > Thanks, > > Sebastian > > |
|
|
Re: Review Request: Nepomuk desktop query API
by Sebastian Trueg
::
Rate this Message:
> On 2009-11-05 17:58:15, Volker Krause wrote: > > Looks good, just a few minor details. Why add the explicit keyword? I don't see any possibility for misuse of the constructors. Plus I really like to be able to write ComparisionTerm( Vocabulary::NAO::hasTag(), QString("nepomuk") ); instead of ComparisionTerm( Nepomuk::Types::Property(Vocabulary::NAO::hasTag()), LiteralTerm(Soprano::LiteralValue(QString("nepomuk")))); - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/#review2935 ----------------------------------------------------------- On 2009-11-04 14:54:51, Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2061/ > ----------------------------------------------------------- > > (Updated 2009-11-04 14:54:51) > > > Review request for kdelibs. > > > Summary > ------- > > One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. > This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. > > It makes perfect sense to include this API in KDE 4.4. > > > Diffs > ----- > > trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION > trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/querybuilderdata.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/2061/diff > > > Testing > ------- > > > Thanks, > > Sebastian > > |
|
|
Re: Review Request: Nepomuk desktop query API
by Sebastian Trueg
::
Rate this Message:
> On 2009-11-06 13:53:51, Tobias Koenig wrote: > > trunk/KDE/kdelibs/nepomuk/query/dateparser.h, line 39 > > <http://reviewboard.kde.org/r/2061/diff/1/?file=13751#file13751line39> > > > > Should be hidden in private class This class is supposed to be hidden actually. I will thus, rename the header to dataparser_p.h > On 2009-11-06 13:53:51, Tobias Koenig wrote: > > trunk/KDE/kdelibs/nepomuk/query/dateparser.h, line 46 > > <http://reviewboard.kde.org/r/2061/diff/1/?file=13751#file13751line46> > > > > Why not using enum with QFLAGS here? No reason. Will fix it. > On 2009-11-06 13:53:51, Tobias Koenig wrote: > > trunk/KDE/kdelibs/nepomuk/query/query.h, line 140 > > <http://reviewboard.kde.org/r/2061/diff/1/?file=13771#file13771line140> > > > > All implementations of this class should got to the .cpp file. And a d-pointer is missing. Agreed. > On 2009-11-06 13:53:51, Tobias Koenig wrote: > > trunk/KDE/kdelibs/nepomuk/query/query.h, line 195 > > <http://reviewboard.kde.org/r/2061/diff/1/?file=13771#file13771line195> > > > > Does it make sense to have these 'search file' specific methods in the general query object? Shouldn't there be a FileQuery class instead that inherits from Query? That is a nice idea. I will have a look if that is easily doable. > On 2009-11-06 13:53:51, Tobias Koenig wrote: > > trunk/KDE/kdelibs/nepomuk/query/query.h, line 247 > > <http://reviewboard.kde.org/r/2061/diff/1/?file=13771#file13771line247> > > > > As it doesn't change the 'this' object but returns a new one, the method should be renamed to 'optimized', like QString::trimmed() agreed. > On 2009-11-06 13:53:51, Tobias Koenig wrote: > > trunk/KDE/kdelibs/nepomuk/query/querybuilderdata.h, line 1 > > <http://reviewboard.kde.org/r/2061/diff/1/?file=13774#file13774line1> > > > > If this class is only used internally, rename it to querybuilderdata_p.h? yes. > On 2009-11-06 13:53:51, Tobias Koenig wrote: > > trunk/KDE/kdelibs/nepomuk/query/queryparser.h, line 92 > > <http://reviewboard.kde.org/r/2061/diff/1/?file=13775#file13775line92> > > > > Can be made const as well, or? agreed. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/#review2948 ----------------------------------------------------------- On 2009-11-04 14:54:51, Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2061/ > ----------------------------------------------------------- > > (Updated 2009-11-04 14:54:51) > > > Review request for kdelibs. > > > Summary > ------- > > One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. > This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. > > It makes perfect sense to include this API in KDE 4.4. > > > Diffs > ----- > > trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION > trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/querybuilderdata.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/2061/diff > > > Testing > ------- > > > Thanks, > > Sebastian > > |
|
|
Re: Review Request: Nepomuk desktop query API
by Sebastian Trueg
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/ ----------------------------------------------------------- (Updated 2009-11-09 08:45:24.075954) Review request for kdelibs. Changes ------- New diff fixing most of the issues except: - no new explicit constructors as I do not see the point. - QueryParser::parse cannot be const as it changes the property cache Other changes: - No more Query::resolveProperties. This seemed like the wrong place. Instead we now have QueryParser::matchProperty which might even be used in query GUIs to provide auto-completion of query strings. - No more Query::optimized. It does not make sense not to call it so we can do it internally. - Removed ComparisonTerm::field. As the matching of the properties is now done by the query parser there is no need for this clutter anymore. Summary ------- One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. It makes perfect sense to include this API in KDE 4.4. Diffs (updated) ----- trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/FileQuery PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dateparser_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/filequery.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/filequery.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/querybuilderdata_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/2061/diff Testing ------- Thanks, Sebastian |
|
|
Re: Review Request: Nepomuk desktop query API
by Sebastian Trueg
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/ ----------------------------------------------------------- (Updated 2009-11-09 08:53:09.485258) Review request for kdelibs. Changes ------- One more small update: It does not make sense to export the DBus operators to the public API. Summary ------- One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. It makes perfect sense to include this API in KDE 4.4. Diffs (updated) ----- trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/querybuilderdata_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/filequery.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/filequery.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dateparser_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/FileQuery PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/2061/diff Testing ------- Thanks, Sebastian |
|
|
Re: Review Request: Nepomuk desktop query API
by Sebastian Trueg
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/ ----------------------------------------------------------- (Updated 2009-11-09 10:47:26.955823) Review request for kdelibs. Changes ------- One more change and a comment: - Added ComparisonTerm::Regexp for regular expression matching in special cases. - DateParser is not "fixed" yet. I will do that once I re-integrate it into the QueryParser. Since it is a private class that should not be a problem. Summary ------- One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. It makes perfect sense to include this API in KDE 4.4. Diffs (updated) ----- trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/FileQuery PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dateparser_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/filequery.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/filequery.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/querybuilderdata_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION Diff: http://reviewboard.kde.org/r/2061/diff Testing ------- Thanks, Sebastian |
|
|
Re: Review Request: Nepomuk desktop query API
by Bugzilla from tokoe@kde.org
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/#review3001 ----------------------------------------------------------- trunk/KDE/kdelibs/nepomuk/query/andterm.h <http://reviewboard.kde.org/r/2061/#comment2453> api docs missing for different ctors trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h <http://reviewboard.kde.org/r/2061/#comment2451> argument name 'property' is missing, should be included into doxygen as well: 'Set the @p property of ...' trunk/KDE/kdelibs/nepomuk/query/filequery.h <http://reviewboard.kde.org/r/2061/#comment2452> Add d-pointer to be future proof additional copyctor and operator= for FileQuery can be added later on trunk/KDE/kdelibs/nepomuk/query/groupterm.h <http://reviewboard.kde.org/r/2061/#comment2454> api docs missing for dtor subTerms/setSubTerms/addSubTerm trunk/KDE/kdelibs/nepomuk/query/literalterm.h <http://reviewboard.kde.org/r/2061/#comment2455> apidocs missing for all methods trunk/KDE/kdelibs/nepomuk/query/negationterm.h <http://reviewboard.kde.org/r/2061/#comment2456> apidocs missing for ctors trunk/KDE/kdelibs/nepomuk/query/orterm.h <http://reviewboard.kde.org/r/2061/#comment2457> apidocs missing for all ctors trunk/KDE/kdelibs/nepomuk/query/query.h <http://reviewboard.kde.org/r/2061/#comment2458> apidocs missing for RequestProperty ctors and methods trunk/KDE/kdelibs/nepomuk/query/queryparser.h <http://reviewboard.kde.org/r/2061/#comment2459> Should definitely be const trunk/KDE/kdelibs/nepomuk/query/queryparser.h <http://reviewboard.kde.org/r/2061/#comment2460> Can be made const by marking fieldMatchCache mutable trunk/KDE/kdelibs/nepomuk/query/resourceterm.h <http://reviewboard.kde.org/r/2061/#comment2461> apidocs for ctor and methods trunk/KDE/kdelibs/nepomuk/query/simpleterm.h <http://reviewboard.kde.org/r/2061/#comment2462> add apidocs for methods - Tobias On 2009-11-09 10:47:26, Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2061/ > ----------------------------------------------------------- > > (Updated 2009-11-09 10:47:26) > > > Review request for kdelibs. > > > Summary > ------- > > One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. > This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. > > It makes perfect sense to include this API in KDE 4.4. > > > Diffs > ----- > > trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/FileQuery PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION > trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/filequery.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/filequery.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/querybuilderdata_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/2061/diff > > > Testing > ------- > > > Thanks, > > Sebastian > > |
|
|
Re: Review Request: Nepomuk desktop query API
by Sebastian Trueg
::
Rate this Message:
> On 2009-11-10 15:58:25, Tobias Koenig wrote: > > I will finalize the API docs next week. > On 2009-11-10 15:58:25, Tobias Koenig wrote: > > trunk/KDE/kdelibs/nepomuk/query/filequery.h, line 42 > > <http://reviewboard.kde.org/r/2061/diff/4/?file=14179#file14179line42> > > > > Add d-pointer to be future proof additional copyctor and operator= for FileQuery can be added later on No need. If we really need to store additional data fields with FileQuery in the future we can use the same approach as for Term: a private class hierarchy. > On 2009-11-10 15:58:25, Tobias Koenig wrote: > > trunk/KDE/kdelibs/nepomuk/query/queryparser.h, line 105 > > <http://reviewboard.kde.org/r/2061/diff/4/?file=14201#file14201line105> > > > > Should definitely be const done. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2061/#review3001 ----------------------------------------------------------- On 2009-11-09 10:47:26, Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2061/ > ----------------------------------------------------------- > > (Updated 2009-11-09 10:47:26) > > > Review request for kdelibs. > > > Summary > ------- > > One thing has been missing ever since KDE 4.0: A good Nepomuk query API. We cannot expect app developers to all learn SPARQL. > This API is the final version (Virtuoso-extensions-based) of the query API that has already been in kdebase/workspace/libs/nepomukquery and kdebase/runtime/nepomuk/libnepomukquery. The API is already used by the Nepomuk query service, the Nepomuk search kio slave, the Nepomuk Plasma runner, and the simple search client in playground. > > It makes perfect sense to include this API in KDE 4.4. > > > Diffs > ----- > > trunk/KDE/kdelibs/includes/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/includes/Nepomuk/Query/AndTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ComparisonTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/FileQuery PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/GroupTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/LiteralTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/NegationTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/OrTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Query PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryParser PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/QueryServiceClient PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/ResourceTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Result PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/SimpleTerm PRE-CREATION > trunk/KDE/kdelibs/includes/Nepomuk/Query/Term PRE-CREATION > trunk/KDE/kdelibs/nepomuk/CMakeLists.txt 1044143 > trunk/KDE/kdelibs/nepomuk/query/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/andterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/comparisonterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dateparser_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/dbusoperators.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/filequery.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/filequery.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/groupterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/literalterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/negationterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nepomukquery_export.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/nie.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.Query.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/org.kde.nepomuk.QueryService.xml PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/orterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/query_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/querybuilderdata_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryparser.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/queryserviceclient.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/resourceterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/result.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/simpleterm_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/term_p.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/CMakeLists.txt PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/pimo.trig PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/queryparsertest.cpp PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.h PRE-CREATION > trunk/KDE/kdelibs/nepomuk/query/test/querytest.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/2061/diff > > > Testing > ------- > > > Thanks, > > Sebastian > > |
| Free embeddable forum powered by Nabble | Forum Help |
