« Return to Thread: Review Request: Redesign Window Switcher layout design

Review Request: Redesign Window Switcher layout design

by Martin Gräßlin :: Rate this Message:

| View in Thread

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104948/

Review request for kwin.
By Martin Gräßlin.

Description

Redesign Window Switcher layout design

Complete rewrite of the dialog to select the window switcher
layout to fix the usability and scalability issues of the
existing implementation:
* added search functionality through QSortFilterProxyModel
* increased the dialog size to better render large layouts
* added scrollbar from decoration kcm
* "normal" list background and selection instead of window
  background
* only show one preview at a time

BUG: 299278
FIXED-IN: 4.9.0

Testing

current remaining issues:
* small icons looks really bad
* initial selected layout is broken, fixed after forced re-rendering
* grid layout does not use all available space
* highlight moves too slow
Bugs: 299278

Diffs

  • kwin/kcmkwin/kwindecoration/CMakeLists.txt (4762bb983b8e431daaf3a2e600d460e2186a870b)
  • kwin/kcmkwin/kwintabbox/layoutconfig.h (a83574ad170a80efefa123061d8dc77687ef5cfb)
  • kwin/kcmkwin/kwintabbox/layoutconfig.cpp (b2a426685ace2e0c4a76258ff1c05c7a105d0e92)
  • kwin/kcmkwin/kwintabbox/main.cpp (bb705dbfc911a9b718821ac43e70196cef31f430)
  • kwin/kcmkwin/kwintabbox/qml/main.qml (8858e208c9f45c9d9836210f51a5324687c10c92)

View Diff

Screenshots


_______________________________________________
kwin mailing list
kwin@...
https://mail.kde.org/mailman/listinfo/kwin

 « Return to Thread: Review Request: Redesign Window Switcher layout design