Review Request: Refactor writing of styles.xml in libppt

View: New views
1 Messages — Rating Filter:   Alert me  

Review Request: Refactor writing of styles.xml in libppt

by jos.van.den.oever :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1999/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

Add a few improvements to libppt:

- use convenience class KoXmlWriter in generating the ODF
- use saveOdfStylesDotXml to create 'styles.xml' instead of with XML writer
- save picture names in manifest along with their mimetype.

The new code partially mimics filters/kpresenter/kpr2odf/Filterkpr2odf.cpp


Diffs
-----

  trunk/koffice/filters/kpresenter/powerpoint/import/pictures.h 1041440
  trunk/koffice/filters/kpresenter/powerpoint/import/pictures.cc 1041440
  trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.h 1041440
  trunk/koffice/filters/kpresenter/powerpoint/import/powerpointimport.cc 1041440

Diff: http://reviewboard.kde.org/r/1999/diff


Testing
-------

Ran filter across some ppt files and validated them with xmllint.


Thanks,

vandenoever

_______________________________________________
koffice-devel mailing list
koffice-devel@...
https://mail.kde.org/mailman/listinfo/koffice-devel