WARNING: This server is unstable and will be retired in the next days. If you want to keep this forum available, please request immediately a migration on the Nabble Support forum. Forums that don't receive any migration request will be deleted forever.

 « Return to Thread: Review Request: The "Copy Input To" submenu should use combo boxes instead of check boxes

Review Request: The "Copy Input To" submenu should use combo boxes instead of check boxes

by Bugzilla from adaptee@gmail.com :: Rate this Message:

| View in Thread

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104202/

Review request for Konsole.
By Jekyll Wu.

Description

The existing UI is misleading: the three check boxes imply that you can enable any of them independently, but actually you can only enable one of them at any time. So the three choices should be shown using combo boxes instead of check boxes.

The code is basically stolen from dolphin. Again, I'm always not that confident with UI changes, so please check the code for any stupid or unnecessary code.

Testing

Seems fine.

Diffs

  • desktop/sessionui.rc (0dd1b66)
  • src/SessionController.h (46714c0)
  • src/SessionController.cpp (f437d9b)

View Diff

Screenshots

before after

_______________________________________________
konsole-devel mailing list
konsole-devel@...
https://mail.kde.org/mailman/listinfo/konsole-devel

 « Return to Thread: Review Request: The "Copy Input To" submenu should use combo boxes instead of check boxes