Review Request: adds kmail support for RFC2369, List-* headers to display in preview pane with links to URLs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?


Diffs
-----

  /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031213
  /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031213
  /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031213
  /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031213

Diff: http://reviewboard.kde.org/r/1768/diff


Testing
-------

tested on kmail-1.12.1 (kde-4.3.1)


Thanks,

Daniel

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/
-----------------------------------------------------------

(Updated 2009-10-04 22:59:27.304648)


Review request for KDE PIM.


Changes
-------

added screenshots


Summary
-------

This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?


Diffs
-----

  /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031213
  /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031213
  /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031213
  /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031213

Diff: http://reviewboard.kde.org/r/1768/diff


Testing
-------

tested on kmail-1.12.1 (kde-4.3.1)


Screenshots
-----------

fancy style
  http://reviewboard.kde.org/r/1768/s/219/
enterprise style
  http://reviewboard.kde.org/r/1768/s/220/
standard style
  http://reviewboard.kde.org/r/1768/s/221/


Thanks,

Daniel

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2547
-----------------------------------------------------------


Probably shouldn't be in enterprise style as that is more or less frozen, but someone from KDAB know that better.


/trunk/KDE/kdepim/kmail/mailinglist-magic.h
<http://reviewboard.kde.org/r/1768/#comment1864>

    Missing API doc



/trunk/KDE/kdepim/kmail/mailinglist-magic.h
<http://reviewboard.kde.org/r/1768/#comment1865>

    Missing API doc


- Torgny


On 2009-10-04 22:59:27, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-04 22:59:27)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031213
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031213
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031213
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031213
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> fancy style
>   http://reviewboard.kde.org/r/1768/s/219/
> enterprise style
>   http://reviewboard.kde.org/r/1768/s/220/
> standard style
>   http://reviewboard.kde.org/r/1768/s/221/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Markus-84]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2549
-----------------------------------------------------------


Very nice. Small visual gripe, though:
You have no space before the brackets. Use dots or en dashes to separate list name, subscribe and unsubscribe.
subscribe and unsubscribe via mailto should probably be the default action in a mail client, so "subscribe" and "unsubscribe" itself should be links. The http option (maybe call it "via web") can be an alternative in brackets.
I'd put subscribe and unsubscribe in a new line as well as the list title can be quite long.

Example:

List: My mailing list.
      Subscribe (via web) – Unsubscribe (via web)

- Markus


On 2009-10-04 22:59:27, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-04 22:59:27)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031213
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031213
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031213
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031213
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> fancy style
>   http://reviewboard.kde.org/r/1768/s/219/
> enterprise style
>   http://reviewboard.kde.org/r/1768/s/220/
> standard style
>   http://reviewboard.kde.org/r/1768/s/221/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[David Jarvie-4]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2550
-----------------------------------------------------------


I like this idea. I think there does need to be a clearer separation between the list title and "Post". Perhaps enclose the options in square brackets [Post ...].

I find the fancy header list of options rather confusing. It's not immediately obvious that the "http" and "mailto" refer to the preceding Unsubscribe and Subscribe - the fact that (Un)subscribe are not highlighted contributes to the confusion. I'd suggest making the web link the default (which is the same as Post and Archive), and show for the mail links "Unsubscribe (by mail)" and "Subscribe (by mail)". There may need to be a slightly larger spacing between the options to make it clear.

Bear in mind that ordinary users won't necessarily understand the terms "http" and "mailto" - these are technical terms for protocols - and as such they don't belong in a user interface like this.

- David


On 2009-10-04 22:59:27, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-04 22:59:27)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031213
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031213
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031213
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031213
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> fancy style
>   http://reviewboard.kde.org/r/1768/s/219/
> enterprise style
>   http://reviewboard.kde.org/r/1768/s/220/
> standard style
>   http://reviewboard.kde.org/r/1768/s/221/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/
-----------------------------------------------------------

(Updated 2009-10-05 14:29:35.921063)


Review request for KDE PIM.


Changes
-------

Torgny: I've left Enterprise in for the time being. easy enough to remove. Added API docs since there were none to start with.
Markus/David: Thanks for the visual ideas. What I have done is:
1. Reorder header fields in a logical order, Post, Archive, Help, Owner, Subscribe, Unsubscribe - unsubscribe left till last for easy viability.
2. mailto -> email, http/https -> web. Other protocols left as is (never seen anything else used and irc/ftp are probably friendly enough)
3. Header fields link to the mailto if one exists otherwise the first URL in the header field.
4. Multiple URLs - "Post (by web)" where Post is a mailto: link and web is a http one.
5. Many Multiple URLs - "Help (by web or irc or jabber or fish)" where Help talks the mailto: link and the others are their respective protocols.
6. As per Markus's suggestion I've gone for the two line approach.
7. Separations use an en-dash as Markus suggested.

Think I should make "Post (web or email)" when both options exist? The current display of "Post (by web)" slightly hides the email option.


Summary
-------

This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
  /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
  /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
  /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501

Diff: http://reviewboard.kde.org/r/1768/diff


Testing
-------

tested on kmail-1.12.1 (kde-4.3.1)


Screenshots (updated)
-----------

Enterprise Style
  http://reviewboard.kde.org/r/1768/s/224/
Fancy Style
  http://reviewboard.kde.org/r/1768/s/225/
Long Style
  http://reviewboard.kde.org/r/1768/s/226/


Thanks,

Daniel

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2557
-----------------------------------------------------------


Please make it optional. It might be nice to have those options available when you need them, but how often do you need them? Most of the time they are just a waste of precious vertical screen space. The current headers do already take more than enough space.

I really hope that we will soon have fully customizable preview pane layouts (via the Grantlee template system)...

- Ingo


On 2009-10-05 14:29:35, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-05 14:29:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> Enterprise Style
>   http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
>   http://reviewboard.kde.org/r/1768/s/225/
> Long Style
>   http://reviewboard.kde.org/r/1768/s/226/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

> On 2009-10-05 21:48:07, Ingo Klöcker wrote:
> > Please make it optional. It might be nice to have those options available when you need them, but how often do you need them? Most of the time they are just a waste of precious vertical screen space. The current headers do already take more than enough space.
> >
> > I really hope that we will soon have fully customizable preview pane layouts (via the Grantlee template system)...

List: headers were not included in "Brief" style for the reason of space conservation. I'd use the archive link often when quoting a conversations. Mailing list operators and therefore like giving users an unsubscribe that's visible (hence email footers) because unsubscribing users can be impatient. Maybe the List-ID doesn't add much (though I've omitted <...> bit from display). Is this sufficient?

You're right though that a fully customizable preview pane layout would be serving the user best.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2557
-----------------------------------------------------------


On 2009-10-05 14:29:35, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-05 14:29:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> Enterprise Style
>   http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
>   http://reviewboard.kde.org/r/1768/s/225/
> Long Style
>   http://reviewboard.kde.org/r/1768/s/226/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Ingo Klöcker]

On Tuesday 06 October 2009, Daniel Black wrote:

> > On 2009-10-05 21:48:07, Ingo Klöcker wrote:
> > > Please make it optional. It might be nice to have those options
> > > available when you need them, but how often do you need them?
> > > Most of the time they are just a waste of precious vertical
> > > screen space. The current headers do already take more than
> > > enough space.
> > >
> > > I really hope that we will soon have fully customizable preview
> > > pane layouts (via the Grantlee template system)...
>
> List: headers were not included in "Brief" style for the reason of
> space conservation. I'd use the archive link often when quoting a
> conversations. Mailing list operators and therefore like giving users
> an unsubscribe that's visible (hence email footers) because
> unsubscribing users can be impatient.

Unsubscribing is something the user does exactly once. I don't think
this justifies putting the information how to unsubscribe in the header
right in the user's face. And, as you correctly say, on many mailing
lists this information is already included in the footer (which is the
correct place for such rarely needed information).

> Maybe the List-ID doesn't add
> much (though I've omitted <...> bit from display). Is this
> sufficient?

I still think it should be customizable since I am definitely not
interested in this information. Alternatively, try to achieve your goal
with a few unintrusive icons instead of with one or two lines of text.


Regards,
Ingo

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/#review2557
> -----------------------------------------------------------
>
> On 2009-10-05 14:29:35, Daniel Black wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1768/
> > -----------------------------------------------------------
> >
> > (Updated 2009-10-05 14:29:35)
> >
> >
> > Review request for KDE PIM.
> >
> >
> > Summary
> > -------
> >
> > This patch displays the
> > List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a
> > href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is
> > RFC2919) URLs of email header fields on the view plane in kmail.
> > The display occurs on styles: Enterprise, Fancy, Standard, and
> > Long. The format is: List: Linux Australia  Post Unsubscribe(http
> > mailto) Subscribe(http mailto) Archive Help The Post, Archive and
> > Help are links to the single URL present. The Subscribe/Unsubcribe
> > have two links so the http and mailto, extracted from the URL
> > protocol, are links to those two options. Only list tags that exist
> > are show. Visual separation from the title and Post.... is a bit
> > weak. Is "List: List Title <Post....>" better?
> >
> >
> > Diffs
> > -----
> >
> >   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
> >   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
> >   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
> >   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501
> >
> > Diff: http://reviewboard.kde.org/r/1768/diff
> >
> >
> > Testing
> > -------
> >
> > tested on kmail-1.12.1 (kde-4.3.1)
> >
> >
> > Screenshots
> > -----------
> >
> > Enterprise Style
> >   http://reviewboard.kde.org/r/1768/s/224/
> > Fancy Style
> >   http://reviewboard.kde.org/r/1768/s/225/
> > Long Style
> >   http://reviewboard.kde.org/r/1768/s/226/
> >
> >
> > Thanks,
> >
> > Daniel
>
> _______________________________________________
> KDE PIM mailing list kde-pim@...
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2574
-----------------------------------------------------------


while I think of it, RFC5064 (X-)Archived-At: could here here too.

- Daniel


On 2009-10-05 14:29:35, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-05 14:29:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> Enterprise Style
>   http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
>   http://reviewboard.kde.org/r/1768/s/225/
> Long Style
>   http://reviewboard.kde.org/r/1768/s/226/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Markus-84]

Am Dienstag, 6. Oktober 2009 23:44:15 schrieb Ingo Klöcker:

> I don't think
> this justifies putting the information how to unsubscribe in the header
> right in the user's face.

As already told: It's not in "Brief" style. AFAIK there's also a new theme
engine in the works that makes it easier to create custom themes. So you'll
get "Brief Fancy" soon enough.
I think it's very good to at least have the options to display that
information, but the option should not be in the options window, but based on
the selected theme.
AFAIK the new theme engine will be available with KMail 2.0 / KDE 4.5.
Maybe as compromise a drop-down menu could be used in the meantime...

> And, as you correctly say, on many mailing
> lists this information is already included in the footer (which is the
> correct place for such rarely needed information).

On many, but not all. Evolution also has nice mailing list management
features. IMO this feature increases the usability more than it hurts.
_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

> On 2009-10-05 21:48:07, Ingo Klöcker wrote:
> > Please make it optional. It might be nice to have those options available when you need them, but how often do you need them? Most of the time they are just a waste of precious vertical screen space. The current headers do already take more than enough space.
> >
> > I really hope that we will soon have fully customizable preview pane layouts (via the Grantlee template system)...
>
> Daniel Black wrote:
>     List: headers were not included in "Brief" style for the reason of space conservation. I'd use the archive link often when quoting a conversations. Mailing list operators and therefore like giving users an unsubscribe that's visible (hence email footers) because unsubscribing users can be impatient. Maybe the List-ID doesn't add much (though I've omitted <...> bit from display). Is this sufficient?
>    
>     You're right though that a fully customizable preview pane layout would be serving the user best.

Make it a hidden setting for now.
I agree with Ingo that it should not be mandatory.


- Torgny


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2557
-----------------------------------------------------------


On 2009-10-05 14:29:35, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-05 14:29:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> Enterprise Style
>   http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
>   http://reviewboard.kde.org/r/1768/s/225/
> Long Style
>   http://reviewboard.kde.org/r/1768/s/226/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Ingo Klöcker]

On Wednesday 07 October 2009, Markus wrote:
> Am Dienstag, 6. Oktober 2009 23:44:15 schrieb Ingo Klöcker:
> > I don't think
> > this justifies putting the information how to unsubscribe in the
> > header right in the user's face.
>
> As already told: It's not in "Brief" style.

I'm not going to use the ultra-spartan "Brief" style just because a
handful of people think wasting header space with List-* headers is a
leet idea. I'll rather patch KMail. The problem is that the majority of
KMail users don't know how to do this.


> AFAIK there's also a new
> theme engine in the works that makes it easier to create custom
> themes.

Yes, the Grantlee template system.


> So you'll get "Brief Fancy" soon enough.
> I think it's very good to at least have the options to display that
> information, but the option should not be in the options window, but
> based on the selected theme.

I agree.


> AFAIK the new theme engine will be available with KMail 2.0 / KDE
> 4.5. Maybe as compromise a drop-down menu could be used in the
> meantime...

I could live with that.


> > And, as you correctly say, on many mailing
> > lists this information is already included in the footer (which is
> > the correct place for such rarely needed information).
>
> On many, but not all. Evolution also has nice mailing list management
> features. IMO this feature increases the usability more than it
> hurts.

KMail also has nice mailing list management features, but they are bound
to folders and thus only useful if one has one folder per mailing list.


Regards,
Ingo


_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2589
-----------------------------------------------------------


I agree that this needs a configure option before this patch can be applied.
Fortunately, there is enough space in the message window configure tab for an other checkbox :)
In addition, it might be an idea to have these list links at the bottom of a mail, not at the top. Not sure if that is better, though, just an opinion.

As usual, I have made some inline comments below, please have a look at them.


/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1904>

    Please remove the trailing whitespace here



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1910>

    it would be nice to rename style to cssStyle or something like that, since otherwise a variable named style is confusing in a file named headerstyle.cpp :)



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1905>

    Add missing spaces, which are needed because of the coding styles rules, this should be:
    if ( list.size() == 0 ) {
    Or even better, use list.isEmpty()
   
    Please add those spaces inside of parenthesis also in other places



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1901>

    Should be a kWarning, instead of "warn" in the debug statement



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1906>

    QString() instead of QString::null



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1916>

    This is only used inside the for loop, right? Then it should be declared there, not here.
    In general, variables should be declared as late as possible.



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1902>

    Using foreach here would be significantly less code



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1909>

    This an "web" below need to be i18n-ized



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1917>

    "or" is not i18n-ized



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1918>

    That will not work if " or " is i18n-ized



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1911>

    this "by" needs i18n context, otherwise it can't properly be translated.



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1908>

    This variable shadows another one with the same name, that is a bit confusing



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1912>

    Please move the { to a new line for function definitions.



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1907>

    Please use more descriptive variable names, not slist, flist and mlist.



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1914>

    There is no i18n context here, although it is there for other uses of "List: "



/trunk/KDE/kdepim/kmail/headerstyle.cpp
<http://reviewboard.kde.org/r/1768/#comment1913>

    Where is this used?



/trunk/KDE/kdepim/kmail/mailinglist-magic.h
<http://reviewboard.kde.org/r/1768/#comment1915>

    Please use the standard comment style for all comments in this file, which is:
   
    /**
     * Bla Bla Bla
     */


- Thomas


On 2009-10-05 14:29:35, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-05 14:29:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> Enterprise Style
>   http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
>   http://reviewboard.kde.org/r/1768/s/225/
> Long Style
>   http://reviewboard.kde.org/r/1768/s/226/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

My remaining questions is from comment 1:
"Torgny Nyblom
Posted 4 days, 17 hours ago (October 5th, 2009, 6:59 a.m.)

Probably shouldn't be in enterprise style as that is more or less frozen, but
someone from KDAB know that better."

1. should this be added to the enterprise style?

also:

2. I'll add the RFC5064 Archived-At header link at the front of this list
before post. I'm hoping those who are interested in using this feature are
happy with the format.

3. Sorry Ingo. I'm not sure I can develop good intuitive icons so I'll take
yours' and Thomas' suggestion of a config option. A drop down box with links
would of been nice but I don't know how to do this either.

On Friday 09 October 2009 02:30:02 Thomas McGuire wrote:
> I agree that this needs a configure option before this patch can be
>  applied. Fortunately, there is enough space in the message window
>  configure tab for an other checkbox :)

thanks for the specific guidance.

>  In addition, it might be an idea to  have these list links at the bottom of
a mail, not at the top. Not sure if  that is better, though, just an opinion.

given there is no footer class for email displays I'm loathed to create one.
>
> As usual, I have made some inline comments below, please have a look at
>  them.
I will - thank you and forgive my lack of awareness of some of these style
issues.

Thanks for the reviews and everything else,

Daniel
_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Markus-84]

> On 2009-10-08 15:30:08, Thomas McGuire wrote:
> > I agree that this needs a configure option before this patch can be applied.
> > Fortunately, there is enough space in the message window configure tab for an other checkbox :)
> > In addition, it might be an idea to have these list links at the bottom of a mail, not at the top. Not sure if that is better, though, just an opinion.
> >
> > As usual, I have made some inline comments below, please have a look at them.

> Fortunately, there is enough space in the message window configure tab for an other checkbox :)

No, please not that way. It just adds clutter to a place where IMHO it doesn't even belong. Which header information is displayed, is already handled by the theme. Why should this be the only exception?
I suggest a single, special mailing list header theme ("Decorative for mailing lists") as interim solution until the new theming engine is implemented. Once that is done, there will probably a theme config tab somewhere anyway.


- Markus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2589
-----------------------------------------------------------


On 2009-10-05 14:29:35, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-05 14:29:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> Enterprise Style
>   http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
>   http://reviewboard.kde.org/r/1768/s/225/
> Long Style
>   http://reviewboard.kde.org/r/1768/s/226/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Gary L. Greene, Jr.-3]

On Saturday 10 October 2009 12:53:54 am Daniel Black wrote:
> given there is no footer class for email displays I'm loathed to create
>  one.

To be honest, a footer class might not be a bad idea, since then the
attachments could be moved there instead of being in the header, cluttering
the interface, much like how Chrome does for downloads.
 
--
Gary L. Greene, Jr.
Sent from: skuld.tolharadys.net
  4:15pm  up  13:28,  4 users,  load average: 0.15, 0.23, 0.19
==========================================================================
Developer and Project Lead for the AltimatOS open source project
Volunteer Developer for the KDE open source project
See http://www.altimatos.com/ and http://www.kde.org/ for more information
==========================================================================

Please avoid sending me Word or PowerPoint attachments.
_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

On Sunday 11 October 2009 10:18:02 Gary L. Greene, Jr. wrote:
> On Saturday 10 October 2009 12:53:54 am Daniel Black wrote:
> > given there is no footer class for email displays I'm loathed to create
> >  one.
>
> To be honest, a footer class might not be a bad idea, since then the
> attachments could be moved there instead of being in the header,
I actually agree. Though I'm finding the Qt learning curve a little steep for
the time I thought I 'd spend on this patch. Don't get me wrong for adding
stuff like List-ID headers this is a pretty flexible framework for it.

If someone writes the footer class in the near future I'll move this patch to
it (with no configuration option).
_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2637
-----------------------------------------------------------


Ok, after thinking about this more and after seeing the comments to this, I believe using the links in the message is not the way to go. Sorry.
The links are not needed 99% of the time and they use a lot of space.
They could be disabled by default, but that again makes no sense since the links would be used mainly by beginners, who might not figure out how to turn them on in the first place. For the same reason, I'm against using an additional style.

Instead of links in the mail itself, it might be an idea to add the actions to a menu some, like the context menu of the "To:" link, when that is a mailing list, or even the context menu of the message in the reader.

To summarize, I will not accept a patch that adds links to the message. Sorry that this response is so late, I should have thought about this right from the beginning.

- Thomas


On 2009-10-05 14:29:35, Daniel Black wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-05 14:29:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help
> The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
>   /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> Enterprise Style
>   http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
>   http://reviewboard.kde.org/r/1768/s/225/
> Long Style
>   http://reviewboard.kde.org/r/1768/s/226/
>
>
> Thanks,
>
> Daniel
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

On Wednesday 14 October 2009 07:20:40 Thomas McGuire wrote:
> Instead of links in the mail itself, it might be an idea to add the actions
>  to a menu some, like the context menu of the "To:" link, when that is a
>  mailing list, or even the context menu of the message in the reader.
ok - I'll look into that.

>  To summarize, I will not accept a patch that adds links to the message.
ok

>  Sorry that this response is so late,
It was a good foundation for the Authenticated-Results RFC5451 patch I am
considering writing.

> I should have thought about this right from the beginning.
happens. Better late than never.
_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/