Review Request: find_package support for libkleo

[Eduardo Robles Elvira]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim.

This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.


Diffs
-----

  /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981
  /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION

Diff: http://reviewboard.kde.org/r/1967/diff


Testing
-------

So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.


Thanks,

Eduardo

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/#review2802
-----------------------------------------------------------


Please give more informations: Does your project concern KHTML or Konqueror ?
If it's KHTML, this patch doesn't make sense: kdelibs cannot depend on kdepim,
If it's Konqueror, you would make kdepim a dependency for kdebase(/apps) which also doesn't sound correct.

For any case: the stuff in kdepim doesn't have to be BC.
As long as libkleo is in kdepim, it shouldn't install any cmake file (that's why `find_package(Kdepim)` will return a fatal error).
If you really want to use libkleo, please consider adding a FindLibKleo.cmake in your project instead.

About the patch itself: KleoLibraryDepends.cmake contains all the kdepim dependencies. That makes your file bigger for nothing (you only need two lines from the generated file).




- Christophe


On 2009-10-24 23:48:22, Eduardo Robles Elvira wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1967/
> -----------------------------------------------------------
>
> (Updated 2009-10-24 23:48:22)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim.
>
> This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981
>   /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1967/diff
>
>
> Testing
> -------
>
> So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.
>
>
> Thanks,
>
> Eduardo
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/#review2816
-----------------------------------------------------------


Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.

- Ingo


On 2009-10-24 23:48:22, Eduardo Robles Elvira wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1967/
> -----------------------------------------------------------
>
> (Updated 2009-10-24 23:48:22)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim.
>
> This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981
>   /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1967/diff
>
>
> Testing
> -------
>
> So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.
>
>
> Thanks,
>
> Eduardo
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

> On 2009-10-26 22:30:10, Ingo Klöcker wrote:
> > Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.

FWIW, we (the KDE PIM team) have discussed to allow GPL licensed libraries in kdepimlibs. This would allow us to move libkleo to kdepimlibs from where it could be used by anything not in kdelibs. Of course, this move wouldn't change the GPL requirement for anything using libkleo.


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/#review2816
-----------------------------------------------------------


On 2009-10-24 23:48:22, Eduardo Robles Elvira wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1967/
> -----------------------------------------------------------
>
> (Updated 2009-10-24 23:48:22)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim.
>
> This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981
>   /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1967/diff
>
>
> Testing
> -------
>
> So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.
>
>
> Thanks,
>
> Eduardo
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Eduardo Robles Elvira]

> On 2009-10-25 10:07:39, Christophe Giboudeaux wrote:
> > Please give more informations: Does your project concern KHTML or Konqueror ?
> > If it's KHTML, this patch doesn't make sense: kdelibs cannot depend on kdepim,
> > If it's Konqueror, you would make kdepim a dependency for kdebase(/apps) which also doesn't sound correct.
> >
> > For any case: the stuff in kdepim doesn't have to be BC.
> > As long as libkleo is in kdepim, it shouldn't install any cmake file (that's why `find_package(Kdepim)` will return a fatal error).
> > If you really want to use libkleo, please consider adding a FindLibKleo.cmake in your project instead.
> >
> > About the patch itself: KleoLibraryDepends.cmake contains all the kdepim dependencies. That makes your file bigger for nothing (you only need two lines from the generated file).
> >
> >
> >

> Please give more informations: Does your project concern KHTML or Konqueror ?

The project I'm talking about is my university final project which is about implementing support for end-to-end
encryption support in HTML as a proof of concept (not something I will try to push to trunk/ but something I
just want to see if it works). Something like supporting <input type="text" encryption="GPG" addressee="GPG-ID-here">.
For decrypting, I'll do something like <div encryption="GPG">encrypted-data-here</div>. As I say, it's a proof of
concept only. For testing, I'll try to find a jabber-web client and add support for the mentioned encryption method,
and then run a demo with one person using this web service with konqueror, and another other using the encryption
plugin of kopete, chatting with the first one, for example.

The part that affects Konqueror is only modifying the Configure dialog so you can set up which private GPG key to use
for encrypting.

> If it's KHTML, this patch doesn't make sense: kdelibs cannot depend on kdepim,
> If it's Konqueror, you would make kdepim a dependency for kdebase(/apps) which also doesn't sound correct.
>
>
> For any case: the stuff in kdepim doesn't have to be BC.
> As long as libkleo is in kdepim, it shouldn't install any cmake file (that's why `find_package(Kdepim)` will return a fatal error).
> If you really want to use libkleo, please consider adding a FindLibKleo.cmake in your project instead.

I see, so there's currently no nice way to depend on libkleo at the moment. I'll use the FindKleo.cmake option in
my project (i.e. in my "work branch" for khtml & konqueror).

> About the patch itself: KleoLibraryDepends.cmake contains all the kdepim dependencies. That makes your file bigger for nothing (you only need two lines from the generated file).

Yeah, I know, I just copied that from gpgme++ in fact, I thought that if it was ok for them it would be ok for Kleo too :P


- Eduardo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/#review2802
-----------------------------------------------------------


On 2009-10-24 23:48:22, Eduardo Robles Elvira wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1967/
> -----------------------------------------------------------
>
> (Updated 2009-10-24 23:48:22)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim.
>
> This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981
>   /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1967/diff
>
>
> Testing
> -------
>
> So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.
>
>
> Thanks,
>
> Eduardo
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Eduardo Robles Elvira]

> On 2009-10-26 22:30:10, Ingo Klöcker wrote:
> > Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.
>
> Ingo Klöcker wrote:
>     FWIW, we (the KDE PIM team) have discussed to allow GPL licensed libraries in kdepimlibs. This would allow us to move libkleo to kdepimlibs from where it could be used by anything not in kdelibs. Of course, this move wouldn't change the GPL requirement for anything using libkleo.

> Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.
 
Oh I had not noticed, anyway Khtml is LGPL which is GPL compatible so it should be fine I suppose?
 
> FWIW, we (the KDE PIM team) have discussed to allow GPL licensed libraries in kdepimlibs. This would allow us to move libkleo to kdepimlibs from where it could be used by anything not in kdelibs. Of course, this move wouldn't change the GPL requirement for anything using libkleo.

That would be cool, anyway the move from kdepim to kdepimlibs would depend on more factors that factor it seems, for
example Christophe Giboudeaux mentioned that being it in kdepim has the advantage (for libkleo developers at least)
of not being forced to maintain BC, so I guess that's something up to KDAB people :P. Other than that, I think that
would be the best case scenario for those who would like to use libkleo (a KMyMoney developer already mentioned that
he would like to use it too).


- Eduardo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/#review2816
-----------------------------------------------------------


On 2009-10-24 23:48:22, Eduardo Robles Elvira wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1967/
> -----------------------------------------------------------
>
> (Updated 2009-10-24 23:48:22)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim.
>
> This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981
>   /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1967/diff
>
>
> Testing
> -------
>
> So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.
>
>
> Thanks,
>
> Eduardo
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

> On 2009-10-26 22:30:10, Ingo Klöcker wrote:
> > Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.
>
> Ingo Klöcker wrote:
>     FWIW, we (the KDE PIM team) have discussed to allow GPL licensed libraries in kdepimlibs. This would allow us to move libkleo to kdepimlibs from where it could be used by anything not in kdelibs. Of course, this move wouldn't change the GPL requirement for anything using libkleo.
>
> Eduardo Robles Elvira wrote:
>     > Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.
>      
>     Oh I had not noticed, anyway Khtml is LGPL which is GPL compatible so it should be fine I suppose?
>      
>     > FWIW, we (the KDE PIM team) have discussed to allow GPL licensed libraries in kdepimlibs. This would allow us to move libkleo to kdepimlibs from where it could be used by anything not in kdelibs. Of course, this move wouldn't change the GPL requirement for anything using libkleo.
>    
>     That would be cool, anyway the move from kdepim to kdepimlibs would depend on more factors that factor it seems, for
>     example Christophe Giboudeaux mentioned that being it in kdepim has the advantage (for libkleo developers at least)
>     of not being forced to maintain BC, so I guess that's something up to KDAB people :P. Other than that, I think that
>     would be the best case scenario for those who would like to use libkleo (a KMyMoney developer already mentioned that
>     he would like to use it too).

> Oh I had not noticed, anyway Khtml is LGPL which is GPL compatible so it should be fine I suppose?

No, you can't use GPL libraries in LGPL projects.
Stuff using GPL libraries needs to be GPL itself.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/#review2816
-----------------------------------------------------------


On 2009-10-24 23:48:22, Eduardo Robles Elvira wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1967/
> -----------------------------------------------------------
>
> (Updated 2009-10-24 23:48:22)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim.
>
> This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981
>   /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1967/diff
>
>
> Testing
> -------
>
> So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.
>
>
> Thanks,
>
> Eduardo
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Eduardo Robles Elvira]

> On 2009-10-26 22:30:10, Ingo Klöcker wrote:
> > Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.
>
> Ingo Klöcker wrote:
>     FWIW, we (the KDE PIM team) have discussed to allow GPL licensed libraries in kdepimlibs. This would allow us to move libkleo to kdepimlibs from where it could be used by anything not in kdelibs. Of course, this move wouldn't change the GPL requirement for anything using libkleo.
>
> Eduardo Robles Elvira wrote:
>     > Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.
>      
>     Oh I had not noticed, anyway Khtml is LGPL which is GPL compatible so it should be fine I suppose?
>      
>     > FWIW, we (the KDE PIM team) have discussed to allow GPL licensed libraries in kdepimlibs. This would allow us to move libkleo to kdepimlibs from where it could be used by anything not in kdelibs. Of course, this move wouldn't change the GPL requirement for anything using libkleo.
>    
>     That would be cool, anyway the move from kdepim to kdepimlibs would depend on more factors that factor it seems, for
>     example Christophe Giboudeaux mentioned that being it in kdepim has the advantage (for libkleo developers at least)
>     of not being forced to maintain BC, so I guess that's something up to KDAB people :P. Other than that, I think that
>     would be the best case scenario for those who would like to use libkleo (a KMyMoney developer already mentioned that
>     he would like to use it too).
>
> Thomas McGuire wrote:
>     > Oh I had not noticed, anyway Khtml is LGPL which is GPL compatible so it should be fine I suppose?
>    
>     No, you can't use GPL libraries in LGPL projects.
>     Stuff using GPL libraries needs to be GPL itself.

> No, you can't use GPL libraries in LGPL projects.
> Stuff using GPL libraries needs to be GPL itself.

Are you 100% sure? I might be wrong in this, but let me cite the FSF GPL FAQ:

http://www.gnu.org/licenses/gpl-faq.html#IfLibraryIsGPL
"If a library is released under the GPL (not the LGPL), does that mean that any program which uses it has to be under the GPL or a GPL-compatible license?

    Yes, because the program as it is actually run includes the library."

Key being here "GPL-compatible license". And LGPL is such a license, as shown here: http://www.gnu.org/philosophy/license-list.html#GPLCompatibleLicenses


- Eduardo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/#review2816
-----------------------------------------------------------


On 2009-10-24 23:48:22, Eduardo Robles Elvira wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1967/
> -----------------------------------------------------------
>
> (Updated 2009-10-24 23:48:22)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim.
>
> This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981
>   /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1967/diff
>
>
> Testing
> -------
>
> So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.
>
>
> Thanks,
>
> Eduardo
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

On Tuesday, 2009-10-27, Eduardo Robles Elvira wrote:
> > On 2009-10-26 22:30:10, Ingo Klöcker wrote:

> > No, you can't use GPL libraries in LGPL projects.
> > Stuff using GPL libraries needs to be GPL itself.
>
> Are you 100% sure? I might be wrong in this, but let me cite the FSF GPL
>  FAQ:
>
> http://www.gnu.org/licenses/gpl-faq.html#IfLibraryIsGPL
> "If a library is released under the GPL (not the LGPL), does that mean that
>  any program which uses it has to be under the GPL or a GPL-compatible
>  license?
>
>     Yes, because the program as it is actually run includes the library."
>
> Key being here "GPL-compatible license". And LGPL is such a license, as
>  shown here:
>  http://www.gnu.org/philosophy/license-list.html#GPLCompatibleLicenses

While I think that you are right, the intend of licencing KHTML under LGPL is
to allow its use in non-GPL projects.
So deriving from or linking to GPL code might be OK as far as KHTML is
concerned, it would have unwanted consequences of how any work derived from or
linking to KHTML has to be licenced.

However, this is moot anyway, KHTML is in kdelibs, evne kdepimlibs is "on top"
of that.

Cheers,
Kevin

--
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Eduardo Robles Elvira]

2009/10/27 Kevin Krammer <kevin.krammer@...>:

> While I think that you are right, the intend of licencing KHTML under LGPL is
> to allow its use in non-GPL projects.
> So deriving from or linking to GPL code might be OK as far as KHTML is
> concerned, it would have unwanted consequences of how any work derived from or
> linking to KHTML has to be licenced.
>
> However, this is moot anyway, KHTML is in kdelibs, evne kdepimlibs is "on top"
> of that.
>
> Cheers,
> Kevin

Hello,

Yeah, we couldn't use libkleo in khtml trunk even if it was in
kdepimlibs. But I can use it in khtml for the purposes of my final
project and now I know which would be the most correct way: not
patching libkleo but adding a FindKleo.cmake module to khtml.

Thanks for the review to everyone who contributed, I think it's clear
that the proposed Config.cmake file should not be added to
kdepim/libkleo and I should use a FindKleo.cmake file in my khtml &
konqueror work branch. Only if in the future libkleo is moved to
kdepimlibs (if GPL libs are accepted at all in kdepimlibs and the
libkleo maintainers wish libkleo to be moved to kdepimlibs, which are
too many "ifs" at the moment) a KleoConfig.cmake file would make
sense.

Regards,
   Eduardo Robles Elvira.
_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

> On 2009-10-26 22:30:10, Ingo Klöcker wrote:
> > Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.
>
> Ingo Klöcker wrote:
>     FWIW, we (the KDE PIM team) have discussed to allow GPL licensed libraries in kdepimlibs. This would allow us to move libkleo to kdepimlibs from where it could be used by anything not in kdelibs. Of course, this move wouldn't change the GPL requirement for anything using libkleo.
>
> Eduardo Robles Elvira wrote:
>     > Are you aware that libkleo is licensed under the GPL (and will never be relicensed to LGPL because its author does not want to do so)? This means that anything linking libkleo will also have to be GPL licensed.
>      
>     Oh I had not noticed, anyway Khtml is LGPL which is GPL compatible so it should be fine I suppose?
>      
>     > FWIW, we (the KDE PIM team) have discussed to allow GPL licensed libraries in kdepimlibs. This would allow us to move libkleo to kdepimlibs from where it could be used by anything not in kdelibs. Of course, this move wouldn't change the GPL requirement for anything using libkleo.
>    
>     That would be cool, anyway the move from kdepim to kdepimlibs would depend on more factors that factor it seems, for
>     example Christophe Giboudeaux mentioned that being it in kdepim has the advantage (for libkleo developers at least)
>     of not being forced to maintain BC, so I guess that's something up to KDAB people :P. Other than that, I think that
>     would be the best case scenario for those who would like to use libkleo (a KMyMoney developer already mentioned that
>     he would like to use it too).
>
> Thomas McGuire wrote:
>     > Oh I had not noticed, anyway Khtml is LGPL which is GPL compatible so it should be fine I suppose?
>    
>     No, you can't use GPL libraries in LGPL projects.
>     Stuff using GPL libraries needs to be GPL itself.
>
> Eduardo Robles Elvira wrote:
>     > No, you can't use GPL libraries in LGPL projects.
>     > Stuff using GPL libraries needs to be GPL itself.
>    
>     Are you 100% sure? I might be wrong in this, but let me cite the FSF GPL FAQ:
>    
>     http://www.gnu.org/licenses/gpl-faq.html#IfLibraryIsGPL
>     "If a library is released under the GPL (not the LGPL), does that mean that any program which uses it has to be under the GPL or a GPL-compatible license?
>    
>         Yes, because the program as it is actually run includes the library."
>    
>     Key being here "GPL-compatible license". And LGPL is such a license, as shown here: http://www.gnu.org/philosophy/license-list.html#GPLCompatibleLicenses

LGPL has an implicit GPL-downgrade option, which allows to combine GPL and LGPL code. We did that for a long time, before Qt was released under the LGPL, remember? ;-)

You cannot use more restrictive licenses than the GPL together with GPL code of course, but the other way around, less restrictive licenses that can be "downgraded" to GPL are perfectly fine.


- Volker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/#review2816
-----------------------------------------------------------


On 2009-10-24 23:48:22, Eduardo Robles Elvira wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1967/
> -----------------------------------------------------------
>
> (Updated 2009-10-24 23:48:22)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim.
>
> This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981
>   /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1967/diff
>
>
> Testing
> -------
>
> So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.
>
>
> Thanks,
>
> Eduardo
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/