Review Request: improved, Solid-based network error handling

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1933/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Adds Solid integration into basic network error-handling. This implementation should be applied across all applications that use standard error-handling messages, but I think it might be more proper for Solid to be integrated at the individual back-ends (for example, automatically disconnecting from online services and sending a message to the application a la Kopete).

This is my first patch, so feedback is welcomed and appreciated.


Diffs
-----

  trunk/KDE/kdelibs/kio/kio/global.cpp 1031233

Diff: http://reviewboard.kde.org/r/1933/diff


Testing
-------

The only testing I have been able to do is to see whether this compiles properly - which it does. I have not been able to build kdebase/any individual applications against it recently, which is what I plan to do.


Thanks,

Marcus

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1933/#review2918
-----------------------------------------------------------


I like the idea, but obviously this needs to be tested.

Of course this can never be 100% correct in its analysis. Your network interfaces could be up and your router could be offline, or your ISP messing up routing, etc. ;) So "incorrectly typed" is really just one possibility among many ;)


trunk/KDE/kdelibs/kio/kio/global.cpp
<http://reviewboard.kde.org/r/1933/#comment2321>

    Please use a switch() to avoid calling Solid::Networking::Status() twice.


- David


On 2009-10-22 15:18:41, Marcus Harrison wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1933/
> -----------------------------------------------------------
>
> (Updated 2009-10-22 15:18:41)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Adds Solid integration into basic network error-handling. This implementation should be applied across all applications that use standard error-handling messages, but I think it might be more proper for Solid to be integrated at the individual back-ends (for example, automatically disconnecting from online services and sending a message to the application a la Kopete).
>
> This is my first patch, so feedback is welcomed and appreciated.
>
>
> Diffs
> -----
>
>   trunk/KDE/kdelibs/kio/kio/global.cpp 1031233
>
> Diff: http://reviewboard.kde.org/r/1933/diff
>
>
> Testing
> -------
>
> The only testing I have been able to do is to see whether this compiles properly - which it does. I have not been able to build kdebase/any individual applications against it recently, which is what I plan to do.
>
>
> Thanks,
>
> Marcus
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1933/#review2923
-----------------------------------------------------------


I implemented this as a patch for KDE 3, but it was never integrated because KDE 3.6 was never released.  Here are the diffs, it may be informative, or a giant hack!

http://ktown.kde.org/~wstephenson/kde3_kdelibs_offline_mode.diff
http://ktown.kde.org/~wstephenson/kdebase_http_offline_mode.diff
http://ktown.kde.org/~wstephenson/kde3_kdepim_offline_mode.diff

The svn branches that the patches come from are here:
http://websvn.kde.org/branches/work/~wstephens/

- Will


On 2009-10-22 15:18:41, Marcus Harrison wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1933/
> -----------------------------------------------------------
>
> (Updated 2009-10-22 15:18:41)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Adds Solid integration into basic network error-handling. This implementation should be applied across all applications that use standard error-handling messages, but I think it might be more proper for Solid to be integrated at the individual back-ends (for example, automatically disconnecting from online services and sending a message to the application a la Kopete).
>
> This is my first patch, so feedback is welcomed and appreciated.
>
>
> Diffs
> -----
>
>   trunk/KDE/kdelibs/kio/kio/global.cpp 1031233
>
> Diff: http://reviewboard.kde.org/r/1933/diff
>
>
> Testing
> -------
>
> The only testing I have been able to do is to see whether this compiles properly - which it does. I have not been able to build kdebase/any individual applications against it recently, which is what I plan to do.
>
>
> Thanks,
>
> Marcus
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1933/
-----------------------------------------------------------

(Updated 2009-11-05 21:41:45.820010)


Review request for kdelibs.


Summary
-------

Adds Solid integration into basic network error-handling. This implementation should be applied across all applications that use standard error-handling messages, but I think it might be more proper for Solid to be integrated at the individual back-ends (for example, automatically disconnecting from online services and sending a message to the application a la Kopete).

This is my first patch, so feedback is welcomed and appreciated.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kio/kio/global.cpp 1044591

Diff: http://reviewboard.kde.org/r/1933/diff


Testing
-------

The only testing I have been able to do is to see whether this compiles properly - which it does. I have not been able to build kdebase/any individual applications against it recently, which is what I plan to do.


Thanks,

Marcus