Review Request: incidence.cpp:606: warning: enumeration value 'None' not handled in switch

[Guy Maurel-2]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1902/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
/.../kdepim/akonadi/resources/kolabproxy/incidence.cpp:606: warning: enumeration value 'None' not handled in switch

at
static QString attendeeStatusToString( KCal::Attendee::PartStat status )

my proposal: add the enumeration value 'None' in the switch
see: incidence-gm-19.diff


Diffs
-----

  /trunk/KDE/kdepim/akonadi/resources/kolabproxy/incidence.cpp 1031659

Diff: http://reviewboard.kde.org/r/1902/diff


Testing
-------


Thanks,

Guy

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1902/#review2734
-----------------------------------------------------------



/trunk/KDE/kdepim/akonadi/resources/kolabproxy/incidence.cpp
<http://reviewboard.kde.org/r/1902/#comment2052>

    Better to return an empty string as in
    return QString() as the method should return a QString.


- Torgny


On 2009-10-19 16:49:47, Guy Maurel wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1902/
> -----------------------------------------------------------
>
> (Updated 2009-10-19 16:49:47)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/akonadi/resources/kolabproxy/incidence.cpp:606: warning: enumeration value 'None' not handled in switch
>
> at
> static QString attendeeStatusToString( KCal::Attendee::PartStat status )
>
> my proposal: add the enumeration value 'None' in the switch
> see: incidence-gm-19.diff
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/akonadi/resources/kolabproxy/incidence.cpp 1031659
>
> Diff: http://reviewboard.kde.org/r/1902/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[Guy Maurel-2]

> On 2009-10-21 06:58:37, Torgny Nyblom wrote:
> > /trunk/KDE/kdepim/akonadi/resources/kolabproxy/incidence.cpp, line 622
> > <http://reviewboard.kde.org/r/1902/diff/1/?file=12961#file12961line622>
> >
> >     Better to return an empty string as in
> >     return QString() as the method should return a QString.

I would like to propose somethings else!
Have a look to my calls 1902 and 1906.
It is the same problem/question. And have a look 3 lines after. The author has allready an idea what is to do, but place this at a not very good place. Within the switch should be better.
BUT:
why do we have two files with nearly the same code? Some functions are really the same!
Should it be better to try to do a "merge"?


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1902/#review2734
-----------------------------------------------------------


On 2009-10-19 16:49:47, Guy Maurel wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1902/
> -----------------------------------------------------------
>
> (Updated 2009-10-19 16:49:47)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/akonadi/resources/kolabproxy/incidence.cpp:606: warning: enumeration value 'None' not handled in switch
>
> at
> static QString attendeeStatusToString( KCal::Attendee::PartStat status )
>
> my proposal: add the enumeration value 'None' in the switch
> see: incidence-gm-19.diff
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/akonadi/resources/kolabproxy/incidence.cpp 1031659
>
> Diff: http://reviewboard.kde.org/r/1902/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/