|
»
»
Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch
|
View:
New views
7 Messages
—
Rating Filter:
Alert me
|
 |
Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch
by Bugzilla from guy-kde@maurel.de
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1906/ ----------------------------------------------------------- Review request for KDE PIM. Summary ------- The dashboard http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs reports: /.../kdepim/kresources/kolab/kcal/incidence.cpp:622: warning: enumeration value 'None' not handled in switch at static QString attendeeStatusToString( KCal::Attendee::PartStat status ) my proposal:add the enumeration value 'None' in the switch see: incidence-gm-21.diff Diffs ----- /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp 1031659 Diff: http://reviewboard.kde.org/r/1906/diff Testing ------- Thanks, Guy _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch
by Bugzilla from kde@nyblom.org
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1906/#review2735 ----------------------------------------------------------- For consistency you should use the same value for the "None" case in this patch as in the other for the same variable. Either go with the default (seems to be "accepted") or return another meaningful string (might be empty, but as I don't know the code...) - Torgny On 2009-10-19 18:28:42, Guy Maurel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1906/ > ----------------------------------------------------------- > > (Updated 2009-10-19 18:28:42) > > > Review request for KDE PIM. > > > Summary > ------- > > The dashboard > http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs > reports: > /.../kdepim/kresources/kolab/kcal/incidence.cpp:622: warning: enumeration value 'None' not handled in switch > > at > static QString attendeeStatusToString( KCal::Attendee::PartStat status ) > > my proposal:add the enumeration value 'None' in the switch > see: incidence-gm-21.diff > > > Diffs > ----- > > /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp 1031659 > > Diff: http://reviewboard.kde.org/r/1906/diff > > > Testing > ------- > > > Thanks, > > Guy > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch
by Bugzilla from guy-kde@maurel.de
::
Rate this Message:
> On 2009-10-21 07:03:35, Torgny Nyblom wrote: > > For consistency you should use the same value for the "None" case in this patch as in the other for the same variable. > > Either go with the default (seems to be "accepted") or return another meaningful string (might be empty, but as I don't know the code...) right, thanks - Guy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1906/#review2735 ----------------------------------------------------------- On 2009-10-19 18:28:42, Guy Maurel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1906/ > ----------------------------------------------------------- > > (Updated 2009-10-19 18:28:42) > > > Review request for KDE PIM. > > > Summary > ------- > > The dashboard > http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs > reports: > /.../kdepim/kresources/kolab/kcal/incidence.cpp:622: warning: enumeration value 'None' not handled in switch > > at > static QString attendeeStatusToString( KCal::Attendee::PartStat status ) > > my proposal:add the enumeration value 'None' in the switch > see: incidence-gm-21.diff > > > Diffs > ----- > > /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp 1031659 > > Diff: http://reviewboard.kde.org/r/1906/diff > > > Testing > ------- > > > Thanks, > > Guy > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch
by Bugzilla from guy-kde@maurel.de
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1906/ ----------------------------------------------------------- (Updated 2009-10-21 19:01:28.401375) Review request for KDE PIM. Summary ------- The dashboard http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs reports: /.../kdepim/kresources/kolab/kcal/incidence.cpp:622: warning: enumeration value 'None' not handled in switch at static QString attendeeStatusToString( KCal::Attendee::PartStat status ) my proposal:add the enumeration value 'None' in the switch see: incidence-gm-21.diff Diffs (updated) ----- /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp 1031659 Diff: http://reviewboard.kde.org/r/1906/diff Testing ------- Thanks, Guy _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch
by David Jarvie-4
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1906/#review2781 ----------------------------------------------------------- /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp <http://reviewboard.kde.org/r/1906/#comment2132> Rather return QString() - David On 2009-10-21 19:01:28, Guy Maurel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1906/ > ----------------------------------------------------------- > > (Updated 2009-10-21 19:01:28) > > > Review request for KDE PIM. > > > Summary > ------- > > The dashboard > http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs > reports: > /.../kdepim/kresources/kolab/kcal/incidence.cpp:622: warning: enumeration value 'None' not handled in switch > > at > static QString attendeeStatusToString( KCal::Attendee::PartStat status ) > > my proposal:add the enumeration value 'None' in the switch > see: incidence-gm-21.diff > > > Diffs > ----- > > /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp 1031659 > > Diff: http://reviewboard.kde.org/r/1906/diff > > > Testing > ------- > > > Thanks, > > Guy > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch
by Bugzilla from b.broeksema@home.nl
::
Rate this Message:
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1906/#review2940 ----------------------------------------------------------- /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp <http://reviewboard.kde.org/r/1906/#comment2334> I would say that you should return "none" here. That seems the best option when looking at NeedsAction. - Bertjan On 2009-10-21 19:01:28, Guy Maurel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1906/ > ----------------------------------------------------------- > > (Updated 2009-10-21 19:01:28) > > > Review request for KDE PIM. > > > Summary > ------- > > The dashboard > http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs > reports: > /.../kdepim/kresources/kolab/kcal/incidence.cpp:622: warning: enumeration value 'None' not handled in switch > > at > static QString attendeeStatusToString( KCal::Attendee::PartStat status ) > > my proposal:add the enumeration value 'None' in the switch > see: incidence-gm-21.diff > > > Diffs > ----- > > /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp 1031659 > > Diff: http://reviewboard.kde.org/r/1906/diff > > > Testing > ------- > > > Thanks, > > Guy > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
|
|
Re: Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch
by Bugzilla from guy-kde@maurel.de
::
Rate this Message:
> On 2009-11-05 19:01:11, Bertjan Broeksema wrote: > > /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp, line 639 > > <http://reviewboard.kde.org/r/1906/diff/2/?file=13119#file13119line639> > > > > I would say that you should return "none" here. That seems the best option when looking at NeedsAction. I would like to propose somethings else! Have a look to my calls 1902 and 1906. It is the same problem/question. And have a look 3 lines after. The author has allready an idea what is to do, but place this at a not very good place. Within the switch should be better. BUT: why do we have two files with nearly the same code? Some functions are really the same! Should it be better to try to do a "merge"? - Guy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1906/#review2940 ----------------------------------------------------------- On 2009-10-21 19:01:28, Guy Maurel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1906/ > ----------------------------------------------------------- > > (Updated 2009-10-21 19:01:28) > > > Review request for KDE PIM. > > > Summary > ------- > > The dashboard > http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs > reports: > /.../kdepim/kresources/kolab/kcal/incidence.cpp:622: warning: enumeration value 'None' not handled in switch > > at > static QString attendeeStatusToString( KCal::Attendee::PartStat status ) > > my proposal:add the enumeration value 'None' in the switch > see: incidence-gm-21.diff > > > Diffs > ----- > > /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp 1031659 > > Diff: http://reviewboard.kde.org/r/1906/diff > > > Testing > ------- > > > Thanks, > > Guy > > _______________________________________________ KDE PIM mailing list kde-pim@... https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ |
| Free embeddable forum powered by Nabble | Forum Help |
