Review Request: mbox.cpp:462: warning: comparison between signed and unsigned integer expressions

View: New views
3 Messages — Rating Filter:   Alert me  

Review Request: mbox.cpp:462: warning: comparison between signed and unsigned integer expressions

by Guy Maurel-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2062/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

he dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdepim
reports:
/.../kdepim/akonadi/resources/mbox/libmbox/mbox.cpp:462: warning: comparison between signed and unsigned integer expressions

my proposal: this line is allready modified at the next line
see: mbox-gm-31.diff


Diffs
-----

  /trunk/KDE/kdepim/akonadi/resources/mbox/libmbox/mbox.cpp 1044823

Diff: http://reviewboard.kde.org/r/2062/diff


Testing
-------


Thanks,

Guy

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

Re: Review Request: mbox.cpp:462: warning: comparison between signed and unsigned integer expressions

by Bugzilla from b.broeksema@home.nl :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2062/#review2933
-----------------------------------------------------------


Looks okay. If you can commit please feel free to do, otherwise I'll add it.

- Bertjan


On 2009-11-04 18:59:35, Guy Maurel wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2062/
> -----------------------------------------------------------
>
> (Updated 2009-11-04 18:59:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> he dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdepim
> reports:
> /.../kdepim/akonadi/resources/mbox/libmbox/mbox.cpp:462: warning: comparison between signed and unsigned integer expressions
>
> my proposal: this line is allready modified at the next line
> see: mbox-gm-31.diff
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/akonadi/resources/mbox/libmbox/mbox.cpp 1044823
>
> Diff: http://reviewboard.kde.org/r/2062/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

Re: Review Request: mbox.cpp:462: warning: comparison between signed and unsigned integer expressions

by Bugzilla from b.broeksema@home.nl :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2062/#review2939
-----------------------------------------------------------

Ship it!


commited in akonadi-ports branch, will be merged to trunk soon. Please close the review and thanks for reporting..

- Bertjan


On 2009-11-04 18:59:35, Guy Maurel wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2062/
> -----------------------------------------------------------
>
> (Updated 2009-11-04 18:59:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> he dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdepim
> reports:
> /.../kdepim/akonadi/resources/mbox/libmbox/mbox.cpp:462: warning: comparison between signed and unsigned integer expressions
>
> my proposal: this line is allready modified at the next line
> see: mbox-gm-31.diff
>
>
> Diffs
> -----
>
>   /trunk/KDE/kdepim/akonadi/resources/mbox/libmbox/mbox.cpp 1044823
>
> Diff: http://reviewboard.kde.org/r/2062/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy
>
>

_______________________________________________
KDE PIM mailing list kde-pim@...
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/