Rocs moved to kdereview.

[Tomaz Canabrava-2]

 Hello fols,
 
 maybe a bit 6 months later than I expected ( mostly because I was always
 rewritting the app ) I finally moved  rocs to kdereview.
 annma is working with the conversion from "Documentation by mail" ->
  "Docbook" ( thanks, lova ya ). and the app is feature ready.
 
 I'm no designer, probably I need to rethink something on the ui, but I'm
  not sure what, and whatnot, a new name whould be ok,
 and of course, bashing my code, this way I can improve further.
 
 Thanks for your time, your confidence, your code spanking and your
  patience.
 
 Tomaz

[Parker Coates]

On Tue, Nov 3, 2009 at 09:51, Tomaz Canabrava wrote:
>
> I finally moved  rocs to kdereview.

Could you explain briefly what rocs is and which module you're
planning to move it to?

Parker

[Anne-Marie Mahfouf-2]

On Tuesday 03 November 2009 17:49:29 Parker Coates wrote:
> On Tue, Nov 3, 2009 at 09:51, Tomaz Canabrava wrote:
> > I finally moved  rocs to kdereview.
>
> Could you explain briefly what rocs is and which module you're
> planning to move it to?
>
> Parker
>
Rocs is a graph theory tool and after a discussion with both the Edu people
and the Release Team we agreed to move it to kdeedu if it's OK for all other
people (the alternate option was to create a kdescience module for advanced
uni apps or an extragear edu one but we'll see what the future of KDE-Edu
might be in the coming year for lack of (wo)man power currently).

Rocs needs a bit of interface relooking, maybe Ane Cecilia will look into it.
I'll do the doc part which is currently missing, Tomaz sent me a text already.

Best regards,

Anne-Marie
KDE-Edu coordinator

[Tomaz Canabrava]

Ok, it lacked definition, truly, so here it goes.:

Rocs aims to be a Graph Theory IDE for helping professors to show the
results of a Graph Algorithm and also helping students to do the
algorithms, no default algorithm is given, since the idea is to make
the students implement them and try.

it has a scripting module, done in Qt Script, that interacts with the
drawned graph ( in the Canvas module ), and every change in the graph
is reflected on the drawned one.

The module that this app will go is kde-edu.


--
Um Computador sem Windows é como um Navio sem dançarinas de Can-Can

[Albert Astals Cid-2]

A Dimarts, 3 de novembre de 2009, Tomaz Canabrava va escriure:

>  Hello fols,
>
>  maybe a bit 6 months later than I expected ( mostly because I was always
>  rewritting the app ) I finally moved  rocs to kdereview.
>  annma is working with the conversion from "Documentation by mail" ->
>   "Docbook" ( thanks, lova ya ). and the app is feature ready.
>
>  I'm no designer, probably I need to rethink something on the ui, but I'm
>   not sure what, and whatnot, a new name whould be ok,
>  and of course, bashing my code, this way I can improve further.
>
>  Thanks for your time, your confidence, your code spanking and your
>   patience.

When compiling i got

rocs/src/GraphicsItem/NodeItem.h:115: Warning: Class NodeItem implements the
interface QGraphicsItem but does not list it in Q_INTERFACES. qobject_cast to
QGraphicsItem will not work!

This is probably worth fixing

Then there's at least one kDebug with brazilian text
  kDebug() << "Chamando Corretamente";

And more important the code is missing some i18n() calls, some examples (grep
for them):
  _graph->addNode("Untitled"); <-- Not sure if it's needed
  QString("Column %1")
  QString("Row %1")
  QString("Untitled%1")
  _document->addGraph("Untitled"); <-- Not sure if it's needed
  "Align on the base" & friends
  "New Graph"
  "Add"
  "Untitled" + QString("%1") <-- That's bad because it concatenates strings

The tool behaviour is a bit weird, i'd prefer that the toolbar buttons to
remain pressed to show that if i press "Add Node" i'll be adding nodes until i
press another button. Also probably it would make sense changing the cursor to
indicate the current mode we are in.

Albert

>
>  Tomaz
>

On Tuesday 03 November 2009 15:51:50 Tomaz Canabrava wrote:
>  I'm no designer, probably I need to rethink something on the ui, but I'm
>   not sure what, and whatnot, a new name whould be ok,
>  and of course, bashing my code, this way I can improve further.

Some comment from my side.

First, there really should be some tutorial examples included, so that anyone
that is too lazy to read manuals can have a quick look on what it does and how
it works. Those should be editable, and could even have "bugs" so that you (as
the student) are invited to fix/improve them.

Found some bugs:

- "Open Graph..." menu item I got a crash (reported as bug 213003 to "Rocs"
product, which unfortunately has no assignee). That was after I added some
nodes. May be a Qt bug, though.

- When you start the app, the "editor" is shown, but the Editor "tab button"
is not selected. Clicking on the three buttons "Editor/Debugger/Run" seems to
randomly open/close the respective items.

- Same bug is about the "Node Properties" dialog, that appears when I click on  
a selected node. The "Show" name/value buttons are inverse to their click
state (and those should probably be check boxes).

- That "Node Properties" dialog is not a parent of the main window, so that
when you click main window, the dialog hides behind it. Maybe just make it a
dock into the main window, so that it can float or be fixed.

- Those six "..." buttons should at least have a short text if there is no
icon yet.

Didn't look at the source.

Otherwise the idea is very nice. While you could draw simple graphs with many
other applications (Kivio?), something that is "scriptable" really makes sense
to learn how transformations can be made. Ah yes, provide a good weighted tree
rebalancer as an example ;)

Christoph Feck (kdepepo)

[Tomaz Canabrava-2]

On Tuesday 03 November 2009 22:00:57 you wrote:

> On Tuesday 03 November 2009 15:51:50 Tomaz Canabrava wrote:
> >  I'm no designer, probably I need to rethink something on the ui, but I'm
> >   not sure what, and whatnot, a new name whould be ok,
> >  and of course, bashing my code, this way I can improve further.
>
> Some comment from my side.
>
> First, there really should be some tutorial examples included, so that
>  anyone that is too lazy to read manuals can have a quick look on what it
>  does and how it works. Those should be editable, and could even have
>  "bugs" so that you (as the student) are invited to fix/improve them.

There's a folder 'scripts' with really simple Graphs and Scripts ( on the
sourcecode folder ) ready to be loaded and used. I will add more later.


> Found some bugs:
>
> - "Open Graph..." menu item I got a crash (reported as bug 213003 to "Rocs"
> product, which unfortunately has no assignee). That was after I added some
> nodes. May be a Qt bug, though.

Coudn't reproduce, it crashed just by clicking on the item or by loading a
graph?

>
> - When you start the app, the "editor" is shown, but the Editor "tab
>  button" is not selected. Clicking on the three buttons
>  "Editor/Debugger/Run" seems to randomly open/close the respective items.

it's not random. if you active the editor, but the debugger is active, then
the editor is activated. if you click on it again, it will hide everything,
but I should add the 'activated' part, keep it pressed or so. thanks.

> - Same bug is about the "Node Properties" dialog, that appears when I click
>  on a selected node. The "Show" name/value buttons are inverse to their
>  click state (and those should probably be check boxes).

They have a tooltip while I'm waiting for icons, I didn't want to do
checkboxes because checkboxes have a label on the side, a toogle button works
ok ( in my no-ui-designer opinion) , with checkboxes i think that the UI will
be huge.


> - That "Node Properties" dialog is not a parent of the main window, so that
> when you click main window, the dialog hides behind it. Maybe just make it
>  a dock into the main window, so that it can float or be fixed.

Good idea,
 
> - Those six "..." buttons should at least have a short text if there is no
> icon yet.

There's the tooltip text, or you mean full text while there's no icon?

> Didn't look at the source.

Please, take a look there, i need tips to improve my coding skills.

> Otherwise the idea is very nice. While you could draw simple graphs with
>  many other applications (Kivio?), something that is "scriptable" really
>  makes sense to learn how transformations can be made. Ah yes, provide a
>  good weighted tree rebalancer as an example ;)

há =)

> Christoph Feck (kdepepo)

Tomaz

[Anne-Marie Mahfouf-2]

Tomaz, here is the first round of problems, brace yourself!

1)
> When compiling i got
>
> rocs/src/GraphicsItem/NodeItem.h:115: Warning: Class NodeItem implements
>  the interface QGraphicsItem but does not list it in Q_INTERFACES.
>  qobject_cast to QGraphicsItem will not work!
>
> This is probably worth fixing

2)

> And more important the code is missing some i18n() calls, some examples
>  (grep for them):
>   _graph->addNode("Untitled"); <-- Not sure if it's needed
>   QString("Column %1")
>   QString("Row %1")
>   QString("Untitled%1")
>   _document->addGraph("Untitled"); <-- Not sure if it's needed
>   "Align on the base" & friends
>   "New Graph"
>   "Add"
>   "Untitled" + QString("%1") <-- That's bad because it concatenates strings

I fixed some but am not sure about them and others like
./src/Core/graphDocument.h:    Graph *addGraph(QString name = "untitled");
./src/Core/graph.h:    Node* node(const QString& name = "Untitled");

Tomaz, run it in Portuguese to see about translated strings.

Also, what about the "untitled" in Scripts? won't translated "untitled" break
this (in GrapghToy.graf)?

I fixed typos and translated Portuguese debug messages to En.

3)
> The tool behaviour is a bit weird, i'd prefer that the toolbar buttons to
> remain pressed to show that if i press "Add Node" i'll be adding nodes
>  until i press another button. Also probably it would make sense changing
>  the cursor to indicate the current mode we are in.
Yes, we started to look into it at Latinoware. This must be fixed.

4) Examples are needed (also implement KNewStuff upload and download?)

5) Segfault when Cancelling an Open Graph (gdb gave no backtrace)
File -> Graph -> Open Graph then Cancel in the dialog
Christoph reported a crash as well (213003)

6) Albert (or anyone else ;): what do you think about the File menu with the
submenus Graph and Script? Shouldn't Graph and Script be menus on their own?

7) The QWhatsThis need to be done
<whatsthis>long explanation needed. </whatsthis> cannot stay as it is, wastes
translators time and brings nothing to users.

8) Right click mouse events: in Add Node mode for example, I expect left click
to add a node and right click to edit properties. Both add a node.
Properties dialog is weird to find (you need to be in Select mode...)

In this Properties dialog: we need to ask usability people about the
(label)Show: (button)Name (button)Value
which I also find very weird and not consistent with KDE. Christoph also noted
that.

9) See Christoph mail for other bugs!

Any usability reader please help on the design :)

Anne-Marie

[Tomaz Canabrava]

Ok, I'v managed to fix 2 crashes, workarounding a well known
qt-problem on trees & graphicsview.
it shoudn't crash no more.

and improved the showing of the properties of the nodes and edges.

tomorrow I will do nothing ( beach time ), but I plan to have
everything that anyone say here fixed by next sunday.