SBSC: Method concatenates strings using + in a loop

View: New views
1 Messages — Rating Filter:   Alert me  

SBSC: Method concatenates strings using + in a loop

by gardner_art :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.

My guess would be that we don’t want to flag the “Method concatenates strings using + in a loop” condition, if the string is always intialized in the loop, as well?

 

The following was flagged in 1.3.9.20090821:

 

                                while (all.hasNext()) {

                                                Map.Entry entry = (Map.Entry) all.next();

                                                String key = (String) entry.getKey();

                                                if (!usedObjects.containsKey(key)) {

                                                                Content cont = (Content) entry.getValue();

                                                                String msg = key + "\t" + cont.getName();

                                                                if (!versioning)

                                                                                msg += " " + cont.getVersion();

                                                                msg += "\t";

                                                                if (!cont.getDocumentName().equals(masterDoc))

>>>                                                                        msg += cont.getDocumentName();

                                                                sw.logUnused(msg);

                                                }

                                }

 

Art


_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@...
https://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss