SCEnvelopeView class and doc fixes

View: New views
14 Messages — Rating Filter:   Alert me  

SCEnvelopeView class and doc fixes

by Scott Wilson-8 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

SCEnvelopeView help claims that there are getters for grid, gridOn and  
gridColor. There aren't.

Also, would have been nice to know that grid corresponds to times, not  
pixels.

I'm going to commit corrected versions of these.

S.

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by blackrain-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

primitive dodge 0.0?
it does crash bad.

thanks,

x

On Fri, Apr 24, 2009 at 3:55 AM, Scott Wilson <i@...> wrote:

> SCEnvelopeView help claims that there are getters for grid, gridOn and
> gridColor. There aren't.
>
> Also, would have been nice to know that grid corresponds to times, not
> pixels.
>
> I'm going to commit corrected versions of these.
>
> S.
>
> _______________________________________________
> sc-dev mailing list
>
> info (subscription, etc.):
> http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
> archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
> search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/
>

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by blackrain-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Wait!
I meant the env view - apologies.

x

On Fri, Apr 24, 2009 at 3:56 AM, blackrain <blackrain.sc@...> wrote:

> primitive dodge 0.0?
> it does crash bad.
>
> thanks,
>
> x
>
> On Fri, Apr 24, 2009 at 3:55 AM, Scott Wilson <i@...> wrote:
>> SCEnvelopeView help claims that there are getters for grid, gridOn and
>> gridColor. There aren't.
>>
>> Also, would have been nice to know that grid corresponds to times, not
>> pixels.
>>
>> I'm going to commit corrected versions of these.
>>
>> S.
>>
>> _______________________________________________
>> sc-dev mailing list
>>
>> info (subscription, etc.):
>> http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
>> archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
>> search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/
>>
>

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by Scott Wilson-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On 24 Apr 2009, at 09:56, blackrain wrote:

primitive dodge 0.0?
it does crash bad.

Ouch! That should be fixed. I would have thought 0.0 on one axis would mean no grid for that.

Also just noticed the help file says this in the example:

// show grid
b.gridOn_(false);

Hmm...

S.

Re: SCEnvelopeView class and doc fixes

by blackrain-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

kewl!
thanks =)

x

On Fri, Apr 24, 2009 at 4:01 AM, Scott Wilson <s.d.wilson.1@...> wrote:

>
> On 24 Apr 2009, at 09:56, blackrain wrote:
>
> primitive dodge 0.0?
> it does crash bad.
>
> Ouch! That should be fixed. I would have thought 0.0 on one axis would mean
> no grid for that.
> Also just noticed the help file says this in the example:
> // show grid
> b.gridOn_(false);
> Hmm...
> S.

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by Scott Wilson-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I'm trying to track this down, but in the meantime in the C++  
setProperty, does this actually ever get used?

                if (strcmp(name, "setGraphView")==0) {
                        mDrawCenteredConnection = false;
                        mIsEnvView = false;
                        return errNone;
                }

Seems to be dead code.

S.

On 24 Apr 2009, at 10:02, blackrain wrote:

> kewl!
> thanks =)
>
> x
>
> On Fri, Apr 24, 2009 at 4:01 AM, Scott Wilson <s.d.wilson.
> 1@...> wrote:
>>
>> On 24 Apr 2009, at 09:56, blackrain wrote:
>>
>> primitive dodge 0.0?
>> it does crash bad.
>>
>> Ouch! That should be fixed. I would have thought 0.0 on one axis  
>> would mean
>> no grid for that.
>> Also just noticed the help file says this in the example:
>> // show grid
>> b.gridOn_(false);
>> Hmm...
>> S.
>
> _______________________________________________
> sc-dev mailing list
>
> info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
> archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
> search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/


_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by blackrain-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

hmm, to be honest, I gave the prim a go once.
got my views as I wanted, played with it and saw the bug - I stepped out.

maybe Jan is the best to ask. I never took a look at that code.
'shouldnt be to hard to hijack zero tho.

cheers,

x


On Fri, Apr 24, 2009 at 4:06 AM, Scott Wilson <s.d.wilson.1@...> wrote:

> I'm trying to track this down, but in the meantime in the C++ setProperty,
> does this actually ever get used?
>
>                if (strcmp(name, "setGraphView")==0) {
>                        mDrawCenteredConnection = false;
>                        mIsEnvView = false;
>                        return errNone;
>                }
>
> Seems to be dead code.
>
> S.
>
> On 24 Apr 2009, at 10:02, blackrain wrote:
>
>> kewl!
>> thanks =)
>>
>> x
>>
>> On Fri, Apr 24, 2009 at 4:01 AM, Scott Wilson <s.d.wilson.1@...>
>> wrote:
>>>
>>> On 24 Apr 2009, at 09:56, blackrain wrote:
>>>
>>> primitive dodge 0.0?
>>> it does crash bad.
>>>
>>> Ouch! That should be fixed. I would have thought 0.0 on one axis would
>>> mean
>>> no grid for that.
>>> Also just noticed the help file says this in the example:
>>> // show grid
>>> b.gridOn_(false);
>>> Hmm...
>>> S.
>>
>> _______________________________________________
>> sc-dev mailing list
>>
>> info (subscription, etc.):
>> http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
>> archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
>> search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/
>
>
> _______________________________________________
> sc-dev mailing list
>
> info (subscription, etc.):
> http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
> archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
> search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/
>

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by Scott Wilson-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Okay fixed I think:

while(xgridpos < maxwidth && (xgrid != 0.0))
{
drawRect = CGRectMake(xgridpos, 
  bounds.y + 1.f
  1.f
  bounds.height-2.f);
CGContextFillRect (cgc, drawRect); 
xgridpos += xgrid;
}


while(ygridpos < maxheight && (ygrid != 0.0))
{
drawRect = CGRectMake(bounds.x+1.f
  ygridpos, 
  bounds.width-2.f
  1.f);
CGContextFillRect (cgc, drawRect); 
ygridpos += ygrid;
}


Now you can say b.grid = 0.0@... for only horizontal, etc.

On a related track, gridColor in SCScope seems to do nothing. This should at least be removed from the help file, or?

Also setting gridResolution to 0.0 on an SCSoundfile causes a crash as well.

S.


On 24 Apr 2009, at 10:10, blackrain wrote:

hmm, to be honest, I gave the prim a go once.
got my views as I wanted, played with it and saw the bug - I stepped out.

maybe Jan is the best to ask. I never took a look at that code.
'shouldnt be to hard to hijack zero tho.

cheers,

x


On Fri, Apr 24, 2009 at 4:06 AM, Scott Wilson <s.d.wilson.1@...> wrote:
I'm trying to track this down, but in the meantime in the C++ setProperty,
does this actually ever get used?

               if (strcmp(name, "setGraphView")==0) {
                       mDrawCenteredConnection = false;
                       mIsEnvView = false;
                       return errNone;
               }

Seems to be dead code.

S.

On 24 Apr 2009, at 10:02, blackrain wrote:

kewl!
thanks =)

x

On Fri, Apr 24, 2009 at 4:01 AM, Scott Wilson <s.d.wilson.1@...>
wrote:

On 24 Apr 2009, at 09:56, blackrain wrote:

primitive dodge 0.0?
it does crash bad.

Ouch! That should be fixed. I would have thought 0.0 on one axis would
mean
no grid for that.
Also just noticed the help file says this in the example:
// show grid
b.gridOn_(false);
Hmm...
S.

_______________________________________________
sc-dev mailing list

info (subscription, etc.):
http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/


_______________________________________________
sc-dev mailing list

info (subscription, etc.):
http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/


_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/


Re: SCEnvelopeView class and doc fixes

by blackrain-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Apr 24, 2009 at 4:20 AM, Scott Wilson <s.d.wilson.1@...> wrote:

> Okay fixed I think:
> while(xgridpos < maxwidth && (xgrid != 0.0))
> {
> drawRect = CGRectMake(xgridpos,
>   bounds.y + 1.f,
>   1.f,
>   bounds.height-2.f);
> CGContextFillRect (cgc, drawRect);
> xgridpos += xgrid;
> }
>
> while(ygridpos < maxheight && (ygrid != 0.0))
> {
> drawRect = CGRectMake(bounds.x+1.f,
>   ygridpos,
>   bounds.width-2.f,
>   1.f);
> CGContextFillRect (cgc, drawRect);
> ygridpos += ygrid;
> }
>
> Now you can say b.grid = 0.0@... for only horizontal, etc.
> On a related track, gridColor in SCScope seems to do nothing. This should at
> least be removed from the help file, or?
> Also setting gridResolution to 0.0 on an SCSoundfile causes a crash as well.
> S.
>

I would say yes about the grid colour, mean time that is.
I wasnt aware of the SCSoundfile issue tho

I'd say cut? at least till there is a true implementation?

cheers,

x

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by Scott Wilson-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On 24 Apr 2009, at 10:26, blackrain wrote:

> On Fri, Apr 24, 2009 at 4:20 AM, Scott Wilson <s.d.wilson.
> 1@...> wrote:
>> Okay fixed I think:
>> while(xgridpos < maxwidth && (xgrid != 0.0))
>> {
>> drawRect = CGRectMake(xgridpos,
>>   bounds.y + 1.f,
>>   1.f,
>>   bounds.height-2.f);
>> CGContextFillRect (cgc, drawRect);
>> xgridpos += xgrid;
>> }
>>
>> while(ygridpos < maxheight && (ygrid != 0.0))
>> {
>> drawRect = CGRectMake(bounds.x+1.f,
>>   ygridpos,
>>   bounds.width-2.f,
>>   1.f);
>> CGContextFillRect (cgc, drawRect);
>> ygridpos += ygrid;
>> }
>>
>> Now you can say b.grid = 0.0@... for only horizontal, etc.
>> On a related track, gridColor in SCScope seems to do nothing. This  
>> should at
>> least be removed from the help file, or?
>> Also setting gridResolution to 0.0 on an SCSoundfile causes a crash  
>> as well.
>> S.
>>
>
> I would say yes about the grid colour, mean time that is.
> I wasnt aware of the SCSoundfile issue tho
>
> I'd say cut? at least till there is a true implementation?

It's not used as far as I can see anywhere in SCScope's draw method.  
So I suppose it's something half done. Maybe just remove from the help  
file so somebody can finish later?

S.

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by blackrain-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Apr 24, 2009 at 4:29 AM, Scott Wilson <s.d.wilson.1@...> wrote:
>
> It's not used as far as I can see anywhere in SCScope's draw method. So I
> suppose it's something half done. Maybe just remove from the help file so
> somebody can finish later?
>

kewl.
scope doesnt seem to do much in this case - it does for inheritance on
the lang side AFAIK.
not the case. right?

SCSoundFileView is a good example of this.

x

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by Scott Wilson-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On 24 Apr 2009, at 10:35, blackrain wrote:

> On Fri, Apr 24, 2009 at 4:29 AM, Scott Wilson <s.d.wilson.
> 1@...> wrote:
>>
>> It's not used as far as I can see anywhere in SCScope's draw  
>> method. So I
>> suppose it's something half done. Maybe just remove from the help  
>> file so
>> somebody can finish later?
>>
>
> kewl.
> scope doesnt seem to do much in this case - it does for inheritance on
> the lang side AFAIK.
> not the case. right?
>
> SCSoundFileView is a good example of this.

It's not an abstract class, so that seems a little fishy.

It's not a big deal though. Maybe we should leave it until post-3.3?

S.

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by blackrain-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Apr 24, 2009 at 5:40 AM, Scott Wilson <s.d.wilson.1@...> wrote:

>
> On 24 Apr 2009, at 10:35, blackrain wrote:
>
>> On Fri, Apr 24, 2009 at 4:29 AM, Scott Wilson <s.d.wilson.1@...>
>> wrote:
>>>
>>> It's not used as far as I can see anywhere in SCScope's draw method. So I
>>> suppose it's something half done. Maybe just remove from the help file so
>>> somebody can finish later?
>>>
>>
>> kewl.
>> scope doesnt seem to do much in this case - it does for inheritance on
>> the lang side AFAIK.
>> not the case. right?
>>
>> SCSoundFileView is a good example of this.
>
> It's not an abstract class, so that seems a little fishy.
>

hmm that was my point but I see yours.

> It's not a big deal though. Maybe we should leave it until post-3.3?
>

sure np.

> S.
>

cheers,

x

_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/

Re: SCEnvelopeView class and doc fixes

by ronald kuivila :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

BTW: this view also fails to draw perfectly horizontal segments.

RJK
On Apr 24, 2009, at 6:43 AM, blackrain wrote:

> On Fri, Apr 24, 2009 at 5:40 AM, Scott Wilson <s.d.wilson.
> 1@...> wrote:
>>
>> On 24 Apr 2009, at 10:35, blackrain wrote:
>>
>>> On Fri, Apr 24, 2009 at 4:29 AM, Scott Wilson <s.d.wilson.1@...
>>> >
>>> wrote:
>>>>
>>>> It's not used as far as I can see anywhere in SCScope's draw  
>>>> method. So I
>>>> suppose it's something half done. Maybe just remove from the help  
>>>> file so
>>>> somebody can finish later?
>>>>
>>>
>>> kewl.
>>> scope doesnt seem to do much in this case - it does for  
>>> inheritance on
>>> the lang side AFAIK.
>>> not the case. right?
>>>
>>> SCSoundFileView is a good example of this.
>>
>> It's not an abstract class, so that seems a little fishy.
>>
>
> hmm that was my point but I see yours.
>
>> It's not a big deal though. Maybe we should leave it until post-3.3?
>>
>
> sure np.
>
>> S.
>>
>
> cheers,
>
> x
>
> _______________________________________________
> sc-dev mailing list
>
> info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
> archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
> search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/
>


_______________________________________________
sc-dev mailing list

info (subscription, etc.): http://www.beast.bham.ac.uk/research/sc_mailing_lists.shtml
archive: http://www.listarc.bham.ac.uk/marchives/sc-dev/
search: http://www.listarc.bham.ac.uk/lists/sc-dev/search/