SVN 6397 issues JSON warnings and RPM catch 22

[Michael R. Davis]

GPSD Folks,
1) Are these build warnings an issue?

json.c: In function 'json_internal_read_object':
json.c:116: warning: 'maxlen' may be used uninitialized in this function
json.c:113: warning: 'value_quoted' may be used uninitialized in this function

2) tar needs jsongen.py

make[1]: *** No rule to make target `jsongen.py', needed by `ais_json.i'.  Stop.

Looks like jsongen.py needs to be in the tar ball.

3) I know that you guys hate putting generated files in the distribution but the packaging/gpsd.spec file needs to be added to the tar in order to be able to boot strap the rpmbuild process.

$ ./autogen.sh
$ make dist-rpm

`make dist-rpm` will not work without the spec file.

Here is the diff that I used to get things going.


$ svn diff
Index: Makefile.am
===================================================================
--- Makefile.am (revision 6397)
+++ Makefile.am (working copy)
@@ -401,7 +401,10 @@
        gpscap.ini \
        packaging/etc_default_gpsd \
        packaging/etc_init.d_gpsd \
-       packaging/etc_init.d_gpsd_rpm
+       packaging/etc_init.d_gpsd_rpm \
+        packaging/gpsd.spec \
+        devtools/maskaudit \
+        jsongen.py
 
 #dist-hook:
 #      $(MKDIR_P) '$(distdir)/contrib' && \

I don't know what "maskaudit" is but I guess that will be cleaned up before shipping and I assume that jsongen.py was an oversight.  I have no idea if I put these in the correct section.

Any reason we are pushing a Y every second now?  Is that coming from my BU-303?

GPSD,O=?
GPSD,Y=MID4 1255408358.640 11:5 11 90 0 0:6 12 309 32 0:27 47 118 0 0:15 47 46 42 0:29 11 199 0 0:21 76 268 0 0:18 54 304 36 0:22 22 285 0 0:3 6 316 0 0:9 39 142 0 0:26 24 228 0 0:
GPSD,O=?
GPSD,Y=MID4 1255408359.640 11:5 11 90 0 0:6 12 309 32 0:27 47 118 0 0:15 47 46 42 0:29 11 199 0 0:21 76 268 0 0:18 54 304 36 0:22 22 285 0 0:3 6 316 0 0:9 39 142 0 0:26 24 228 0 0:

Thanks,
Mike (mrdvt92)


     
_______________________________________________
Gpsd-dev mailing list
Gpsd-dev@...
https://lists.berlios.de/mailman/listinfo/gpsd-dev

[Eric S. Raymond-2]

Michael R. Davis <mrdvt92@...>:
> GPSD Folks,
> 1) Are these build warnings an issue?
>
> json.c: In function 'json_internal_read_object':
> json.c:116: warning: 'maxlen' may be used uninitialized in this function
> json.c:113: warning: 'value_quoted' may be used uninitialized in this function

They're probably not an issue, but I've fixed them anyway.
 
> 2) tar needs jsongen.py
>
> make[1]: *** No rule to make target `jsongen.py', needed by `ais_json.i'.  Stop.
>
> Looks like jsongen.py needs to be in the tar ball.

Done.
 
> 3) I know that you guys hate putting generated files in the distribution but the packaging/gpsd.spec file needs to be added to the tar in order to be able to boot strap the rpmbuild process.
>
> $ ./autogen.sh
> $ make dist-rpm
>
> `make dist-rpm` will not work without the spec file.

Done.

> I don't know what "maskaudit" is but I guess that will be cleaned up
> before shipping and I assume that jsongen.py was an oversight.  I
> have no idea if I put these in the correct section.

You did right.  makaudit generates some C code used for writing debug messages.
Next time you run at -D 4 and see detailed lists of what flag masks are set,
that's what the generated code is doing.
 
> Any reason we are pushing a Y every second now?  Is that coming from my BU-303?

Yes. Our driver was ignoring 4 out of 5 of those until recently, in order
to simulate the 5-second GPGSV report interval you normally get on NMEA
devices.
--
                <a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
_______________________________________________
Gpsd-dev mailing list
Gpsd-dev@...
https://lists.berlios.de/mailman/listinfo/gpsd-dev