Script errors in with Firefox 3.5 / Opencms 7.0.5

[Christian Steinert]

Dear all,

with the recently released Firefox 3.5, I get script errors in opencms
7.0.5, when trying to navigate into most folders in the explorer  view.

Is anybody else seeing something similar?

Best Regards
Christian

_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Christoph P. Kukulies]

On Thu, Jul 02, 2009 at 08:53:36AM +0200, Christian Steinert wrote:
> Dear all,
>
> with the recently released Firefox 3.5, I get script errors in opencms
> 7.0.5, when trying to navigate into most folders in the explorer  view.
>
> Is anybody else seeing something similar?
>
> Best Regards
> Christian

I just gave it a try (FF 3.5 on 7.0.5) and I can confirm that I get at
least a strange behaviour when logging into the workplace. Folders do
not appear as folders but greyed out file symbols. Context menu doesn't
work. I'm trying to go back to 3.0.0.x and see if it's the same.


--
Chris Christoph P. U. Kukulies kukulies (at) rwth-aachen.de



_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Roman Uhlig]

Same here. I.e. clicking on a folder generates a JS error and nothing happens.

I also like to note, that this happens in a lot of webapps we did, even with pure JQuery usage. So I think it's a JS bug or at least an unwanted change in JS behaviour in FF 3.5.

[Christoph P. Kukulies]

On Thu, Jul 02, 2009 at 02:18:18AM -0700, Roman Uhlig wrote:
>
> Same here. I.e. clicking on a folder generates a JS error and nothing
> happens.

I cannot see the script errors though and the behaviour is different
on two different computers.  

--
Chris Christoph P. U. Kukulies kukulies (at) rwth-aachen.de

_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Roman Uhlig]

The strange thing is: it's not happening all the time and on all servers. E.g. if I log into one of our local intranet OpenCms servers, it's happening almost all the time. On one of our online servers its almost working fine.

But as I said before, it's most probably a Firefox problem, not an OpenCms one. We have massive javascript problems in other web applications as well with Firefox 3.5.

Hi Roman,

this could be a time - dependent / synchronization change issue. FF 3.5
has become faster than it's predecessor.

Would be great if those javascript errors would  be posted to see if it
is the same:


Error: node is undefined
Source File: http://localhost:8080/opencms_head/resources/commons/tree.js
Line: 268

Kind Regards,
Achim.

-------------------
Achim Westermann

Alkacon Software GmbH  - The OpenCms Experts
http://www.alkacon.com - http://www.opencms.org


Roman Uhlig schrieb:
> The strange thing is: it's not happening all the time and on all servers.
> E.g. if I log into one of our local intranet OpenCms servers, it's happening
> almost all the time. On one of our online servers its almost working fine.
>
> But as I said before, it's most probably a Firefox problem, not an OpenCms
> one. We have massive javascript problems in other web applications as well
> with Firefox 3.5.

_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Roman Uhlig]

Hi Achim,

this gives very interesting results:

in OpenCms when clicking on a folder item in workplace:

assignment to undeclared variable i
[Break on this error] for (i=0; i<childs.length; i++) {\r\n
tree.js (Linie 421)

in one of our own webapps/js scripts:

assignment to undeclared variable queueLength
[Break on this error] queueLength = queue.length;\r\n
async.js (Linie 618)

Since when do you HAVE TO declare variables in javascript?

[Roman Uhlig]

BTW: Despite the title of the thread this happens in OpenCms 7.5 as well.

[Roman Uhlig]

To me it seems it's only happening in the following scenario, when you use a not declared variable with the same identifier in alternative parts of a javascript script, e.g.:

if (true) {
  v1 = 'a';
} else {
  v1 = 'b';
}

while this is working fine:

var v1;
if (true) {
  v1 = 'a';
} else {
  v1 = 'b';
}

Best regards,
Roman

[Christian Steinert]

> in OpenCms when clicking on a folder item in workplace:
>
> assignment to undeclared variable i
> [Break on this error] for (i=0; i<childs.length; i++) {\r\n
> tree.js (Linie 421)

This is very strange. normally, "i" should be made into a global variable, if it has not been declared before.
This can lead to horrible bugs, of course, so variables should not be global, if it can be avoided at all, but that there is an explicit error being reported there, is rather surprising to me.

The same goes for the second example
> [Break on this error] queueLength = queue.length;\r\n

Normally, assigning to an undefined variable should automatically create a global variable.

Regards
Christian
______________________________________________________
GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://movieflat.web.de


_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Roman Uhlig]

There is even more strangeness with Firefox 3.5. As Achim already mentioned, there may be timing issues with Firefox' increased javascript performance. And indeed, a lot of our Ajax scripts started behaving strangely. More commonly, XMLHttpRequest seems to behave differently now with Firefox 3.5, especially if you work on localhost. There is a big difference in what works and what not depending on what server you are working on (local or remote).

[Christian Steinert]

> There is even more strangeness with Firefox 3.5. As Achim already mentioned,
> there may be timing issues with Firefox' increased javascript performance.
> And indeed, a lot of our Ajax scripts started behaving strangely. More
> commonly, XMLHttpRequest seems to behave differently now with Firefox 3.5,
> especially if you work on localhost. There is a big difference in what works
> and what not depending on what server you are working on (local or remote).

What you describe sounds like some sort of race condition to me.

FF3.5 has changed the way how parsing interacts with javascript (called speculative parsing): HTML parsing does not block anymore, while Javascript files are loaded and then later, things like document.write(...) are patched into already parsed DOM tree.


But the script error that I get is "subnode is undefined":

  function getNodeIdByName(nodeName) {
  ....
     for (i=0; i<childs.length; i++) {
         subnode = tree.nodes[childs[i]];
         var subname = result + subnode.name;


Having subnode be undefined there is rather weird.
Both tree.nods and childs contain proper data. For entries in childs, there seems to be a corresponding entry in tree.nodes. And all entries in tree.nodes have a name property. So I really don't know what is wrong there. It all looks right

Sadly, the Javascript debugger of Firebug also seems to have a few issues in Firefox 3.5 right now, so some things behave a little strange (the source code location, where the degugger is at, is not shown properly, when stopping at a break point).

But the opencms-Javascript seems to be fine and the data also seems to be right, too.

Weird indeed :(

Best regards
Christian
______________________________________________________
GRATIS für alle WEB.DE-Nutzer: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://movieflat.web.de


_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Christoph P. Kukulies]

On Thu, Jul 02, 2009 at 11:03:57AM +0200, Christoph P. Kukulies wrote:

> On Thu, Jul 02, 2009 at 08:53:36AM +0200, Christian Steinert wrote:
> > Dear all,
> >
> > with the recently released Firefox 3.5, I get script errors in opencms
> > 7.0.5, when trying to navigate into most folders in the explorer  view.
> >
> > Is anybody else seeing something similar?
> >
> > Best Regards
> > Christian
>
> I just gave it a try (FF 3.5 on 7.0.5) and I can confirm that I get at
> least a strange behaviour when logging into the workplace. Folders do
> not appear as folders but greyed out file symbols. Context menu doesn't
> work. I'm trying to go back to 3.0.0.x and see if it's the same.

I got rid of this strange looking workplace by deleting browser cache
and cookies in FF3.5 .

I did not experience any javascript error yet, though with FF3.5 and the
7.5 workplace.


--
Chris Christoph P. U. Kukulies kukulies (at) rwth-aachen.de


_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

Hi Roman,

thanks, this was a hint for us. We found a similar snippet in tree.js,
changed it and it looks good on my FF 3.5.


Kind Regards,
Achim.

-------------------
Achim Westermann

Alkacon Software GmbH  - The OpenCms Experts
http://www.alkacon.com - http://www.opencms.org





Roman Uhlig schrieb:

> To me it seems it's only happening in the following scenario, when you use a
> not declared variable with the same identifier in alternative parts of a
> javascript script, e.g.:
>
> if (true) {
>   v1 = 'a';
> } else {
>   v1 = 'b';
> }
>
> while this is working fine:
>
> var v1;
> if (true) {
>   v1 = 'a';
> } else {
>   v1 = 'b';
> }
>
> Best regards,
> Roman

_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Roman Uhlig]

Unfortunately it seems this does not completely solve the FF 3.5 issue. Browsing with the workplace explorer got much better after updating tree.js, but it sometimes still "hangs". In my case especially when I click "Level Up".

[Roman Uhlig]

Unfortunately it seems this does not completely solve the FF 3.5 issue.
Browsing with the workplace explorer got much better after updating tree.js,
but it sometimes still "hangs". In my case especially when I click "Level
Up".


--
View this message in context: http://www.nabble.com/Script-errors-in-with-Firefox-3.5---Opencms-7.0.5-tp24302151p24352174.html
Sent from the OpenCMS - Dev mailing list archive at Nabble.com.


_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Beyer Detlef]

Hi there,

just a quick question: I installed the 7.5 update on our test server -  
works fine so far.
I run into one problem:

- when I open a structured content page that uses the  
ImageGalleryWidget and open an image, I see a new window but no image  
there and no galleries to select from. Both pages are empty.

What do I have to change to get the galleries running with 7.5?

Thanks for your help!

Detlef

_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Christian Steinert]

Roman Uhlig wrote:
> Unfortunately it seems this does not completely solve the FF 3.5 issue.
> Browsing with the workplace explorer got much better after updating tree.js,
> but it sometimes still "hangs". In my case especially when I click "Level
> Up".
>
>
>  
Dear Roman

I also stepped into some more explorer problems with FF3.5
I tried to clean some things up and debug things, but so far, there are
still  issues - sometimes freezes and with some folders I have the
problem, that part of the folder hierarchy is repeatedly added into the
navigation tree on.


So far, I have not been able to track anything down.
The tree function getNodeIdByName still seems to behave somewhat
unpredictably and sometimes does seem to not find folders that are
already loaded. These problems don't seem to be there, if I de-activate
the jit. I have not been  able to pinpoint anything and a few attempts
at changing the code slightly have also not worked around the problem.
When I debugged step by step, then things work properly, but when not
doing that, folders were inserted again, despite existing already,
because getNodeIdByName did not find them, if I was not debugging.
Strange indeed.


Christian

_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

Hi Detlef,

did you install all modules from the updater? Did you try to

- Clear the browser cache ?
- Purge your jsp repository?
- delete the work directory of tomcat?


Kind Regards,
Achim.

-------------------
Achim Westermann

Alkacon Software GmbH  - The OpenCms Experts
http://www.alkacon.com - http://www.opencms.org


Beyer Detlef wrote:

> Hi there,
>
> just a quick question: I installed the 7.5 update on our test server -  
> works fine so far.
> I run into one problem:
>
> - when I open a structured content page that uses the  
> ImageGalleryWidget and open an image, I see a new window but no image  
> there and no galleries to select from. Both pages are empty.
>
> What do I have to change to get the galleries running with 7.5?
>
> Thanks for your help!
>
> Detlef
>
> _______________________________________________
> This mail is sent to you from the opencms-dev mailing list
> To change your list options, or to unsubscribe from the list, please visit
> http://lists.opencms.org/mailman/listinfo/opencms-dev

_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev

[Beyer Detlef]

Hi Achim,

is there anything I have to change to get my 7.0.5 galleries to work  
with 7.5? At the moment this is a real show stopper for me, because  
I'm not able to modify any images contained in a structured content  
document.
When I jump into the directory were my galleries are stored (/img/)  
and open one of them - the new 7.5 interface works and shows all  
images within this gallery...

Im using:

<xsd:element name="ImageSrc"  type="OpenCmsVfsFile" minOccurs="0"  
maxOccurs="1" />

with

<layout element="ImageSrc" widget="ImageGalleryWidget" />

Thanks a lot for the help,

Detlef

Am 06.07.2009 um 17:21 schrieb a.westermann@...:

> Hi Detlef,
>
> did you install all modules from the updater? Did you try to
>
> - Clear the browser cache ?
> - Purge your jsp repository?
> - delete the work directory of tomcat?
>
>
> Kind Regards,
> Achim.
>
> -------------------
> Achim Westermann
>
> Alkacon Software GmbH  - The OpenCms Experts
> http://www.alkacon.com - http://www.opencms.org
>
>
> Beyer Detlef wrote:
>> Hi there,
>>
>> just a quick question: I installed the 7.5 update on our test  
>> server -
>> works fine so far.
>> I run into one problem:
>>
>> - when I open a structured content page that uses the
>> ImageGalleryWidget and open an image, I see a new window but no image
>> there and no galleries to select from. Both pages are empty.
>>
>> What do I have to change to get the galleries running with 7.5?
>>
>> Thanks for your help!
>>
>> Detlef
>>
>> _______________________________________________
>> This mail is sent to you from the opencms-dev mailing list
>> To change your list options, or to unsubscribe from the list,  
>> please visit
>> http://lists.opencms.org/mailman/listinfo/opencms-dev
>
> _______________________________________________
> This mail is sent to you from the opencms-dev mailing list
> To change your list options, or to unsubscribe from the list, please  
> visit
> http://lists.opencms.org/mailman/listinfo/opencms-dev

_______________________________________________
This mail is sent to you from the opencms-dev mailing list
To change your list options, or to unsubscribe from the list, please visit
http://lists.opencms.org/mailman/listinfo/opencms-dev