Should I clean up and submit patches?

View: New views
3 Messages — Rating Filter:   Alert me  

Should I clean up and submit patches?

by Roger Scott-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
Hello list,

For the past couple of years I have been applying my own set of rather rough patches to the xine library.  Although this list seems curiously devoid of traffic I thought I'd ask if there was enough interest that it would be worth me spending some time to clean them up and submit them?  There are three that might be of interest:

1. An amendment to the stdin plugin (fd:// url) to allow a supplied file descriptor number.  This is used by my pvr software which handles the creation of a pipe by itself and then passes the descriptor number to xine for display.

2. A Topfield rec file input plugin derived from the MPEG-TS plugin.

3. A closed caption teletext spu plugin which decodes and displays the DVB teletext captions broadcast in Australia.  This is probably the most useful but it also the most rough and I cannot guarantee it will work elsewhere in the world.

Any interest?

Roger.


Find out how here Use Messenger in your Hotmail inbox
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: Should I clean up and submit patches?

by Darren Salt :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I demand that Roger Scott may or may not have written...

> For the past couple of years I have been applying my own set of rather
> rough patches to the xine library.  Although this list seems curiously
> devoid of traffic I thought I'd ask if there was enough interest that it
> would be worth me spending some time to clean them up and submit them?

The first step is to post them here with suitable subject lines and
descriptions. If you have a local xine-lib repository (cloned from [0]), then
you could commit them then use "hg email" to send them.

They'll probably either end up in the patch queue [1] or be committed to the
master repository (and if you want to test stuff that's in the patch queue,
that'd be useful).

BTW, you should check if any significant changes are needed for porting to
the 1.2 branch.

[snip]

[0] http://hg.debian.org/hg/xine-lib/xine-lib/
[1] http://hg.debian.org/hg/xine-lib/xine-lib-patch-queue/
--
| Darren Salt            | linux at youmustbejoking | nr. Ashington, | Doon
| using Debian GNU/Linux | or ds    ,demon,co,uk    | Northumberland | Army
| + Use more efficient products. Use less.          BE MORE ENERGY EFFICIENT.

You will live a long, healthy, happy life and make bags for money.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: Should I clean up and submit patches?

by Roger Scott-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Some parts of this message have been removed. Learn more about Nabble's security policy.
Hi Darren,

> The first step is to post them here with suitable subject lines and
> descriptions. If you have a local xine-lib repository (cloned from [0]), then
> you could commit them then use "hg email" to send them.

I haven't received any responses other than your own so I'll leave it on the back burner until I have time to clean things up.  Fixing deadlocks and changing my code so it can execute MHP-like java xlets will get a higher priority.

> BTW, you should check if any significant changes are needed for porting to
> the 1.2 branch.

The input and demux patches will probably be fine but the teletext spu decoder will at a minimum need tweaking for the different API.  I've never managed to get the 1.2 branch to properly compile and link so I can't say what else might be needed.

Regards,
Roger.


Click Here View photos of singles in your area
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel