Should the GUI preserve file names across sessions?

[Robert Lipe-4]

Probably not big news here, but I launched new betas for Mac and Windows earlier today.  http://www.gpsbabel.org/news/20090906.html   That led to the following comment:

Frank> I like the new GUI but it doesn't remember my last input file like v1.3.5 did

I thought it used to.   The code went to pains to save the input and output files but didn't restore them.   Should it?

It's pretty easy to add/fix if we think it's a good idea.  


Index: mainwindow.cpp
===================================================================
RCS file: /cvsroot/gpsbabel/gpsbabel/gui/mainwindow.cpp,v
retrieving revision 1.9
diff -p -u -r1.9 mainwindow.cpp
--- mainwindow.cpp    8 Sep 2009 00:29:09 -0000    1.9
+++ mainwindow.cpp    8 Sep 2009 02:29:29 -0000
@@ -943,6 +943,8 @@ void MainWindow::setWidgetValues()
   if (bd.inputType == BabelData::fileType) {
     ui.inputFileOptBtn->setChecked(true);
     inputFileOptBtnClicked();
+    ui.inputFileNameText->setText(bd.inputBrowse);
+    bd.inputFileNames << bd.inputBrowse;
     setComboToFormat(ui.inputFormatCombo, bd.inputFileFormat, true);
     ui.inputStackedWidget->setCurrentWidget(ui.inputFilePage);
   }
@@ -959,6 +961,8 @@ void MainWindow::setWidgetValues()
   if (bd.outputType == BabelData::fileType) {
     ui.outputFileOptBtn->setChecked(true);
     outputFileOptBtnClicked();
+    ui.outputFileNameText->setText(bd.outputBrowse);
+    bd.outputFileName = bd.outputBrowse;
     setComboToFormat(ui.outputFormatCombo, bd.outputFileFormat, true);
     ui.outputStackedWidget->setCurrentWidget(ui.outputFilePage);
   }


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code@...
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

[Khai Mong]

Also, the current beta will restore the old, saved file name in the file dialog, both for input and output, but only if the saved input & output format type matches the current settings.

On Tue, Sep 8, 2009 at 6:40 AM, Khai Mong <khai@...> wrote:

I thought it was a bad idea to save output file names and have it automatically in the output filename entry by default.  It's bad because the lazy user might just hit "Apply" without changing it.   This might result in overwriting a data file that was saved a week ago.

On Mon, Sep 7, 2009 at 10:34 PM, Robert Lipe <robertlipe@...> wrote:

Probably not big news here, but I launched new betas for Mac and Windows earlier today.  http://www.gpsbabel.org/news/20090906.html   That led to the following comment:

Frank> I like the new GUI but it doesn't remember my last input file like v1.3.5 did

I thought it used to.   The code went to pains to save the input and output files but didn't restore them.   Should it?

It's pretty easy to add/fix if we think it's a good idea.  

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code@...
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

[Robert Lipe-4]

On Tue, Sep 8, 2009 at 5:45 AM, Khai Mong <khai@...> wrote:

Also, the current beta will restore the old, saved file name in the file dialog, both for input and output, but only if the saved input & output format type matches the current settings.

I'm not seeing that happen.   If I populate the file dialogs and do a conversion, exit, and restart it remembers the formats but seems to forget the filenames for both input and output without my patch below.

I wonder if we should keep the output filename and add a "this file already exists, do you want to clobber it" dialog to prevent the problem you're describing.

RJL

 

On Tue, Sep 8, 2009 at 6:40 AM, Khai Mong <khai@...> wrote:

I thought it was a bad idea to save output file names and have it automatically in the output filename entry by default.  It's bad because the lazy user might just hit "Apply" without changing it.   This might result in overwriting a data file that was saved a week ago.

On Mon, Sep 7, 2009 at 10:34 PM, Robert Lipe <robertlipe@...> wrote:

Probably not big news here, but I launched new betas for Mac and Windows earlier today.  http://www.gpsbabel.org/news/20090906.html   That led to the following comment:

Frank> I like the new GUI but it doesn't remember my last input file like v1.3.5 did

I thought it used to.   The code went to pains to save the input and output files but didn't restore them.   Should it?

It's pretty easy to add/fix if we think it's a good idea.  

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
Gpsbabel-code@...
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code