Shrinksafe issue

[Deno Vichas-2]

Some parts of this message have been removed. Learn more about Nabble's security policy.

I’ve noticed some weirdness with my build using shrinksafe (v1.3.2).  This (sudo) code doesn’t get optimized correctly

 

(function() {

 

Function bar(){ dojo.connect(dijitBy(), onClick, foo);}

 

Function foo(){ code here … }

 

})()

 

It shrink safe will compress foo to something like _1 but will not update the reference in the dojo connect.  If I flip the two function it works.

 

(function() {

 

Function foo() {…code here …}

 

Function bar(){  dojo.connect(dijitBy(), onClick, foo);}

 

})()

 

 

Should to ordering my functions really matter?

 

Thanks,

deno

 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Hockey, Ben]

Some parts of this message have been removed. Learn more about Nabble's security policy.

how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2 release but if this is the same issue then this is fixed in trunk and i assume in 1.4+

http://bugs.dojotoolkit.org/ticket/3241

http://bugs.dojotoolkit.org/ticket/9693

 

ben...

---

From: dojo-interest-bounces@... [mailto:dojo-interest-bounces@...] On Behalf Of Deno Vichas
Sent: Friday, November 06, 2009 1:54 PM
To: dojo-interest@...
Subject: [Dojo-interest] Shrinksafe issue

I’ve noticed some weirdness with my build using shrinksafe (v1.3.2).  This (sudo) code doesn’t get optimized correctly

 

(function() {

 

Function bar(){ dojo.connect(dijitBy(), onClick, foo);}

 

Function foo(){ code here … }

 

})()

 

It shrink safe will compress foo to something like _1 but will not update the reference in the dojo connect.  If I flip the two function it works.

 

(function() {

 

Function foo() {…code here …}

 

Function bar(){  dojo.connect(dijitBy(), onClick, foo);}

 

})()

 

 

Should to ordering my functions really matter?

 

Thanks,

deno

 

The information contained in this message and any attachment may be
proprietary, confidential, and privileged or subject to the work
product doctrine and thus protected from disclosure.  If the reader
of this message is not the intended recipient, or an employee or
agent responsible for delivering this message to the intended
recipient, you are hereby notified that any dissemination,
distribution or copying of this communication is strictly prohibited.
If you have received this communication in error, please notify me
immediately by replying to this message and deleting it and all
copies and backups thereof.  Thank you.

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Deno Vichas-2]

Some parts of this message have been removed. Learn more about Nabble's security policy.

Yep, that’s my problem.

 

What all do I need out of 1.4, anything more than shrinksafe.jar?

 

From: dojo-interest-bounces@... [mailto:dojo-interest-bounces@...] On Behalf Of Hockey, Ben
Sent: Friday, November 06, 2009 11:51 AM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

 

how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2 release but if this is the same issue then this is fixed in trunk and i assume in 1.4+

http://bugs.dojotoolkit.org/ticket/3241

http://bugs.dojotoolkit.org/ticket/9693

 

ben...

 

---

From: dojo-interest-bounces@... [mailto:dojo-interest-bounces@...] On Behalf Of Deno Vichas
Sent: Friday, November 06, 2009 1:54 PM
To: dojo-interest@...
Subject: [Dojo-interest] Shrinksafe issue

I’ve noticed some weirdness with my build using shrinksafe (v1.3.2).  This (sudo) code doesn’t get optimized correctly

 

(function() {

 

Function bar(){ dojo.connect(dijitBy(), onClick, foo);}

 

Function foo(){ code here … }

 

})()

 

It shrink safe will compress foo to something like _1 but will not update the reference in the dojo connect.  If I flip the two function it works.

 

(function() {

 

Function foo() {…code here …}

 

Function bar(){  dojo.connect(dijitBy(), onClick, foo);}

 

})()

 

 

Should to ordering my functions really matter?

 

Thanks,

deno

 

The information contained in this message and any attachment may be

proprietary, confidential, and privileged or subject to the work

product doctrine and thus protected from disclosure.  If the reader

of this message is not the intended recipient, or an employee or

agent responsible for delivering this message to the intended

recipient, you are hereby notified that any dissemination,

distribution or copying of this communication is strictly prohibited.

If you have received this communication in error, please notify me

immediately by replying to this message and deleting it and all

copies and backups thereof.  Thank you.

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Peter E Higgins-2]

You should be able to just drop in shrinksafe.jar over top of the old
one (or checkout the /util/shrinksafe/ folder and get the full source).
ShrinkSafe, for all intents and purposes, is a standalone project just
happening to live in Dojo.

Regards,
peter

Deno Vichas wrote:

>
> Yep, that’s my problem.
>
>  
>
> What all do I need out of 1.4, anything more than shrinksafe.jar?
>
>  
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Hockey, Ben
> *Sent:* Friday, November 06, 2009 11:51 AM
> *To:* dojo-interest@...
> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>
>  
>
> how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2
> release but if this is the same issue then this is fixed in trunk and
> i assume in 1.4+
>
> http://bugs.dojotoolkit.org/ticket/3241
>
> http://bugs.dojotoolkit.org/ticket/9693
>
>  
>
> ben...
>
>  
>
> ------------------------------------------------------------------------
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Deno Vichas
> *Sent:* Friday, November 06, 2009 1:54 PM
> *To:* dojo-interest@...
> *Subject:* [Dojo-interest] Shrinksafe issue
>
> I’ve noticed some weirdness with my build using shrinksafe (v1.3.2).
> This (sudo) code doesn’t get optimized correctly
>
>  
>
> (function() {
>
>  
>
> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> Function foo(){ code here … }
>
>  
>
> })()
>
>  
>
> It shrink safe will compress foo to something like _1 but will not
> update the reference in the dojo connect.  If I flip the two function
> it works.
>
>  
>
> (function() {
>
>  
>
> Function foo() {…code here …}
>
>  
>
> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> })()
>
>  
>
>  
>
> Should to ordering my functions really matter?
>
>  
>
> Thanks,
>
> deno
>
>  
>
>  
>  
> The information contained in this message and any attachment may be
> proprietary, confidential, and privileged or subject to the work
> product doctrine and thus protected from disclosure.  If the reader
> of this message is not the intended recipient, or an employee or
> agent responsible for delivering this message to the intended
> recipient, you are hereby notified that any dissemination,
> distribution or copying of this communication is strictly prohibited.
> If you have received this communication in error, please notify me
> immediately by replying to this message and deleting it and all
> copies and backups thereof.  Thank you.
>  
> ------------------------------------------------------------------------
>
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Deno Vichas-2]

I took just the .jar and now I'm getting the following

js: Can't find method org.dojotoolkit.shrinksafe.Compressor.compressScript(object,number,number).


thought?

-----Original Message-----
From: dojo-interest-bounces@... [mailto:dojo-interest-bounces@...] On Behalf Of Peter E Higgins
Sent: Saturday, November 07, 2009 7:07 AM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

You should be able to just drop in shrinksafe.jar over top of the old
one (or checkout the /util/shrinksafe/ folder and get the full source).
ShrinkSafe, for all intents and purposes, is a standalone project just
happening to live in Dojo.

Regards,
peter

Deno Vichas wrote:

>
> Yep, that’s my problem.
>
>  
>
> What all do I need out of 1.4, anything more than shrinksafe.jar?
>
>  
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Hockey, Ben
> *Sent:* Friday, November 06, 2009 11:51 AM
> *To:* dojo-interest@...
> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>
>  
>
> how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2
> release but if this is the same issue then this is fixed in trunk and
> i assume in 1.4+
>
> http://bugs.dojotoolkit.org/ticket/3241
>
> http://bugs.dojotoolkit.org/ticket/9693
>
>  
>
> ben...
>
>  
>
> ------------------------------------------------------------------------
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Deno Vichas
> *Sent:* Friday, November 06, 2009 1:54 PM
> *To:* dojo-interest@...
> *Subject:* [Dojo-interest] Shrinksafe issue
>
> I’ve noticed some weirdness with my build using shrinksafe (v1.3.2).
> This (sudo) code doesn’t get optimized correctly
>
>  
>
> (function() {
>
>  
>
> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> Function foo(){ code here … }
>
>  
>
> })()
>
>  
>
> It shrink safe will compress foo to something like _1 but will not
> update the reference in the dojo connect.  If I flip the two function
> it works.
>
>  
>
> (function() {
>
>  
>
> Function foo() {…code here …}
>
>  
>
> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> })()
>
>  
>
>  
>
> Should to ordering my functions really matter?
>
>  
>
> Thanks,
>
> deno
>
>  
>
>  
>  
> The information contained in this message and any attachment may be
> proprietary, confidential, and privileged or subject to the work
> product doctrine and thus protected from disclosure.  If the reader
> of this message is not the intended recipient, or an employee or
> agent responsible for delivering this message to the intended
> recipient, you are hereby notified that any dissemination,
> distribution or copying of this communication is strictly prohibited.
> If you have received this communication in error, please notify me
> immediately by replying to this message and deleting it and all
> copies and backups thereof.  Thank you.
>  
> ------------------------------------------------------------------------
>
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Deno Vichas-2]

Anyone?

does shrink safe from the svn trunk work for anybody?


-----Original Message-----
From: dojo-interest-bounces@... [mailto:dojo-interest-bounces@...] On Behalf Of Deno Vichas
Sent: Tuesday, November 10, 2009 3:27 PM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

I took just the .jar and now I'm getting the following

js: Can't find method org.dojotoolkit.shrinksafe.Compressor.compressScript(object,number,number).


thought?

-----Original Message-----
From: dojo-interest-bounces@... [mailto:dojo-interest-bounces@...] On Behalf Of Peter E Higgins
Sent: Saturday, November 07, 2009 7:07 AM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

You should be able to just drop in shrinksafe.jar over top of the olad
one (or checkout the /util/shrinksafe/ folder and get the full source).
ShrinkSafe, for all intents and purposes, is a standalone project just
happening to live in Dojo.

Regards,
peter

Deno Vichas wrote:

>
> Yep, that’s my problem.
>
>  
>
> What all do I need out of 1.4, anything more than shrinksafe.jar?
>
>  
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Hockey, Ben
> *Sent:* Friday, November 06, 2009 11:51 AM
> *To:* dojo-interest@...
> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>
>  
>
> how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2
> release but if this is the same issue then this is fixed in trunk and
> i assume in 1.4+
>
> http://bugs.dojotoolkit.org/ticket/3241
>
> http://bugs.dojotoolkit.org/ticket/9693
>
>  
>
> ben...
>
>  
>
> ------------------------------------------------------------------------
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Deno Vichas
> *Sent:* Friday, November 06, 2009 1:54 PM
> *To:* dojo-interest@...
> *Subject:* [Dojo-interest] Shrinksafe issue
>
> I’ve noticed some weirdness with my build using shrinksafe (v1.3.2).
> This (sudo) code doesn’t get optimized correctly
>
>  
>
> (function() {
>
>  
>
> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> Function foo(){ code here … }
>
>  
>
> })()
>
>  
>
> It shrink safe will compress foo to something like _1 but will not
> update the reference in the dojo connect.  If I flip the two function
> it works.
>
>  
>
> (function() {
>
>  
>
> Function foo() {…code here …}
>
>  
>
> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> })()
>
>  
>
>  
>
> Should to ordering my functions really matter?
>
>  
>
> Thanks,
>
> deno
>
>  
>
>  
>  
> The information contained in this message and any attachment may be
> proprietary, confidential, and privileged or subject to the work
> product doctrine and thus protected from disclosure.  If the reader
> of this message is not the intended recipient, or an employee or
> agent responsible for delivering this message to the intended
> recipient, you are hereby notified that any dissemination,
> distribution or copying of this communication is strictly prohibited.
> If you have received this communication in error, please notify me
> immediately by replying to this message and deleting it and all
> copies and backups thereof.  Thank you.
>  
> ------------------------------------------------------------------------
>
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Peter E Higgins-2]

Hmmmm. I may have misspoken before. The call signature for trunk's
shrinksafe differs slightly from the 1.3.2 version. We moved the
stripConsole stuff into Shrinksafe directly ... but yes, java -jar
shrinksafe.jar < file.js works just fine for me. There may be an issue
in the build scripts passing along stripConsole now, whereas it didn't
before, but the method should still be named the same. (but I guess Java
is saying it's not finding a function with _that_ signature)

Peter

Deno Vichas wrote:

> Anyone?
>
> does shrink safe from the svn trunk work for anybody?
>
>
> -----Original Message-----
> From: dojo-interest-bounces@... [mailto:dojo-interest-bounces@...] On Behalf Of Deno Vichas
> Sent: Tuesday, November 10, 2009 3:27 PM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> I took just the .jar and now I'm getting the following
>
> js: Can't find method org.dojotoolkit.shrinksafe.Compressor.compressScript(object,number,number).
>
>
> thought?
>
> -----Original Message-----
> From: dojo-interest-bounces@... [mailto:dojo-interest-bounces@...] On Behalf Of Peter E Higgins
> Sent: Saturday, November 07, 2009 7:07 AM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> You should be able to just drop in shrinksafe.jar over top of the olad
> one (or checkout the /util/shrinksafe/ folder and get the full source).
> ShrinkSafe, for all intents and purposes, is a standalone project just
> happening to live in Dojo.
>
> Regards,
> peter
>
> Deno Vichas wrote:
>  
>> Yep, that’s my problem.
>>
>>  
>>
>> What all do I need out of 1.4, anything more than shrinksafe.jar?
>>
>>  
>>
>> *From:* dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>> *Hockey, Ben
>> *Sent:* Friday, November 06, 2009 11:51 AM
>> *To:* dojo-interest@...
>> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>>
>>  
>>
>> how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2
>> release but if this is the same issue then this is fixed in trunk and
>> i assume in 1.4+
>>
>> http://bugs.dojotoolkit.org/ticket/3241
>>
>> http://bugs.dojotoolkit.org/ticket/9693
>>
>>  
>>
>> ben...
>>
>>  
>>
>> ------------------------------------------------------------------------
>>
>> *From:* dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>> *Deno Vichas
>> *Sent:* Friday, November 06, 2009 1:54 PM
>> *To:* dojo-interest@...
>> *Subject:* [Dojo-interest] Shrinksafe issue
>>
>> I’ve noticed some weirdness with my build using shrinksafe (v1.3.2).
>> This (sudo) code doesn’t get optimized correctly
>>
>>  
>>
>> (function() {
>>
>>  
>>
>> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>>
>>  
>>
>> Function foo(){ code here … }
>>
>>  
>>
>> })()
>>
>>  
>>
>> It shrink safe will compress foo to something like _1 but will not
>> update the reference in the dojo connect.  If I flip the two function
>> it works.
>>
>>  
>>
>> (function() {
>>
>>  
>>
>> Function foo() {…code here …}
>>
>>  
>>
>> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>>
>>  
>>
>> })()
>>
>>  
>>
>>  
>>
>> Should to ordering my functions really matter?
>>
>>  
>>
>> Thanks,
>>
>> deno
>>
>>  
>>
>>  
>>  
>> The information contained in this message and any attachment may be
>> proprietary, confidential, and privileged or subject to the work
>> product doctrine and thus protected from disclosure.  If the reader
>> of this message is not the intended recipient, or an employee or
>> agent responsible for delivering this message to the intended
>> recipient, you are hereby notified that any dissemination,
>> distribution or copying of this communication is strictly prohibited.
>> If you have received this communication in error, please notify me
>> immediately by replying to this message and deleting it and all
>> copies and backups thereof.  Thank you.
>>  
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>>  
>>    
>
>
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Hockey, Ben]

trunk *should* work (haven't tried it myself) - I'm not sure of all the
dependencies and so I would try taking the whole util directory (or at
least the whole shrinksafe directory).

ben...

-----Original Message-----
From: dojo-interest-bounces@...
[mailto:dojo-interest-bounces@...] On Behalf Of Deno
Vichas
Sent: Thursday, November 12, 2009 3:54 PM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

Anyone?

does shrink safe from the svn trunk work for anybody?


-----Original Message-----
From: dojo-interest-bounces@...
[mailto:dojo-interest-bounces@...] On Behalf Of Deno
Vichas
Sent: Tuesday, November 10, 2009 3:27 PM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

I took just the .jar and now I'm getting the following

js: Can't find method
org.dojotoolkit.shrinksafe.Compressor.compressScript(object,number,numbe
r).


thought?

-----Original Message-----
From: dojo-interest-bounces@...
[mailto:dojo-interest-bounces@...] On Behalf Of Peter E
Higgins
Sent: Saturday, November 07, 2009 7:07 AM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

You should be able to just drop in shrinksafe.jar over top of the olad
one (or checkout the /util/shrinksafe/ folder and get the full source).
ShrinkSafe, for all intents and purposes, is a standalone project just
happening to live in Dojo.

Regards,
peter

Deno Vichas wrote:

>
> Yep, that's my problem.
>
>  
>
> What all do I need out of 1.4, anything more than shrinksafe.jar?
>
>  
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Hockey, Ben
> *Sent:* Friday, November 06, 2009 11:51 AM
> *To:* dojo-interest@...
> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>
>  
>
> how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2
> release but if this is the same issue then this is fixed in trunk and
> i assume in 1.4+
>
> http://bugs.dojotoolkit.org/ticket/3241
>
> http://bugs.dojotoolkit.org/ticket/9693
>
>  
>
> ben...
>
>  
>
> ----------------------------------------------------------------------
> --
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Deno Vichas
> *Sent:* Friday, November 06, 2009 1:54 PM
> *To:* dojo-interest@...
> *Subject:* [Dojo-interest] Shrinksafe issue
>
> I've noticed some weirdness with my build using shrinksafe (v1.3.2).
> This (sudo) code doesn't get optimized correctly
>
>  
>
> (function() {
>
>  
>
> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> Function foo(){ code here ... }
>
>  
>
> })()
>
>  
>
> It shrink safe will compress foo to something like _1 but will not
> update the reference in the dojo connect.  If I flip the two function
> it works.
>
>  
>
> (function() {
>
>  
>
> Function foo() {...code here ...}
>
>  
>
> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> })()
>
>  
>
>  
>
> Should to ordering my functions really matter?
>
>  
>
> Thanks,
>
> deno
>
>  
>
>  
>  
> The information contained in this message and any attachment may be
> proprietary, confidential, and privileged or subject to the work
> product doctrine and thus protected from disclosure.  If the reader of

> this message is not the intended recipient, or an employee or agent
> responsible for delivering this message to the intended recipient, you

> are hereby notified that any dissemination, distribution or copying of

> this communication is strictly prohibited.
> If you have received this communication in error, please notify me
> immediately by replying to this message and deleting it and all copies

> and backups thereof.  Thank you.
>  
> ----------------------------------------------------------------------
> --
>
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Deno Vichas-2]

Haven't tested yet but, the method sigs for Compressor.compressScript
changes.  There are matching changes in jslib/buildUtils.js in
buildUtil.optimizeJs(). SO, one probably should take the whole util dir.

-----Original Message-----
From: dojo-interest-bounces@...
[mailto:dojo-interest-bounces@...] On Behalf Of Hockey,
Ben
Sent: Thursday, November 12, 2009 1:05 PM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

trunk *should* work (haven't tried it myself) - I'm not sure of all the
dependencies and so I would try taking the whole util directory (or at
least the whole shrinksafe directory).

ben...

-----Original Message-----
From: dojo-interest-bounces@...
[mailto:dojo-interest-bounces@...] On Behalf Of Deno
Vichas
Sent: Thursday, November 12, 2009 3:54 PM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

Anyone?

does shrink safe from the svn trunk work for anybody?


-----Original Message-----
From: dojo-interest-bounces@...
[mailto:dojo-interest-bounces@...] On Behalf Of Deno
Vichas
Sent: Tuesday, November 10, 2009 3:27 PM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

I took just the .jar and now I'm getting the following

js: Can't find method
org.dojotoolkit.shrinksafe.Compressor.compressScript(object,number,numbe
r).


thought?

-----Original Message-----
From: dojo-interest-bounces@...
[mailto:dojo-interest-bounces@...] On Behalf Of Peter E
Higgins
Sent: Saturday, November 07, 2009 7:07 AM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

You should be able to just drop in shrinksafe.jar over top of the olad
one (or checkout the /util/shrinksafe/ folder and get the full source).
ShrinkSafe, for all intents and purposes, is a standalone project just
happening to live in Dojo.

Regards,
peter

Deno Vichas wrote:

>
> Yep, that's my problem.
>
>  
>
> What all do I need out of 1.4, anything more than shrinksafe.jar?
>
>  
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Hockey, Ben
> *Sent:* Friday, November 06, 2009 11:51 AM
> *To:* dojo-interest@...
> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>
>  
>
> how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2
> release but if this is the same issue then this is fixed in trunk and
> i assume in 1.4+
>
> http://bugs.dojotoolkit.org/ticket/3241
>
> http://bugs.dojotoolkit.org/ticket/9693
>
>  
>
> ben...
>
>  
>
> ----------------------------------------------------------------------
> --
>
> *From:* dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] *On Behalf Of
> *Deno Vichas
> *Sent:* Friday, November 06, 2009 1:54 PM
> *To:* dojo-interest@...
> *Subject:* [Dojo-interest] Shrinksafe issue
>
> I've noticed some weirdness with my build using shrinksafe (v1.3.2).
> This (sudo) code doesn't get optimized correctly
>
>  
>
> (function() {
>
>  
>
> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> Function foo(){ code here ... }
>
>  
>
> })()
>
>  
>
> It shrink safe will compress foo to something like _1 but will not
> update the reference in the dojo connect.  If I flip the two function
> it works.
>
>  
>
> (function() {
>
>  
>
> Function foo() {...code here ...}
>
>  
>
> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>
>  
>
> })()
>
>  
>
>  
>
> Should to ordering my functions really matter?
>
>  
>
> Thanks,
>
> deno
>
>  
>
>  
>  
> The information contained in this message and any attachment may be
> proprietary, confidential, and privileged or subject to the work
> product doctrine and thus protected from disclosure.  If the reader of

> this message is not the intended recipient, or an employee or agent
> responsible for delivering this message to the intended recipient, you

> are hereby notified that any dissemination, distribution or copying of

> this communication is strictly prohibited.
> If you have received this communication in error, please notify me
> immediately by replying to this message and deleting it and all copies

> and backups thereof.  Thank you.
>  
> ----------------------------------------------------------------------
> --
>
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Peter E Higgins-2]

Yah I was hesitant to suggest that because of possible changes to the
build system, but thinking about it a minute I don't believe anything
could have regressed. Everything changed is new feature (dojo.cache
support, etc) and everything previously in place should still work.
Taking the whole /util/buildscripts and /util/shrinksafe package should
get you running again ....

Peter

Deno Vichas wrote:

> Haven't tested yet but, the method sigs for Compressor.compressScript
> changes.  There are matching changes in jslib/buildUtils.js in
> buildUtil.optimizeJs(). SO, one probably should take the whole util dir.
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of Hockey,
> Ben
> Sent: Thursday, November 12, 2009 1:05 PM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> trunk *should* work (haven't tried it myself) - I'm not sure of all the
> dependencies and so I would try taking the whole util directory (or at
> least the whole shrinksafe directory).
>
> ben...
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of Deno
> Vichas
> Sent: Thursday, November 12, 2009 3:54 PM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> Anyone?
>
> does shrink safe from the svn trunk work for anybody?
>
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of Deno
> Vichas
> Sent: Tuesday, November 10, 2009 3:27 PM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> I took just the .jar and now I'm getting the following
>
> js: Can't find method
> org.dojotoolkit.shrinksafe.Compressor.compressScript(object,number,numbe
> r).
>
>
> thought?
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of Peter E
> Higgins
> Sent: Saturday, November 07, 2009 7:07 AM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> You should be able to just drop in shrinksafe.jar over top of the olad
> one (or checkout the /util/shrinksafe/ folder and get the full source).
> ShrinkSafe, for all intents and purposes, is a standalone project just
> happening to live in Dojo.
>
> Regards,
> peter
>
> Deno Vichas wrote:
>  
>> Yep, that's my problem.
>>
>>  
>>
>> What all do I need out of 1.4, anything more than shrinksafe.jar?
>>
>>  
>>
>> *From:* dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>> *Hockey, Ben
>> *Sent:* Friday, November 06, 2009 11:51 AM
>> *To:* dojo-interest@...
>> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>>
>>  
>>
>> how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2
>> release but if this is the same issue then this is fixed in trunk and
>> i assume in 1.4+
>>
>> http://bugs.dojotoolkit.org/ticket/3241
>>
>> http://bugs.dojotoolkit.org/ticket/9693
>>
>>  
>>
>> ben...
>>
>>  
>>
>> ----------------------------------------------------------------------
>> --
>>
>> *From:* dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>> *Deno Vichas
>> *Sent:* Friday, November 06, 2009 1:54 PM
>> *To:* dojo-interest@...
>> *Subject:* [Dojo-interest] Shrinksafe issue
>>
>> I've noticed some weirdness with my build using shrinksafe (v1.3.2).
>> This (sudo) code doesn't get optimized correctly
>>
>>  
>>
>> (function() {
>>
>>  
>>
>> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>>
>>  
>>
>> Function foo(){ code here ... }
>>
>>  
>>
>> })()
>>
>>  
>>
>> It shrink safe will compress foo to something like _1 but will not
>> update the reference in the dojo connect.  If I flip the two function
>> it works.
>>
>>  
>>
>> (function() {
>>
>>  
>>
>> Function foo() {...code here ...}
>>
>>  
>>
>> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>>
>>  
>>
>> })()
>>
>>  
>>
>>  
>>
>> Should to ordering my functions really matter?
>>
>>  
>>
>> Thanks,
>>
>> deno
>>
>>  
>>
>>  
>>  
>> The information contained in this message and any attachment may be
>> proprietary, confidential, and privileged or subject to the work
>> product doctrine and thus protected from disclosure.  If the reader of
>>    
>
>  
>> this message is not the intended recipient, or an employee or agent
>> responsible for delivering this message to the intended recipient, you
>>    
>
>  
>> are hereby notified that any dissemination, distribution or copying of
>>    
>
>  
>> this communication is strictly prohibited.
>> If you have received this communication in error, please notify me
>> immediately by replying to this message and deleting it and all copies
>>    
>
>  
>> and backups thereof.  Thank you.
>>  
>> ----------------------------------------------------------------------
>> --
>>
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>>  
>>    
>
>
> --
> Peter E Higgins
> Dojo Project Lead : http://dojotoolkit.org 
>
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Deno Vichas-2]

Taking the whole util dir did it.

What's the dojo.cache about?  We have had some serious issues with FF
caching files making upgrades a pain for users.


-----Original Message-----
From: dojo-interest-bounces@...
[mailto:dojo-interest-bounces@...] On Behalf Of Peter E
Higgins
Sent: Thursday, November 12, 2009 1:26 PM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

Yah I was hesitant to suggest that because of possible changes to the
build system, but thinking about it a minute I don't believe anything
could have regressed. Everything changed is new feature (dojo.cache
support, etc) and everything previously in place should still work.
Taking the whole /util/buildscripts and /util/shrinksafe package should
get you running again ....

Peter

Deno Vichas wrote:
> Haven't tested yet but, the method sigs for Compressor.compressScript
> changes.  There are matching changes in jslib/buildUtils.js in
> buildUtil.optimizeJs(). SO, one probably should take the whole util
dir.
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of
Hockey,
> Ben
> Sent: Thursday, November 12, 2009 1:05 PM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> trunk *should* work (haven't tried it myself) - I'm not sure of all
the

> dependencies and so I would try taking the whole util directory (or at
> least the whole shrinksafe directory).
>
> ben...
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of Deno
> Vichas
> Sent: Thursday, November 12, 2009 3:54 PM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> Anyone?
>
> does shrink safe from the svn trunk work for anybody?
>
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of Deno
> Vichas
> Sent: Tuesday, November 10, 2009 3:27 PM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> I took just the .jar and now I'm getting the following
>
> js: Can't find method
>

org.dojotoolkit.shrinksafe.Compressor.compressScript(object,number,numbe
> r).
>
>
> thought?
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of Peter
E
> Higgins
> Sent: Saturday, November 07, 2009 7:07 AM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> You should be able to just drop in shrinksafe.jar over top of the olad
> one (or checkout the /util/shrinksafe/ folder and get the full
source).

> ShrinkSafe, for all intents and purposes, is a standalone project just
> happening to live in Dojo.
>
> Regards,
> peter
>
> Deno Vichas wrote:
>  
>> Yep, that's my problem.
>>
>>  
>>
>> What all do I need out of 1.4, anything more than shrinksafe.jar?
>>
>>  
>>
>> *From:* dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>> *Hockey, Ben
>> *Sent:* Friday, November 06, 2009 11:51 AM
>> *To:* dojo-interest@...
>> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>>
>>  
>>
>> how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2

>> release but if this is the same issue then this is fixed in trunk and

>> i assume in 1.4+
>>
>> http://bugs.dojotoolkit.org/ticket/3241
>>
>> http://bugs.dojotoolkit.org/ticket/9693
>>
>>  
>>
>> ben...
>>
>>  
>>
>>

----------------------------------------------------------------------

>> --
>>
>> *From:* dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>> *Deno Vichas
>> *Sent:* Friday, November 06, 2009 1:54 PM
>> *To:* dojo-interest@...
>> *Subject:* [Dojo-interest] Shrinksafe issue
>>
>> I've noticed some weirdness with my build using shrinksafe (v1.3.2).
>> This (sudo) code doesn't get optimized correctly
>>
>>  
>>
>> (function() {
>>
>>  
>>
>> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>>
>>  
>>
>> Function foo(){ code here ... }
>>
>>  
>>
>> })()
>>
>>  
>>
>> It shrink safe will compress foo to something like _1 but will not
>> update the reference in the dojo connect.  If I flip the two function

>> it works.
>>
>>  
>>
>> (function() {
>>
>>  
>>
>> Function foo() {...code here ...}
>>
>>  
>>
>> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>>
>>  
>>
>> })()
>>
>>  
>>
>>  
>>
>> Should to ordering my functions really matter?
>>
>>  
>>
>> Thanks,
>>
>> deno
>>
>>  
>>
>>  
>>  
>> The information contained in this message and any attachment may be
>> proprietary, confidential, and privileged or subject to the work
>> product doctrine and thus protected from disclosure.  If the reader

of
>>    
>
>  
>> this message is not the intended recipient, or an employee or agent
>> responsible for delivering this message to the intended recipient,
you
>>    
>
>  
>> are hereby notified that any dissemination, distribution or copying
of
>>    
>
>  
>> this communication is strictly prohibited.
>> If you have received this communication in error, please notify me
>> immediately by replying to this message and deleting it and all
copies
>>    
>
>  
>> and backups thereof.  Thank you.
>>  
>>
----------------------------------------------------------------------

>> --
>>
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>>  
>>    
>
>
> --
> Peter E Higgins
> Dojo Project Lead : http://dojotoolkit.org 
>
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
> _______________________________________________
> FAQ: http://dojotoolkit.org/support/faq
> Book: http://docs.dojocampus.org
> Dojo-interest@...
> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Peter E Higgins-2]

dojo.cache is a new way to inline cache templates and whatnot, much like
templatePath: dojo.moduleUrl("foo", "bar.html") // inline foo/bar.html
into this position

you can dojo.cache() any file and have it interned in 1.4

var foo = dojo.fromJson(dojo.cache("myns", "resources/staticjson.js"));

before build an xhr is issued, after build the string from staticjson.js
is interned.

The new way to do templates in Dijit is:

templateString: dojo.cache("dijit", "templates/Something.html")

removing the confusing templatePath/templateString dichotomy. Build
still handles templateString/Path, but Dojo has been changed internally
to use dojo.cache/templateString exclusively (which is documented as a
know regression in the case you are subclassing a widget and replacing
it's template with templatePath in pre-build scenarios. The fix is
trivial, and it's noted in the release notes, but I suspect we'll hear
more about it after 1.4 ships)

Regards,
Peter



Deno Vichas wrote:

> Taking the whole util dir did it.
>
> What's the dojo.cache about?  We have had some serious issues with FF
> caching files making upgrades a pain for users.
>
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of Peter E
> Higgins
> Sent: Thursday, November 12, 2009 1:26 PM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> Yah I was hesitant to suggest that because of possible changes to the
> build system, but thinking about it a minute I don't believe anything
> could have regressed. Everything changed is new feature (dojo.cache
> support, etc) and everything previously in place should still work.
> Taking the whole /util/buildscripts and /util/shrinksafe package should
> get you running again ....
>
> Peter
>
> Deno Vichas wrote:
>  
>> Haven't tested yet but, the method sigs for Compressor.compressScript
>> changes.  There are matching changes in jslib/buildUtils.js in
>> buildUtil.optimizeJs(). SO, one probably should take the whole util
>>    
> dir.
>  
>> -----Original Message-----
>> From: dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] On Behalf Of
>>    
> Hockey,
>  
>> Ben
>> Sent: Thursday, November 12, 2009 1:05 PM
>> To: dojo-interest@...
>> Subject: Re: [Dojo-interest] Shrinksafe issue
>>
>> trunk *should* work (haven't tried it myself) - I'm not sure of all
>>    
> the
>  
>> dependencies and so I would try taking the whole util directory (or at
>> least the whole shrinksafe directory).
>>
>> ben...
>>
>> -----Original Message-----
>> From: dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] On Behalf Of Deno
>> Vichas
>> Sent: Thursday, November 12, 2009 3:54 PM
>> To: dojo-interest@...
>> Subject: Re: [Dojo-interest] Shrinksafe issue
>>
>> Anyone?
>>
>> does shrink safe from the svn trunk work for anybody?
>>
>>
>> -----Original Message-----
>> From: dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] On Behalf Of Deno
>> Vichas
>> Sent: Tuesday, November 10, 2009 3:27 PM
>> To: dojo-interest@...
>> Subject: Re: [Dojo-interest] Shrinksafe issue
>>
>> I took just the .jar and now I'm getting the following
>>
>> js: Can't find method
>>
>>    
> org.dojotoolkit.shrinksafe.Compressor.compressScript(object,number,numbe
>  
>> r).
>>
>>
>> thought?
>>
>> -----Original Message-----
>> From: dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] On Behalf Of Peter
>>    
> E
>  
>> Higgins
>> Sent: Saturday, November 07, 2009 7:07 AM
>> To: dojo-interest@...
>> Subject: Re: [Dojo-interest] Shrinksafe issue
>>
>> You should be able to just drop in shrinksafe.jar over top of the olad
>> one (or checkout the /util/shrinksafe/ folder and get the full
>>    
> source).
>  
>> ShrinkSafe, for all intents and purposes, is a standalone project just
>> happening to live in Dojo.
>>
>> Regards,
>> peter
>>
>> Deno Vichas wrote:
>>  
>>    
>>> Yep, that's my problem.
>>>
>>>  
>>>
>>> What all do I need out of 1.4, anything more than shrinksafe.jar?
>>>
>>>  
>>>
>>> *From:* dojo-interest-bounces@...
>>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>>> *Hockey, Ben
>>> *Sent:* Friday, November 06, 2009 11:51 AM
>>> *To:* dojo-interest@...
>>> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>>>
>>>  
>>>
>>> how recent is the copy of shrinksafe?  this is not fixed in the 1.3.2
>>>      
>
>  
>>> release but if this is the same issue then this is fixed in trunk and
>>>      
>
>  
>>> i assume in 1.4+
>>>
>>> http://bugs.dojotoolkit.org/ticket/3241
>>>
>>> http://bugs.dojotoolkit.org/ticket/9693
>>>
>>>  
>>>
>>> ben...
>>>
>>>  
>>>
>>>
>>>      
> ----------------------------------------------------------------------
>  
>>> --
>>>
>>> *From:* dojo-interest-bounces@...
>>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>>> *Deno Vichas
>>> *Sent:* Friday, November 06, 2009 1:54 PM
>>> *To:* dojo-interest@...
>>> *Subject:* [Dojo-interest] Shrinksafe issue
>>>
>>> I've noticed some weirdness with my build using shrinksafe (v1.3.2).
>>> This (sudo) code doesn't get optimized correctly
>>>
>>>  
>>>
>>> (function() {
>>>
>>>  
>>>
>>> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>>>
>>>  
>>>
>>> Function foo(){ code here ... }
>>>
>>>  
>>>
>>> })()
>>>
>>>  
>>>
>>> It shrink safe will compress foo to something like _1 but will not
>>> update the reference in the dojo connect.  If I flip the two function
>>>      
>
>  
>>> it works.
>>>
>>>  
>>>
>>> (function() {
>>>
>>>  
>>>
>>> Function foo() {...code here ...}
>>>
>>>  
>>>
>>> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>>>
>>>  
>>>
>>> })()
>>>
>>>  
>>>
>>>  
>>>
>>> Should to ordering my functions really matter?
>>>
>>>  
>>>
>>> Thanks,
>>>
>>> deno
>>>
>>>  
>>>
>>>  
>>>  
>>> The information contained in this message and any attachment may be
>>> proprietary, confidential, and privileged or subject to the work
>>> product doctrine and thus protected from disclosure.  If the reader
>>>      
> of
>  
>>>    
>>>      
>>  
>>    
>>> this message is not the intended recipient, or an employee or agent
>>> responsible for delivering this message to the intended recipient,
>>>      
> you
>  
>>>    
>>>      
>>  
>>    
>>> are hereby notified that any dissemination, distribution or copying
>>>      
> of
>  
>>>    
>>>      
>>  
>>    
>>> this communication is strictly prohibited.
>>> If you have received this communication in error, please notify me
>>> immediately by replying to this message and deleting it and all
>>>      
> copies
>  
>>>    
>>>      
>>  
>>    
>>> and backups thereof.  Thank you.
>>>  
>>>
>>>      
> ----------------------------------------------------------------------
>  
>>> --
>>>
>>> _______________________________________________
>>> FAQ: http://dojotoolkit.org/support/faq
>>> Book: http://docs.dojocampus.org
>>> Dojo-interest@...
>>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>>>  
>>>    
>>>      
>> --
>> Peter E Higgins
>> Dojo Project Lead : http://dojotoolkit.org 
>>
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>>
>>  
>>    
>
>
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest

[Deno Vichas-2]

Cool stuff, keep up the great work.


-----Original Message-----
From: dojo-interest-bounces@...
[mailto:dojo-interest-bounces@...] On Behalf Of Peter E
Higgins
Sent: Thursday, November 12, 2009 1:45 PM
To: dojo-interest@...
Subject: Re: [Dojo-interest] Shrinksafe issue

dojo.cache is a new way to inline cache templates and whatnot, much like
templatePath: dojo.moduleUrl("foo", "bar.html") // inline foo/bar.html
into this position

you can dojo.cache() any file and have it interned in 1.4

var foo = dojo.fromJson(dojo.cache("myns", "resources/staticjson.js"));

before build an xhr is issued, after build the string from staticjson.js
is interned.

The new way to do templates in Dijit is:

templateString: dojo.cache("dijit", "templates/Something.html")

removing the confusing templatePath/templateString dichotomy. Build
still handles templateString/Path, but Dojo has been changed internally
to use dojo.cache/templateString exclusively (which is documented as a
know regression in the case you are subclassing a widget and replacing
it's template with templatePath in pre-build scenarios. The fix is
trivial, and it's noted in the release notes, but I suspect we'll hear
more about it after 1.4 ships)

Regards,
Peter



Deno Vichas wrote:
> Taking the whole util dir did it.
>
> What's the dojo.cache about?  We have had some serious issues with FF
> caching files making upgrades a pain for users.
>
>
> -----Original Message-----
> From: dojo-interest-bounces@...
> [mailto:dojo-interest-bounces@...] On Behalf Of Peter
E

> Higgins
> Sent: Thursday, November 12, 2009 1:26 PM
> To: dojo-interest@...
> Subject: Re: [Dojo-interest] Shrinksafe issue
>
> Yah I was hesitant to suggest that because of possible changes to the
> build system, but thinking about it a minute I don't believe anything
> could have regressed. Everything changed is new feature (dojo.cache
> support, etc) and everything previously in place should still work.
> Taking the whole /util/buildscripts and /util/shrinksafe package

should

> get you running again ....
>
> Peter
>
> Deno Vichas wrote:
>  
>> Haven't tested yet but, the method sigs for Compressor.compressScript
>> changes.  There are matching changes in jslib/buildUtils.js in
>> buildUtil.optimizeJs(). SO, one probably should take the whole util
>>    
> dir.
>  
>> -----Original Message-----
>> From: dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] On Behalf Of
>>    
> Hockey,
>  
>> Ben
>> Sent: Thursday, November 12, 2009 1:05 PM
>> To: dojo-interest@...
>> Subject: Re: [Dojo-interest] Shrinksafe issue
>>
>> trunk *should* work (haven't tried it myself) - I'm not sure of all
>>    
> the
>  
>> dependencies and so I would try taking the whole util directory (or

at

>> least the whole shrinksafe directory).
>>
>> ben...
>>
>> -----Original Message-----
>> From: dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] On Behalf Of Deno
>> Vichas
>> Sent: Thursday, November 12, 2009 3:54 PM
>> To: dojo-interest@...
>> Subject: Re: [Dojo-interest] Shrinksafe issue
>>
>> Anyone?
>>
>> does shrink safe from the svn trunk work for anybody?
>>
>>
>> -----Original Message-----
>> From: dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] On Behalf Of Deno
>> Vichas
>> Sent: Tuesday, November 10, 2009 3:27 PM
>> To: dojo-interest@...
>> Subject: Re: [Dojo-interest] Shrinksafe issue
>>
>> I took just the .jar and now I'm getting the following
>>
>> js: Can't find method
>>
>>    
>

org.dojotoolkit.shrinksafe.Compressor.compressScript(object,number,numbe
>  
>> r).
>>
>>
>> thought?
>>
>> -----Original Message-----
>> From: dojo-interest-bounces@...
>> [mailto:dojo-interest-bounces@...] On Behalf Of
Peter
>>    
> E
>  
>> Higgins
>> Sent: Saturday, November 07, 2009 7:07 AM
>> To: dojo-interest@...
>> Subject: Re: [Dojo-interest] Shrinksafe issue
>>
>> You should be able to just drop in shrinksafe.jar over top of the
olad
>> one (or checkout the /util/shrinksafe/ folder and get the full
>>    
> source).
>  
>> ShrinkSafe, for all intents and purposes, is a standalone project
just

>> happening to live in Dojo.
>>
>> Regards,
>> peter
>>
>> Deno Vichas wrote:
>>  
>>    
>>> Yep, that's my problem.
>>>
>>>  
>>>
>>> What all do I need out of 1.4, anything more than shrinksafe.jar?
>>>
>>>  
>>>
>>> *From:* dojo-interest-bounces@...
>>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>>> *Hockey, Ben
>>> *Sent:* Friday, November 06, 2009 11:51 AM
>>> *To:* dojo-interest@...
>>> *Subject:* Re: [Dojo-interest] Shrinksafe issue
>>>
>>>  
>>>
>>> how recent is the copy of shrinksafe?  this is not fixed in the

1.3.2
>>>      
>
>  
>>> release but if this is the same issue then this is fixed in trunk
and

>>>      
>
>  
>>> i assume in 1.4+
>>>
>>> http://bugs.dojotoolkit.org/ticket/3241
>>>
>>> http://bugs.dojotoolkit.org/ticket/9693
>>>
>>>  
>>>
>>> ben...
>>>
>>>  
>>>
>>>
>>>      
> ----------------------------------------------------------------------
>  
>>> --
>>>
>>> *From:* dojo-interest-bounces@...
>>> [mailto:dojo-interest-bounces@...] *On Behalf Of
>>> *Deno Vichas
>>> *Sent:* Friday, November 06, 2009 1:54 PM
>>> *To:* dojo-interest@...
>>> *Subject:* [Dojo-interest] Shrinksafe issue
>>>
>>> I've noticed some weirdness with my build using shrinksafe (v1.3.2).

>>> This (sudo) code doesn't get optimized correctly
>>>
>>>  
>>>
>>> (function() {
>>>
>>>  
>>>
>>> Function bar(){ dojo.connect(dijitBy(), onClick, foo);}
>>>
>>>  
>>>
>>> Function foo(){ code here ... }
>>>
>>>  
>>>
>>> })()
>>>
>>>  
>>>
>>> It shrink safe will compress foo to something like _1 but will not
>>> update the reference in the dojo connect.  If I flip the two

function

>>>      
>
>  
>>> it works.
>>>
>>>  
>>>
>>> (function() {
>>>
>>>  
>>>
>>> Function foo() {...code here ...}
>>>
>>>  
>>>
>>> Function bar(){  dojo.connect(dijitBy(), onClick, foo);}
>>>
>>>  
>>>
>>> })()
>>>
>>>  
>>>
>>>  
>>>
>>> Should to ordering my functions really matter?
>>>
>>>  
>>>
>>> Thanks,
>>>
>>> deno
>>>
>>>  
>>>
>>>  
>>>  
>>> The information contained in this message and any attachment may be
>>> proprietary, confidential, and privileged or subject to the work
>>> product doctrine and thus protected from disclosure.  If the reader
>>>      
> of
>  
>>>    
>>>      
>>  
>>    
>>> this message is not the intended recipient, or an employee or agent
>>> responsible for delivering this message to the intended recipient,
>>>      
> you
>  
>>>    
>>>      
>>  
>>    
>>> are hereby notified that any dissemination, distribution or copying
>>>      
> of
>  
>>>    
>>>      
>>  
>>    
>>> this communication is strictly prohibited.
>>> If you have received this communication in error, please notify me
>>> immediately by replying to this message and deleting it and all
>>>      
> copies
>  
>>>    
>>>      
>>  
>>    
>>> and backups thereof.  Thank you.
>>>  
>>>
>>>      
> ----------------------------------------------------------------------
>  
>>> --
>>>
>>> _______________________________________________
>>> FAQ: http://dojotoolkit.org/support/faq
>>> Book: http://docs.dojocampus.org
>>> Dojo-interest@...
>>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>>>  
>>>    
>>>      
>> --
>> Peter E Higgins
>> Dojo Project Lead : http://dojotoolkit.org 
>>
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>> _______________________________________________
>> FAQ: http://dojotoolkit.org/support/faq
>> Book: http://docs.dojocampus.org
>> Dojo-interest@...
>> http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
>>
>>  
>>    
>
>
>  

--
Peter E Higgins
Dojo Project Lead : http://dojotoolkit.org 

_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest
_______________________________________________
FAQ: http://dojotoolkit.org/support/faq
Book: http://docs.dojocampus.org
Dojo-interest@...
http://mail.dojotoolkit.org/mailman/listinfo/dojo-interest