Simple patch to acpi_ibm

[John Baldwin]

Can someone with acpi_ibm(4) test that this patch works ok and removes the LOR
between acpi_ibm and the sysctl lock on HEAD or 8 with WITNESS enabled?

Index: acpi_ibm.c
===================================================================
--- acpi_ibm.c (revision 197430)
+++ acpi_ibm.c (working copy)
@@ -356,8 +356,6 @@
  }
  sc->ec_handle = acpi_get_handle(sc->ec_dev);
 
- ACPI_SERIAL_BEGIN(ibm);
-
  /* Get the sysctl tree */
  sc->sysctl_ctx = device_get_sysctl_ctx(dev);
  sc->sysctl_tree = device_get_sysctl_tree(dev);
@@ -404,8 +402,6 @@
     "Thermal zones");
  }
 
- ACPI_SERIAL_END(ibm);
-
  /* Handle notifies */
  AcpiInstallNotifyHandler(sc->handle, ACPI_DEVICE_NOTIFY,
     acpi_ibm_notify, dev);


--
John Baldwin
_______________________________________________
freebsd-acpi@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@..."

[Fabian Keil-2]

John Baldwin <jhb@...> wrote:

> Can someone with acpi_ibm(4) test that this patch works ok and removes the LOR
> between acpi_ibm and the sysctl lock on HEAD or 8 with WITNESS enabled?

It does remove the LOR and the sysctls I tried so far (bluetooth,
fan, fan_level, thinklight) still work as expected.

Thanks
Fabian

[Alexandre "Sunny" Kovalenko-2]

On Thu, 2009-09-24 at 10:10 -0400, John Baldwin wrote:
> Can someone with acpi_ibm(4) test that this patch works ok and removes the LOR
> between acpi_ibm and the sysctl lock on HEAD or 8 with WITNESS enabled?
>
I can confirm that on my system (FreeBSD xxx 8.0-RC1 FreeBSD 8.0-RC1 #2
r197402M: Thu Sep 24 11:47:46 EDT 2009
root@xxx:/usr/obj/usr/src/sys/TPX60  i386) patch removes the LOR.
IBM-specific ACPI knobs seem to continue functioning properly after the
patch.

HTH,
--
Alexandre Kovalenko (Олександр Коваленко)


_______________________________________________
freebsd-acpi@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-acpi
To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@..."