Small fix for Global 5.7.3 on Win32/MinGW

View: New views
4 Messages — Rating Filter:   Alert me  

Small fix for Global 5.7.3 on Win32/MinGW

by Giuseppe Corbelli :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

libutil/path.c:217

mkdir function does not use permissions on win32/mingw
Here's the simple ifdef

#if (defined(_WIN32) && !defined(__CYGWIN__)) || defined(__DJGPP__)
                        if (mkdir(p) < 0) {
#else
                        if (mkdir(p, 0775) < 0) {
#endif /* WIN32 */

Compiles on gcc version 3.4.2 (mingw-special)

======================================================================

     I, Giuseppe Corbelli, hereby disclaim all copyright interest in my
     changes and enhancements to GLOBAL (herein called
     the "Program").

     I affirm that I have no other intellectual property interest that
     would undermine this release, or the use of the Program, and will
     do nothing to undermine it in the future.  I represent that the
     changes and enhancements are my own and not a copy of someone
     else's work.

     Giuseppe Corbelli, 12 December 2008

======================================================================


--
         Giuseppe "Cowo" Corbelli ~\/~ My software: http://cowo.yoda2000.net
-<! Non c'e' niente da dire in proposito. Tutto quello che uno deve fare e'
   colpire i tasti giusti al momento giusto, e lo strumento suona da solo. !>-
                                 J.S. Bach


_______________________________________________
Bug-global mailing list
Bug-global@...
http://lists.gnu.org/mailman/listinfo/bug-global

Re: Small fix for Global 5.7.3 on Win32/MinGW

by Shigio YAMAGUCHI-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello,
I have commited the patch.
Thank you!

> libutil/path.c:217
>
> mkdir function does not use permissions on win32/mingw
> Here's the simple ifdef
>
> #if (defined(_WIN32) && !defined(__CYGWIN__)) || defined(__DJGPP__)
> if (mkdir(p) < 0) {
> #else
> if (mkdir(p, 0775) < 0) {
> #endif /* WIN32 */
>
> Compiles on gcc version 3.4.2 (mingw-special)
--
Shigio YAMAGUCHI <shigio@...>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3


_______________________________________________
Bug-global mailing list
Bug-global@...
http://lists.gnu.org/mailman/listinfo/bug-global

Re: Small fix for Global 5.7.3 on Win32/MinGW

by Jason Hood :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Giuseppe Corbelli wrote:
> libutil/path.c:217
>
> mkdir function does not use permissions on win32/mingw
> Here's the simple ifdef
>
> #if (defined(_WIN32) && !defined(__CYGWIN__)) || defined(__DJGPP__)

DJGPP does, though.

Jason.
--


_______________________________________________
Bug-global mailing list
Bug-global@...
http://lists.gnu.org/mailman/listinfo/bug-global

Re: Small fix for Global 5.7.3 on Win32/MinGW

by Shigio YAMAGUCHI-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Jason,
> Giuseppe Corbelli wrote:
> > libutil/path.c:217
> >
> > mkdir function does not use permissions on win32/mingw
> > Here's the simple ifdef
> >
> > #if (defined(_WIN32) && !defined(__CYGWIN__)) || defined(__DJGPP__)
>
> DJGPP does, though.

Thank you for reporting this. I will fix it.

I will also take your patch for htags/htags.c in your new DOS/Win32 ports.
Hereafter, I sometimes examine your package.

Always thank you.
--
Shigio YAMAGUCHI <shigio@...>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3


_______________________________________________
Bug-global mailing list
Bug-global@...
http://lists.gnu.org/mailman/listinfo/bug-global