|
View:
New views
9 Messages
—
Rating Filter:
Alert me
|
|
|
Solar_Cli_MakeApp typo in view-index.phpHi Paul
Solar_Cli_MakeApp_Data_view-index.php $this->gettext('TEXT_WELCOME'); generates a exception 'Solar_Class_Stack_Exception_ClassNotFound' when run after making a new app due to the lower case "T" in getText() Jeff Surgeson _______________________________________________ Solar-talk mailing list Solar-talk@... http://mailman-mail5.webfaction.com/listinfo/solar-talk |
|
|
Re: Solar_Cli_MakeApp typo in view-index.phpOn Sep 9, 2009, at 07:46 , Jeff Surgeson wrote: > Hi Paul > > Solar_Cli_MakeApp_Data_view-index.php > > $this->gettext('TEXT_WELCOME'); > generates a exception 'Solar_Class_Stack_Exception_ClassNotFound' > when run > after making a new app due to the lower case "T" in getText() Saw your bug, just committed the fix. :-) -- Paul M. Jones http://paul-m-jones.com/ _______________________________________________ Solar-talk mailing list Solar-talk@... http://mailman-mail5.webfaction.com/listinfo/solar-talk |
|
|
Re: Solar_Cli_MakeApp typo in view-index.php> Hi Paul
> > Solar_Cli_MakeApp_Data_view-index.php > > $this->gettext('TEXT_WELCOME'); > generates a exception 'Solar_Class_Stack_Exception_ClassNotFound' when run > after making a new app due to the lower case "T" in getText() > Jeff Surgeson You fixed it before I could even post this :-) Sorry will not duplicate in future! :( _______________________________________________ Solar-talk mailing list Solar-talk@... http://mailman-mail5.webfaction.com/listinfo/solar-talk |
|
|
Re: Solar_Cli_MakeApp typo in view-index.phpOn Sep 9, 2009, at 07:53 , Jeff Surgeson wrote: >> Hi Paul >> >> Solar_Cli_MakeApp_Data_view-index.php >> >> $this->gettext('TEXT_WELCOME'); >> generates a exception 'Solar_Class_Stack_Exception_ClassNotFound' >> when run >> after making a new app due to the lower case "T" in getText() >> Jeff Surgeson > > You fixed it before I could even post this :-) Yeah, I happened to be in front of the machine right then. :-) > Sorry will not duplicate in future! :( No, you did fine. Please feel free to do so in the future if you need to. -- Paul M. Jones http://paul-m-jones.com/ _______________________________________________ Solar-talk mailing list Solar-talk@... http://mailman-mail5.webfaction.com/listinfo/solar-talk |
|
|
Re: Solar_Cli_MakeApp typo in view-index.php> On Sep 9, 2009, at 07:46 , Jeff Surgeson wrote:
> > Hi Paul > > > > Solar_Cli_MakeApp_Data_view-index.php > > > > $this->gettext('TEXT_WELCOME'); > > generates a exception 'Solar_Class_Stack_Exception_ClassNotFound' > > when run > > after making a new app due to the lower case "T" in getText() > > Saw your bug, just committed the fix. :-) Typo also exists in make-vendor add & search files under Vendor_Controller_Model_View _______________________________________________ Solar-talk mailing list Solar-talk@... http://mailman-mail5.webfaction.com/listinfo/solar-talk |
|
|
Re: Solar_Cli_MakeApp typo in view-index.phpOn Sep 9, 2009, at 08:32 , Jeff Surgeson wrote: >> On Sep 9, 2009, at 07:46 , Jeff Surgeson wrote: >>> Hi Paul >>> >>> Solar_Cli_MakeApp_Data_view-index.php >>> >>> $this->gettext('TEXT_WELCOME'); >>> generates a exception 'Solar_Class_Stack_Exception_ClassNotFound' >>> when run >>> after making a new app due to the lower case "T" in getText() >> >> Saw your bug, just committed the fix. :-) > > Typo also exists in make-vendor add & search files under > Vendor_Controller_Model_View Fixed & committed. I grepped the rest of the codebase, too, and found nothing else. Thanks for the report, and sorry for the trouble. -- Paul M. Jones http://paul-m-jones.com/ _______________________________________________ Solar-talk mailing list Solar-talk@... http://mailman-mail5.webfaction.com/listinfo/solar-talk |
|
|
Re: Solar_Cli_MakeApp typo in view-index.php> > Typo also exists in make-vendor add & search files under
> > Vendor_Controller_Model_View > > Fixed & committed. I grepped the rest of the codebase, too, and found > nothing else. Thanks for the report, and sorry for the trouble. No trouble at all :D If you have the time please explain the logic and or necessity behind having a Solar_Controller_Page and Solar_Controller_Model which extends _Page Thanks again _______________________________________________ Solar-talk mailing list Solar-talk@... http://mailman-mail5.webfaction.com/listinfo/solar-talk |
|
|
Re: Solar_Cli_MakeApp typo in view-index.phpOn Sep 9, 2009, at 12:08 , Jeff Surgeson wrote: >>> Typo also exists in make-vendor add & search files under >>> Vendor_Controller_Model_View >> >> Fixed & committed. I grepped the rest of the codebase, too, and >> found >> nothing else. Thanks for the report, and sorry for the trouble. > > No trouble at all :D > > If you have the time please explain the logic and or necessity > behind having a > Solar_Controller_Page and Solar_Controller_Model which extends _Page Sure thing. :-) First of all, Vendor_Controller_Page extends Solar_Controller_Page so you have an interception point for your own base layouts, views, and common action methods. It used to be that a Vendor_App would extend Solar_App_Base, but it makes more sense for a Vendor_App to extend its own Vendor_Controller_Page as a base. Next is Vendor_Controller_Model. It used to be that `make-app -- model` would make a new class for you with all the necessary code inside that class. However, when you make multiple apps that all contain the same code, you end up with a lot of duplication. It makes more sense, then, to create a base class for model-based apps to descend from, and extend it instead, overriding whatever methods need customizing. That's what Vendor_Controller_Model is: a page- controller with all the necessary baseline action methods and views for a Vendor to customize as needed, reducing duplication of code. Hope that all makes sense; please let me know if it helps or not. -- Paul M. Jones http://paul-m-jones.com/ _______________________________________________ Solar-talk mailing list Solar-talk@... http://mailman-mail5.webfaction.com/listinfo/solar-talk |
|
|
Re: Solar_Cli_MakeApp typo in view-index.php> That's what Vendor_Controller_Model is: a page-
> controller with all the necessary baseline action methods and views > for a Vendor to customize as needed, reducing duplication of code. > Hope that all makes sense; please let me know if it helps or not. Paul thanks, it sure does. _______________________________________________ Solar-talk mailing list Solar-talk@... http://mailman-mail5.webfaction.com/listinfo/solar-talk |
| Free embeddable forum powered by Nabble | Forum Help |