Some assertions for the testing of ActionView::TestCase are worthless

View: New views
1 Messages — Rating Filter:   Alert me  

Some assertions for the testing of ActionView::TestCase are worthless

by Chris Cruft :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


A poster child for TDD ...or perhaps more caffeine for finishing off
those pesky tests required by the core team!

In view/test_case_test.rb there are several assertions of this form:

    assert 'Holla!', from_shared_helper

I've created a patch that makes more meaningful assertions. For
example:

    assert_equal 'Holla!', from_shared_helper

The patch applies to 2-3-stable.

Looking for reviewers here: https://rails.lighthouseapp.com/projects/8994/tickets/3468

Good news:  after strengthening the assertions, all tests still pass.
At least on 2-3-stable.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@...
To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---