« Return to Thread: Some development questions

Some development questions

by Christian Gmeiner-4 :: Rate this Message:

Reply to Author | View in Thread

Hi all,

I have spend some time in the sources of the driver now, that I got a
good understanding of whats going on.
I have started to make /usr/src/linux/scripts/checkpatch.pl more
happier about the current source. I want
to "fix" most of the style issues which are left. You can have a first
look at my work here:
http://freehg.org/u/austriancoder/em8300-cgmeiner/
Hope such patches will find their way into the main repository :)

The next thing on my clean up list is to get rid of these "Register
access macros". If you look closely
at the source you will find references to write_register and to writel
- for writing values into registers.
After a quick research I found this one:
http://lwn.net/Articles/102232/ (usable > 2.6.9).
I hope you share my opinion to do it everywhere in the source the
same... so I want go for writel.

What is your opinion?

After this, I will try to update some known registers as I saw two or
more times the same sequence like

        writel(0x2, &em->mem[0x2000]);
        writel(0x0, &em->mem[0x2000]);

or

        /* Release reset */
        write_register(0x2000, 0x1);

So it seems that register 0x2000 has something to do with risc core reset.

cheers,
Christian

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dxr3-devel mailing list
Dxr3-devel@...
https://lists.sourceforge.net/lists/listinfo/dxr3-devel

 « Return to Thread: Some development questions