Spec/JavaDoc "Bug" on UIComponentBase.setParent()

View: New views
5 Messages — Rating Filter:   Alert me  

Spec/JavaDoc "Bug" on UIComponentBase.setParent()

by Matthias Wessendorf-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

while working on Trinidad 2 I checked JavaDoc (hosted at java.sun.com)
and MyFaces impl for UIComponentBase for setParent().

The JavaDoc says:

<snip>
This method will cause an PostAddToViewEvent to be published and if
parent.isInView() returns true an PostAddToViewEvent will be published
as well.
</snip>

MyFaces basically queues two events:
-PostAddToViewEvent
-PreRemoveFromViewEvent

Generally I think the JavaDoc should be polished to better reflect the
total algorithm...

Also, I found it funny that the spec doesn't mention the
PostAddToViewEvent class at all.
Is that an oversight ?

Greetings,
Matthias

http://svn.apache.org/repos/asf/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java

--
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Spec/JavaDoc "Bug" on UIComponentBase.setParent()

by Matthias Wessendorf-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Wed, Oct 21, 2009 at 8:45 PM, Matthias Wessendorf <matzew@...> wrote:

> Hi,
>
> while working on Trinidad 2 I checked JavaDoc (hosted at java.sun.com)
> and MyFaces impl for UIComponentBase for setParent().
>
> The JavaDoc says:
>
> <snip>
> This method will cause an PostAddToViewEvent to be published and if
> parent.isInView() returns true an PostAddToViewEvent will be published
> as well.
> </snip>
>
> MyFaces basically queues two events:
> -PostAddToViewEvent
> -PreRemoveFromViewEvent
>
> Generally I think the JavaDoc should be polished to better reflect the
> total algorithm...
>
> Also, I found it funny that the spec doesn't mention the
> PostAddToViewEvent class at all.

PreRemoveFromViewEvent is not mentioned ..........



--
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Spec/JavaDoc "Bug" on UIComponentBase.setParent()

by Matthias Wessendorf-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Too bad, there was no response...
So I filed this bug:
https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1384

-Matthias

On Wed, Oct 21, 2009 at 8:55 PM, Matthias Wessendorf <matzew@...> wrote:

> On Wed, Oct 21, 2009 at 8:45 PM, Matthias Wessendorf <matzew@...> wrote:
>> Hi,
>>
>> while working on Trinidad 2 I checked JavaDoc (hosted at java.sun.com)
>> and MyFaces impl for UIComponentBase for setParent().
>>
>> The JavaDoc says:
>>
>> <snip>
>> This method will cause an PostAddToViewEvent to be published and if
>> parent.isInView() returns true an PostAddToViewEvent will be published
>> as well.
>> </snip>
>>
>> MyFaces basically queues two events:
>> -PostAddToViewEvent
>> -PreRemoveFromViewEvent
>>
>> Generally I think the JavaDoc should be polished to better reflect the
>> total algorithm...
>>
>> Also, I found it funny that the spec doesn't mention the
>> PostAddToViewEvent class at all.
>
> PreRemoveFromViewEvent is not mentioned ..........
>
>> Is that an oversight ?
>>
>> Greetings,
>> Matthias
>>
>> http://svn.apache.org/repos/asf/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>



--
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Spec/JavaDoc "Bug" on UIComponentBase.setParent()

by Jim Driscoll :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Matthias -

You caught us at a bad time - I was spinning the new 2.0.1, and everyone
else was similarly crunched last week.

A bug report is probably the best way to get this on our radar right now.

Jim

On 10/21/09 8:55 PM, Matthias Wessendorf wrote:

> On Wed, Oct 21, 2009 at 8:45 PM, Matthias Wessendorf<matzew@...>  wrote:
>> Hi,
>>
>> while working on Trinidad 2 I checked JavaDoc (hosted at java.sun.com)
>> and MyFaces impl for UIComponentBase for setParent().
>>
>> The JavaDoc says:
>>
>> <snip>
>> This method will cause an PostAddToViewEvent to be published and if
>> parent.isInView() returns true an PostAddToViewEvent will be published
>> as well.
>> </snip>
>>
>> MyFaces basically queues two events:
>> -PostAddToViewEvent
>> -PreRemoveFromViewEvent
>>
>> Generally I think the JavaDoc should be polished to better reflect the
>> total algorithm...
>>
>> Also, I found it funny that the spec doesn't mention the
>> PostAddToViewEvent class at all.
>
> PreRemoveFromViewEvent is not mentioned ..........
>
>> Is that an oversight ?
>>
>> Greetings,
>> Matthias
>>
>> http://svn.apache.org/repos/asf/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: Spec/JavaDoc "Bug" on UIComponentBase.setParent()

by Matthias Wessendorf-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

ok, I did that already :-)

On Tue, Oct 27, 2009 at 12:08 PM, Jim Driscoll <Jim.Driscoll@...> wrote:

> Hi Matthias -
>
> You caught us at a bad time - I was spinning the new 2.0.1, and everyone
> else was similarly crunched last week.
>
> A bug report is probably the best way to get this on our radar right now.
>
> Jim
>
> On 10/21/09 8:55 PM, Matthias Wessendorf wrote:
>>
>> On Wed, Oct 21, 2009 at 8:45 PM, Matthias Wessendorf<matzew@...>
>>  wrote:
>>>
>>> Hi,
>>>
>>> while working on Trinidad 2 I checked JavaDoc (hosted at java.sun.com)
>>> and MyFaces impl for UIComponentBase for setParent().
>>>
>>> The JavaDoc says:
>>>
>>> <snip>
>>> This method will cause an PostAddToViewEvent to be published and if
>>> parent.isInView() returns true an PostAddToViewEvent will be published
>>> as well.
>>> </snip>
>>>
>>> MyFaces basically queues two events:
>>> -PostAddToViewEvent
>>> -PreRemoveFromViewEvent
>>>
>>> Generally I think the JavaDoc should be polished to better reflect the
>>> total algorithm...
>>>
>>> Also, I found it funny that the spec doesn't mention the
>>> PostAddToViewEvent class at all.
>>
>> PreRemoveFromViewEvent is not mentioned ..........
>>
>>> Is that an oversight ?
>>>
>>> Greetings,
>>> Matthias
>>>
>>>
>>> http://svn.apache.org/repos/asf/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java
>>>
>>> --
>>> Matthias Wessendorf
>>>
>>> blog: http://matthiaswessendorf.wordpress.com/
>>> sessions: http://www.slideshare.net/mwessendorf
>>> twitter: http://twitter.com/mwessendorf
>>>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>



--
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...