StAX API change for final version

[Chris Burdess-2]

Our current StAX API is based on an early version. This change brings  
it in line with the final API implemented in J2SE 6.0.

2009-07-07  Ludovic Claude  <ludovic.claude@...>

         PR java/40663
         * javax/xml/stream/util/ReaderDelegate.java: Removed.
         * javax/xml/stream/util/StreamReaderDelegate.java: Renamed  
class.

--
Chris Burdess

[gnu_andrew]

2009/7/7 Chris Burdess <dog@...>:

> Our current StAX API is based on an early version. This change brings it in
> line with the final API implemented in J2SE 6.0.
>
> 2009-07-07  Ludovic Claude  <ludovic.claude@...>
>
>        PR java/40663
>        * javax/xml/stream/util/ReaderDelegate.java: Removed.
>        * javax/xml/stream/util/StreamReaderDelegate.java: Renamed class.
>
> --
> Chris Burdess
>

Chris, are you committing these patches? Or waiting for approval? Or
do you want someone else to commit them?
--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[Chris Burdess-2]

Andrew John Hughes wrote:

> 2009/7/7 Chris Burdess <dog@...>:
>> Our current StAX API is based on an early version. This change  
>> brings it in
>> line with the final API implemented in J2SE 6.0.
>>
>> 2009-07-07  Ludovic Claude  <ludovic.claude@...>
>>
>>        PR java/40663
>>        * javax/xml/stream/util/ReaderDelegate.java: Removed.
>>        * javax/xml/stream/util/StreamReaderDelegate.java: Renamed  
>> class.
>>
>> --
>> Chris Burdess
>>
>
> Chris, are you committing these patches? Or waiting for approval? Or
> do you want someone else to commit them?

I'm happy with them, I'm not at a location that I can commit right at  
the moment, so if someone else could do it earlier then great, if not  
I will do it as soon as I can (sometime this evening).
--
Chris Burdess

[gnu_andrew]

2009/7/7 Chris Burdess <dog@...>:

> Andrew John Hughes wrote:
>>
>> 2009/7/7 Chris Burdess <dog@...>:
>>>
>>> Our current StAX API is based on an early version. This change brings it
>>> in
>>> line with the final API implemented in J2SE 6.0.
>>>
>>> 2009-07-07  Ludovic Claude  <ludovic.claude@...>
>>>
>>>       PR java/40663
>>>       * javax/xml/stream/util/ReaderDelegate.java: Removed.
>>>       * javax/xml/stream/util/StreamReaderDelegate.java: Renamed class.
>>>
>>> --
>>> Chris Burdess
>>>
>>
>> Chris, are you committing these patches? Or waiting for approval? Or
>> do you want someone else to commit them?
>
>
> I'm happy with them, I'm not at a location that I can commit right at the
> moment, so if someone else could do it earlier then great, if not I will do
> it as soon as I can (sometime this evening).
> --
> Chris Burdess
>
>

Ok, it just wasn't clear from your first posts what you actually wanted to do :)
I'm about to commit a bugfix and I'd be happy to commit these afterwards.
--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[Chris Burdess-2]

Andrew John Hughes wrote:

>>> Chris, are you committing these patches? Or waiting for approval? Or
>>> do you want someone else to commit them?
>>
>>
>> I'm happy with them, I'm not at a location that I can commit right  
>> at the
>> moment, so if someone else could do it earlier then great, if not I  
>> will do
>> it as soon as I can (sometime this evening).
>>
>>
>
> Ok, it just wasn't clear from your first posts what you actually  
> wanted to do :)
> I'm about to commit a bugfix and I'd be happy to commit these  
> afterwards.

Great, thank you.
--
Chris Burdess

[gnu_andrew]

2009/7/7 Chris Burdess <dog@...>:

> Andrew John Hughes wrote:
>>>>
>>>> Chris, are you committing these patches? Or waiting for approval? Or
>>>> do you want someone else to commit them?
>>>
>>>
>>> I'm happy with them, I'm not at a location that I can commit right at the
>>> moment, so if someone else could do it earlier then great, if not I will
>>> do
>>> it as soon as I can (sometime this evening).
>>>
>>>
>>
>> Ok, it just wasn't clear from your first posts what you actually wanted to
>> do :)
>> I'm about to commit a bugfix and I'd be happy to commit these afterwards.
>
>
> Great, thank you.
> --
> Chris Burdess
>
>

On closer inspection, there may be an issue as Ludovic does not have a
copyright assignment.  Both look more complicated at present than
simple renaming.

I'm assuming that this file also needs the patch
http://gcc.gnu.org/bugzilla/attachment.cgi?id=18143 which seems to
have some changes outside just fixing the class used.
--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[Chris Burdess-2]

Andrew John Hughes wrote:
> On closer inspection, there may be an issue as Ludovic does not have a
> copyright assignment.  Both look more complicated at present than
> simple renaming.

The first issue, #40653, involves only a trivial change (a few one-
liners).

> I'm assuming that this file also needs the patch
> http://gcc.gnu.org/bugzilla/attachment.cgi?id=18143 which seems to
> have some changes outside just fixing the class used.


I'll look into this.
--
Chris Burdess

[gnu_andrew]

2009/7/7 Chris Burdess <dog@...>:
> Andrew John Hughes wrote:
>>
>> On closer inspection, there may be an issue as Ludovic does not have a
>> copyright assignment.  Both look more complicated at present than
>> simple renaming.
>
> The first issue, #40653, involves only a trivial change (a few one-liners).
>

Committed.

>> I'm assuming that this file also needs the patch
>> http://gcc.gnu.org/bugzilla/attachment.cgi?id=18143 which seems to
>> have some changes outside just fixing the class used.
>
>
> I'll look into this.

Thanks.

> --
> Chris Burdess
>
>



--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[Chris Burdess-2]

I redid the API changes myself to avoid any assignment issues; this  
seems to resolve all the original problems with the StAX API.

Committed.

2009-07-08  Chris Burdess  <dog@...>

         PR xml/40663:
         * javax/xml/stream/XMLEventFactory.java,
         * javax/xml/stream/XMLInputFactory.java,
         * javax/xml/stream/XMLOutputFactory.java,
         * javax/xml/stream/events/Namespace.java: Update API to match  
final
           version of StAX.
         * javax/xml/stream/util/ReaderDelegate.java: Removed.
         * javax/xml/stream/util/StreamReaderDelegate.java: Added  
(renamed
           from ReaderDelegate)
         * gnu/xml/stream/FilteredStreamReader.java,
         * gnu/xml/stream/NamespaceImpl.java,
         * gnu/xml/stream/XIncludeFilter.java,
         * gnu/xml/stream/XMLEventAllocatorImpl.java,
         * gnu/xml/stream/XMLEventFactoryImpl.java: Update  
implementation to
           match final version of StAX API.

--
Chris Burdess