Nabble - Stripes

[JIRA] Commented: (STS-678) DynamicMappingFilter fails with "Could not get a reference to StripesFilter" on WAS 6.1

2009-11-14T17:19:18Z

[ http://www.stripesframework.org/jira/browse/STS-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11875#action_11875 ]

david wade commented on STS-678:
--------------------------------

It appears that WebSphere does indeed break the servlet spec but not as thought above. It may be relevant here so I will share.

The servlet spec states there will be only one instance of a particular named Filter, but we found if requests are already being received by WebSphere _before/during_ the start of of a web application, WebSphere (6.1 FP13 thru FP27) will create multiple instances of the same named filter and initialize each one. However, come application shutdown, only the last instance has the destroy method invoked (because it loses the rest when the filters are put into presumably some map indexed by the filter name).

So, delaying Filter creation/initialization until the first request, while not against the servlet spec, is a bad idea because they really need to add synchronization code around the code responsible. Clearly they have not as multiple instances are created.

To reproduce, create a very simple web app with a Filter and one JSP. Put a constructor on the Filter that simply increments a static instance counter and outputs that instance number to stdout. Deploy, then stop the web app. Start up multiple clients requesting the JSP, then start the web app. When started, stop the clients and have a look at the SystemOut.log. Both machine the client is running on and the server need to be SMP machines to reliably demonstrate this issue.

Am happy to supply an example web app + source if nobody believes me that WebSphere could be so blatantly dumb. IBM currently in denial mode on this issue.

> DynamicMappingFilter fails with "Could not get a reference to StripesFilter" on WAS 6.1
> ---------------------------------------------------------------------------------------
>
> Key: STS-678
> URL: http://www.stripesframework.org/jira/browse/STS-678
> Project: Stripes
> Issue Type: Bug
> Components: ActionBean Dispatching
> Affects Versions: Release 1.5.1
> Environment: WebSphere Application Server 6.1.0.0, JDK 1.5, Servlet 2.4
> Reporter: Jan Novotný
> Assignee: Ben Gunter
> Fix For: Release 1.5.3
>
>
> DynamicMappingFilter fails with message:
> Could not get a reference to StripesFilter from the servlet context. The dynamic mapping filter works in conjunction with StripesFilter and requires that it be defined in web.xml
> even though StripesFilter is defined in web.xml.
> Problem lies in following statement in JavaDoc documentation of the filter:
> * {@link StripesFilter} and {@link DispatcherServlet} need not be mapped to any URL patterns in
> * {@code web.xml} since this filter will determine at runtime whether or not they need to be
> * invoked.
> This is like I have had it:
> <filter>
> <display-name>Stripes Filter</display-name>
> <filter-name>StripesFilter</filter-name>
> <filter-class>net.sourceforge.stripes.controller.StripesFilter</filter-class>
> ... proper init params
> </filter>
> <filter>
> <filter-name>DynamicMappingFilter</filter-name>
> <filter-class>net.sourceforge.stripes.controller.DynamicMappingFilter</filter-class>
> </filter>
> <filter-mapping>
> <filter-name>DynamicMappingFilter</filter-name>
> <url-pattern>/*</url-pattern>
> <dispatcher>REQUEST</dispatcher>
> <dispatcher>FORWARD</dispatcher>
> <dispatcher>INCLUDE</dispatcher>
> </filter-mapping>
> Which is correct according to documentation and works for example on Tomcat.
> Problem is that StripesFilter init method needs to be called - it writes a specific attribute into the ServletContext that is expected by DynamicMappingFilter (naturaly - because it means StripesFilter has been initialized). But this method is not called on WAS while having this configuration.
> I found out that WAS applies different lifecycle on the filters (I wonder whether it doesn't violate the Servlet specification?). It doesn't call init methods of filters and servlets on web application start, but delays it up to the time when Filters are really needed (means if there is request to the url the filter participates in). And when no filter-mapping for the StripesFilter is defined - it is never called although its definition is present in web.xml.
> Solution that works for me is simple - just adding filter mapping for Stripes filter:
> <filter-mapping>
> <filter-name>DynamicMappingFilter</filter-name>
> <url-pattern>/*</url-pattern>
> <dispatcher>REQUEST</dispatcher>
> <dispatcher>FORWARD</dispatcher>
> <dispatcher>INCLUDE</dispatcher>
> </filter-mapping>
> <filter-mapping>
> <filter-name>StripesFilter</filter-name>
> <url-pattern>/*</url-pattern>
> <dispatcher>REQUEST</dispatcher>
> </filter-mapping>
> And StripesFilter is initialized at last.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Stripes-development mailing list
Stripes-development@...
https://lists.sourceforge.net/lists/listinfo/stripes-development

From forum: stripes-dev

Re: Stripes annotation validation error messages

2009-11-13T05:10:37Z

I'm not sure if you mean it would be great because it would ease programming or because you could put the error near the field. If it is the latter, then you can do this:

<stripes:label for="user.username">User name</stripes:label>
<stripes:error field="user.username" />
<stripes:text name="user.username" />

Take a look at the stripes.fieldErrors.* group of properties in StripesResource.properties to format field errors as you like.

-Ben

On Fri, Nov 13, 2009 at 5:10 AM, Jan Künstler <jan.kuenstler@...> wrote:

Wouldn't it be great if the <stripes:label> value would be used for
errors for that field?
If we have something like:

<stripes:label for="user.username">User name</stripes:label>
<stripes:text name="user.username" />

Hmm... this sounds great 'till I thought about implementing this. I
guess we must pass the label value with every form-submit. I can think
of people who will not like the idea :=)

Greets
Jan

Lionel schrieb:

> Jan Künstler wrote:
>
>> Hi Abhi,
>>
>> yes you can. You need two entries in your resource bundle: One for a
>> generic error message and one for the field name.
>>
>> validation.required.valueNotPresent = {0} is requierd
>> fieldname = Field Name
>>
>
> there is one issue with that behaviour: it creates lots of duplicates in the
> resource bundle.
> example:
>
> UserActionBean uses: user.name
> In resource bundle: user.name=User name
>
> OrderActionBean users: order.user.userId
> In resource bundle: order.user.userId=User name
>
> InvoiceActionBean uses: invoice.user.userId
> In resource bundle: invoice.user.userId=User name
>
> 3 times the same label...
> Is there some way to override the key ?
> Would be great to override the resource bundle key in the Validate
> annotation.
>
>

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Stripes-users mailing list
Stripes-users@...
https://lists.sourceforge.net/lists/listinfo/stripes-users

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Stripes-users mailing list
Stripes-users@...
https://lists.sourceforge.net/lists/listinfo/stripes-users

Nabble - Stripes

[JIRA] Commented: (STS-678) DynamicMappingFilter fails with "Could not get a reference to StripesFilter" on WAS 6.1

Re: Stripes annotation validation error messages

Problem with required field validation in indexed properties

Re: jsessionid in urls

jsessionid in urls

Re: Stripes annotation validation error messages

Re: Stripes annotation validation error messages

Re: Stripes annotation validation error messages

[JIRA] Updated: (STS-728) Taglib broken due to generics in Weblogic 10.0

[JIRA] Created: (STS-728) Taglib broken due to generics in Weblogic 10.0

Stripes presentation for the Portuguese JUG

Re: Where to put the logic?

Re: Where to put the logic?

[JIRA] Updated: (STS-727) UrlBindingFactory interprets parameters first in url as conflict

[JIRA] Created: (STS-727) UrlBindingFactory interprets parameters first in url as conflict

Re: Where to put the logic?

Re: Stripes annotation validation error messages

[JIRA] Commented: (STS-726) Multiple submit buttons in first Wizard page cause multiple events on second page

Re: Stripes annotation validation error messages

Stripes annotation validation error messages

Re: Where to put the logic?

Re: Problem with Quick Start Guide example

Re: Problem with Quick Start Guide example

Re: Problem with Quick Start Guide example

[JIRA] Commented: (STS-726) Multiple submit buttons in first Wizard page cause multiple events on second page

[JIRA] Commented: (STS-726) Multiple submit buttons in first Wizard page cause multiple events on second page

[JIRA] Commented: (STS-726) Multiple submit buttons in first Wizard page cause multiple events on second page

[JIRA] Commented: (STS-726) Multiple submit buttons in first Wizard page cause multiple events on second page

Re: Problem with Quick Start Guide example

Re: Problem with Quick Start Guide example

Re: Problem with Quick Start Guide example

Re: RedirectResolution using POST

Problem with Quick Start Guide example

Re: RedirectResolution using POST

Re: RedirectResolution using POST