Submit to 4.1 for msv validation work

[bimargulies]

I committed a revision to 4.1.

It consists of:

a set of 2009.1 snapshots of the msv jars in lib/msv2009. I didn't change the version numbers on the outside.
a copy of build.xml that uses them.
changes to the repackage xml file to cope with them.
a disabled unit test of trying to start validation at the START_ELEMENT of an element, which is what the SOAP-y case calls for.

(src/test/wstxtest/msv/TestWsdlValidation.java)

ant test seems happy enough -- no errors, lots of 'failures' around trying to run test cases that aren't test cases.

Note that this msv requires JDK 1.5 stuff, and I can't recall if Tatu told me that this was cool for 4.1. If not, I'll have to unwind this.

[Cowtowncoder]

On Sun, May 31, 2009 at 7:14 PM, Benson Margulies <bimargulies@...> wrote:

> I committed a revision to 4.1.
>
> It consists of:
>
> a set of 2009.1 snapshots of the msv jars in lib/msv2009. I didn't change
> the version numbers on the outside.
> a copy of build.xml that uses them.
> changes to the repackage xml file to cope with them.
> a disabled unit test of trying to start validation at the START_ELEMENT of
> an element, which is what the SOAP-y case calls for.

Sounds good. I think I had a related simple (and also commented out)
test that tries to verify sub-tree validation.

>
> (src/test/wstxtest/msv/TestWsdlValidation.java)
>
> ant test seems happy enough -- no errors, lots of 'failures' around trying
> to run test cases that aren't test cases.

Hmmh. What would those be? Ant build ignores inner classes (any class
with '$' in its name), those used to cause bogus warnings. But is
there something else?

>
> Note that this msv requires JDK 1.5 stuff, and I can't recall if Tatu told
> me that this was cool for 4.1. If not, I'll have to unwind this.

Yes, 4.x is for 1.4. But I think it is ok to have 1.5-only build, as
long as runtime works for non-MSV-based functionality.
5.0 will require 1.5.
I think it is ok to use 1.5 for builds, and just use javac
'target="1.4"' settings: that is already being done for 4.0.

Quick question for others: I recall that some users wanted 1.4
compatibility. But is there need for 1.4 compatibility for W3C
Schema/RelaxNG validation?
These are parts that use MSV.

-+ Tatu +-

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[bimargulies]

If you run 'ant test', you get zero errors, and 27 failures.

Unit Test Results
        Designed for use with JUnit and Ant.
All Failures
Class Name Status Type Time(s)
TestBase64Reader warning Failure No tests found in test.TestBase64Reader

junit.framework.AssertionFailedError: No tests found in test.TestBase64Reader
        0.003
TestDomReader warning Failure No tests found in test.TestDomReader

junit.framework.AssertionFailedError: No tests found in test.TestDomReader
        0.001
TestEventCopier warning Failure Class test.TestEventCopier has no
public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestEventCopier has
no public constructor TestCase(String name) or TestCase()
        0.000
TestEventReader warning Failure No tests found in test.TestEventReader

junit.framework.AssertionFailedError: No tests found in test.TestEventReader
        0.001
TestNonNsStreamWriter warning Failure Class test.TestNonNsStreamWriter
has no public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestNonNsStreamWriter
has no public constructor TestCase(String name) or TestCase()
        0.001
TestNsEventWriter warning Failure Class test.TestNsEventWriter has no
public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestNsEventWriter has
no public constructor TestCase(String name) or TestCase()
        0.001
TestNsStreamWriter warning Failure Class test.TestNsStreamWriter has
no public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestNsStreamWriter
has no public constructor TestCase(String name) or TestCase()
        0.000
TestNsStreamWriter2 warning Failure Class test.TestNsStreamWriter2 has
no public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestNsStreamWriter2
has no public constructor TestCase(String name) or TestCase()
        0.000
TestNsStreamWriter3 warning Failure Class test.TestNsStreamWriter3 has
no public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestNsStreamWriter3
has no public constructor TestCase(String name) or TestCase()
        0.000
TestRelaxNG warning Failure Class test.TestRelaxNG has no public
constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestRelaxNG has no
public constructor TestCase(String name) or TestCase()
        0.000
TestReporter warning Failure No tests found in test.TestReporter

junit.framework.AssertionFailedError: No tests found in test.TestReporter
        0.000
TestResolver1 warning Failure No tests found in test.TestResolver1

junit.framework.AssertionFailedError: No tests found in test.TestResolver1
        0.000
TestResolver2 warning Failure No tests found in test.TestResolver2

junit.framework.AssertionFailedError: No tests found in test.TestResolver2
        0.001
TestSaxReader warning Failure Class test.TestSaxReader has no public
constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestSaxReader has no
public constructor TestCase(String name) or TestCase()
        0.001
TestSaxValidation warning Failure Class test.TestSaxValidation has no
public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestSaxValidation has
no public constructor TestCase(String name) or TestCase()
        0.000
TestStreamCopier warning Failure Class test.TestStreamCopier has no
public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestStreamCopier has
no public constructor TestCase(String name) or TestCase()
        0.001
TestStreamReader warning Failure Class test.TestStreamReader has no
public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestStreamReader has
no public constructor TestCase(String name) or TestCase()
        0.000
TestStreamSpeed warning Failure Class test.TestStreamSpeed has no
public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestStreamSpeed has
no public constructor TestCase(String name) or TestCase()
        0.000
TestTypedReader warning Failure No tests found in test.TestTypedReader

junit.framework.AssertionFailedError: No tests found in test.TestTypedReader
        0.001
TestTypedSpeed warning Failure Class test.TestTypedSpeed has no public
constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestTypedSpeed has no
public constructor TestCase(String name) or TestCase()
        0.001
TestTypedWriter warning Failure No tests found in test.TestTypedWriter

junit.framework.AssertionFailedError: No tests found in test.TestTypedWriter
        0.001
TestValidatingReader warning Failure Class test.TestValidatingReader
has no public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestValidatingReader
has no public constructor TestCase(String name) or TestCase()
        0.000
TestValidation warning Failure Class test.TestValidation has no public
constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestValidation has no
public constructor TestCase(String name) or TestCase()
        0.001
TestW3CSchema warning Failure Class test.TestW3CSchema has no public
constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestW3CSchema has no
public constructor TestCase(String name) or TestCase()
        0.000
TestWordResolver warning Failure Class test.TestWordResolver has no
public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestWordResolver has
no public constructor TestCase(String name) or TestCase()
        0.001
TestWordSet warning Failure Class test.TestWordSet has no public
constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestWordSet has no
public constructor TestCase(String name) or TestCase()
        0.000
TestWriterAdapter warning Failure Class test.TestWriterAdapter has no
public constructor TestCase(String name) or TestCase()

junit.framework.AssertionFailedError: Class test.TestWriterAdapter has
no public constructor TestCase(String name) or TestCase()
        0.000




On Mon, Jun 1, 2009 at 5:40 PM, Tatu Saloranta <tsaloranta@...> wrote:

> On Sun, May 31, 2009 at 7:14 PM, Benson Margulies <bimargulies@...> wrote:
>> I committed a revision to 4.1.
>>
>> It consists of:
>>
>> a set of 2009.1 snapshots of the msv jars in lib/msv2009. I didn't change
>> the version numbers on the outside.
>> a copy of build.xml that uses them.
>> changes to the repackage xml file to cope with them.
>> a disabled unit test of trying to start validation at the START_ELEMENT of
>> an element, which is what the SOAP-y case calls for.
>
> Sounds good. I think I had a related simple (and also commented out)
> test that tries to verify sub-tree validation.
>
>>
>> (src/test/wstxtest/msv/TestWsdlValidation.java)
>>
>> ant test seems happy enough -- no errors, lots of 'failures' around trying
>> to run test cases that aren't test cases.
>
> Hmmh. What would those be? Ant build ignores inner classes (any class
> with '$' in its name), those used to cause bogus warnings. But is
> there something else?
>
>>
>> Note that this msv requires JDK 1.5 stuff, and I can't recall if Tatu told
>> me that this was cool for 4.1. If not, I'll have to unwind this.
>
> Yes, 4.x is for 1.4. But I think it is ok to have 1.5-only build, as
> long as runtime works for non-MSV-based functionality.
> 5.0 will require 1.5.
> I think it is ok to use 1.5 for builds, and just use javac
> 'target="1.4"' settings: that is already being done for 4.0.
>
> Quick question for others: I recall that some users wanted 1.4
> compatibility. But is there need for 1.4 compatibility for W3C
> Schema/RelaxNG validation?
> These are parts that use MSV.
>
> -+ Tatu +-
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[bimargulies]

The 1.5 dependency mostly reared its head with the OSGi repackage
scripts, since the new msv references packages from 1.5.

On Mon, Jun 1, 2009 at 5:40 PM, Tatu Saloranta <tsaloranta@...> wrote:

> On Sun, May 31, 2009 at 7:14 PM, Benson Margulies <bimargulies@...> wrote:
>> I committed a revision to 4.1.
>>
>> It consists of:
>>
>> a set of 2009.1 snapshots of the msv jars in lib/msv2009. I didn't change
>> the version numbers on the outside.
>> a copy of build.xml that uses them.
>> changes to the repackage xml file to cope with them.
>> a disabled unit test of trying to start validation at the START_ELEMENT of
>> an element, which is what the SOAP-y case calls for.
>
> Sounds good. I think I had a related simple (and also commented out)
> test that tries to verify sub-tree validation.
>
>>
>> (src/test/wstxtest/msv/TestWsdlValidation.java)
>>
>> ant test seems happy enough -- no errors, lots of 'failures' around trying
>> to run test cases that aren't test cases.
>
> Hmmh. What would those be? Ant build ignores inner classes (any class
> with '$' in its name), those used to cause bogus warnings. But is
> there something else?
>
>>
>> Note that this msv requires JDK 1.5 stuff, and I can't recall if Tatu told
>> me that this was cool for 4.1. If not, I'll have to unwind this.
>
> Yes, 4.x is for 1.4. But I think it is ok to have 1.5-only build, as
> long as runtime works for non-MSV-based functionality.
> 5.0 will require 1.5.
> I think it is ok to use 1.5 for builds, and just use javac
> 'target="1.4"' settings: that is already being done for 4.0.
>
> Quick question for others: I recall that some users wanted 1.4
> compatibility. But is there need for 1.4 compatibility for W3C
> Schema/RelaxNG validation?
> These are parts that use MSV.
>
> -+ Tatu +-
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Cowtowncoder]

On Mon, Jun 1, 2009 at 2:43 PM, Benson Margulies <bimargulies@...> wrote:

> If you run 'ant test', you get zero errors, and 27 failures.
>
> Unit Test Results
>        Designed for use with JUnit and Ant.
> All Failures
> Class   Name    Status  Type    Time(s)
> TestBase64Reader        warning Failure No tests found in test.TestBase64Reader
>
> junit.framework.AssertionFailedError: No tests found in test.TestBase64Reader
>        0.003
> TestDomReader   warning Failure No tests found in test.TestDomReader

Ah I see. That is due to very unfortunate naming (my mistake) of
adding miscallenous tools to help testing, in package "test" (from
under src/java/test). In trunk these have been moved to "src/tools",
but for 4.0 they are still there (and 4.1 was cut from 4.0).

So these should not be included in junit test runs as they are not
tests despite naming that might suggest otherwise.

-+ Tatu +-

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Cowtowncoder]

On Mon, Jun 1, 2009 at 2:44 PM, Benson Margulies <bimargulies@...> wrote:
> The 1.5 dependency mostly reared its head with the OSGi repackage
> scripts, since the new msv references packages from 1.5.

Ok. Let's see if anyone needs 1.4 compatibility for Schema/RNG
validation -- if not, I think we can deal with it.

Also: I suspect users running an OSGi-based container will be using
1.5, if that matters (wrt OSGi dependency definitions).

-+ Tatu +-

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email