Subtle changes in seam-gen affecting JBDS :)

View: New views
4 Messages — Rating Filter:   Alert me  

Subtle changes in seam-gen affecting JBDS :)

by Max Rydahl Andersen-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

I've added Pete as a watcher on https://jira.jboss.org/jira/browse/JBDS-828
but if someone else knows about what components-war-tokenized.xml is and why
components.xml is not targeting AS5 so JBoss Tools/JBDS breaks...then
please feel free to comment.

p.s. I assume the tokenized.xml is to add some flexibility and that is
great, but adding that flexibility to JBDS
this close to codefreeze is something I would like to avoid if possible.
Next version we should sync on what
flexibilities were added since I got a feeling that more than this were
added to seam-gen recently ;)

/max
_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

Re: Subtle changes in seam-gen affecting JBDS :)

by Pete Muir-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Ok, I will respond on the issue.

On 17 Aug 2009, at 12:36, Max Rydahl Andersen wrote:

> Hi,
>
> I've added Pete as a watcher on https://jira.jboss.org/jira/browse/JBDS-828
> but if someone else knows about what components-war-tokenized.xml is  
> and why
> components.xml is not targeting AS5 so JBoss Tools/JBDS breaks...then
> please feel free to comment.
>
> p.s. I assume the tokenized.xml is to add some flexibility and that is
> great, but adding that flexibility to JBDS
> this close to codefreeze is something I would like to avoid if  
> possible.
> Next version we should sync on what
> flexibilities were added since I got a feeling that more than this  
> were
> added to seam-gen recently ;)
>
> /max
> _______________________________________________
> seam-dev mailing list
> seam-dev@...
> https://lists.jboss.org/mailman/listinfo/seam-dev

_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

Re: Subtle changes in seam-gen affecting JBDS :)

by Pete Muir-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Regarding whether JBT can use the tokenized-war, I don't think it can  
as it relies on ant replacement tokens.

Dan, could we achieve the same thing using an ftl at generation time?

In general, for the next major rev of Seam-gen, we should use ftl for  
every template file, no matter how trivial, as it gives us a lot more  
flexibility in the future to add features.

On 17 Aug 2009, at 13:04, Pete Muir wrote:

> Ok, I will respond on the issue.
>
> On 17 Aug 2009, at 12:36, Max Rydahl Andersen wrote:
>
>> Hi,
>>
>> I've added Pete as a watcher on https://jira.jboss.org/jira/browse/JBDS-828
>> but if someone else knows about what components-war-tokenized.xml is
>> and why
>> components.xml is not targeting AS5 so JBoss Tools/JBDS breaks...then
>> please feel free to comment.
>>
>> p.s. I assume the tokenized.xml is to add some flexibility and that  
>> is
>> great, but adding that flexibility to JBDS
>> this close to codefreeze is something I would like to avoid if
>> possible.
>> Next version we should sync on what
>> flexibilities were added since I got a feeling that more than this
>> were
>> added to seam-gen recently ;)
>>
>> /max
>> _______________________________________________
>> seam-dev mailing list
>> seam-dev@...
>> https://lists.jboss.org/mailman/listinfo/seam-dev
>
> _______________________________________________
> seam-dev mailing list
> seam-dev@...
> https://lists.jboss.org/mailman/listinfo/seam-dev

_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

Re: Subtle changes in seam-gen affecting JBDS :)

by Dan Allen (mojavelinux) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Sigh. I have explained this before, but I take the blame for not making this information part of the official documentation. Perhaps I should.

Here's the story. The purpose of the tokenized file is to allow the same build to target different application servers. Right now, JBoss AS 5 and GlassFish are supported. This cannot be done at project setup time because the point of supporting multiple servers is to demonstrate portability of an application, hence a switch at build time.

Before raising objection to token replacements, know that I have set it up so that the JBoss Tools sees files in the place it expects to see them with explicit values. The tokenized files are only used by Ant when running the build for GlassFish or with an alternative profile (in theory).

With that said, there could be bugs in this setup. The problem is that people keep changing the files without a full understand of how everything works. I know, it is confusing as hell. We have established already that seam-gen is just not going to get any better until it is rethought. It was never designed to support JBoss Tools. Therefore, we have these problems.

We really need to just leave seam-gen as it is at this point because the complexity is too high for it to be stable with so many hands in the pot. I know Pete said that a year ago, but we really need to support GlassFish to fix the perception that Seam only worked on JBoss AS. Yes, it was risky, but it has expanded our user base, so it was worth the effort.

-Dan

On Mon, Aug 17, 2009 at 8:12 AM, Pete Muir <pmuir@...> wrote:
Regarding whether JBT can use the tokenized-war, I don't think it can
as it relies on ant replacement tokens.

Dan, could we achieve the same thing using an ftl at generation time?

In general, for the next major rev of Seam-gen, we should use ftl for
every template file, no matter how trivial, as it gives us a lot more
flexibility in the future to add features.

On 17 Aug 2009, at 13:04, Pete Muir wrote:

> Ok, I will respond on the issue.
>
> On 17 Aug 2009, at 12:36, Max Rydahl Andersen wrote:
>
>> Hi,
>>
>> I've added Pete as a watcher on https://jira.jboss.org/jira/browse/JBDS-828
>> but if someone else knows about what components-war-tokenized.xml is
>> and why
>> components.xml is not targeting AS5 so JBoss Tools/JBDS breaks...then
>> please feel free to comment.
>>
>> p.s. I assume the tokenized.xml is to add some flexibility and that
>> is
>> great, but adding that flexibility to JBDS
>> this close to codefreeze is something I would like to avoid if
>> possible.
>> Next version we should sync on what
>> flexibilities were added since I got a feeling that more than this
>> were
>> added to seam-gen recently ;)
>>
>> /max
>> _______________________________________________
>> seam-dev mailing list
>> seam-dev@...
>> https://lists.jboss.org/mailman/listinfo/seam-dev
>
> _______________________________________________
> seam-dev mailing list
> seam-dev@...
> https://lists.jboss.org/mailman/listinfo/seam-dev

_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev



--
Dan Allen
Senior Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597

http://mojavelinux.com
http://mojavelinux.com/seaminaction
http://in.relation.to/Bloggers/Dan

_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev