Suggestion - Windows GUI Open File Dialog

[ajk-eis]

PSPP 0.7.9 - pspp-079-20120315-32bits
OS - Windows 7 Pro (up to date)

The PSPP GUI Open File Dialog (Open ...) is Case Sensitive in the listing
order of folders and files.  This puts "pspp" (the windows standard install
folder suggested by GNU Installer) at the end of all installation folders in
"Program Files" which is not expected by the user. The file selection in the
dialog (which is its primary purpose) is of course also affected by this
ordering issue.

Two suggestions -
1. The default installation folder should be upper case "PSPP" for the
windows installation to match the normal naming conventions in windows.
(Regardless of 2.)
2. The file dialog should be case insensitive as far as the ordering of
files and folders is concerned since this is the behaviour expected by the
normal user.

Alle


_______________________________________________
Pspp-users mailing list
Pspp-users@...
https://lists.gnu.org/mailman/listinfo/pspp-users

[Ben Pfaff]

"ajk-eis" <ajk-eis@...> writes:

> 1. The default installation folder should be upper case "PSPP" for the
> windows installation to match the normal naming conventions in windows.
> (Regardless of 2.)

I'm CCing Harry, who makes the Windows builds.  He'd have to make
that change.

> 2. The file dialog should be case insensitive as far as the ordering of
> files and folders is concerned since this is the behaviour expected by the
> normal user.

John (CCed), the following solves this particular issue but it
make me nervous because who knows what might depend on LC_COLLATE
while the file chooser dialog runs?  We might have to carefully
audit the source to avoid unwanted LC_COLLATE dependencies, and
then set LC_COLLATE based on the locale globally.  What do you think?

diff --git a/src/ui/gui/psppire-window.c b/src/ui/gui/psppire-window.c
index 4c7fcf5..379e007 100644
--- a/src/ui/gui/psppire-window.c
+++ b/src/ui/gui/psppire-window.c
@@ -791,9 +791,15 @@ psppire_window_file_chooser_dialog (PsppireWindow *toplevel)
 void
 psppire_window_open (PsppireWindow *de)
 {
-  GtkWidget *dialog = psppire_window_file_chooser_dialog (de);
+  GtkWidget *dialog;
+  gint retval;
+
+  setlocale (LC_COLLATE, "");
+  dialog = psppire_window_file_chooser_dialog (de);
+  retval = gtk_dialog_run (GTK_DIALOG (dialog));
+  setlocale (LC_COLLATE, "C");
 
-  switch (gtk_dialog_run (GTK_DIALOG (dialog)))
+  switch (retval)
     {
     case GTK_RESPONSE_ACCEPT:
       {

_______________________________________________
Pspp-users mailing list
Pspp-users@...
https://lists.gnu.org/mailman/listinfo/pspp-users

[Harry Thijssen]

Hi

You are right about this. I changed the installer accordingly. I just
build a new RC package with the latest master version which should
also include the update for the german langauage issue. You can find
it at http://sourceforge.net/projects/pspp4windows/files/2012-05-09-ReleaseCandidate/

Due to personal reasons I have no time to do any testing at all on
this build. If anybody has the time available please do so and report
your results.

Have fun



2012/5/9 Ben Pfaff <blp@...>:

> "ajk-eis" <ajk-eis@...> writes:
>
>> 1. The default installation folder should be upper case "PSPP" for the
>> windows installation to match the normal naming conventions in windows.
>> (Regardless of 2.)
>
> I'm CCing Harry, who makes the Windows builds.  He'd have to make
> that change.
>
>> 2. The file dialog should be case insensitive as far as the ordering of
>> files and folders is concerned since this is the behaviour expected by the
>> normal user.
>
> John (CCed), the following solves this particular issue but it
> make me nervous because who knows what might depend on LC_COLLATE
> while the file chooser dialog runs?  We might have to carefully
> audit the source to avoid unwanted LC_COLLATE dependencies, and
> then set LC_COLLATE based on the locale globally.  What do you think?
>
> diff --git a/src/ui/gui/psppire-window.c b/src/ui/gui/psppire-window.c
> index 4c7fcf5..379e007 100644
> --- a/src/ui/gui/psppire-window.c
> +++ b/src/ui/gui/psppire-window.c
> @@ -791,9 +791,15 @@ psppire_window_file_chooser_dialog (PsppireWindow *toplevel)
>  void
>  psppire_window_open (PsppireWindow *de)
>  {
> -  GtkWidget *dialog = psppire_window_file_chooser_dialog (de);
> +  GtkWidget *dialog;
> +  gint retval;
> +
> +  setlocale (LC_COLLATE, "");
> +  dialog = psppire_window_file_chooser_dialog (de);
> +  retval = gtk_dialog_run (GTK_DIALOG (dialog));
> +  setlocale (LC_COLLATE, "C");
>
> -  switch (gtk_dialog_run (GTK_DIALOG (dialog)))
> +  switch (retval)
>     {
>     case GTK_RESPONSE_ACCEPT:
>       {

_______________________________________________
Pspp-users mailing list
Pspp-users@...
https://lists.gnu.org/mailman/listinfo/pspp-users

[ajk-eis]

Thanks again to all of you!

I will try to check it out in the next few days.  My son had a bit of
trouble using the make file with the repository clone to compile a LINUX
(UBUNTU) version. Are there specific steps / instructions for that? He's
pretty knowledgeable (much more so than I am) but doesn't have much time.

Alle

> -----Ursprüngliche Nachricht-----
> Von: harry.thijssen@... [mailto:harry.thijssen@...] Im Auftrag
> von Harry Thijssen
> Gesendet: Mittwoch, 9. Mai 2012 14:32
> An: blp@...
> Cc: ajk-eis; John Darrington; pspp-users@...
> Betreff: Re: Suggestion - Windows GUI Open File Dialog
>
> Hi
>
> You are right about this. I changed the installer accordingly. I just
> build a new RC package with the latest master version which should
> also include the update for the german langauage issue. You can find
> it at http://sourceforge.net/projects/pspp4windows/files/2012-05-09-
> ReleaseCandidate/
>
> Due to personal reasons I have no time to do any testing at all on
> this build. If anybody has the time available please do so and report
> your results.
>
> Have fun
>
>
>
> 2012/5/9 Ben Pfaff <blp@...>:
> > "ajk-eis" <ajk-eis@...> writes:
> >
> >> 1. The default installation folder should be upper case "PSPP" for the
> >> windows installation to match the normal naming conventions in windows.
> >> (Regardless of 2.)
> >
> > I'm CCing Harry, who makes the Windows builds.  He'd have to make
> > that change.
> >
> >> 2. The file dialog should be case insensitive as far as the ordering of
> >> files and folders is concerned since this is the behaviour expected by
> the
> >> normal user.
> >
> > John (CCed), the following solves this particular issue but it
> > make me nervous because who knows what might depend on LC_COLLATE
> > while the file chooser dialog runs?  We might have to carefully
> > audit the source to avoid unwanted LC_COLLATE dependencies, and
> > then set LC_COLLATE based on the locale globally.  What do you think?
> >
> > diff --git a/src/ui/gui/psppire-window.c b/src/ui/gui/psppire-window.c
> > index 4c7fcf5..379e007 100644
> > --- a/src/ui/gui/psppire-window.c
> > +++ b/src/ui/gui/psppire-window.c
> > @@ -791,9 +791,15 @@ psppire_window_file_chooser_dialog (PsppireWindow
> *toplevel)
> >  void
> >  psppire_window_open (PsppireWindow *de)
> >  {
> > -  GtkWidget *dialog = psppire_window_file_chooser_dialog (de);
> > +  GtkWidget *dialog;
> > +  gint retval;
> > +
> > +  setlocale (LC_COLLATE, "");
> > +  dialog = psppire_window_file_chooser_dialog (de);
> > +  retval = gtk_dialog_run (GTK_DIALOG (dialog));
> > +  setlocale (LC_COLLATE, "C");
> >
> > -  switch (gtk_dialog_run (GTK_DIALOG (dialog)))
> > +  switch (retval)
> >     {
> >     case GTK_RESPONSE_ACCEPT:
> >       {

_______________________________________________
Pspp-users mailing list
Pspp-users@...
https://lists.gnu.org/mailman/listinfo/pspp-users

[John Darrington-4]

On Wed, May 09, 2012 at 09:00:47PM +0200, ajk-eis wrote:
     Thanks again to all of you!
     
     I will try to check it out in the next few days.  My son had a bit of
     trouble using the make file with the repository clone to compile a LINUX
     (UBUNTU) version. Are there specific steps / instructions for that? He's
     pretty knowledgeable (much more so than I am) but doesn't have much time.
     
The instructions are in the file called INSTALL.

--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.



_______________________________________________
Pspp-users mailing list
Pspp-users@...
https://lists.gnu.org/mailman/listinfo/pspp-users

[ajk-eis]

pspp4windows -  Release Candidate 20120509
pspp-079-20120509-32bits-Setup.exe

Just to let you all know, the fix works fine. The SPS file in UTF-8 with
german national characters now reads in to PSPP with no problems.

Also Harry fixed the installation folder to upper case "PSPP".

Thanks again to all of you.

Alle

> -----Ursprüngliche Nachricht-----
> Von: pspp-users-bounces+ajk-eis=rvhome.de@... [mailto:pspp-users-
> bounces+ajk-eis=rvhome.de@...] Im Auftrag von ajk-eis
> Gesendet: Mittwoch, 9. Mai 2012 21:01
> An: 'Harry Thijssen'; blp@...
> Cc: pspp-users@...
> Betreff: AW: Suggestion - Windows GUI Open File Dialog
>
> Thanks again to all of you!
>
> I will try to check it out in the next few days.  My son had a bit of
> trouble using the make file with the repository clone to compile a LINUX
> (UBUNTU) version. Are there specific steps / instructions for that? He's
> pretty knowledgeable (much more so than I am) but doesn't have much time.
>
> Alle
>
> > -----Ursprüngliche Nachricht-----
> > Von: harry.thijssen@... [mailto:harry.thijssen@...] Im
> Auftrag
> > von Harry Thijssen
> > Gesendet: Mittwoch, 9. Mai 2012 14:32
> > An: blp@...
> > Cc: ajk-eis; John Darrington; pspp-users@...
> > Betreff: Re: Suggestion - Windows GUI Open File Dialog
> >
> > Hi
> >
> > You are right about this. I changed the installer accordingly. I just
> > build a new RC package with the latest master version which should
> > also include the update for the german langauage issue. You can find
> > it at http://sourceforge.net/projects/pspp4windows/files/2012-05-09-
> > ReleaseCandidate/
> >
> > Due to personal reasons I have no time to do any testing at all on
> > this build. If anybody has the time available please do so and report
> > your results.
> >
> > Have fun
> >
> >
> >
> > 2012/5/9 Ben Pfaff <blp@...>:
> > > "ajk-eis" <ajk-eis@...> writes:
> > >
> > >> 1. The default installation folder should be upper case "PSPP" for
> the
> > >> windows installation to match the normal naming conventions in
> windows.
> > >> (Regardless of 2.)
> > >
> > > I'm CCing Harry, who makes the Windows builds.  He'd have to make
> > > that change.
> > >
> > >> 2. The file dialog should be case insensitive as far as the ordering
> of
> > >> files and folders is concerned since this is the behaviour expected
> by
> > the
> > >> normal user.
> > >
> > > John (CCed), the following solves this particular issue but it
> > > make me nervous because who knows what might depend on LC_COLLATE
> > > while the file chooser dialog runs?  We might have to carefully
> > > audit the source to avoid unwanted LC_COLLATE dependencies, and
> > > then set LC_COLLATE based on the locale globally.  What do you think?
> > >
> > > diff --git a/src/ui/gui/psppire-window.c b/src/ui/gui/psppire-window.c
> > > index 4c7fcf5..379e007 100644
> > > --- a/src/ui/gui/psppire-window.c
> > > +++ b/src/ui/gui/psppire-window.c
> > > @@ -791,9 +791,15 @@ psppire_window_file_chooser_dialog (PsppireWindow
> > *toplevel)
> > >  void
> > >  psppire_window_open (PsppireWindow *de)
> > >  {
> > > -  GtkWidget *dialog = psppire_window_file_chooser_dialog (de);
> > > +  GtkWidget *dialog;
> > > +  gint retval;
> > > +
> > > +  setlocale (LC_COLLATE, "");
> > > +  dialog = psppire_window_file_chooser_dialog (de);
> > > +  retval = gtk_dialog_run (GTK_DIALOG (dialog));
> > > +  setlocale (LC_COLLATE, "C");
> > >
> > > -  switch (gtk_dialog_run (GTK_DIALOG (dialog)))
> > > +  switch (retval)
> > >     {
> > >     case GTK_RESPONSE_ACCEPT:
> > >       {
>
>
> _______________________________________________
> Pspp-users mailing list
> Pspp-users@...
> https://lists.gnu.org/mailman/listinfo/pspp-users

_______________________________________________
Pspp-users mailing list
Pspp-users@...
https://lists.gnu.org/mailman/listinfo/pspp-users