Support for Hibernate ParameterizedType - contrib

[Dave Hallam-4]

Hi,

I've been looking at the Grails support for UserType and noticed that it doesn't support UserTypes that also implement ParameterizedType.  Adding this functionality will allow for much more powerful user types to be developed.

I've made some changes to the latest Grails code locally to get it to work and there is very little that needs to be done that will allow something like:

class Order {
   

   String orderDate

   static mapping = {
      columns {
          orderDate type: DateType, params: [ format: "ddMMyyyy" ]
      }

   }
}

class DateType implements UserType, ParameterizedType {
   private String format

   ...

   public void setParameterValues(Properties parameters) {
      format = parameters.format
   }


   ...

}

The classes that are affected are GrailsDomainBinder.java (in setTypeForProperty), HibernateMappingBuilder.groovy (in handleMethodMissing closure) and PropertyConfig.groovy (additional class attribute).

What's the process and what do I need to do to get this minor mod rolled into the Grails codebase?

Many thanks.

Dave

[Graeme Rocher-3]

Hi Dave,

Please raise a JIRA and submit a patch or pull request via Git. Thanks
for the contribution.

Regards,

On Wed, Oct 28, 2009 at 9:43 AM, Dave Hallam <dev@...> wrote:

> Hi,
>
> I've been looking at the Grails support for UserType and noticed that it
> doesn't support UserTypes that also implement ParameterizedType.  Adding
> this functionality will allow for much more powerful user types to be
> developed.
>
> I've made some changes to the latest Grails code locally to get it to work
> and there is very little that needs to be done that will allow something
> like:
>
> class Order {
>
>
>    String orderDate
>
>    static mapping = {
>       columns {
>           orderDate type: DateType, params: [ format: "ddMMyyyy" ]
>       }
>
>    }
> }
>
> class DateType implements UserType, ParameterizedType {
>    private String format
>
>    ...
>
>    public void setParameterValues(Properties parameters) {
>       format = parameters.format
>    }
>
>
>    ...
>
> }
>
> The classes that are affected are GrailsDomainBinder.java (in
> setTypeForProperty), HibernateMappingBuilder.groovy (in handleMethodMissing
> closure) and PropertyConfig.groovy (additional class attribute).
>
> What's the process and what do I need to do to get this minor mod rolled
> into the Grails codebase?
>
> Many thanks.
>
> Dave
>
>

--
Graeme Rocher
Head of Grails Development
SpringSource - Weapons for the War on Java Complexity
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Dave Hallam-4]

Patch created and JIRA raised http://jira.codehaus.org/browse/GRAILS-5286

2009/10/28 Graeme Rocher <graeme.rocher@...>

Hi Dave,

Please raise a JIRA and submit a patch or pull request via Git. Thanks
for the contribution.

Regards,

On Wed, Oct 28, 2009 at 9:43 AM, Dave Hallam <dev@...> wrote:
> Hi,
>
> I've been looking at the Grails support for UserType and noticed that it
> doesn't support UserTypes that also implement ParameterizedType.  Adding
> this functionality will allow for much more powerful user types to be
> developed.
>
> I've made some changes to the latest Grails code locally to get it to work
> and there is very little that needs to be done that will allow something
> like:
>
> class Order {
>
>
>    String orderDate
>
>    static mapping = {
>       columns {
>           orderDate type: DateType, params: [ format: "ddMMyyyy" ]
>       }
>
>    }
> }
>
> class DateType implements UserType, ParameterizedType {
>    private String format
>
>    ...
>
>    public void setParameterValues(Properties parameters) {
>       format = parameters.format
>    }
>
>
>    ...
>
> }
>
> The classes that are affected are GrailsDomainBinder.java (in
> setTypeForProperty), HibernateMappingBuilder.groovy (in handleMethodMissing
> closure) and PropertyConfig.groovy (additional class attribute).
>
> What's the process and what do I need to do to get this minor mod rolled
> into the Grails codebase?
>
> Many thanks.
>
> Dave
>
>

--
Graeme Rocher
Head of Grails Development
SpringSource - Weapons for the War on Java Complexity
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email