TagLib 1.6

Hi,

TagLib 1.6 is released. This release includes support for four new
file formats - ASF, MP4, AIFF, WAV, new ID4v2.4 frames - POPM and
PRIV, and a number of bug fixes.

I'm not sure if Scott has time to update his page, so I've created a
_temporary_ page for TagLib 1.6 where you can find
download/documentation links and change log --
http://oxygene.sk/lukas/taglib/

As I said in the 1.6 RC announce email, this is the last release in
1.x series. The next release will be 2.0, which will include
incompatible changes. I'll send a separate mail regarding 2.0
development later.

Source code
=========

http://ftp.musicbrainz.org/pub/musicbrainz/users/luks/taglib/taglib-1.6.tar.gz
(1.0M)

Changes since version 1.5
===================

1.6:

 * New CMake option to build a static version - ENABLE_STATIC.
 * Added support for disabling dllimport/dllexport on Windows using the
   TAGLIB_STATIC macro.
 * Support for parsing the obsolete 'gnre' MP4 atom.
 * New cpp macros TAGLIB_WITH_MP4 and TAGLIB_WITH_ASF to determin if
   TagLib was built with MP4/ASF support.

1.6 RC1:

 * Split Ogg packets larger than 64k into multiple pages. (BUG:171957)
 * TagLib can now use FLAC padding block. (BUG:107659)
 * ID3v2.2 frames are now not incorrectly saved. (BUG:176373)
 * Support for ID3v2.2 PIC frames. (BUG:167786)
 * Fixed a bug in ByteVectorList::split().
 * XiphComment::year() now falls back to YEAR if DATE doesn't exist
   and XiphComment::year() falls back to TRACKNUM if TRACKNUMBER doesn't
   exist. (BUG:144396)
 * Improved ID3v2.3 genre parsing. (BUG:188578)
 * Better checking of corrupted ID3v2 APIC data. (BUG:168382)
 * Bitrate calculating using the Xing header now uses floating point
   numbers. (BUG:172556)
 * New TagLib::String method rfind().
 * Added support for MP4 file format with iTunes-style metadata [optional].
 * Added support for ASF (WMA) file format [optional].
 * Fixed crash when saving a Locator APEv2 tag. (BUG:169810)
 * Fixed a possible crash in the non-const version of String::operator[]
   and in String::operator+=. (BUG:169389)
 * Added support for PRIV ID3v2 frames.
 * Empty ID3v2 genres are no longer treated as numeric ID3v1 genres.
 * Added support for the POPM (rating/playcount) ID3v2 frame.
 * Generic RIFF file format support:
   * Support for AIFF files with ID3v2 tags.
   * Support for WAV files with ID3v2 tags.
 * Fixed crash on handling unsupported ID3v2 frames, e.g. on encrypted
   frames. (BUG:161721)
 * Fixed overflow while calculating bitrate of FLAC files with a very
   high bitrate.

--
Lukas Lalinsky
lalinsky@...
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

[Brett Hoyle]

  In SVN the macros switched and then switched back to WITH_ASF/WITH_MP4
instead of TAGLIB_WITH_ASF/TAGLIB_WITH_MP4.

Also this is clearly too late for 1.6 and not hugely important but the
RIFF/WAV support still lacks the seemingly very simple to calculate
"length" property. This field really should be filled correctly.

On 14/09/2009 12:44 AM, Lukáš Lalinský wrote:

> Hi,
>
> TagLib 1.6 is released. This release includes support for four new
> file formats - ASF, MP4, AIFF, WAV, new ID4v2.4 frames - POPM and
> PRIV, and a number of bug fixes.
>
> I'm not sure if Scott has time to update his page, so I've created a
> _temporary_ page for TagLib 1.6 where you can find
> download/documentation links and change log --
> http://oxygene.sk/lukas/taglib/
>
> As I said in the 1.6 RC announce email, this is the last release in
> 1.x series. The next release will be 2.0, which will include
> incompatible changes. I'll send a separate mail regarding 2.0
> development later.
>
> Source code
> =========
>
> http://ftp.musicbrainz.org/pub/musicbrainz/users/luks/taglib/taglib-1.6.tar.gz
> (1.0M)
>
> Changes since version 1.5
> ===================
>
> 1.6:
>
>   * New CMake option to build a static version - ENABLE_STATIC.
>   * Added support for disabling dllimport/dllexport on Windows using the
>     TAGLIB_STATIC macro.
>   * Support for parsing the obsolete 'gnre' MP4 atom.
>   * New cpp macros TAGLIB_WITH_MP4 and TAGLIB_WITH_ASF to determin if
>     TagLib was built with MP4/ASF support.
>
> 1.6 RC1:
>
>   * Split Ogg packets larger than 64k into multiple pages. (BUG:171957)
>   * TagLib can now use FLAC padding block. (BUG:107659)
>   * ID3v2.2 frames are now not incorrectly saved. (BUG:176373)
>   * Support for ID3v2.2 PIC frames. (BUG:167786)
>   * Fixed a bug in ByteVectorList::split().
>   * XiphComment::year() now falls back to YEAR if DATE doesn't exist
>     and XiphComment::year() falls back to TRACKNUM if TRACKNUMBER doesn't
>     exist. (BUG:144396)
>   * Improved ID3v2.3 genre parsing. (BUG:188578)
>   * Better checking of corrupted ID3v2 APIC data. (BUG:168382)
>   * Bitrate calculating using the Xing header now uses floating point
>     numbers. (BUG:172556)
>   * New TagLib::String method rfind().
>   * Added support for MP4 file format with iTunes-style metadata [optional].
>   * Added support for ASF (WMA) file format [optional].
>   * Fixed crash when saving a Locator APEv2 tag. (BUG:169810)
>   * Fixed a possible crash in the non-const version of String::operator[]
>     and in String::operator+=. (BUG:169389)
>   * Added support for PRIV ID3v2 frames.
>   * Empty ID3v2 genres are no longer treated as numeric ID3v1 genres.
>   * Added support for the POPM (rating/playcount) ID3v2 frame.
>   * Generic RIFF file format support:
>     * Support for AIFF files with ID3v2 tags.
>     * Support for WAV files with ID3v2 tags.
>   * Fixed crash on handling unsupported ID3v2 frames, e.g. on encrypted
>     frames. (BUG:161721)
>   * Fixed overflow while calculating bitrate of FLAC files with a very
>     high bitrate.
>

_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

On Sun, Sep 13, 2009 at 5:34 PM, Brett Hoyle <kickbits@...> wrote:
> In SVN the macros switched and then switched back to WITH_ASF/WITH_MP4
> instead of TAGLIB_WITH_ASF/TAGLIB_WITH_MP4.

In TagLib's internal code. WITH_ASF/WITH_MP4 are defined in config.h
which exists only when building TagLib.
TAGLIB_WITH_ASF/TAGLIB_WITH_MP4 are public macros for users of TagLib.

> Also this is clearly too late for 1.6 and not hugely important but the
> RIFF/WAV support still lacks the seemingly very simple to calculate
> "length" property. This field really should be filled correctly.

Please file a bug report about this.

--
Lukas Lalinsky
lalinsky@...
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

[Brett Hoyle]

On 14/09/2009 1:08 AM, Lukáš Lalinský wrote:
> On Sun, Sep 13, 2009 at 5:34 PM, Brett Hoyle<kickbits@...>  wrote:
>
>> Also this is clearly too late for 1.6 and not hugely important but the
>> RIFF/WAV support still lacks the seemingly very simple to calculate
>> "length" property. This field really should be filled correctly.
> Please file a bug report about this.

The bug/feature request is already listed here:
https://bugs.kde.org/show_bug.cgi?id=116033
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

[Michael Schwendt]

On Sun, 13 Sep 2009 17:14:17 +0200, Lukáš wrote:

> Hi,
>
> TagLib 1.6 is released. This release includes support for four new
> file formats - ASF, MP4, AIFF, WAV, new ID4v2.4 frames - POPM and
> PRIV, and a number of bug fixes.

Test-suite fails on ppc64 (haven't had any look at the related source code yet):

http://koji.fedoraproject.org/koji/taskinfo?taskID=1676252
 => http://koji.fedoraproject.org/koji/getfile?taskID=1676258&name=build.log

[...]
TestMP4::testSaveExisingWhenIlstIsLast : OK
TestMP4::test64BitAtomTagLib: MP4: No audio tracks
TagLib: MP4: No audio tracks
 : assertion
TestASF::testProperties : OK
TestASF::testRead : OK
TestASF::testSaveMultipleValues : OK
TestASF::testSaveStream : OK
TestASF::testSaveLanguage : OK
test_mp4.cpp:138:Assertion
Test name: TestMP4::test64BitAtom
equality assertion failed
- Expected: 1
- Actual  : 0
Failures !!!
Run: 80   Failure total: 1   Failures: 1   Errors: 0
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

[Michael Schwendt]

On Mon, 14 Sep 2009 10:29:19 +0200, Michael wrote:

> On Sun, 13 Sep 2009 17:14:17 +0200, Lukáš wrote:
>
> > Hi,
> >
> > TagLib 1.6 is released. This release includes support for four new
> > file formats - ASF, MP4, AIFF, WAV, new ID4v2.4 frames - POPM and
> > PRIV, and a number of bug fixes.
>
> Test-suite fails on ppc64 (haven't had any look at the related source code yet):
>
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1676252
>  => http://koji.fedoraproject.org/koji/getfile?taskID=1676258&name=build.log
>
> [...]
> TestMP4::testSaveExisingWhenIlstIsLast : OK
> TestMP4::test64BitAtomTagLib: MP4: No audio tracks
> TagLib: MP4: No audio tracks
>  : assertion
> TestASF::testProperties : OK
> TestASF::testRead : OK
> TestASF::testSaveMultipleValues : OK
> TestASF::testSaveStream : OK
> TestASF::testSaveLanguage : OK
> test_mp4.cpp:138:Assertion
> Test name: TestMP4::test64BitAtom
> equality assertion failed
> - Expected: 1
> - Actual  : 0
> Failures !!!
> Run: 80   Failure total: 1   Failures: 1   Errors: 0

And because i686 and x86_64 succeed, here will be a scratch-build
for ppc to find out whether it might be an endianness issue:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1676339
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

On Mon, Sep 14, 2009 at 10:57 AM, Michael Schwendt <mschwendt@...> wrote:

> On Mon, 14 Sep 2009 10:29:19 +0200, Michael wrote:
>
>> On Sun, 13 Sep 2009 17:14:17 +0200, Lukáš wrote:
>>
>> > Hi,
>> >
>> > TagLib 1.6 is released. This release includes support for four new
>> > file formats - ASF, MP4, AIFF, WAV, new ID4v2.4 frames - POPM and
>> > PRIV, and a number of bug fixes.
>>
>> Test-suite fails on ppc64 (haven't had any look at the related source code yet):
>>
>> http://koji.fedoraproject.org/koji/taskinfo?taskID=1676252
>>  => http://koji.fedoraproject.org/koji/getfile?taskID=1676258&name=build.log
>>
>> [...]
>> TestMP4::testSaveExisingWhenIlstIsLast : OK
>> TestMP4::test64BitAtomTagLib: MP4: No audio tracks
>> TagLib: MP4: No audio tracks
>>  : assertion
>> TestASF::testProperties : OK
>> TestASF::testRead : OK
>> TestASF::testSaveMultipleValues : OK
>> TestASF::testSaveStream : OK
>> TestASF::testSaveLanguage : OK
>> test_mp4.cpp:138:Assertion
>> Test name: TestMP4::test64BitAtom
>> equality assertion failed
>> - Expected: 1
>> - Actual  : 0
>> Failures !!!
>> Run: 80   Failure total: 1   Failures: 1   Errors: 0
>
> And because i686 and x86_64 succeed, here will be a scratch-build
> for ppc to find out whether it might be an endianness issue:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1676339

Because I don't have access to a ppc64 machine and I don't see any
obvious problems, there is not much I can do about it without more
information. If somebody with such a machine can run the test suite
with the attached patch and post the output here, it would help a lot.

--
Lukas Lalinsky
lalinsky@...

[ppc64-dump.diff]

---

Index: tests/test_mp4.cpp
===================================================================
--- tests/test_mp4.cpp (revision 1022918)
+++ tests/test_mp4.cpp (working copy)
@@ -134,6 +134,13 @@
     f->save();
 
     f = new MP4::File(filename.c_str());
+    f->seek(0);
+    ByteVector data = f->readBlock(1000);
+    for (int i = 0; i < data.size(); i++) {
+        printf("%02x%s", (unsigned char)data[i], (i % 16 == 15) ? "\n": " ");
+    }
+    printf("\n");
+
     CPPUNIT_ASSERT_EQUAL(true, f->tag()->itemListMap()["cpil"].toBool());
     CPPUNIT_ASSERT_EQUAL(true, f->tag()->itemListMap()["pgap"].toBool());
 

---

_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

[Michael Schwendt]

On Mon, 14 Sep 2009 11:45:39 +0200, Lukáš wrote:

> Because I don't have access to a ppc64 machine and I don't see any
> obvious problems, there is not much I can do about it without more
> information. If somebody with such a machine can run the test suite
> with the attached patch and post the output here, it would help a lot.

http://koji.fedoraproject.org/koji/getfile?taskID=1676449&name=build.log
[ task: http://koji.fedoraproject.org/koji/taskinfo?taskID=1676449 ]

TestMP4::testSaveExisingWhenIlstIsLast : OK
TestMP4::test64BitAtomTagLib: MP4: No audio tracks
TagLib: MP4: No audio tracks
00 00 00 01 6d 6f 6f 76 00 00 00 00 00 00 04 34
00 00 00 01 75 64 74 61 00 00 00 00 00 00 04 24
00 00 00 01 6d 65 74 61 00 00 00 00 00 00 00 2d
00 00 00 00 00 00 00 3a 69 6c 73 74 00 00 00 19
63 70 69 6c 00 00 00 11 64 61 74 61 00 00 00 15
00 00 00 00 01 00 00 00 19 70 67 61 70 00 00 00
11 64 61 74 61 00 00 00 15 00 00 00 00 00 00 00
03 ce 66 72 65 65 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01
01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01
[and so on...]
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

On Mon, Sep 14, 2009 at 12:03 PM, Michael Schwendt <mschwendt@...> wrote:
> On Mon, 14 Sep 2009 11:45:39 +0200, Lukáš wrote:
>
>> Because I don't have access to a ppc64 machine and I don't see any
>> obvious problems, there is not much I can do about it without more
>> information. If somebody with such a machine can run the test suite
>> with the attached patch and post the output here, it would help a lot.
>
> http://koji.fedoraproject.org/koji/getfile?taskID=1676449&name=build.log
> [ task: http://koji.fedoraproject.org/koji/taskinfo?taskID=1676449 ]

Thank you! The problem was in the test, not TagLib's actual code
(although it could at least print a warning in such situations). See
http://websvn.kde.org/?view=rev&revision=1023246 for a fix.

--
Lukas Lalinsky
lalinsky@...
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel