TestNG upgrade for 2.2 GA

View: New views
9 Messages — Rating Filter:   Alert me  

TestNG upgrade for 2.2 GA

by Christian Bauer-8 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I want to upgrade TestNG from 5.6 to 5.9, however, there is this  
comment in build/core.pom.xml:

     <!-- Surefire can't cope with such a new version of testng, so we  
have to specify it
       here, otherwise ui build fails -->
     <dependency>
       <groupId>org.testng</groupId>
       <artifactId>testng</artifactId>
       <version>5.6</version>
       <optional>true</optional>
       <exclusions>
         <exclusion>
           <groupId>junit</groupId>
           <artifactId>junit</artifactId>
         </exclusion>
       </exclusions>
     </dependency>

After switching this to 5.9 I've had a clean build and tests. Can we  
get this into 2.2 GA? If yes, I can probably commit some nice  
enhancements to test infrastructure (dbunit, resteasy) tomorrow.

_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

Re: TestNG upgrade for 2.2 GA

by Dan Allen (mojavelinux) :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I'm pretty sure the surefire problems with TestNG have been resolved (at least in Maven 2.0.9 and above). So +1 from me

-Dan

On Tue, Jul 7, 2009 at 1:20 PM, Christian Bauer <christian.bauer@...> wrote:
I want to upgrade TestNG from 5.6 to 5.9, however, there is this comment in build/core.pom.xml:

   <!-- Surefire can't cope with such a new version of testng, so we have to specify it
     here, otherwise ui build fails -->
   <dependency>
     <groupId>org.testng</groupId>
     <artifactId>testng</artifactId>
     <version>5.6</version>
     <optional>true</optional>
     <exclusions>
       <exclusion>
         <groupId>junit</groupId>
         <artifactId>junit</artifactId>
       </exclusion>
     </exclusions>
   </dependency>

After switching this to 5.9 I've had a clean build and tests. Can we get this into 2.2 GA? If yes, I can probably commit some nice enhancements to test infrastructure (dbunit, resteasy) tomorrow.

_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev



--
Dan Allen
Senior Software Engineer, Red Hat | Author of Seam in Action

http://mojavelinux.com
http://mojavelinux.com/seaminaction
http://in.relation.to/Bloggers/Dan

NOTE: While I make a strong effort to keep up with my email on a daily
basis, personal or other work matters can sometimes keep me away
from my email. If you contact me, but don't hear back for more than a week,
it is very likely that I am excessively backlogged or the message was
caught in the spam filters.  Please don't hesitate to resend a message if
you feel that it did not reach my attention.

_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

Re: TestNG upgrade for 2.2 GA

by Marek Novotny :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

exactly, I have upgraded to 5.8 in EAP and all is OK. It only requires
to upgrade surefire plugin to 2.4.3

Dan Allen píše v Út 07. 07. 2009 v 15:02 -0400:

> I'm pretty sure the surefire problems with TestNG have been resolved
> (at least in Maven 2.0.9 and above). So +1 from me
>
> -Dan
>
> On Tue, Jul 7, 2009 at 1:20 PM, Christian Bauer
> <christian.bauer@...> wrote:
>         I want to upgrade TestNG from 5.6 to 5.9, however, there is
>         this comment in build/core.pom.xml:
>        
>            <!-- Surefire can't cope with such a new version of testng,
>         so we have to specify it
>              here, otherwise ui build fails -->
>            <dependency>
>              <groupId>org.testng</groupId>
>              <artifactId>testng</artifactId>
>              <version>5.6</version>
>              <optional>true</optional>
>              <exclusions>
>                <exclusion>
>                  <groupId>junit</groupId>
>                  <artifactId>junit</artifactId>
>                </exclusion>
>              </exclusions>
>            </dependency>
>        
>         After switching this to 5.9 I've had a clean build and tests.
>         Can we get this into 2.2 GA? If yes, I can probably commit
>         some nice enhancements to test infrastructure (dbunit,
>         resteasy) tomorrow.
>        
>         _______________________________________________
>         seam-dev mailing list
>         seam-dev@...
>         https://lists.jboss.org/mailman/listinfo/seam-dev
>
>
>
> --
> Dan Allen
> Senior Software Engineer, Red Hat | Author of Seam in Action
>
> http://mojavelinux.com
> http://mojavelinux.com/seaminaction
> http://in.relation.to/Bloggers/Dan
>
> NOTE: While I make a strong effort to keep up with my email on a daily
> basis, personal or other work matters can sometimes keep me away
> from my email. If you contact me, but don't hear back for more than a
> week,
> it is very likely that I am excessively backlogged or the message was
> caught in the spam filters.  Please don't hesitate to resend a message
> if
> you feel that it did not reach my attention.
> _______________________________________________
> seam-dev mailing list
> seam-dev@...
> https://lists.jboss.org/mailman/listinfo/seam-dev
--
Marek Novotny
--
JBoss Seam Product Lead

Red Hat Czech s.r.o.
Purkynova 99
612 45 Brno

Email: mnovotny@...
Office phone: +420 532 294 287, ext. 82-62 087
mobile: +420 608 509 230

------------------------------------------------------
Looking to carve out IT costs?
www.europe.redhat.com/promo/carveoutcosts/


_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

signature.asc (204 bytes) Download Attachment

Re: TestNG upgrade for 2.2 GA

by Christian Bauer-8 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Jul 08, 2009, at 10:17 , Marek Novotny wrote:

> exactly, I have upgraded to 5.8 in EAP and all is OK. It only requires
> to upgrade surefire plugin to 2.4.3

Being a !Maven, do I have to do anything in a Seam POM or is that up  
to the individual?
_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

Re: TestNG upgrade for 2.2 GA

by Marek Novotny :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

hmm, I don't understand what you mean, anyway look at
http://fisheye.jboss.org/changelog/Seam/?cs=11223


Christian Bauer píše v St 08. 07. 2009 v 10:19 +0200:

> On Jul 08, 2009, at 10:17 , Marek Novotny wrote:
>
> > exactly, I have upgraded to 5.8 in EAP and all is OK. It only requires
> > to upgrade surefire plugin to 2.4.3
>
> Being a !Maven, do I have to do anything in a Seam POM or is that up  
> to the individual?
> _______________________________________________
> seam-dev mailing list
> seam-dev@...
> https://lists.jboss.org/mailman/listinfo/seam-dev
--
Marek Novotny
--
JBoss Seam Product Lead

Red Hat Czech s.r.o.
Purkynova 99
612 45 Brno

Email: mnovotny@...
Office phone: +420 532 294 287, ext. 82-62 087
mobile: +420 608 509 230

------------------------------------------------------
Looking to carve out IT costs?
www.europe.redhat.com/promo/carveoutcosts/


_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

signature.asc (204 bytes) Download Attachment

Re: TestNG upgrade for 2.2 GA

by Christian Bauer-8 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Jul 08, 2009, at 10:29 , Marek Novotny wrote:

> hmm, I don't understand what you mean, anyway look at
> http://fisheye.jboss.org/changelog/Seam/?cs=11223

Did all of this, except commenting out the maven_central thing in  
root.pom.xml which doesn't exist in Seam base. I had to remove the  
<classifier>jdk15</classifier> in ui.pom.xml though. You apparently  
did the same, then added it back before committing?
_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

Re: TestNG upgrade for 2.2 GA

by Marek Novotny :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Correct.


Christian Bauer píše v St 08. 07. 2009 v 10:50 +0200:

> On Jul 08, 2009, at 10:29 , Marek Novotny wrote:
>
> > hmm, I don't understand what you mean, anyway look at
> > http://fisheye.jboss.org/changelog/Seam/?cs=11223
>
> Did all of this, except commenting out the maven_central thing in  
> root.pom.xml which doesn't exist in Seam base. I had to remove the  
> <classifier>jdk15</classifier> in ui.pom.xml though. You apparently  
> did the same, then added it back before committing?
> _______________________________________________
> seam-dev mailing list
> seam-dev@...
> https://lists.jboss.org/mailman/listinfo/seam-dev
--
Marek Novotny
--
JBoss Seam Product Lead

Red Hat Czech s.r.o.
Purkynova 99
612 45 Brno

Email: mnovotny@...
Office phone: +420 532 294 287, ext. 82-62 087
mobile: +420 608 509 230

------------------------------------------------------
Looking to carve out IT costs?
www.europe.redhat.com/promo/carveoutcosts/


_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

signature.asc (204 bytes) Download Attachment

Re: TestNG upgrade for 2.2 GA

by Christian Bauer-8 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Jul 08, 2009, at 10:58 , Marek Novotny wrote:

> Correct.
>
>
> Christian Bauer píše v St 08. 07. 2009 v 10:50 +0200:
>> On Jul 08, 2009, at 10:29 , Marek Novotny wrote:
>>
>>> hmm, I don't understand what you mean, anyway look at
>>> http://fisheye.jboss.org/changelog/Seam/?cs=11223
>>
>> Did all of this, except commenting out the maven_central thing in
>> root.pom.xml which doesn't exist in Seam base. I had to remove the
>> <classifier>jdk15</classifier> in ui.pom.xml though. You apparently
>> did the same, then added it back before committing?

Ah, so it looks like for TestNG 5.9 we only have the jdk15 version in  
the repository anyway, according to the central maven repository hashes.

Any particular reasons why a) you didn't use 5.9 and b) the JBoss repo  
has different layout for 5.9 compared to 5.8 and maven central?


_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

Re: TestNG upgrade for 2.2 GA

by Marek Novotny :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I think, that at the time of my changes version 5.9 was only at testng
site available not in central maven repo. Therefore I took 5.8. I knew
that 5.9 was available at testng.org, but nowhere in maven repo.

I didn't look for 5.9 in jboss.org, but the current layout is wrong for
jboss.org, it should use classifier IMO. This was added by galder on
30th June.

$ svn log 5.9
r27601 | galder.zamarreno@... | 2009-06-30 13:07:16 +0200 (Út, 30
čen 2009) | 1 line

Uploaded testng 5.9


 


Christian Bauer píše v St 08. 07. 2009 v 11:21 +0200:

> On Jul 08, 2009, at 10:58 , Marek Novotny wrote:
>
> > Correct.
> >
> >
> > Christian Bauer píše v St 08. 07. 2009 v 10:50 +0200:
> >> On Jul 08, 2009, at 10:29 , Marek Novotny wrote:
> >>
> >>> hmm, I don't understand what you mean, anyway look at
> >>> http://fisheye.jboss.org/changelog/Seam/?cs=11223
> >>
> >> Did all of this, except commenting out the maven_central thing in
> >> root.pom.xml which doesn't exist in Seam base. I had to remove the
> >> <classifier>jdk15</classifier> in ui.pom.xml though. You apparently
> >> did the same, then added it back before committing?
>
> Ah, so it looks like for TestNG 5.9 we only have the jdk15 version in  
> the repository anyway, according to the central maven repository hashes.
>
> Any particular reasons why a) you didn't use 5.9 and b) the JBoss repo  
> has different layout for 5.9 compared to 5.8 and maven central?
>
>
> _______________________________________________
> seam-dev mailing list
> seam-dev@...
> https://lists.jboss.org/mailman/listinfo/seam-dev
--
Marek Novotny
--
JBoss Seam Product Lead

Red Hat Czech s.r.o.
Purkynova 99
612 45 Brno

Email: mnovotny@...
Office phone: +420 532 294 287, ext. 82-62 087
mobile: +420 608 509 230

------------------------------------------------------
Looking to carve out IT costs?
www.europe.redhat.com/promo/carveoutcosts/


_______________________________________________
seam-dev mailing list
seam-dev@...
https://lists.jboss.org/mailman/listinfo/seam-dev

signature.asc (204 bytes) Download Attachment