Testing changes and Grails 1.2 release

[Peter Ledbrook]

Hi,

There have been a couple of suggestions for changes to the test-app
command so that plugin authors find it easier to integrate
test-related plugins, such as Spock, Selenium-RC, EasyB, etc. The
question I have is should we try to get these changes into Grails 1.2?
It's late in the day for a feature change like this, so I'm reluctant
to promote the idea on that basis. However, I also think that it makes
sense to have the changes available in a major version release,
otherwise users will wonder why the plugins work with Grails 1.2.1 but
not 1.2.

So, what do others think? If all those plugin authors are hammering
the test script making sure that it works with their plugin, does that
mitigate the dangers of a feature change this late in the day? Or
should we just leave it to a minor/patch release or 1.3?

Cheers,

Peter

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Graeme Rocher-3]

Yes as long as they are not breaking, now is the time to do it before
the RC is out (probably end of next week)

Regards

On Tue, Oct 27, 2009 at 3:27 PM, Peter Ledbrook <peter@...> wrote:

> Hi,
>
> There have been a couple of suggestions for changes to the test-app
> command so that plugin authors find it easier to integrate
> test-related plugins, such as Spock, Selenium-RC, EasyB, etc. The
> question I have is should we try to get these changes into Grails 1.2?
> It's late in the day for a feature change like this, so I'm reluctant
> to promote the idea on that basis. However, I also think that it makes
> sense to have the changes available in a major version release,
> otherwise users will wonder why the plugins work with Grails 1.2.1 but
> not 1.2.
>
> So, what do others think? If all those plugin authors are hammering
> the test script making sure that it works with their plugin, does that
> mitigate the dangers of a feature change this late in the day? Or
> should we just leave it to a minor/patch release or 1.3?
>
> Cheers,
>
> Peter
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>

--
Graeme Rocher
Head of Grails Development
SpringSource - Weapons for the War on Java Complexity
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Luke Daley]

Here is what I plan to do:

• Separate test phases from types more cleanly and make types  
responsible for running the tests (patch sent in earlier email)
• Separate GrailsTestHelper and friends from the JUnit API to be  
runner agnostic, but provide JUnit3 versions.
• Abstract the reporting stuff away from JUnit, but still using the  
Ant JUnit reporting stuff (this can be done, did it for Spock)
        This will allow any test runner to produce reports
• Put a lot more events in there as customisation points

Long story short: make it possible to plug in any test runner, and  
provide support for participating in the status output and reporting.

On 28/10/2009, at 12:29 AM, Graeme Rocher wrote:

> Yes as long as they are not breaking, now is the time to do it before
> the RC is out (probably end of next week)
>
> Regards
>
> On Tue, Oct 27, 2009 at 3:27 PM, Peter Ledbrook  
> <peter@...> wrote:
>> Hi,
>>
>> There have been a couple of suggestions for changes to the test-app
>> command so that plugin authors find it easier to integrate
>> test-related plugins, such as Spock, Selenium-RC, EasyB, etc. The
>> question I have is should we try to get these changes into Grails  
>> 1.2?
>> It's late in the day for a feature change like this, so I'm reluctant
>> to promote the idea on that basis. However, I also think that it  
>> makes
>> sense to have the changes available in a major version release,
>> otherwise users will wonder why the plugins work with Grails 1.2.1  
>> but
>> not 1.2.
>>
>> So, what do others think? If all those plugin authors are hammering
>> the test script making sure that it works with their plugin, does  
>> that
>> mitigate the dangers of a feature change this late in the day? Or
>> should we just leave it to a minor/patch release or 1.3?
>>
>> Cheers,
>>
>> Peter
>>
>> ---------------------------------------------------------------------
>> To unsubscribe from this list, please visit:
>>
>>    http://xircles.codehaus.org/manage_email
>>
>>
>>
>
>
>
> --
> Graeme Rocher
> Head of Grails Development
> SpringSource - Weapons for the War on Java Complexity
> http://www.springsource.com
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

[Graeme Rocher-3]

Ok, but I will need to changes probably this week to give time for
review before RC1 (probably end of next week)

Regards

On Wed, Oct 28, 2009 at 12:56 AM, Luke Daley <ld@...> wrote:

> Here is what I plan to do:
>
> • Separate test phases from types more cleanly and make types responsible
> for running the tests (patch sent in earlier email)
> • Separate GrailsTestHelper and friends from the JUnit API to be runner
> agnostic, but provide JUnit3 versions.
> • Abstract the reporting stuff away from JUnit, but still using the Ant
> JUnit reporting stuff (this can be done, did it for Spock)
>        This will allow any test runner to produce reports
> • Put a lot more events in there as customisation points
>
> Long story short: make it possible to plug in any test runner, and provide
> support for participating in the status output and reporting.
>
> On 28/10/2009, at 12:29 AM, Graeme Rocher wrote:
>
>> Yes as long as they are not breaking, now is the time to do it before
>> the RC is out (probably end of next week)
>>
>> Regards
>>
>> On Tue, Oct 27, 2009 at 3:27 PM, Peter Ledbrook <peter@...>
>> wrote:
>>>
>>> Hi,
>>>
>>> There have been a couple of suggestions for changes to the test-app
>>> command so that plugin authors find it easier to integrate
>>> test-related plugins, such as Spock, Selenium-RC, EasyB, etc. The
>>> question I have is should we try to get these changes into Grails 1.2?
>>> It's late in the day for a feature change like this, so I'm reluctant
>>> to promote the idea on that basis. However, I also think that it makes
>>> sense to have the changes available in a major version release,
>>> otherwise users will wonder why the plugins work with Grails 1.2.1 but
>>> not 1.2.
>>>
>>> So, what do others think? If all those plugin authors are hammering
>>> the test script making sure that it works with their plugin, does that
>>> mitigate the dangers of a feature change this late in the day? Or
>>> should we just leave it to a minor/patch release or 1.3?
>>>
>>> Cheers,
>>>
>>> Peter
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe from this list, please visit:
>>>
>>>   http://xircles.codehaus.org/manage_email
>>>
>>>
>>>
>>
>>
>>
>> --
>> Graeme Rocher
>> Head of Grails Development
>> SpringSource - Weapons for the War on Java Complexity
>> http://www.springsource.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe from this list, please visit:
>>
>>   http://xircles.codehaus.org/manage_email
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>   http://xircles.codehaus.org/manage_email
>
>
>

--
Graeme Rocher
Head of Grails Development
SpringSource - Weapons for the War on Java Complexity
http://www.springsource.com

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email