Too large messages on glibc-cvs@

[Petr Baudis-2]

  Hi!

On Tue, Jun 09, 2009 at 02:02:23PM -0000, glibc-cvs-help@... wrote:
> Messages to you from the glibc-cvs mailing list seem to
> have been bouncing. I've attached a copy of the first bounce
> message I received.
..snip..

> Here are the message numbers:
>
>    49316
>    49373
>
> --- Enclosed is a copy of the bounce message I received.
>
> Return-Path: <>
> Received: (qmail 1328 invoked for bounce); 25 May 2009 23:20:11 -0000
> Date: 25 May 2009 23:20:11 -0000
> From: MAILER-DAEMON@...
> To: glibc-cvs-return-49316-@...
> MIME-Version: 1.0
> Content-Type: multipart/mixed; boundary="1243029993sourceware.org29032561"
> Subject: failure notice
>
> Hi. This is the qmail-send program at sourceware.org.
> I'm afraid I wasn't able to deliver your message to the following addresses.
> This is a permanent error; I've given up. Sorry it didn't work out.
>
> <pasky@...>:
> 195.135.220.15 failed after I sent the message.
> Remote host said: 552 Error: message too large

  Would it be possible to trim too large diffs to some sane size
before sending them to the mailing list? I think even something as
simple as

        | head -c 1048576

would do fine...

--
                                Petr "Pasky" Baudis
The lyf so short, the craft so long to lerne. -- Chaucer

[Roland McGrath]

Jim is our local expert on the git scripts.
But I'm sure this issue is not new among all other projects using git.
If anybody else has script hacks for this stuff, please come forward.


Thanks,
Roland

[Jim Meyering]

Roland McGrath wrote:
> Jim is our local expert on the git scripts.
> But I'm sure this issue is not new among all other projects using git.
> If anybody else has script hacks for this stuff, please come forward.

I noticed those, too.  I wrote/posted a tiny script to insert into the
existing hook.  I'll actually test and install it Thursday or Friday.

[Jim Meyering]

Petr Baudis wrote:

> On Tue, Jun 09, 2009 at 11:09:56PM +0200, Jim Meyering wrote:
>> Roland McGrath wrote:
>> > Jim is our local expert on the git scripts.
>> > But I'm sure this issue is not new among all other projects using git.
>> > If anybody else has script hacks for this stuff, please come forward.
>>
>> I noticed those, too.  I wrote/posted a tiny script to insert into the
>> existing hook.  I'll actually test and install it Thursday or Friday.
>
>   I'm now adding this hook to repo.or.cz and I'd like to do this too,
> I'm wondering, how did you do this?

Hi Petr,

I wrote this limit-pipe script:

    http://sourceware.org/ml/libc-ports/2009-05/msg00056.html

but I never got around to making the hook use it.
I can do something like this to the post-receive-email script
we're currently using (with a probable PATH update):

-                generate_email $oldrev $newrev $refname | send_mail
+                generate_email $oldrev $newrev $refname |
+                  limit-pipe 524288 | send_mail

On second thought, that limit, 512KB (just made up by me, btw),
has to come from config, set via e.g.,

    git config hooks.email-max-size 524288

since it's per-repo policy, while the hook script is typically shared.

On the other hand, since no one has complained about overly-large
messages in 4 months, maybe it's not worth doing after all.

If no one says they want it (and provides a max message size),
I'll presume there's no need.  Same applies to libc-ports.

Jim

[Petr Baudis-2]

On Wed, Nov 04, 2009 at 05:14:18PM +0100, Jim Meyering wrote:

> Petr Baudis wrote:
> > On Tue, Jun 09, 2009 at 11:09:56PM +0200, Jim Meyering wrote:
> >> Roland McGrath wrote:
> >> > Jim is our local expert on the git scripts.
> >> > But I'm sure this issue is not new among all other projects using git.
> >> > If anybody else has script hacks for this stuff, please come forward.
> >>
> >> I noticed those, too.  I wrote/posted a tiny script to insert into the
> >> existing hook.  I'll actually test and install it Thursday or Friday.
> >
> >   I'm now adding this hook to repo.or.cz and I'd like to do this too,
> > I'm wondering, how did you do this?
>
> Hi Petr,
>
> I wrote this limit-pipe script:
>
>     http://sourceware.org/ml/libc-ports/2009-05/msg00056.html
>
> but I never got around to making the hook use it.

Ah, thanks. In the end, I went with much simpler hack in mail.sh, since
I'm using a customized one myself anyway...

> size_limit()
> {
>         size=0
>         while IFS= read line; do
>                 size=$((size+${#line}))
>                 if [ $size -gt $1 ]; then
>                         echo "...e-mail trimmed, has been too large."
>                         break
>                 fi
>                 echo "$line"
>         done
> }

--
                                Petr "Pasky" Baudis
A lot of people have my books on their bookshelves.
That's the problem, they need to read them. -- Don Knuth