Trinidad test runner + Included pages

View: New views
5 Messages — Rating Filter:   Alert me  

Trinidad test runner + Included pages

by Glenn Halstead :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi folks,

 

I've mentioned this before but got no response.  I'll try to ask a
better question.

 

We use fitnesse for testing our gui (browser) and for testing our
services (soa).

 

We run our fitnesse tests from Hudson.

 

Originally we used the normal fitnesse test runner however we started
getting memory failures if our test suites were to big.  We moved to the
Trinidad test runner with Hudson because it resolved the memory issues.
The problem we have with the Trinidad runner is that it does not support
included pages.  We use and include page to specific release and
environment parameters which in turn were expanded into jar paths within
the fitnesse page.  This allowed us to use a release and environment
specific jar.

 

We've got around this by specifying the release and environment
parameters in the Hudson job.  Hudson runs a batch file which exports
jar paths based on the parameters then runs the Trinidad fitnesse
runner.  This works but it's a limiting factor for us.

 

Is anyone else using the Trinidad test runner from Hudson?

 

Am I doing something wrong?

 

Thanks

 

glenn

 




-----------------------------------------
Information in this email including any attachments may be
privileged, confidential and is intended exclusively for the
addressee. The views expressed may not be official policy, but the
personal views of the originator. If you have received it in error,
please notify the sender by return e-mail and delete it from your
system. You should not reproduce, distribute, store, retransmit,
use or disclose its contents to anyone.

Please note we reserve the right to monitor all e-mail
communication through our internal and external networks.

SKY and the SKY marks are trade marks of British Sky Broadcasting
Group plc and are used under licence. British Sky Broadcasting
Limited (Registration No. 2906991), Sky Interactive Limited
(Registration No. 3554332), Sky-In-Home Service Limited
(Registration No. 2067075) and Sky Subscribers Services Limited
(Registration No. 2340150) are direct or indirect subsidiaries of
British Sky Broadcasting Group plc (Registration No. 2247735). All
of the companies mentioned in this paragraph are incorporated in
England and Wales and share the same registered office at Grant
Way, Isleworth, Middlesex TW7 5QD.  

Re: Trinidad test runner + Included pages

by adoptableCoho :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


We are using Trinidad to run our fitnesse tests under Hudson.  While we haven't had trouble with !include's, we have had issues with it not including SuiteSetup and SuiteTearDown.

I spent some time with the Fitnesse code last week and found that the FitnesseRepository is not adding these pages to the list of pages to be executed.  

I added the following lines to "src/fitnesse/trinidad/FitnesseRepository.java" after line 77:

      PageListSetUpTearDownSurrounder surrounder = new PageListSetUpTearDownSurrounder(root);
      surrounder.surroundGroupsOfTestPagesWithRespectiveSetUpAndTearDowns(pages);
     
I have not spent much time in the Fitnesse codebase, so I was not confident about committing my change immediately.  I wanted to see my changes work in our environment for a bit before committing.  

If you think this might solve your problem, either grab the code and make the change, or I can send you a copy of the jar that I built.

- Michael

--- In fitnesse@..., "Halstead, Glenn (E&T)" <glenn.halstead@...> wrote:

>
> Hi folks,
>
>  
>
> I've mentioned this before but got no response.  I'll try to ask a
> better question.
>
>  
>
> We use fitnesse for testing our gui (browser) and for testing our
> services (soa).
>
>  
>
> We run our fitnesse tests from Hudson.
>
>  
>
> Originally we used the normal fitnesse test runner however we started
> getting memory failures if our test suites were to big.  We moved to the
> Trinidad test runner with Hudson because it resolved the memory issues.
> The problem we have with the Trinidad runner is that it does not support
> included pages.  We use and include page to specific release and
> environment parameters which in turn were expanded into jar paths within
> the fitnesse page.  This allowed us to use a release and environment
> specific jar.
>
>  
>
> We've got around this by specifying the release and environment
> parameters in the Hudson job.  Hudson runs a batch file which exports
> jar paths based on the parameters then runs the Trinidad fitnesse
> runner.  This works but it's a limiting factor for us.
>
>  
>
> Is anyone else using the Trinidad test runner from Hudson?
>
>  
>
> Am I doing something wrong?
>
>  
>
> Thanks
>
>  
>
> glenn
>
>  
>
>
>
>
> -----------------------------------------
> Information in this email including any attachments may be
> privileged, confidential and is intended exclusively for the
> addressee. The views expressed may not be official policy, but the
> personal views of the originator. If you have received it in error,
> please notify the sender by return e-mail and delete it from your
> system. You should not reproduce, distribute, store, retransmit,
> use or disclose its contents to anyone.
>
> Please note we reserve the right to monitor all e-mail
> communication through our internal and external networks.
>
> SKY and the SKY marks are trade marks of British Sky Broadcasting
> Group plc and are used under licence. British Sky Broadcasting
> Limited (Registration No. 2906991), Sky Interactive Limited
> (Registration No. 3554332), Sky-In-Home Service Limited
> (Registration No. 2067075) and Sky Subscribers Services Limited
> (Registration No. 2340150) are direct or indirect subsidiaries of
> British Sky Broadcasting Group plc (Registration No. 2247735). All
> of the companies mentioned in this paragraph are incorporated in
> England and Wales and share the same registered office at Grant
> Way, Isleworth, Middlesex TW7 5QD.
>



Parent Message unknown Re: Trinidad test runner + Included pages

by unclebob :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

> Re: Trinidad test runner + Included pagesPosted by: "adoptablecoho" adoptablecoho@...
>    adoptablecohoTue Nov 3, 2009 10:23 am (PST)
>
>
>
> We are using Trinidad to run our fitnesse tests under Hudson. While  
> we haven't had trouble with !include's, we have had issues with it  
> not including SuiteSetup and SuiteTearDown.
>
> I spent some time with the Fitnesse code last week and found that  
> the FitnesseRepository is not adding these pages to the list of  
> pages to be executed.
>
> I added the following lines to "src/fitnesse/trinidad/
> FitnesseRepository.java" after line 77:
>
> PageListSetUpTearDownSurrounder surrounder = new  
> PageListSetUpTearDownSurrounder(root);
> surrounder
> .surroundGroupsOfTestPagesWithRespectiveSetUpAndTearDowns(pages);
>
> I have not spent much time in the Fitnesse codebase, so I was not  
> confident about committing my change immediately. I wanted to see my  
> changes work in our environment for a bit before committing.
>
> If you think this might solve your problem, either grab the code and  
> make the change, or I can send you a copy of the jar that I built.
>
> - Michael


Michael,

That sounds like the right change.  If it works for you, please send  
me a pull request.

----
Robert C. Martin (Uncle Bob)  | email: unclebob@...
Object Mentor Inc.            | blog:  blog.objectmentor.com
The Agile Transition Experts  | web:   www.objectmentor.com
800-338-6716                  | twitter: unclebobmartin






Re: Trinidad test runner + Included pages

by adoptableCoho :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


This is my first time using Git, so I am stumbling a bit...

I've made the changes to my local branch, and all compiles.   When I run Fitnesse and browse to a test page CPU usage spikes (and stays) and takes a very long time to load the page (15 - 20 seconds.)

I don't believe my changes in the trinidad namespace would have had this effect. I reached the end of my timebox for working on this today  - but I thought I would check if anyone else working on the HEAD is seeing that behavior?

--- In fitnesse@..., Robert Martin <UncleBob@...> wrote:

>
> > Re: Trinidad test runner + Included pagesPosted by: "adoptablecoho" adoptablecoho@...
> >    adoptablecohoTue Nov 3, 2009 10:23 am (PST)
> >
> >
> >
> > We are using Trinidad to run our fitnesse tests under Hudson. While  
> > we haven't had trouble with !include's, we have had issues with it  
> > not including SuiteSetup and SuiteTearDown.
> >
> > I spent some time with the Fitnesse code last week and found that  
> > the FitnesseRepository is not adding these pages to the list of  
> > pages to be executed.
> >
> > I added the following lines to "src/fitnesse/trinidad/
> > FitnesseRepository.java" after line 77:
> >
> > PageListSetUpTearDownSurrounder surrounder = new  
> > PageListSetUpTearDownSurrounder(root);
> > surrounder
> > .surroundGroupsOfTestPagesWithRespectiveSetUpAndTearDowns(pages);
> >
> > I have not spent much time in the Fitnesse codebase, so I was not  
> > confident about committing my change immediately. I wanted to see my  
> > changes work in our environment for a bit before committing.
> >
> > If you think this might solve your problem, either grab the code and  
> > make the change, or I can send you a copy of the jar that I built.
> >
> > - Michael
>
>
> Michael,
>
> That sounds like the right change.  If it works for you, please send  
> me a pull request.
>
> ----
> Robert C. Martin (Uncle Bob)  | email: unclebob@...
> Object Mentor Inc.            | blog:  blog.objectmentor.com
> The Agile Transition Experts  | web:   www.objectmentor.com
> 800-338-6716                  | twitter: unclebobmartin
>



Parent Message unknown Re: Trinidad test runner + Included pages

by unclebob :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

> Re: Trinidad test runner + Included pagesPosted by: "adoptablecoho" adoptablecoho@...
>    adoptablecohoMon Nov 9, 2009 1:47 pm (PST)
>
> This is my first time using Git, so I am stumbling a bit...
>
> I've made the changes to my local branch, and all compiles. When I  
> run Fitnesse and browse to a test page CPU usage spikes (and stays)  
> and takes a very long time to load the page (15 - 20 seconds.)
>
> I don't believe my changes in the trinidad namespace would have had  
> this effect. I reached the end of my timebox for working on this  
> today - but I thought I would check if anyone else working on the  
> HEAD is seeing that behavior?

Yes, that's been fixed in the latest HEAD.


----
Robert C. Martin (Uncle Bob)  | email: unclebob@...
Object Mentor Inc.            | blog:  blog.objectmentor.com
The Agile Transition Experts  | web:   www.objectmentor.com
800-338-6716                  | twitter: unclebobmartin