Upgrading from MyFaces 1.1.4 to 1.1.5

[mraible]

I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.  When I do this, my tests start failing because I have a couple pages that use JavaScript to call an managed bean's method. Here's my password hint page:

<f:view>
<f:loadBundle var="text" basename="#{basePage.bundleName}"/>
<title>#{text['user.passwordHint']}</title>

<p>Looking up password hint for ${param.username}...</p>

<h:form id="passwordForm">
    <h:inputHidden id="username" value="#{passwordHint.username}"/>

    <h:commandLink action="#{passwordHint.execute}" id="execute">
        <f:param name="username" value=""/>
    </h:commandLink>
</h:form>

<script type="text/javascript">
    var f = document.forms['passwordForm'];
    f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
    f.elements['username'].value='${param.username}';
    f.submit();
</script>

</f:view>

In PasswordForm.execute(), I have:

    public String execute() {
       
        // ensure that the username has been sent
        if (username == null || "".equals(username)) {
            log.warn("Username not specified, notifying user that it's a required field.");

            addError("errors.required", getText("user.username"));
            return null;
        }
       
        if (log.isDebugEnabled()) {
            log.debug("Processing Password Hint...");
        }
       
        // look up the user's information
        try {
            User user = userManager.getUserByUsername(username);

            StringBuffer msg = new StringBuffer();
            msg.append("Your password hint is: " + user.getPasswordHint());
            msg.append("\n\nLogin at: " + RequestUtil.getAppURL(getRequest()));

            message.setTo(user.getEmail());
            String subject = '[' + getText("webapp.name") + "] " + getText("user.passwordHint");
            message.setSubject(subject);
            message.setText(msg.toString());
            mailEngine.send(message);
           
            addMessage("login.passwordHint.sent",
                       new Object[] { username, user.getEmail() });
           
        } catch (Exception e) {
            e.printStackTrace();
            // If exception is expected do not rethrow
            addError("login.passwordHint.error", username);
        }

        return "success";
    }

This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting back to the same page.  Any ideas?

Thanks,

Matt

[Ricardo Tercero Lozano]

Hi Matt,

I got aware of the same problem time ago, in my tests, mainly because my project start point was appfuse ;-).


What I realized is in Myfaces latest version the _link_hidden_ parameter now is named _idcl



Ricardo.

On 2/22/07, mraible <matt@...> wrote:

I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.  When I
do this, my tests start failing because I have a couple pages that use
JavaScript to call an managed bean's method. Here's my password hint page:

<f:view>
<f:loadBundle var="text" basename="#{basePage.bundleName}"/>
<title>#{text['user.passwordHint']}</title>

<p>Looking up password hint for ${ param.username}...</p>

<h:form id="passwordForm">
    <h:inputHidden id="username" value="#{passwordHint.username}"/>

    <h:commandLink action="#{passwordHint.execute }" id="execute">
        <f:param name="username" value=""/>
    </h:commandLink>
</h:form>

<script type="text/javascript">
    var f = document.forms['passwordForm'];
    f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
    f.elements['username'].value='${param.username}';
    f.submit ();
</script>

</f:view>

In PasswordForm.execute(), I have:

    public String execute() {

        // ensure that the username has been sent
        if (username == null || "".equals(username)) {
            log.warn("Username not specified, notifying user that it's a
required field.");

            addError("errors.required", getText("user.username"));
            return null;
        }

        if (log.isDebugEnabled()) {
            log.debug("Processing Password Hint...");
        }

        // look up the user's information
        try {
            User user = userManager.getUserByUsername(username);

            StringBuffer msg = new StringBuffer();
            msg.append("Your password hint is: " + user.getPasswordHint());
            msg.append("\n\nLogin at: " +
RequestUtil.getAppURL(getRequest()));

            message.setTo(user.getEmail());
            String subject = '[' + getText("webapp.name") + "] " +
getText("user.passwordHint");
            message.setSubject(subject);
            message.setText(msg.toString());
            mailEngine.send(message);

            addMessage("login.passwordHint.sent ",
                       new Object[] { username, user.getEmail() });

        } catch (Exception e) {
            e.printStackTrace();
            // If exception is expected do not rethrow
            addError(" login.passwordHint.error", username);
        }

        return "success";
    }

This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
back to the same page.  Any ideas?

Thanks,

Matt
--
View this message in context: http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
Sent from the MyFaces - Users mailing list archive at Nabble.com.

[Martin Marinschek]

That was - by the way - done to increase RI compatibility.

regards,

Martin

On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:

> Hi Matt,
>
> I got aware of the same problem time ago, in my tests, mainly because my
> project start point was appfuse ;-).
>
>
> What I realized is in Myfaces latest version the _link_hidden_ parameter now
> is named _idcl
>
>
>
> Ricardo.
>
>
>
>
> On 2/22/07, mraible <matt@...> wrote:
> >
> > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> When I
> > do this, my tests start failing because I have a couple pages that use
> > JavaScript to call an managed bean's method. Here's my password hint page:
> >
> > <f:view>
> > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > <title>#{text['user.passwordHint']}</title>
> >
> > <p>Looking up password hint for ${ param.username}...</p>
> >
> > <h:form id="passwordForm">
> >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> >
> >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> >         <f:param name="username" value=""/>
> >     </h:commandLink>
> > </h:form>
> >
> > <script type="text/javascript">
> >     var f = document.forms['passwordForm'];
> >
> f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> >     f.elements['username'].value='${param.username}';
> >     f.submit ();
> > </script>
> >
> > </f:view>
> >
> > In PasswordForm.execute(), I have:
> >
> >     public String execute() {
> >
> >         // ensure that the username has been sent
> >         if (username == null || "".equals(username)) {
> >             log.warn("Username not specified, notifying user that it's a
> > required field.");
> >
> >             addError("errors.required", getText("user.username"));
> >             return null;
> >         }
> >
> >         if (log.isDebugEnabled()) {
> >             log.debug("Processing Password Hint...");
> >         }
> >
> >         // look up the user's information
> >         try {
> >             User user = userManager.getUserByUsername(username);
> >
> >             StringBuffer msg = new StringBuffer();
> >             msg.append("Your password hint is: " +
> user.getPasswordHint());
> >             msg.append("\n\nLogin at: " +
> > RequestUtil.getAppURL(getRequest()));
> >
> >             message.setTo(user.getEmail());
> >             String subject = '[' + getText("webapp.name") + "] " +
> > getText("user.passwordHint");
> >             message.setSubject(subject);
> >             message.setText(msg.toString());
> >             mailEngine.send(message);
> >
> >             addMessage("login.passwordHint.sent ",
> >                        new Object[] { username, user.getEmail() });
> >
> >         } catch (Exception e) {
> >             e.printStackTrace();
> >             // If exception is expected do not rethrow
> >             addError(" login.passwordHint.error", username);
> >         }
> >
> >         return "success";
> >     }
> >
> > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > back to the same page.  Any ideas?
> >
> > Thanks,
> >
> > Matt
> > --
> > View this message in context:
> http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> >
> >
>
>

--

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

[Matthias Wessendorf-4]

did you create an issue for that ?

On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:

> That was - by the way - done to increase RI compatibility.
>
> regards,
>
> Martin
>
> On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:
> > Hi Matt,
> >
> > I got aware of the same problem time ago, in my tests, mainly because my
> > project start point was appfuse ;-).
> >
> >
> > What I realized is in Myfaces latest version the _link_hidden_ parameter now
> > is named _idcl
> >
> >
> >
> > Ricardo.
> >
> >
> >
> >
> > On 2/22/07, mraible <matt@...> wrote:
> > >
> > > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> > When I
> > > do this, my tests start failing because I have a couple pages that use
> > > JavaScript to call an managed bean's method. Here's my password hint page:
> > >
> > > <f:view>
> > > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > > <title>#{text['user.passwordHint']}</title>
> > >
> > > <p>Looking up password hint for ${ param.username}...</p>
> > >
> > > <h:form id="passwordForm">
> > >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> > >
> > >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> > >         <f:param name="username" value=""/>
> > >     </h:commandLink>
> > > </h:form>
> > >
> > > <script type="text/javascript">
> > >     var f = document.forms['passwordForm'];
> > >
> > f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> > >     f.elements['username'].value='${param.username}';
> > >     f.submit ();
> > > </script>
> > >
> > > </f:view>
> > >
> > > In PasswordForm.execute(), I have:
> > >
> > >     public String execute() {
> > >
> > >         // ensure that the username has been sent
> > >         if (username == null || "".equals(username)) {
> > >             log.warn("Username not specified, notifying user that it's a
> > > required field.");
> > >
> > >             addError("errors.required", getText("user.username"));
> > >             return null;
> > >         }
> > >
> > >         if (log.isDebugEnabled()) {
> > >             log.debug("Processing Password Hint...");
> > >         }
> > >
> > >         // look up the user's information
> > >         try {
> > >             User user = userManager.getUserByUsername(username);
> > >
> > >             StringBuffer msg = new StringBuffer();
> > >             msg.append("Your password hint is: " +
> > user.getPasswordHint());
> > >             msg.append("\n\nLogin at: " +
> > > RequestUtil.getAppURL(getRequest()));
> > >
> > >             message.setTo(user.getEmail());
> > >             String subject = '[' + getText("webapp.name") + "] " +
> > > getText("user.passwordHint");
> > >             message.setSubject(subject);
> > >             message.setText(msg.toString());
> > >             mailEngine.send(message);
> > >
> > >             addMessage("login.passwordHint.sent ",
> > >                        new Object[] { username, user.getEmail() });
> > >
> > >         } catch (Exception e) {
> > >             e.printStackTrace();
> > >             // If exception is expected do not rethrow
> > >             addError(" login.passwordHint.error", username);
> > >         }
> > >
> > >         return "success";
> > >     }
> > >
> > > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > > back to the same page.  Any ideas?
> > >
> > > Thanks,
> > >
> > > Matt
> > > --
> > > View this message in context:
> > http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> > >
> > >
> >
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>

--
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

[Mike Kienenberger]

Martin made the change right before we started strongly suggesting
that we create issues for every change.   However, this one might be
important enough to retroactively create.

On 2/22/07, Matthias Wessendorf <matzew@...> wrote:

> did you create an issue for that ?
>
> On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > That was - by the way - done to increase RI compatibility.
> >
> > regards,
> >
> > Martin
> >
> > On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:
> > > Hi Matt,
> > >
> > > I got aware of the same problem time ago, in my tests, mainly because my
> > > project start point was appfuse ;-).
> > >
> > >
> > > What I realized is in Myfaces latest version the _link_hidden_ parameter now
> > > is named _idcl
> > >
> > >
> > >
> > > Ricardo.
> > >
> > >
> > >
> > >
> > > On 2/22/07, mraible <matt@...> wrote:
> > > >
> > > > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> > > When I
> > > > do this, my tests start failing because I have a couple pages that use
> > > > JavaScript to call an managed bean's method. Here's my password hint page:
> > > >
> > > > <f:view>
> > > > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > > > <title>#{text['user.passwordHint']}</title>
> > > >
> > > > <p>Looking up password hint for ${ param.username}...</p>
> > > >
> > > > <h:form id="passwordForm">
> > > >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> > > >
> > > >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> > > >         <f:param name="username" value=""/>
> > > >     </h:commandLink>
> > > > </h:form>
> > > >
> > > > <script type="text/javascript">
> > > >     var f = document.forms['passwordForm'];
> > > >
> > > f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> > > >     f.elements['username'].value='${param.username}';
> > > >     f.submit ();
> > > > </script>
> > > >
> > > > </f:view>
> > > >
> > > > In PasswordForm.execute(), I have:
> > > >
> > > >     public String execute() {
> > > >
> > > >         // ensure that the username has been sent
> > > >         if (username == null || "".equals(username)) {
> > > >             log.warn("Username not specified, notifying user that it's a
> > > > required field.");
> > > >
> > > >             addError("errors.required", getText("user.username"));
> > > >             return null;
> > > >         }
> > > >
> > > >         if (log.isDebugEnabled()) {
> > > >             log.debug("Processing Password Hint...");
> > > >         }
> > > >
> > > >         // look up the user's information
> > > >         try {
> > > >             User user = userManager.getUserByUsername(username);
> > > >
> > > >             StringBuffer msg = new StringBuffer();
> > > >             msg.append("Your password hint is: " +
> > > user.getPasswordHint());
> > > >             msg.append("\n\nLogin at: " +
> > > > RequestUtil.getAppURL(getRequest()));
> > > >
> > > >             message.setTo(user.getEmail());
> > > >             String subject = '[' + getText("webapp.name") + "] " +
> > > > getText("user.passwordHint");
> > > >             message.setSubject(subject);
> > > >             message.setText(msg.toString());
> > > >             mailEngine.send(message);
> > > >
> > > >             addMessage("login.passwordHint.sent ",
> > > >                        new Object[] { username, user.getEmail() });
> > > >
> > > >         } catch (Exception e) {
> > > >             e.printStackTrace();
> > > >             // If exception is expected do not rethrow
> > > >             addError(" login.passwordHint.error", username);
> > > >         }
> > > >
> > > >         return "success";
> > > >     }
> > > >
> > > > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > > > back to the same page.  Any ideas?
> > > >
> > > > Thanks,
> > > >
> > > > Matt
> > > > --
> > > > View this message in context:
> > > http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > > > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> > > >
> > > >
> > >
> > >
> >
> >
> > --
> >
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>

[Matthias Wessendorf-4]

right, since that has some "yet another API break" character.

Martin,
can you create a issue ?

-M

On 2/22/07, Mike Kienenberger <mkienenb@...> wrote:

> Martin made the change right before we started strongly suggesting
> that we create issues for every change.   However, this one might be
> important enough to retroactively create.
>
> On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > did you create an issue for that ?
> >
> > On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > > That was - by the way - done to increase RI compatibility.
> > >
> > > regards,
> > >
> > > Martin
> > >
> > > On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:
> > > > Hi Matt,
> > > >
> > > > I got aware of the same problem time ago, in my tests, mainly because my
> > > > project start point was appfuse ;-).
> > > >
> > > >
> > > > What I realized is in Myfaces latest version the _link_hidden_ parameter now
> > > > is named _idcl
> > > >
> > > >
> > > >
> > > > Ricardo.
> > > >
> > > >
> > > >
> > > >
> > > > On 2/22/07, mraible <matt@...> wrote:
> > > > >
> > > > > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> > > > When I
> > > > > do this, my tests start failing because I have a couple pages that use
> > > > > JavaScript to call an managed bean's method. Here's my password hint page:
> > > > >
> > > > > <f:view>
> > > > > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > > > > <title>#{text['user.passwordHint']}</title>
> > > > >
> > > > > <p>Looking up password hint for ${ param.username}...</p>
> > > > >
> > > > > <h:form id="passwordForm">
> > > > >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> > > > >
> > > > >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> > > > >         <f:param name="username" value=""/>
> > > > >     </h:commandLink>
> > > > > </h:form>
> > > > >
> > > > > <script type="text/javascript">
> > > > >     var f = document.forms['passwordForm'];
> > > > >
> > > > f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> > > > >     f.elements['username'].value='${param.username}';
> > > > >     f.submit ();
> > > > > </script>
> > > > >
> > > > > </f:view>
> > > > >
> > > > > In PasswordForm.execute(), I have:
> > > > >
> > > > >     public String execute() {
> > > > >
> > > > >         // ensure that the username has been sent
> > > > >         if (username == null || "".equals(username)) {
> > > > >             log.warn("Username not specified, notifying user that it's a
> > > > > required field.");
> > > > >
> > > > >             addError("errors.required", getText("user.username"));
> > > > >             return null;
> > > > >         }
> > > > >
> > > > >         if (log.isDebugEnabled()) {
> > > > >             log.debug("Processing Password Hint...");
> > > > >         }
> > > > >
> > > > >         // look up the user's information
> > > > >         try {
> > > > >             User user = userManager.getUserByUsername(username);
> > > > >
> > > > >             StringBuffer msg = new StringBuffer();
> > > > >             msg.append("Your password hint is: " +
> > > > user.getPasswordHint());
> > > > >             msg.append("\n\nLogin at: " +
> > > > > RequestUtil.getAppURL(getRequest()));
> > > > >
> > > > >             message.setTo(user.getEmail());
> > > > >             String subject = '[' + getText("webapp.name") + "] " +
> > > > > getText("user.passwordHint");
> > > > >             message.setSubject(subject);
> > > > >             message.setText(msg.toString());
> > > > >             mailEngine.send(message);
> > > > >
> > > > >             addMessage("login.passwordHint.sent ",
> > > > >                        new Object[] { username, user.getEmail() });
> > > > >
> > > > >         } catch (Exception e) {
> > > > >             e.printStackTrace();
> > > > >             // If exception is expected do not rethrow
> > > > >             addError(" login.passwordHint.error", username);
> > > > >         }
> > > > >
> > > > >         return "success";
> > > > >     }
> > > > >
> > > > > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > > > > back to the same page.  Any ideas?
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Matt
> > > > > --
> > > > > View this message in context:
> > > > http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > > > > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > > --
> > >
> > > http://www.irian.at
> > >
> > > Your JSF powerhouse -
> > > JSF Consulting, Development and
> > > Courses in English and German
> > >
> > > Professional Support for Apache MyFaces
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>

--
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

[Martin Marinschek]

https://issues.apache.org/jira/browse/MYFACES-1539

done.

regards,

Martin

On 2/22/07, Matthias Wessendorf <matzew@...> wrote:

> right, since that has some "yet another API break" character.
>
> Martin,
> can you create a issue ?
>
> -M
>
> On 2/22/07, Mike Kienenberger <mkienenb@...> wrote:
> > Martin made the change right before we started strongly suggesting
> > that we create issues for every change.   However, this one might be
> > important enough to retroactively create.
> >
> > On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > > did you create an issue for that ?
> > >
> > > On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > > > That was - by the way - done to increase RI compatibility.
> > > >
> > > > regards,
> > > >
> > > > Martin
> > > >
> > > > On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:
> > > > > Hi Matt,
> > > > >
> > > > > I got aware of the same problem time ago, in my tests, mainly because my
> > > > > project start point was appfuse ;-).
> > > > >
> > > > >
> > > > > What I realized is in Myfaces latest version the _link_hidden_ parameter now
> > > > > is named _idcl
> > > > >
> > > > >
> > > > >
> > > > > Ricardo.
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On 2/22/07, mraible <matt@...> wrote:
> > > > > >
> > > > > > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> > > > > When I
> > > > > > do this, my tests start failing because I have a couple pages that use
> > > > > > JavaScript to call an managed bean's method. Here's my password hint page:
> > > > > >
> > > > > > <f:view>
> > > > > > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > > > > > <title>#{text['user.passwordHint']}</title>
> > > > > >
> > > > > > <p>Looking up password hint for ${ param.username}...</p>
> > > > > >
> > > > > > <h:form id="passwordForm">
> > > > > >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> > > > > >
> > > > > >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> > > > > >         <f:param name="username" value=""/>
> > > > > >     </h:commandLink>
> > > > > > </h:form>
> > > > > >
> > > > > > <script type="text/javascript">
> > > > > >     var f = document.forms['passwordForm'];
> > > > > >
> > > > > f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> > > > > >     f.elements['username'].value='${param.username}';
> > > > > >     f.submit ();
> > > > > > </script>
> > > > > >
> > > > > > </f:view>
> > > > > >
> > > > > > In PasswordForm.execute(), I have:
> > > > > >
> > > > > >     public String execute() {
> > > > > >
> > > > > >         // ensure that the username has been sent
> > > > > >         if (username == null || "".equals(username)) {
> > > > > >             log.warn("Username not specified, notifying user that it's a
> > > > > > required field.");
> > > > > >
> > > > > >             addError("errors.required", getText("user.username"));
> > > > > >             return null;
> > > > > >         }
> > > > > >
> > > > > >         if (log.isDebugEnabled()) {
> > > > > >             log.debug("Processing Password Hint...");
> > > > > >         }
> > > > > >
> > > > > >         // look up the user's information
> > > > > >         try {
> > > > > >             User user = userManager.getUserByUsername(username);
> > > > > >
> > > > > >             StringBuffer msg = new StringBuffer();
> > > > > >             msg.append("Your password hint is: " +
> > > > > user.getPasswordHint());
> > > > > >             msg.append("\n\nLogin at: " +
> > > > > > RequestUtil.getAppURL(getRequest()));
> > > > > >
> > > > > >             message.setTo(user.getEmail());
> > > > > >             String subject = '[' + getText("webapp.name") + "] " +
> > > > > > getText("user.passwordHint");
> > > > > >             message.setSubject(subject);
> > > > > >             message.setText(msg.toString());
> > > > > >             mailEngine.send(message);
> > > > > >
> > > > > >             addMessage("login.passwordHint.sent ",
> > > > > >                        new Object[] { username, user.getEmail() });
> > > > > >
> > > > > >         } catch (Exception e) {
> > > > > >             e.printStackTrace();
> > > > > >             // If exception is expected do not rethrow
> > > > > >             addError(" login.passwordHint.error", username);
> > > > > >         }
> > > > > >
> > > > > >         return "success";
> > > > > >     }
> > > > > >
> > > > > > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > > > > > back to the same page.  Any ideas?
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Matt
> > > > > > --
> > > > > > View this message in context:
> > > > > http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > > > > > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > >
> > > > http://www.irian.at
> > > >
> > > > Your JSF powerhouse -
> > > > JSF Consulting, Development and
> > > > Courses in English and German
> > > >
> > > > Professional Support for Apache MyFaces
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>

--

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

[Mike Kienenberger]

Do you suppose there's any point in opening a spec issue on this type
of issue when we come across them?

If every implementation has to use the same nomenclature to perform
form "extras", maybe that nomenclature should be put into the spec
explicitly.


On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:

> That was - by the way - done to increase RI compatibility.
>
> regards,
>
> Martin
>
> On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:
> > Hi Matt,
> >
> > I got aware of the same problem time ago, in my tests, mainly because my
> > project start point was appfuse ;-).
> >
> >
> > What I realized is in Myfaces latest version the _link_hidden_ parameter now
> > is named _idcl
> >
> >
> >
> > Ricardo.
> >
> >
> >
> >
> > On 2/22/07, mraible <matt@...> wrote:
> > >
> > > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> > When I
> > > do this, my tests start failing because I have a couple pages that use
> > > JavaScript to call an managed bean's method. Here's my password hint page:
> > >
> > > <f:view>
> > > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > > <title>#{text['user.passwordHint']}</title>
> > >
> > > <p>Looking up password hint for ${ param.username}...</p>
> > >
> > > <h:form id="passwordForm">
> > >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> > >
> > >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> > >         <f:param name="username" value=""/>
> > >     </h:commandLink>
> > > </h:form>
> > >
> > > <script type="text/javascript">
> > >     var f = document.forms['passwordForm'];
> > >
> > f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> > >     f.elements['username'].value='${param.username}';
> > >     f.submit ();
> > > </script>
> > >
> > > </f:view>
> > >
> > > In PasswordForm.execute(), I have:
> > >
> > >     public String execute() {
> > >
> > >         // ensure that the username has been sent
> > >         if (username == null || "".equals(username)) {
> > >             log.warn("Username not specified, notifying user that it's a
> > > required field.");
> > >
> > >             addError("errors.required", getText("user.username"));
> > >             return null;
> > >         }
> > >
> > >         if (log.isDebugEnabled()) {
> > >             log.debug("Processing Password Hint...");
> > >         }
> > >
> > >         // look up the user's information
> > >         try {
> > >             User user = userManager.getUserByUsername(username);
> > >
> > >             StringBuffer msg = new StringBuffer();
> > >             msg.append("Your password hint is: " +
> > user.getPasswordHint());
> > >             msg.append("\n\nLogin at: " +
> > > RequestUtil.getAppURL(getRequest()));
> > >
> > >             message.setTo(user.getEmail());
> > >             String subject = '[' + getText("webapp.name") + "] " +
> > > getText("user.passwordHint");
> > >             message.setSubject(subject);
> > >             message.setText(msg.toString());
> > >             mailEngine.send(message);
> > >
> > >             addMessage("login.passwordHint.sent ",
> > >                        new Object[] { username, user.getEmail() });
> > >
> > >         } catch (Exception e) {
> > >             e.printStackTrace();
> > >             // If exception is expected do not rethrow
> > >             addError(" login.passwordHint.error", username);
> > >         }
> > >
> > >         return "success";
> > >     }
> > >
> > > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > > back to the same page.  Any ideas?
> > >
> > > Thanks,
> > >
> > > Matt
> > > --
> > > View this message in context:
> > http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> > >
> > >
> >
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>

[Matthias Wessendorf-4]

thanks Martin.

another thing would be, if tomahawk is in place
use the Form-, CommandLink-, and CommandButton-Renderer also for the

<h:xxx /> components

with that "improvement"
<h:form>
<t:commandLink />
</h:form>

should work, independent from a impl.

however, thanks.

hopefully the renders are covered a bit more in detail in a future spec.

-M

On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:

> https://issues.apache.org/jira/browse/MYFACES-1539
>
> done.
>
> regards,
>
> Martin
>
> On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > right, since that has some "yet another API break" character.
> >
> > Martin,
> > can you create a issue ?
> >
> > -M
> >
> > On 2/22/07, Mike Kienenberger <mkienenb@...> wrote:
> > > Martin made the change right before we started strongly suggesting
> > > that we create issues for every change.   However, this one might be
> > > important enough to retroactively create.
> > >
> > > On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > > > did you create an issue for that ?
> > > >
> > > > On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > > > > That was - by the way - done to increase RI compatibility.
> > > > >
> > > > > regards,
> > > > >
> > > > > Martin
> > > > >
> > > > > On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:
> > > > > > Hi Matt,
> > > > > >
> > > > > > I got aware of the same problem time ago, in my tests, mainly because my
> > > > > > project start point was appfuse ;-).
> > > > > >
> > > > > >
> > > > > > What I realized is in Myfaces latest version the _link_hidden_ parameter now
> > > > > > is named _idcl
> > > > > >
> > > > > >
> > > > > >
> > > > > > Ricardo.
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 2/22/07, mraible <matt@...> wrote:
> > > > > > >
> > > > > > > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> > > > > > When I
> > > > > > > do this, my tests start failing because I have a couple pages that use
> > > > > > > JavaScript to call an managed bean's method. Here's my password hint page:
> > > > > > >
> > > > > > > <f:view>
> > > > > > > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > > > > > > <title>#{text['user.passwordHint']}</title>
> > > > > > >
> > > > > > > <p>Looking up password hint for ${ param.username}...</p>
> > > > > > >
> > > > > > > <h:form id="passwordForm">
> > > > > > >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> > > > > > >
> > > > > > >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> > > > > > >         <f:param name="username" value=""/>
> > > > > > >     </h:commandLink>
> > > > > > > </h:form>
> > > > > > >
> > > > > > > <script type="text/javascript">
> > > > > > >     var f = document.forms['passwordForm'];
> > > > > > >
> > > > > > f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> > > > > > >     f.elements['username'].value='${param.username}';
> > > > > > >     f.submit ();
> > > > > > > </script>
> > > > > > >
> > > > > > > </f:view>
> > > > > > >
> > > > > > > In PasswordForm.execute(), I have:
> > > > > > >
> > > > > > >     public String execute() {
> > > > > > >
> > > > > > >         // ensure that the username has been sent
> > > > > > >         if (username == null || "".equals(username)) {
> > > > > > >             log.warn("Username not specified, notifying user that it's a
> > > > > > > required field.");
> > > > > > >
> > > > > > >             addError("errors.required", getText("user.username"));
> > > > > > >             return null;
> > > > > > >         }
> > > > > > >
> > > > > > >         if (log.isDebugEnabled()) {
> > > > > > >             log.debug("Processing Password Hint...");
> > > > > > >         }
> > > > > > >
> > > > > > >         // look up the user's information
> > > > > > >         try {
> > > > > > >             User user = userManager.getUserByUsername(username);
> > > > > > >
> > > > > > >             StringBuffer msg = new StringBuffer();
> > > > > > >             msg.append("Your password hint is: " +
> > > > > > user.getPasswordHint());
> > > > > > >             msg.append("\n\nLogin at: " +
> > > > > > > RequestUtil.getAppURL(getRequest()));
> > > > > > >
> > > > > > >             message.setTo(user.getEmail());
> > > > > > >             String subject = '[' + getText("webapp.name") + "] " +
> > > > > > > getText("user.passwordHint");
> > > > > > >             message.setSubject(subject);
> > > > > > >             message.setText(msg.toString());
> > > > > > >             mailEngine.send(message);
> > > > > > >
> > > > > > >             addMessage("login.passwordHint.sent ",
> > > > > > >                        new Object[] { username, user.getEmail() });
> > > > > > >
> > > > > > >         } catch (Exception e) {
> > > > > > >             e.printStackTrace();
> > > > > > >             // If exception is expected do not rethrow
> > > > > > >             addError(" login.passwordHint.error", username);
> > > > > > >         }
> > > > > > >
> > > > > > >         return "success";
> > > > > > >     }
> > > > > > >
> > > > > > > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > > > > > > back to the same page.  Any ideas?
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Matt
> > > > > > > --
> > > > > > > View this message in context:
> > > > > > http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > > > > > > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > >
> > > > > http://www.irian.at
> > > > >
> > > > > Your JSF powerhouse -
> > > > > JSF Consulting, Development and
> > > > > Courses in English and German
> > > > >
> > > > > Professional Support for Apache MyFaces
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > > http://tinyurl.com/fmywh
> > > >
> > > > further stuff:
> > > > blog: http://jroller.com/page/mwessendorf
> > > > mail: mwessendorf-at-gmail-dot-com
> > > >
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>

--
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

[Martin Marinschek]

Hi Matthias,

yes, well - I do think Trinidad goes a bit far in this respect.
Exchanging the renderer sounds a bit intrusive for me.

regards,

Martin

On 2/22/07, Matthias Wessendorf <matzew@...> wrote:

> thanks Martin.
>
> another thing would be, if tomahawk is in place
> use the Form-, CommandLink-, and CommandButton-Renderer also for the
>
> <h:xxx /> components
>
> with that "improvement"
> <h:form>
> <t:commandLink />
> </h:form>
>
> should work, independent from a impl.
>
> however, thanks.
>
> hopefully the renders are covered a bit more in detail in a future spec.
>
> -M
>
> On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > https://issues.apache.org/jira/browse/MYFACES-1539
> >
> > done.
> >
> > regards,
> >
> > Martin
> >
> > On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > > right, since that has some "yet another API break" character.
> > >
> > > Martin,
> > > can you create a issue ?
> > >
> > > -M
> > >
> > > On 2/22/07, Mike Kienenberger <mkienenb@...> wrote:
> > > > Martin made the change right before we started strongly suggesting
> > > > that we create issues for every change.   However, this one might be
> > > > important enough to retroactively create.
> > > >
> > > > On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > > > > did you create an issue for that ?
> > > > >
> > > > > On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > > > > > That was - by the way - done to increase RI compatibility.
> > > > > >
> > > > > > regards,
> > > > > >
> > > > > > Martin
> > > > > >
> > > > > > On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:
> > > > > > > Hi Matt,
> > > > > > >
> > > > > > > I got aware of the same problem time ago, in my tests, mainly because my
> > > > > > > project start point was appfuse ;-).
> > > > > > >
> > > > > > >
> > > > > > > What I realized is in Myfaces latest version the _link_hidden_ parameter now
> > > > > > > is named _idcl
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Ricardo.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On 2/22/07, mraible <matt@...> wrote:
> > > > > > > >
> > > > > > > > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> > > > > > > When I
> > > > > > > > do this, my tests start failing because I have a couple pages that use
> > > > > > > > JavaScript to call an managed bean's method. Here's my password hint page:
> > > > > > > >
> > > > > > > > <f:view>
> > > > > > > > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > > > > > > > <title>#{text['user.passwordHint']}</title>
> > > > > > > >
> > > > > > > > <p>Looking up password hint for ${ param.username}...</p>
> > > > > > > >
> > > > > > > > <h:form id="passwordForm">
> > > > > > > >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> > > > > > > >
> > > > > > > >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> > > > > > > >         <f:param name="username" value=""/>
> > > > > > > >     </h:commandLink>
> > > > > > > > </h:form>
> > > > > > > >
> > > > > > > > <script type="text/javascript">
> > > > > > > >     var f = document.forms['passwordForm'];
> > > > > > > >
> > > > > > > f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> > > > > > > >     f.elements['username'].value='${param.username}';
> > > > > > > >     f.submit ();
> > > > > > > > </script>
> > > > > > > >
> > > > > > > > </f:view>
> > > > > > > >
> > > > > > > > In PasswordForm.execute(), I have:
> > > > > > > >
> > > > > > > >     public String execute() {
> > > > > > > >
> > > > > > > >         // ensure that the username has been sent
> > > > > > > >         if (username == null || "".equals(username)) {
> > > > > > > >             log.warn("Username not specified, notifying user that it's a
> > > > > > > > required field.");
> > > > > > > >
> > > > > > > >             addError("errors.required", getText("user.username"));
> > > > > > > >             return null;
> > > > > > > >         }
> > > > > > > >
> > > > > > > >         if (log.isDebugEnabled()) {
> > > > > > > >             log.debug("Processing Password Hint...");
> > > > > > > >         }
> > > > > > > >
> > > > > > > >         // look up the user's information
> > > > > > > >         try {
> > > > > > > >             User user = userManager.getUserByUsername(username);
> > > > > > > >
> > > > > > > >             StringBuffer msg = new StringBuffer();
> > > > > > > >             msg.append("Your password hint is: " +
> > > > > > > user.getPasswordHint());
> > > > > > > >             msg.append("\n\nLogin at: " +
> > > > > > > > RequestUtil.getAppURL(getRequest()));
> > > > > > > >
> > > > > > > >             message.setTo(user.getEmail());
> > > > > > > >             String subject = '[' + getText("webapp.name") + "] " +
> > > > > > > > getText("user.passwordHint");
> > > > > > > >             message.setSubject(subject);
> > > > > > > >             message.setText(msg.toString());
> > > > > > > >             mailEngine.send(message);
> > > > > > > >
> > > > > > > >             addMessage("login.passwordHint.sent ",
> > > > > > > >                        new Object[] { username, user.getEmail() });
> > > > > > > >
> > > > > > > >         } catch (Exception e) {
> > > > > > > >             e.printStackTrace();
> > > > > > > >             // If exception is expected do not rethrow
> > > > > > > >             addError(" login.passwordHint.error", username);
> > > > > > > >         }
> > > > > > > >
> > > > > > > >         return "success";
> > > > > > > >     }
> > > > > > > >
> > > > > > > > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > > > > > > > back to the same page.  Any ideas?
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > Matt
> > > > > > > > --
> > > > > > > > View this message in context:
> > > > > > > http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > > > > > > > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > >
> > > > > > http://www.irian.at
> > > > > >
> > > > > > Your JSF powerhouse -
> > > > > > JSF Consulting, Development and
> > > > > > Courses in English and German
> > > > > >
> > > > > > Professional Support for Apache MyFaces
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > > http://tinyurl.com/fmywh
> > > > >
> > > > > further stuff:
> > > > > blog: http://jroller.com/page/mwessendorf
> > > > > mail: mwessendorf-at-gmail-dot-com
> > > > >
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
> >
> > --
> >
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>

--

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

[Matthias Wessendorf-4]

Well,

form and commandXxx are a bit "incestive". They know to much about each other.
But all these details are implementation details. So perhaps that can
be polished in a future spec

-M

On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:

> Hi Matthias,
>
> yes, well - I do think Trinidad goes a bit far in this respect.
> Exchanging the renderer sounds a bit intrusive for me.
>
> regards,
>
> Martin
>
> On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > thanks Martin.
> >
> > another thing would be, if tomahawk is in place
> > use the Form-, CommandLink-, and CommandButton-Renderer also for the
> >
> > <h:xxx /> components
> >
> > with that "improvement"
> > <h:form>
> > <t:commandLink />
> > </h:form>
> >
> > should work, independent from a impl.
> >
> > however, thanks.
> >
> > hopefully the renders are covered a bit more in detail in a future spec.
> >
> > -M
> >
> > On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > > https://issues.apache.org/jira/browse/MYFACES-1539
> > >
> > > done.
> > >
> > > regards,
> > >
> > > Martin
> > >
> > > On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > > > right, since that has some "yet another API break" character.
> > > >
> > > > Martin,
> > > > can you create a issue ?
> > > >
> > > > -M
> > > >
> > > > On 2/22/07, Mike Kienenberger <mkienenb@...> wrote:
> > > > > Martin made the change right before we started strongly suggesting
> > > > > that we create issues for every change.   However, this one might be
> > > > > important enough to retroactively create.
> > > > >
> > > > > On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > > > > > did you create an issue for that ?
> > > > > >
> > > > > > On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > > > > > > That was - by the way - done to increase RI compatibility.
> > > > > > >
> > > > > > > regards,
> > > > > > >
> > > > > > > Martin
> > > > > > >
> > > > > > > On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:
> > > > > > > > Hi Matt,
> > > > > > > >
> > > > > > > > I got aware of the same problem time ago, in my tests, mainly because my
> > > > > > > > project start point was appfuse ;-).
> > > > > > > >
> > > > > > > >
> > > > > > > > What I realized is in Myfaces latest version the _link_hidden_ parameter now
> > > > > > > > is named _idcl
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > Ricardo.
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On 2/22/07, mraible <matt@...> wrote:
> > > > > > > > >
> > > > > > > > > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> > > > > > > > When I
> > > > > > > > > do this, my tests start failing because I have a couple pages that use
> > > > > > > > > JavaScript to call an managed bean's method. Here's my password hint page:
> > > > > > > > >
> > > > > > > > > <f:view>
> > > > > > > > > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > > > > > > > > <title>#{text['user.passwordHint']}</title>
> > > > > > > > >
> > > > > > > > > <p>Looking up password hint for ${ param.username}...</p>
> > > > > > > > >
> > > > > > > > > <h:form id="passwordForm">
> > > > > > > > >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> > > > > > > > >
> > > > > > > > >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> > > > > > > > >         <f:param name="username" value=""/>
> > > > > > > > >     </h:commandLink>
> > > > > > > > > </h:form>
> > > > > > > > >
> > > > > > > > > <script type="text/javascript">
> > > > > > > > >     var f = document.forms['passwordForm'];
> > > > > > > > >
> > > > > > > > f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> > > > > > > > >     f.elements['username'].value='${param.username}';
> > > > > > > > >     f.submit ();
> > > > > > > > > </script>
> > > > > > > > >
> > > > > > > > > </f:view>
> > > > > > > > >
> > > > > > > > > In PasswordForm.execute(), I have:
> > > > > > > > >
> > > > > > > > >     public String execute() {
> > > > > > > > >
> > > > > > > > >         // ensure that the username has been sent
> > > > > > > > >         if (username == null || "".equals(username)) {
> > > > > > > > >             log.warn("Username not specified, notifying user that it's a
> > > > > > > > > required field.");
> > > > > > > > >
> > > > > > > > >             addError("errors.required", getText("user.username"));
> > > > > > > > >             return null;
> > > > > > > > >         }
> > > > > > > > >
> > > > > > > > >         if (log.isDebugEnabled()) {
> > > > > > > > >             log.debug("Processing Password Hint...");
> > > > > > > > >         }
> > > > > > > > >
> > > > > > > > >         // look up the user's information
> > > > > > > > >         try {
> > > > > > > > >             User user = userManager.getUserByUsername(username);
> > > > > > > > >
> > > > > > > > >             StringBuffer msg = new StringBuffer();
> > > > > > > > >             msg.append("Your password hint is: " +
> > > > > > > > user.getPasswordHint());
> > > > > > > > >             msg.append("\n\nLogin at: " +
> > > > > > > > > RequestUtil.getAppURL(getRequest()));
> > > > > > > > >
> > > > > > > > >             message.setTo(user.getEmail());
> > > > > > > > >             String subject = '[' + getText("webapp.name") + "] " +
> > > > > > > > > getText("user.passwordHint");
> > > > > > > > >             message.setSubject(subject);
> > > > > > > > >             message.setText(msg.toString());
> > > > > > > > >             mailEngine.send(message);
> > > > > > > > >
> > > > > > > > >             addMessage("login.passwordHint.sent ",
> > > > > > > > >                        new Object[] { username, user.getEmail() });
> > > > > > > > >
> > > > > > > > >         } catch (Exception e) {
> > > > > > > > >             e.printStackTrace();
> > > > > > > > >             // If exception is expected do not rethrow
> > > > > > > > >             addError(" login.passwordHint.error", username);
> > > > > > > > >         }
> > > > > > > > >
> > > > > > > > >         return "success";
> > > > > > > > >     }
> > > > > > > > >
> > > > > > > > > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > > > > > > > > back to the same page.  Any ideas?
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > >
> > > > > > > > > Matt
> > > > > > > > > --
> > > > > > > > > View this message in context:
> > > > > > > > http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > > > > > > > > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > >
> > > > > > > http://www.irian.at
> > > > > > >
> > > > > > > Your JSF powerhouse -
> > > > > > > JSF Consulting, Development and
> > > > > > > Courses in English and German
> > > > > > >
> > > > > > > Professional Support for Apache MyFaces
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Matthias Wessendorf
> > > > > > http://tinyurl.com/fmywh
> > > > > >
> > > > > > further stuff:
> > > > > > blog: http://jroller.com/page/mwessendorf
> > > > > > mail: mwessendorf-at-gmail-dot-com
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Matthias Wessendorf
> > > > http://tinyurl.com/fmywh
> > > >
> > > > further stuff:
> > > > blog: http://jroller.com/page/mwessendorf
> > > > mail: mwessendorf-at-gmail-dot-com
> > > >
> > >
> > >
> > > --
> > >
> > > http://www.irian.at
> > >
> > > Your JSF powerhouse -
> > > JSF Consulting, Development and
> > > Courses in English and German
> > >
> > > Professional Support for Apache MyFaces
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>

--
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

[Martin Marinschek]

Most of the problem has been fixed in the latest version of the RI - I
discussed about one final remaining issue in IE 5.5, but we didn't
find a solution together with Ryan Lubke.

Thing is, if we replace the renderers, and Trinidad does it as well,
we have another problem, right?

regards,

Martin

On 2/22/07, Matthias Wessendorf <matzew@...> wrote:

> Well,
>
> form and commandXxx are a bit "incestive". They know to much about each other.
> But all these details are implementation details. So perhaps that can
> be polished in a future spec
>
> -M
>
> On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > Hi Matthias,
> >
> > yes, well - I do think Trinidad goes a bit far in this respect.
> > Exchanging the renderer sounds a bit intrusive for me.
> >
> > regards,
> >
> > Martin
> >
> > On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > > thanks Martin.
> > >
> > > another thing would be, if tomahawk is in place
> > > use the Form-, CommandLink-, and CommandButton-Renderer also for the
> > >
> > > <h:xxx /> components
> > >
> > > with that "improvement"
> > > <h:form>
> > > <t:commandLink />
> > > </h:form>
> > >
> > > should work, independent from a impl.
> > >
> > > however, thanks.
> > >
> > > hopefully the renders are covered a bit more in detail in a future spec.
> > >
> > > -M
> > >
> > > On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > > > https://issues.apache.org/jira/browse/MYFACES-1539
> > > >
> > > > done.
> > > >
> > > > regards,
> > > >
> > > > Martin
> > > >
> > > > On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > > > > right, since that has some "yet another API break" character.
> > > > >
> > > > > Martin,
> > > > > can you create a issue ?
> > > > >
> > > > > -M
> > > > >
> > > > > On 2/22/07, Mike Kienenberger <mkienenb@...> wrote:
> > > > > > Martin made the change right before we started strongly suggesting
> > > > > > that we create issues for every change.   However, this one might be
> > > > > > important enough to retroactively create.
> > > > > >
> > > > > > On 2/22/07, Matthias Wessendorf <matzew@...> wrote:
> > > > > > > did you create an issue for that ?
> > > > > > >
> > > > > > > On 2/22/07, Martin Marinschek <martin.marinschek@...> wrote:
> > > > > > > > That was - by the way - done to increase RI compatibility.
> > > > > > > >
> > > > > > > > regards,
> > > > > > > >
> > > > > > > > Martin
> > > > > > > >
> > > > > > > > On 2/22/07, Ricardo Tercero Lozano <rtercerol@...> wrote:
> > > > > > > > > Hi Matt,
> > > > > > > > >
> > > > > > > > > I got aware of the same problem time ago, in my tests, mainly because my
> > > > > > > > > project start point was appfuse ;-).
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > What I realized is in Myfaces latest version the _link_hidden_ parameter now
> > > > > > > > > is named _idcl
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > Ricardo.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 2/22/07, mraible <matt@...> wrote:
> > > > > > > > > >
> > > > > > > > > > I recently tried upgrading MyFaces 1.1.4 to the latest 1.1.5 version.
> > > > > > > > > When I
> > > > > > > > > > do this, my tests start failing because I have a couple pages that use
> > > > > > > > > > JavaScript to call an managed bean's method. Here's my password hint page:
> > > > > > > > > >
> > > > > > > > > > <f:view>
> > > > > > > > > > <f:loadBundle var="text" basename="#{basePage.bundleName}"/>
> > > > > > > > > > <title>#{text['user.passwordHint']}</title>
> > > > > > > > > >
> > > > > > > > > > <p>Looking up password hint for ${ param.username}...</p>
> > > > > > > > > >
> > > > > > > > > > <h:form id="passwordForm">
> > > > > > > > > >     <h:inputHidden id="username" value="#{passwordHint.username}"/>
> > > > > > > > > >
> > > > > > > > > >     <h:commandLink action="#{passwordHint.execute }" id="execute">
> > > > > > > > > >         <f:param name="username" value=""/>
> > > > > > > > > >     </h:commandLink>
> > > > > > > > > > </h:form>
> > > > > > > > > >
> > > > > > > > > > <script type="text/javascript">
> > > > > > > > > >     var f = document.forms['passwordForm'];
> > > > > > > > > >
> > > > > > > > > f.elements['passwordForm:_link_hidden_'].value='passwordForm:execute';
> > > > > > > > > >     f.elements['username'].value='${param.username}';
> > > > > > > > > >     f.submit ();
> > > > > > > > > > </script>
> > > > > > > > > >
> > > > > > > > > > </f:view>
> > > > > > > > > >
> > > > > > > > > > In PasswordForm.execute(), I have:
> > > > > > > > > >
> > > > > > > > > >     public String execute() {
> > > > > > > > > >
> > > > > > > > > >         // ensure that the username has been sent
> > > > > > > > > >         if (username == null || "".equals(username)) {
> > > > > > > > > >             log.warn("Username not specified, notifying user that it's a
> > > > > > > > > > required field.");
> > > > > > > > > >
> > > > > > > > > >             addError("errors.required", getText("user.username"));
> > > > > > > > > >             return null;
> > > > > > > > > >         }
> > > > > > > > > >
> > > > > > > > > >         if (log.isDebugEnabled()) {
> > > > > > > > > >             log.debug("Processing Password Hint...");
> > > > > > > > > >         }
> > > > > > > > > >
> > > > > > > > > >         // look up the user's information
> > > > > > > > > >         try {
> > > > > > > > > >             User user = userManager.getUserByUsername(username);
> > > > > > > > > >
> > > > > > > > > >             StringBuffer msg = new StringBuffer();
> > > > > > > > > >             msg.append("Your password hint is: " +
> > > > > > > > > user.getPasswordHint());
> > > > > > > > > >             msg.append("\n\nLogin at: " +
> > > > > > > > > > RequestUtil.getAppURL(getRequest()));
> > > > > > > > > >
> > > > > > > > > >             message.setTo(user.getEmail());
> > > > > > > > > >             String subject = '[' + getText("webapp.name") + "] " +
> > > > > > > > > > getText("user.passwordHint");
> > > > > > > > > >             message.setSubject(subject);
> > > > > > > > > >             message.setText(msg.toString());
> > > > > > > > > >             mailEngine.send(message);
> > > > > > > > > >
> > > > > > > > > >             addMessage("login.passwordHint.sent ",
> > > > > > > > > >                        new Object[] { username, user.getEmail() });
> > > > > > > > > >
> > > > > > > > > >         } catch (Exception e) {
> > > > > > > > > >             e.printStackTrace();
> > > > > > > > > >             // If exception is expected do not rethrow
> > > > > > > > > >             addError(" login.passwordHint.error", username);
> > > > > > > > > >         }
> > > > > > > > > >
> > > > > > > > > >         return "success";
> > > > > > > > > >     }
> > > > > > > > > >
> > > > > > > > > > This worked fine in 1.1.4, but for some reason - 1.1.5 keeps redirecting
> > > > > > > > > > back to the same page.  Any ideas?
> > > > > > > > > >
> > > > > > > > > > Thanks,
> > > > > > > > > >
> > > > > > > > > > Matt
> > > > > > > > > > --
> > > > > > > > > > View this message in context:
> > > > > > > > > http://www.nabble.com/Upgrading-from-MyFaces-1.1.4-to-1.1.5-tf3271040.html#a9094577
> > > > > > > > > > Sent from the MyFaces - Users mailing list archive at Nabble.com.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > >
> > > > > > > > http://www.irian.at
> > > > > > > >
> > > > > > > > Your JSF powerhouse -
> > > > > > > > JSF Consulting, Development and
> > > > > > > > Courses in English and German
> > > > > > > >
> > > > > > > > Professional Support for Apache MyFaces
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Matthias Wessendorf
> > > > > > > http://tinyurl.com/fmywh
> > > > > > >
> > > > > > > further stuff:
> > > > > > > blog: http://jroller.com/page/mwessendorf
> > > > > > > mail: mwessendorf-at-gmail-dot-com
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > > http://tinyurl.com/fmywh
> > > > >
> > > > > further stuff:
> > > > > blog: http://jroller.com/page/mwessendorf
> > > > > mail: mwessendorf-at-gmail-dot-com
> > > > >
> > > >
> > > >
> > > > --
> > > >
> > > > http://www.irian.at
> > > >
> > > > Your JSF powerhouse -
> > > > JSF Consulting, Development and
> > > > Courses in English and German
> > > >
> > > > Professional Support for Apache MyFaces
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
> >
> > --
> >
> > http://www.irian.at
> >
> > Your JSF powerhouse -
> > JSF Consulting, Development and
> > Courses in English and German
> >
> > Professional Support for Apache MyFaces
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>

--

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces