Very very slow Lilypond uninstall on Windows

[Nick Payne-3]

When I install a new version I uninstall the previous one. I have
noticed, for quite a few versions now, that the uninstall takes a long
time. I just downloaded 2.13.7 and am waiting for the uninstall of
2.13.4 to complete. It has been running for about 32 minutes so far and
the uninstall progress bar is at about 80%.

This machine is dual boot. If I boot into Ubuntu and run the uninstall
of the same version, it takes only a few seconds to complete. I've tried
on two different Windows machines, one running Windows 7 and one running
XP, and the extremely slow uninstall happens on both. Installation on
both runs quite satisfactorily.

Nick


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[David Bobroff]

I've noticed a similar difference between Linux and Windows uninstall
times.  My Windows machine is a few years old; 3GHz Pentium with 2Gb RAM
and the Linux box is a much older machine; 733MHz with maybe 768Mb RAM.
  The uninstall on the much slower Linux hardware is a few seconds,
while on the much faster Windows hardware the uninstall takes much
longer...but not anything like 32 minutes to reach 80%.  Uninstall on my
Windows (XP) takes maybe a few minutes.

I remember once starting an uninstall on Windows and while that was
going on I went to my Linux box, uninstalled LilyPond, downloaded a
newer LP and installed it before the Windows had completed the uninstall.

-David

Nick Payne wrote:

> When I install a new version I uninstall the previous one. I have
> noticed, for quite a few versions now, that the uninstall takes a long
> time. I just downloaded 2.13.7 and am waiting for the uninstall of
> 2.13.4 to complete. It has been running for about 32 minutes so far and
> the uninstall progress bar is at about 80%.
>
> This machine is dual boot. If I boot into Ubuntu and run the uninstall
> of the same version, it takes only a few seconds to complete. I've tried
> on two different Windows machines, one running Windows 7 and one running
> XP, and the extremely slow uninstall happens on both. Installation on
> both runs quite satisfactorily.
>
> Nick
>
>
> _______________________________________________
> lilypond-user mailing list
> lilypond-user@...
> http://lists.gnu.org/mailman/listinfo/lilypond-user
>

_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Patrick McCarty-3]

On Mon, Nov 9, 2009 at 12:25 PM, Nick Payne <nick.payne@...> wrote:
> When I install a new version I uninstall the previous one. I have noticed,
> for quite a few versions now, that the uninstall takes a long time. I just
> downloaded 2.13.7 and am waiting for the uninstall of 2.13.4 to complete. It
> has been running for about 32 minutes so far and the uninstall progress bar
> is at about 80%.

Yes, I've noticed this too.

Please send a report to the bug mailing list.  This is most likely a
problem with GUB, so if it's on the bug tracker, it won't get lost.

Thanks,
Patrick


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Graham Percival-3]

Patches appreciated.  I don't have a clue why this happens.

Cheers,
- Graham

On Mon, Nov 09, 2009 at 08:39:31PM +0000, David Bobroff wrote:

> I've noticed a similar difference between Linux and Windows uninstall  
> times.  My Windows machine is a few years old; 3GHz Pentium with 2Gb RAM  
> and the Linux box is a much older machine; 733MHz with maybe 768Mb RAM.  
> The uninstall on the much slower Linux hardware is a few seconds, while
> on the much faster Windows hardware the uninstall takes much  
> longer...but not anything like 32 minutes to reach 80%.  Uninstall on my  
> Windows (XP) takes maybe a few minutes.
>
> I remember once starting an uninstall on Windows and while that was  
> going on I went to my Linux box, uninstalled LilyPond, downloaded a  
> newer LP and installed it before the Windows had completed the uninstall.
>
> -David
>
> Nick Payne wrote:
>> When I install a new version I uninstall the previous one. I have  
>> noticed, for quite a few versions now, that the uninstall takes a long  
>> time. I just downloaded 2.13.7 and am waiting for the uninstall of  
>> 2.13.4 to complete. It has been running for about 32 minutes so far and
>> the uninstall progress bar is at about 80%.
>>
>> This machine is dual boot. If I boot into Ubuntu and run the uninstall  
>> of the same version, it takes only a few seconds to complete. I've
>> tried on two different Windows machines, one running Windows 7 and one
>> running XP, and the extremely slow uninstall happens on both.
>> Installation on both runs quite satisfactorily.
>>
>> Nick
>>
>>
>> _______________________________________________
>> lilypond-user mailing list
>> lilypond-user@...
>> http://lists.gnu.org/mailman/listinfo/lilypond-user
>>
>
>
>
> _______________________________________________
> lilypond-user mailing list
> lilypond-user@...
> http://lists.gnu.org/mailman/listinfo/lilypond-user

_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Valentin Villenave]

On Mon, Nov 9, 2009 at 10:06 PM, Graham Percival
<graham@...> wrote:
> Patches appreciated.  I don't have a clue why this happens.

It's because LilyPond uses the NSIS scons-enabled "list all installed
files, and then only remove what's been installed" mode. It would be
easier and quicker to have an non-logged installation and then only do
rm -rf (or the Windows equivalent), but then if a user has put some
valuable data in LilyPond installation (sub)folder, this data could be
lost. What we do is the safest way, however its slowness (and I'm not
sure we should change it).

An easy workaround is to delete everything but one line in the
files.txt file, and then delete everything manually.

Cheers,
Valentin.


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Graham Percival-3]

On Mon, Nov 09, 2009 at 10:55:41PM +0100, Valentin Villenave wrote:

> On Mon, Nov 9, 2009 at 10:06 PM, Graham Percival
> <graham@...> wrote:
> > Patches appreciated.  I don't have a clue why this happens.
>
> It's because LilyPond uses the NSIS scons-enabled "list all installed
> files, and then only remove what's been installed" mode. It would be
> easier and quicker to have an non-logged installation and then only do
> rm -rf (or the Windows equivalent), but then if a user has put some
> valuable data in LilyPond installation (sub)folder, this data could be
> lost. What we do is the safest way, however its slowness (and I'm not
> sure we should change it).
>
> An easy workaround is to delete everything but one line in the
> files.txt file, and then delete everything manually.

Maybe I misunderstand... windows takes 30 minutes to delete a
known list of files?  I mean, we *have* files.txt, so we know
what's been installed.  on unix, I'd do something like
  cat files.txt | xargs rm
and it would take a few seconds.

is the installer looking at some windows database to get the
filelist?  would it be faster to just get the /path/to/lilypond
from the windows database, then run through the entire files.txt?


(I suppose that somebody could theoretically modify one of the
base lilypond files -- probably a .ly -- and lose those changes,
but I'm not worried about that.  If they're screwing with the
installed files, then they should be advanced enough to either
know what they're doing, or mature enough to take the hit when
they lose work due to their own fault)

Cheers,
- Graham


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Valentin Villenave]

On Mon, Nov 9, 2009 at 11:07 PM, Graham Percival
<graham@...> wrote:
> Maybe I misunderstand... windows takes 30 minutes to delete a
> known list of files?

Yes :-)

> is the installer looking at some windows database to get the
> filelist?

Nope, the registry database isn't involved at all.

> (I suppose that somebody could theoretically modify one of the
> base lilypond files -- probably a .ly -- and lose those changes,
> but I'm not worried about that.  If they're screwing with the
> installed files, then they should be advanced enough to either
> know what they're doing, or mature enough to take the hit when
> they lose work due to their own fault)

Then we could just rewrite the NSIS installer without logging, and
simply do a rmdir -f in the uninstall script. But that's a bit
intrusive.

Cheers,
Valentin


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Patrick McCarty-3]

On Mon, Nov 9, 2009 at 2:11 PM, Valentin Villenave
<v.villenave@...> wrote:
> On Mon, Nov 9, 2009 at 11:07 PM, Graham Percival
> <graham@...> wrote:
>> Maybe I misunderstand... windows takes 30 minutes to delete a
>> known list of files?
>
> Yes :-)

Well, there is a list of files in files.txt, but most of those files
don't even exist in a LilyPond installation on Windows.

Maybe that's why the uninstallation takes so long?

-Patrick


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Graham Percival-3]

On Mon, Nov 09, 2009 at 02:18:14PM -0800, Patrick McCarty wrote:
> > On Mon, Nov 9, 2009 at 11:07 PM, Graham Percival
> > <graham@...> wrote:
> >> Maybe I misunderstand... windows takes 30 minutes to delete a
> >> known list of files?
>
> Well, there is a list of files in files.txt, but most of those files
> don't even exist in a LilyPond installation on Windows.

Really?  Huh.  To find out if lilypad.exe has been copied, I just
grep files.txt; that seems to work.  (i.e. whenever people
complain that it's missing, I go back and discover that it's not
listed in files.txt)

Cheers,
- Graham


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Patrick McCarty-3]

On Mon, Nov 9, 2009 at 2:20 PM, Graham Percival
<graham@...> wrote:

> On Mon, Nov 09, 2009 at 02:18:14PM -0800, Patrick McCarty wrote:
>> > On Mon, Nov 9, 2009 at 11:07 PM, Graham Percival
>> > <graham@...> wrote:
>> >> Maybe I misunderstand... windows takes 30 minutes to delete a
>> >> known list of files?
>>
>> Well, there is a list of files in files.txt, but most of those files
>> don't even exist in a LilyPond installation on Windows.
>
> Really?  Huh.  To find out if lilypad.exe has been copied, I just
> grep files.txt; that seems to work.  (i.e. whenever people
> complain that it's missing, I go back and discover that it's not
> listed in files.txt)

I should have said "about half" of the files.  Most (if not all) of
the nonexistent files are supposed to be in the "\usr\docs\"
hierarchy.  The directory structure exists, but the files aren't
there.

-Patrick


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Patrick McCarty-3]

On Mon, Nov 9, 2009 at 2:24 PM, Patrick McCarty <pnorcks@...> wrote:

> On Mon, Nov 9, 2009 at 2:20 PM, Graham Percival
> <graham@...> wrote:
>> On Mon, Nov 09, 2009 at 02:18:14PM -0800, Patrick McCarty wrote:
>>> > On Mon, Nov 9, 2009 at 11:07 PM, Graham Percival
>>> > <graham@...> wrote:
>>> >> Maybe I misunderstand... windows takes 30 minutes to delete a
>>> >> known list of files?
>>>
>>> Well, there is a list of files in files.txt, but most of those files
>>> don't even exist in a LilyPond installation on Windows.
>>
>> Really?  Huh.  To find out if lilypad.exe has been copied, I just
>> grep files.txt; that seems to work.  (i.e. whenever people
>> complain that it's missing, I go back and discover that it's not
>> listed in files.txt)
>
> I should have said "about half" of the files.  Most (if not all) of
> the nonexistent files are supposed to be in the "\usr\docs\"
> hierarchy.  The directory structure exists, but the files aren't
> there.

Attached is a compressed copy of files.txt from 2.13.6.

-Patrick


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Nick Payne-3]

Patrick McCarty wrote:

> On Mon, Nov 9, 2009 at 2:20 PM, Graham Percival
> <graham@...> wrote:
>  
>> On Mon, Nov 09, 2009 at 02:18:14PM -0800, Patrick McCarty wrote:
>>    
>>>> On Mon, Nov 9, 2009 at 11:07 PM, Graham Percival
>>>> <graham@...> wrote:
>>>>        
>>>>> Maybe I misunderstand... windows takes 30 minutes to delete a
>>>>> known list of files?
>>>>>          
>>> Well, there is a list of files in files.txt, but most of those files
>>> don't even exist in a LilyPond installation on Windows.
>>>      
>> Really?  Huh.  To find out if lilypad.exe has been copied, I just
>> grep files.txt; that seems to work.  (i.e. whenever people
>> complain that it's missing, I go back and discover that it's not
>> listed in files.txt)
>>    
>
> I should have said "about half" of the files.  Most (if not all) of
> the nonexistent files are supposed to be in the "\usr\docs\"
> hierarchy.  The directory structure exists, but the files aren't
> there.

Yes, nearly all of the time of the uninstall is spent doing something in
the \usr\docs dir structure, according to the path information shown in
the uninstall dialog.

Nick


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Patrick McCarty-3]

On Mon, Nov 9, 2009 at 3:15 PM, Nick Payne <nick.payne@...> wrote:

> Patrick McCarty wrote:
>>
>> I should have said "about half" of the files.  Most (if not all) of
>> the nonexistent files are supposed to be in the "\usr\docs\"
>> hierarchy.  The directory structure exists, but the files aren't
>> there.
>
> Yes, nearly all of the time of the uninstall is spent doing something in the
> \usr\docs dir structure, according to the path information shown in the
> uninstall dialog.

Okay, that's what I suspected.

After a few quick searches on Google, it looks like many of the HTML
files in files.txt are part of the "db" package (the GUB spec is in
gub/specs/db.py), which is used to build LilyPond for Windows.

So maybe something needs to be fixed with the install stage of db?  I
will try to build tools::db and mingw::db to see if I can tell what's
happening.

-Patrick


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Patrick McCarty-3]

On 2009-11-09, Patrick McCarty wrote:

> On Mon, Nov 9, 2009 at 3:15 PM, Nick Payne <nick.payne@...> wrote:
> > Patrick McCarty wrote:
> >>
> >> I should have said "about half" of the files.  Most (if not all) of
> >> the nonexistent files are supposed to be in the "\usr\docs\"
> >> hierarchy.  The directory structure exists, but the files aren't
> >> there.
> >
> > Yes, nearly all of the time of the uninstall is spent doing something in the
> > \usr\docs dir structure, according to the path information shown in the
> > uninstall dialog.
>
> Okay, that's what I suspected.
>
> After a few quick searches on Google, it looks like many of the HTML
> files in files.txt are part of the "db" package (the GUB spec is in
> gub/specs/db.py), which is used to build LilyPond for Windows.
>
> So maybe something needs to be fixed with the install stage of db?  I
> will try to build tools::db and mingw::db to see if I can tell what's
> happening.

Here's an update:

I just built tools::db with GUB, and I found an extensive set of
directories under

  target/tools/root/usr/docs/

...but, almost every file is a symlink to a non-existent HTML file,
which explains why the HTML files are missing from the Windows
installers.  For example, target/tools/root/usr/docs/index.html points
here:

  /home/pnorcks/git/gub/target/tools/root/home/pnorcks/git/gub/target/tools/src/db-4.7.25/docs/index.html

I'm not sure what to do here.  But IWBN if db did not install any of
these invalid symlinks.


-Patrick


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Jan Nieuwenhuizen-2]

Op dinsdag 10-11-2009 om 00:51 uur [tijdzone -0800], schreef Patrick
McCarty:
> On 2009-11-09, Patrick McCarty wrote:
> > On Mon, Nov 9, 2009 at 3:15 PM, Nick Payne <nick.payne@...> wrote:
> > > Patrick McCarty wrote:

> I'm not sure what to do here.  But IWBN if db did not install any of
> these invalid symlinks.

Yes, IWBN if upstream authors had a clue.  I'd go for
something like

   def install (self):
      my-super-class.install (self)
      self.system ('rm -rf %(install_prefix)s/share/doc/')

Jan.


--
Jan Nieuwenhuizen <janneke@...> | GNU LilyPond - The music typesetter
Avatar®: http://AvatarAcademy.nl    | http://lilypond.org



_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Patrick McCarty-3]

On 2009-11-10, Jan Nieuwenhuizen wrote:

> Op dinsdag 10-11-2009 om 00:51 uur [tijdzone -0800], schreef Patrick
> McCarty:
> > On 2009-11-09, Patrick McCarty wrote:
> > > On Mon, Nov 9, 2009 at 3:15 PM, Nick Payne <nick.payne@...> wrote:
> > > > Patrick McCarty wrote:
>
> > I'm not sure what to do here.  But IWBN if db did not install any of
> > these invalid symlinks.
>
> Yes, IWBN if upstream authors had a clue.  I'd go for
> something like
>
>    def install (self):
>       my-super-class.install (self)
>       self.system ('rm -rf %(install_prefix)s/share/doc/')

Okay, here's a patch for that.

Thanks,
Patrick

From 03a4a46493ecf47ed2b384e5514f815358789f1f Mon Sep 17 00:00:00 2001
From: Patrick McCarty <pnorcks@...>
Date: Tue, 10 Nov 2009 01:37:50 -0800
Subject: [PATCH] db: Remove the /usr/docs/ directory structure.

This might speed up the LilyPond Windows uninstaller.
---
 gub/specs/db.py |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/gub/specs/db.py b/gub/specs/db.py
index c046a03..09abebf 100644
--- a/gub/specs/db.py
+++ b/gub/specs/db.py
@@ -20,6 +20,8 @@ class Db (target.AutoBuild):
                         '%(builddir)s/build_unix/Makefile')
     def install (self):
         target.AutoBuild.install (self)
+        # FIXME: /usr/docs/ is full of invalid symlinks
+        self.system ('rm -rf %(install_prefix)s/docs')
         self.system ('rm -f %(install_prefix)s/lib/libdb.{a,so{,.a},la}')
         self.system ('cd %(install_prefix)s/lib && ln -s libdb-*.a libdb.a')
         self.system ('cd %(install_prefix)s/lib && cp libdb-*.la libdb.la')
@@ -57,6 +59,8 @@ LDFLAGS=-lwsock32
 '''))
     def install (self):
         target.AutoBuild.install (self)
+        # FIXME: /usr/docs/ is full of invalid symlinks
+        self.system ('rm -rf %(install_prefix)s/docs')
         self.system ('rm -f %(install_prefix)s/{bin,lib}/libdb.{{,so,dll}{,.a},la}')
         self.system ('cd %(install_prefix)s/lib && cp libdb-*.a libdb.a')
         self.system ('cd %(install_prefix)s/lib && cp libdb-*.la libdb.la')
@@ -81,4 +85,6 @@ class Db__tools (tools.AutoBuild, Db):
         pass
     def install (self):
         tools.AutoBuild.install (self)
+        # FIXME: /usr/docs/ is full of invalid symlinks
+        self.system ('rm -rf %(install_prefix)s/docs')
         self.system ('cd %(install_prefix)s/lib && ln -s libdb-*.la libdb.la')
--
1.6.5.2


_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user

[Jan Nieuwenhuizen-2]

Op dinsdag 10-11-2009 om 01:45 uur [tijdzone -0800], schreef Patrick
McCarty:
> On 2009-11-10, Jan Nieuwenhuizen wrote:
> > Op dinsdag 10-11-2009 om 00:51 uur [tijdzone -0800], schreef Patrick
> > McCarty:
> > > On 2009-11-09, Patrick McCarty wrote:
> > > > On Mon, Nov 9, 2009 at 3:15 PM, Nick Payne <nick.payne@...> wrote:
> > > > > Patrick McCarty wrote:

> Okay, here's a patch for that.

Applied, thanks.

Greetings,
Jan.


--
Jan Nieuwenhuizen <janneke@...> | GNU LilyPond - The music typesetter
Avatar®: http://AvatarAcademy.nl    | http://lilypond.org



_______________________________________________
lilypond-user mailing list
lilypond-user@...
http://lists.gnu.org/mailman/listinfo/lilypond-user