VisualVM 1.2.1 and IcedTea6

[Tomas Hurka]

Hi All,
attached is a patch to include the latest version (1.2.1) of VisualVM  
in IcedTea6. Can somebody commit these changes for me?

Thanks,
--
Tomas Hurka   <mailto:tomas.hurka@...>
NetBeans Profiler http://profiler.netbeans.org
VisualVM http://visualvm.dev.java.net
Software Engineer, Developer Platforms Group
Sun Microsystems, Praha Czech Republic

[gnu_andrew]

2009/11/11 Tomas Hurka <Tomas.Hurka@...>:

> Hi All,
> attached is a patch to include the latest version (1.2.1) of VisualVM in
> IcedTea6. Can somebody commit these changes for me?
>
> Thanks,
> --
> Tomas Hurka   <mailto:tomas.hurka@...>
> NetBeans Profiler http://profiler.netbeans.org
> VisualVM http://visualvm.dev.java.net
> Software Engineer, Developer Platforms Group
> Sun Microsystems, Praha Czech Republic
>
>
>
>
>
>
>

I've applied this to IcedTea7:
http://icedtea.classpath.org/hg/icedtea/rev/d4fe9b0323e0 I'll backport
it to IcedTea6 once I've sorted out the IcedTea7 release for milestone
5.

Note that $(abs_top_builddir) should be used, not $(abs_top_srcdir).

Thanks for the contribution!
--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[Tomas Hurka]

Hi Andrew,

On 17 Nov 2009, at 22:54, Andrew John Hughes wrote:

> 2009/11/11 Tomas Hurka <Tomas.Hurka@...>:
>> Hi All,
>> attached is a patch to include the latest version (1.2.1) of  
>> VisualVM in
>> IcedTea6. Can somebody commit these changes for me?
>
> I've applied this to IcedTea7:
> http://icedtea.classpath.org/hg/icedtea/rev/d4fe9b0323e0 I'll backport
> it to IcedTea6 once I've sorted out the IcedTea7 release for milestone
> 5.

OK.

> Note that $(abs_top_builddir) should be used, not $(abs_top_srcdir).

I see. Thanks for the review of the patch.

Bye,
--
Tomas Hurka   <mailto:tomas.hurka@...>
NetBeans Profiler http://profiler.netbeans.org
VisualVM http://visualvm.dev.java.net
Software Engineer, Developer Platforms Group
Sun Microsystems, Praha Czech Republic

[gnu_andrew]

2009/11/18 Tomas Hurka <Tomas.Hurka@...>:

> Hi Andrew,
>
> On 17 Nov 2009, at 22:54, Andrew John Hughes wrote:
>
>> 2009/11/11 Tomas Hurka <Tomas.Hurka@...>:
>>>
>>> Hi All,
>>> attached is a patch to include the latest version (1.2.1) of VisualVM in
>>> IcedTea6. Can somebody commit these changes for me?
>>
>> I've applied this to IcedTea7:
>> http://icedtea.classpath.org/hg/icedtea/rev/d4fe9b0323e0 I'll backport
>> it to IcedTea6 once I've sorted out the IcedTea7 release for milestone
>> 5.
>
> OK.
>
>> Note that $(abs_top_builddir) should be used, not $(abs_top_srcdir).
>
> I see. Thanks for the review of the patch.
>
> Bye,
> --
> Tomas Hurka   <mailto:tomas.hurka@...>
> NetBeans Profiler http://profiler.netbeans.org
> VisualVM http://visualvm.dev.java.net
> Software Engineer, Developer Platforms Group
> Sun Microsystems, Praha Czech Republic
>
>
>
>

We're getting this failure:

BUILD FAILED
/notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/templates/projectized.xml:93:
The module org.jdesktop.layout
cannot be compiled against because it is part of the cluster
/notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/netbeans_visualvm/platform9
which is not part of cluster.path
in your suite configuration.

Any ideas what this means?

Thanks,
--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[Tomas Hurka]

Hi Andrew,

On 19 Nov 2009, at 17:24, Andrew John Hughes wrote:

>
> We're getting this failure:
>
> BUILD FAILED
> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/
> templates/projectized.xml:93:
> The module org.jdesktop.layout
> cannot be compiled against because it is part of the cluster
> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/
> netbeans_visualvm/platform9
> which is not part of cluster.path
> in your suite configuration.
>
> Any ideas what this means?

You need to build it against NetBeans Platform 6.7.1 (netbeans-
platform-6.7.1-2.fc12.noarch). It looks like you are using older  
version.

Bye,
--
Tomas Hurka   <mailto:tomas.hurka@...>
NetBeans Profiler http://profiler.netbeans.org
VisualVM http://visualvm.dev.java.net
Software Engineer, Developer Platforms Group
Sun Microsystems, Praha Czech Republic

[Lillian Angel]

Andrew,


On 2009-11-19, at 11:38 AM, Tomas Hurka wrote:

> Hi Andrew,
>
> On 19 Nov 2009, at 17:24, Andrew John Hughes wrote:
>>
>> We're getting this failure:
>>
>> BUILD FAILED
>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/templates/projectized.xml:93:
>> The module org.jdesktop.layout
>> cannot be compiled against because it is part of the cluster
>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/netbeans_visualvm/platform9
>> which is not part of cluster.path
>> in your suite configuration.
>>
>> Any ideas what this means?
> You need to build it against NetBeans Platform 6.7.1 (netbeans-platform-6.7.1-2.fc12.noarch). It looks like you are using older version.

Be sure when we update IcedTea in Fedora, this is only applied as a patch in Fedora 12 (and rawhide) and not updated in Fedora 10 or 11. Same case for all other distributions, I just don't know if they build with --enable-visualvm. We should update the docs to say 6.7.1 is required.


Cheers

[Matthias Klose-6]

On 19.11.2009 13:24, Lillian Angel wrote:

> Andrew,
>
>
> On 2009-11-19, at 11:38 AM, Tomas Hurka wrote:
>
>> Hi Andrew,
>>
>> On 19 Nov 2009, at 17:24, Andrew John Hughes wrote:
>>>
>>> We're getting this failure:
>>>
>>> BUILD FAILED
>>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/templates/projectized.xml:93:
>>> The module org.jdesktop.layout
>>> cannot be compiled against because it is part of the cluster
>>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/netbeans_visualvm/platform9
>>> which is not part of cluster.path
>>> in your suite configuration.
>>>
>>> Any ideas what this means?
>> You need to build it against NetBeans Platform 6.7.1 (netbeans-platform-6.7.1-2.fc12.noarch). It looks like you are using older version.
>
> Be sure when we update IcedTea in Fedora, this is only applied as a patch in Fedora 12 (and rawhide) and not updated in Fedora 10 or 11. Same case for all other distributions, I just don't know if they build with --enable-visualvm. We should update the docs to say 6.7.1 is required.

other distributions build separate sources from a separate source package. I
still don't see the value why visualvm needs to be built from IcedTea. But maybe
somebody wants to add javadb as well in the future.

   Matthias

[gnu_andrew]

2009/11/19 Tomas Hurka <Tomas.Hurka@...>:

> Hi Andrew,
>
> On 19 Nov 2009, at 17:24, Andrew John Hughes wrote:
>>
>> We're getting this failure:
>>
>> BUILD FAILED
>>
>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/templates/projectized.xml:93:
>> The module org.jdesktop.layout
>> cannot be compiled against because it is part of the cluster
>>
>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/netbeans_visualvm/platform9
>> which is not part of cluster.path
>> in your suite configuration.
>>
>> Any ideas what this means?
>
> You need to build it against NetBeans Platform 6.7.1
> (netbeans-platform-6.7.1-2.fc12.noarch). It looks like you are using older
> version.
>
> Bye,
> --
> Tomas Hurka   <mailto:tomas.hurka@...>
> NetBeans Profiler http://profiler.netbeans.org
> VisualVM http://visualvm.dev.java.net
> Software Engineer, Developer Platforms Group
> Sun Microsystems, Praha Czech Republic
>
>

Well yes, this is in our nightly build on an F11 box.  You didn't
mention any change of requirements in your original email. I'm in two
minds as to whether we should revert this change or not.
--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[gnu_andrew]

2009/11/19 Lillian Angel <langel@...>:

> Andrew,
>
>
> On 2009-11-19, at 11:38 AM, Tomas Hurka wrote:
>
>> Hi Andrew,
>>
>> On 19 Nov 2009, at 17:24, Andrew John Hughes wrote:
>>>
>>> We're getting this failure:
>>>
>>> BUILD FAILED
>>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/templates/projectized.xml:93:
>>> The module org.jdesktop.layout
>>> cannot be compiled against because it is part of the cluster
>>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/netbeans_visualvm/platform9
>>> which is not part of cluster.path
>>> in your suite configuration.
>>>
>>> Any ideas what this means?
>> You need to build it against NetBeans Platform 6.7.1 (netbeans-platform-6.7.1-2.fc12.noarch). It looks like you are using older version.
>
> Be sure when we update IcedTea in Fedora, this is only applied as a patch in Fedora 12 (and rawhide) and not updated in Fedora 10 or 11. Same case for all other distributions, I just don't know if they build with --enable-visualvm. We should update the docs to say 6.7.1 is required.
>
>
> Cheers

This isn't in IcedTea6 yet but is in IcedTea7, which should be safe;
the likelihood of someone wanting to ship VisualVM with that is pretty
low.  What versions of IcedTea6 are in each of the Fedoras now?  I'm
guessing this would want to go in HEAD and then be used for F12 and up
as part of the next release.
--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[gnu_andrew]

2009/11/19 Matthias Klose <doko@...>:

> On 19.11.2009 13:24, Lillian Angel wrote:
>>
>> Andrew,
>>
>>
>> On 2009-11-19, at 11:38 AM, Tomas Hurka wrote:
>>
>>> Hi Andrew,
>>>
>>> On 19 Nov 2009, at 17:24, Andrew John Hughes wrote:
>>>>
>>>> We're getting this failure:
>>>>
>>>> BUILD FAILED
>>>>
>>>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/templates/projectized.xml:93:
>>>> The module org.jdesktop.layout
>>>> cannot be compiled against because it is part of the cluster
>>>>
>>>> /notnfs/nighttester/icedtea7-target-testing/netbeans/nbbuild/netbeans_visualvm/platform9
>>>> which is not part of cluster.path
>>>> in your suite configuration.
>>>>
>>>> Any ideas what this means?
>>>
>>> You need to build it against NetBeans Platform 6.7.1
>>> (netbeans-platform-6.7.1-2.fc12.noarch). It looks like you are using older
>>> version.
>>
>> Be sure when we update IcedTea in Fedora, this is only applied as a patch
>> in Fedora 12 (and rawhide) and not updated in Fedora 10 or 11. Same case for
>> all other distributions, I just don't know if they build with
>> --enable-visualvm. We should update the docs to say 6.7.1 is required.
>
> other distributions build separate sources from a separate source package. I
> still don't see the value why visualvm needs to be built from IcedTea. But
> maybe somebody wants to add javadb as well in the future.
>

I've also never included it in the ebuilds for Gentoo -- it's
infeasible given it requires NetBeans which in turns requires the very
JDK being built.

It does work from the point of view of a personal build of IcedTea,
giving the builder a JDK with more of the features of the proprietary
JDK, which I believe includes this thing.

>  Matthias
>



--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

[Tomas Hurka]

Hi Andrew,

On 23 Nov 2009, at 10:15, Andrew John Hughes wrote:

> 2009/11/19 Tomas Hurka <Tomas.Hurka@...>:
>>
>> On 19 Nov 2009, at 17:24, Andrew John Hughes wrote:
>>>
>>> We're getting this failure:
>>>
>>> BUILD FAILED
[..]
>>> Any ideas what this means?
>>
>> You need to build it against NetBeans Platform 6.7.1
>> (netbeans-platform-6.7.1-2.fc12.noarch). It looks like you are  
>> using older
>> version.
>
> Well yes, this is in our nightly build on an F11 box.  You didn't
> mention any change of requirements in your original email.
I did mentioned it here: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-October/007408.html
I did not know that you are still using NetBeans 6.5, since NetBeans  
6.7 was released almost half a year ago.

Bye,
--
Tomas Hurka   <mailto:tomas.hurka@...>
NetBeans Profiler http://profiler.netbeans.org
VisualVM http://visualvm.dev.java.net
Software Engineer, Developer Platforms Group
Sun Microsystems, Praha Czech Republic

[gnu_andrew]

2009/11/23 Tomas Hurka <Tomas.Hurka@...>:

> Hi Andrew,
>
> On 23 Nov 2009, at 10:15, Andrew John Hughes wrote:
>
>> 2009/11/19 Tomas Hurka <Tomas.Hurka@...>:
>>>
>>> On 19 Nov 2009, at 17:24, Andrew John Hughes wrote:
>>>>
>>>> We're getting this failure:
>>>>
>>>> BUILD FAILED
>
> [..]
>>>>
>>>> Any ideas what this means?
>>>
>>> You need to build it against NetBeans Platform 6.7.1
>>> (netbeans-platform-6.7.1-2.fc12.noarch). It looks like you are using
>>> older
>>> version.
>>
>> Well yes, this is in our nightly build on an F11 box.  You didn't
>> mention any change of requirements in your original email.
>
> I did mentioned it here:
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-October/007408.html

True, but it would have been much clearer to have mentioned it in the
e-mail rather than expecting people to remember this earlier thread (I
didn't).

> I did not know that you are still using NetBeans 6.5, since NetBeans 6.7 was
> released almost half a year ago.
>

We're not talking about me personally (I don't use any version of
NetBeans), but about what is available in various distributions.  As a
Fedora user, you are probably aware that version 12, which contains
this version of NetBeans, has only just been released, and so it isn't
yet in widespread use.  I would imagine other distributions are the
same; a quick web search shows only the very latest Ubuntu has 6.7 and
Debian is still on 6.0.

Six months is nothing; if we were talking six years, you'd have a point :)

> Bye,
> --
> Tomas Hurka   <mailto:tomas.hurka@...>
> NetBeans Profiler http://profiler.netbeans.org
> VisualVM http://visualvm.dev.java.net
> Software Engineer, Developer Platforms Group
> Sun Microsystems, Praha Czech Republic
>
>
>
>

--
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8