WORDS_BIGENDIAN used inconsistently

[Dwight Kelly]

Hello, the define WORDS_BIGENDIAN is used inconsistently in libtiff
3.9.1 source.

tif_open.c uses:

#ifdef WORDS_BIGENDIAN
..
#else
..
#endif

whereas tif_predict.c uses:

#if WORDS_BIGENDIAN
..
#else
..
#endif

port.h is created by configure script but not used by any source modules.

What is the purpose of having both tif_config.h and tiffconfig.h ?

Sincerely,

--
Dwight Kelly
Apago, Inc.  4080 McGinnis Ferry Rd  Suite 601 Alpharetta, GA 30005
voice:[phone]  fax:[phone]
email: dkelly@... web: http://www.apago.com

_______________________________________________
Tiff mailing list: Tiff@...
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/

[Bob Friesenhahn]

On Fri, 11 Sep 2009, Dwight Kelly wrote:
>
> What is the purpose of having both tif_config.h and tiffconfig.h ?

tif_config.h is used only by the library and libtiff tools and is not
installed.

tiffconfig.h needs to exist for legacy reasons (lots of applications
depend on it).  It includes "feature" defines so that applications can
see what features are in the libtiff when the application is built.
It includes basic type definitions needed by the installed tiff header
files.

Bob
--
Bob Friesenhahn
bfriesen@..., http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
_______________________________________________
Tiff mailing list: Tiff@...
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/

[Dwight Kelly]

Hi Bob,

Should any defines be duplicated in tif_config.h and tiffconfig.h? And
what about port.h created by configure but not used anywhere?


Bob Friesenhahn wrote:

> On Fri, 11 Sep 2009, Dwight Kelly wrote:
>>
>> What is the purpose of having both tif_config.h and tiffconfig.h ?
>
> tif_config.h is used only by the library and libtiff tools and is not
> installed.
>
> tiffconfig.h needs to exist for legacy reasons (lots of applications
> depend on it).  It includes "feature" defines so that applications can
> see what features are in the libtiff when the application is built. It
> includes basic type definitions needed by the installed tiff header
> files.
>

--
Dwight Kelly
Apago, Inc.  4080 McGinnis Ferry Rd  Suite 601 Alpharetta, GA 30005
voice:[phone]  fax:[phone]
email: dkelly@... web: http://www.apago.com

_______________________________________________
Tiff mailing list: Tiff@...
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/

[rob.tillaart]

Hi Bob,

Maybe this explanation should be inserted in the header of both .h files  ...

regards,
rob tillaart

> Bob Friesenhahn wrote:
> > On Fri, 11 Sep 2009, Dwight Kelly wrote:
> >>
> >> What is the purpose of having both tif_config.h and tiffconfig.h ?
> >
> > tif_config.h is used only by the library and libtiff tools and is not
> > installed.
> >
> > tiffconfig.h needs to exist for legacy reasons (lots of applications
> > depend on it).  It includes "feature" defines so that applications can
> > see what features are in the libtiff when the application is built. It
> > includes basic type definitions needed by the installed tiff header
> > files.

_______________________________________________
Tiff mailing list: Tiff@...
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/

[Bob Friesenhahn]

On Fri, 11 Sep 2009, Dwight Kelly wrote:

> Should any defines be duplicated in tif_config.h and tiffconfig.h? And
> what about port.h created by configure but not used anywhere?

Some defines are necessarily duplicated since tiffconf.h is needed by
the installed tiff.h but tif_config.h is only used when building the
library and is not installed.  Is this causing an issue for you?

I am not seeing a port.h created by configure here.

Bob
--
Bob Friesenhahn
bfriesen@..., http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
_______________________________________________
Tiff mailing list: Tiff@...
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/

[Toby Thain-2]

On 11-Sep-09, at 2:26 PM, <rob.tillaart@...> wrote:

>
> Hi Bob,
>
> Maybe this explanation should be inserted in the header of both .h  
> files  ...


+1 :)

--Toby

>
> regards,
> rob tillaart
>
>> Bob Friesenhahn wrote:
>>> On Fri, 11 Sep 2009, Dwight Kelly wrote:
>>>>
>>>> What is the purpose of having both tif_config.h and tiffconfig.h ?
>>>
>>> tif_config.h is used only by the library and libtiff tools and is  
>>> not
>>> installed.
>>>
>>> tiffconfig.h needs to exist for legacy reasons (lots of applications
>>> depend on it).  It includes "feature" defines so that  
>>> applications can
>>> see what features are in the libtiff when the application is  
>>> built. It
>>> includes basic type definitions needed by the installed tiff header
>>> files.
>
> _______________________________________________
> Tiff mailing list: Tiff@...
> http://lists.maptools.org/mailman/listinfo/tiff
> http://www.remotesensing.org/libtiff/

_______________________________________________
Tiff mailing list: Tiff@...
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/