WagonManager discussion archive.

[Joakim Erdfelt-2]

This is just a way to get everyone interested in the WagonManager
debate, to see the prior discussions about it from IRC.  (I log everything)

#maven

Feb 07 19:07:58 <joakim>    big wagon update arriving ...
Feb 07 20:05:23 <jvanzyl>    joakim: there is a WagonManager in
maven-artifact you might want to look at
Feb 07 20:05:23 <jvanzyl>    merge tem
Feb 07 20:05:28 <jvanzyl>    them
Feb 07 20:15:42 <joakim>    jvanzyl, I plan to.

#plexus

Feb 08 13:01:46 <joakim>    jvanzyl_, if you feel like it, my next 2
tasks are to bolt in WagonManager into components/trunk and then
untangle the big ball of mud that is archiva.
Feb 08 13:01:58 <kenney>    that probably means it's marked as a
svn:copy-from location + revision where revision doesn't exist..
probably some local svn mv/cp from a file that hasn't been committed
Feb 08 13:03:47 <jvanzyl_>    yah, i'm sure you'll find the same thing i
did with archiva
Feb 08 13:04:42 <kenney>    joakim: try throwing it to a wall, real
hard, it'll get flatter
Feb 08 13:05:06 <jvanzyl_>    i'm going to put in what i have as soon as
i can but i basically tossed it all
Feb 08 13:05:21 <jvanzyl_>    the scanning is wrong, the reporting is
wrong, and using lucene as a database is wrong

#maven

Feb 09 12:30:01 <joakim>    does components/trunk mostly work right now?
Feb 09 12:35:21 <jvanzyl>    yes
Feb 09 12:35:29 <jvanzyl>    been building with it for quite a while now
Feb 09 12:43:00 <joakim>    I created an ArtifactManager with a *much*
simpler interface, its implementation uses the WagonManager (now in the
wagon subproject).
Feb 09 12:43:25 <joakim>    left the old WagonManager interface inplace,
(for now), and just have it call the new stuff.  turned it into a facade.

Feb 26 16:54:34 <joakim>    jdcasey, ya
Feb 26 16:54:59 <jdcasey>    joakim: I was just wondering where the
AuthenticationInfo-handling went when you moved the wagon-manager over
Feb 26 16:55:41 <joakim>    It's in the WagonManager now.
Feb 26 16:55:55 <joakim>    let it handle the authn and binding to a repo.
Feb 26 16:56:03 <joakim>    don't pass it into the Wagon impl itself.
Feb 26 16:56:13 <jdcasey>    and are the server's in the settings bound
to the wagon manager still?
Feb 26 16:56:21 <jdcasey>    I'm trying to find out where that is
Feb 26 16:57:02 <joakim>    context switching. one moment ...
Feb 26 16:57:30 <jdcasey>    sorry, thanks
Feb 26 16:57:43 <jdcasey>    I don't see anything adding to the
RepositorySettings ...
Feb 26 16:58:06 <joakim>    RepositorySettings are lazy created.
Feb 26 16:58:20 <joakim>    once an Id is requested, the settings is
created. a place holder.
Feb 26 16:58:31 <jdcasey>    yeah, but how does it retrieve the authn info?
Feb 26 16:58:37 <jdcasey>    from the maven settings, I mean?
Feb 26 16:58:53 <joakim>    it was injected before. but jason has been
refactoring that a bit lately.
Feb 26 16:59:20 <joakim>    he's working on decoupling the settings
handling, so that it doesn't infect the rest of the modules.
Feb 26 16:59:22 <jdcasey>    do you know where that injection happened?
Feb 26 16:59:37 <jdcasey>    there used to be a method in DefaultMaven
to mod the wagon manager directly
Feb 26 16:59:41 <jdcasey>    that option's gone now
Feb 26 16:59:48 <jdcasey>    so it's more than injection that has changed
Feb 26 17:00:45 <joakim>    
DefaultMavenExecutionRequestDefaultsPopulator.resolveParameters(Settings)
Feb 26 17:01:09 <joakim>    line 222.
Feb 26 17:01:14 <jdcasey>    hmm,ok
Feb 26 17:01:17 <jdcasey>    thanks

Mar 02 11:08:49 <jvanzyl>    joakim: one change i would like to make is
to make WagonManager threadsafe
Mar 02 11:09:16 <jvanzyl>    manage anything like repositories inside
maven and use a method with everything needed on a per request basis
Mar 02 11:10:21 <jvanzyl>    the repositories and transfer listener used
on each request
Mar 02 11:23:04 <jdcasey>    jvanzyl: are you talking about for the next
dev iteration (re: wagon-manager)?
Mar 02 11:23:12 <jvanzyl>    yes
Mar 02 11:23:18 <jdcasey>    ah, cool
Mar 02 11:23:21 <jdcasey>    agreed

Mar 02 15:09:43 <jvanzyl>    joakim: is there any reason you didn't
remove WagonManager from trunk and use the one in wagon
Mar 02 15:10:01 <jvanzyl>    i'm just tracking down a problme where all
my transfer listeners i set are now not working
Mar 02 15:10:02 <joakim>    jvanzyl, no other reason than for backwards
compat.
Mar 02 15:10:08 <jvanzyl>    with what?
Mar 02 15:10:23 <joakim>    nothing specific.
Mar 02 15:10:27 <joakim>    feel free to remove it if you want.
Mar 02 15:10:31 <joakim>    i have no attachment to it.
Mar 02 15:10:49 <jvanzyl>    i just wondering what code might look it up
and use it
Mar 02 15:11:24 <joakim>    i haven't spent enough time analyzing the
plugins / mojo / continuum / archiva for use of that object.
Mar 02 15:12:13 *    joakim opens up his maven-universe eclipse
workspace and looks around ...
Mar 02 15:13:35 <jvanzyl>    the deploy plugin and the idea plugin
Mar 02 15:13:39 <jvanzyl>    for the love of god
Mar 02 15:13:53 <jvanzyl>    the site plugin
Mar 02 15:14:05 <jvanzyl>    maven project info
Mar 02 15:14:12 <joakim>    heh. just a few important ones.
Mar 02 15:15:10 <joakim>    if we remove that object, then those plugins
are no longer backwards compat. they would be 2.1+ from that point forward.
Mar 02 15:16:00 <joakim>    maven-project test cases use it.
Mar 02 15:16:07 <joakim>    so do a few continuum-notifiers.
Mar 02 15:19:56 <joakim>    i wonder if we should create a
maven-2.0.x-backwards-compatibility module that just maps to the new 2.1
code.
Mar 02 15:20:23 <jdcasey>    joakim, jvanzyl: what about reinstating the
old WagonManager, and making it a facade to the new one?
Mar 02 15:20:23 <jdcasey>    would that help?
Mar 02 15:20:31 <jvanzyl>    i am backing out the new wagon stuff for now
Mar 02 15:20:56 <joakim>    jdcasey, that's what I did in components/trunk
Mar 02 15:20:57 <jvanzyl>    i wanted to keep it but it needs to be
tested more
Mar 02 15:21:25 <jdcasey>    jvanzyl: can we branch it off and then
rollback?
Mar 02 15:21:31 <jdcasey>    that way there's a place to keep pushing
Mar 02 15:21:38 <joakim>    jdcasey, the old WagonManager was just an
interface, DefaultWagonManager (in maven-artifact-manager) was gutted to
talk to the new one.
Mar 02 15:21:49 <jdcasey>    joakim: yeah, that's what I meant...ok
Mar 02 15:21:59 <jdcasey>    I thought DefaultArtifactManager talked
directly to the wagon-manager stuff
Mar 02 15:22:02 <jdcasey>    ?
Mar 02 15:22:10 <jdcasey>    DefaultArtifactMgr is new, I thought
Mar 02 15:22:12 <jdcasey>    no?
Mar 02 15:22:25 <joakim>    jvanzyl, can you branch before rollback please?
Mar 02 15:22:39 <jvanzyl>    go ahead
Mar 02 15:23:28 <jvanzyl>    i'll help you write tests for the new
stuff, i want to use it
Mar 02 15:23:35 <joakim>    k
Mar 02 15:24:15 <jvanzyl>    it's got some weird coupling to plexus with
the extension container and and i'll add some tests for the transfer
listener stuff
Mar 02 15:24:27 <joakim>    k.
Mar 02 15:24:43 <joakim>    i modified the transfer listener handling to
be a list vs the single instance it was before.
Mar 02 15:26:58 <jvanzyl>    we should probably just roll back in wagon
to before your changes and release it
Mar 02 15:27:01 <jvanzyl>    and then move on
Mar 02 15:27:07 <jvanzyl>    we can't do that stuff in beta
Mar 02 15:27:15 <jvanzyl>    even though we haven't touched it in forever
Mar 02 15:27:21 <jvanzyl>    let's just boot it out and then fix ti
Mar 02 15:27:32 <joakim>    sounds fair.
Mar 02 15:28:01 <joakim>    then the next wagon will be a bigger change
than we talked about. ;-)
Mar 02 15:28:09 <joakim>    there's a handful of legitimate fixes
elsewhere in wagon.
Mar 02 15:28:27 <joakim>    for existing bugs (pre-wagon-manager)
Mar 02 15:29:41 <jvanzyl>    when you have a block of time again i will
help you
Mar 02 15:31:27 <joakim>    k
Mar 02 15:32:17 <joakim>    other than HTTP error 500, what other
reponse codes cause a repository blacklisting?
Mar 02 15:34:55 <jvanzyl>    unless you have time now and want to track
down the transfer listener problem
Mar 02 15:35:00 <jvanzyl>    otherwise i have to roll back
Mar 02 15:35:31 <jvanzyl>    i've check my end and it's going in live
and there are no container problems, only one instance of the wagon manager
Mar 02 15:35:35 <joakim>    jvanzyl, i created
https://svn.apache.org/repos/asf/maven/components/branches/maven-wagon-ng
Mar 02 15:35:42 <joakim>    what's going on, and from where?
Mar 02 15:36:16 <jvanzyl>    the console download monitor does nothing,
and eu says the listener doesn't work in the eclipse plugin
Mar 02 15:36:45 <joakim>    "eclipse plugin" being m2eclipse?
Mar 02 15:36:58 <jvanzyl>    the live console download monitor goes in
live and does nothing afterward
Mar 02 15:37:01 <jvanzyl>    we can focus on teh cli
Mar 02 15:37:08 <joakim>    k
Mar 02 15:37:37 <joakim>    updating ...
Mar 02 15:37:57 <jvanzyl>    one second i have a bunch of stuff
Mar 02 15:38:20 <joakim>    i'm finishing up some other work too.
Mar 02 15:38:24 <joakim>    be right on it (today)
Mar 02 15:39:38 <jvanzyl>    there it's in
Mar 02 15:40:19 <jvanzyl>    the only place i add stuff to the wagon
manager is in
http://svn.apache.org/repos/asf/maven/components/trunk/maven-embedder/src/main/java/org/apache/maven/embedder/execution/DefaultMavenExecutionRequestDefaultsPopulator.java
Mar 02 15:40:50 <joakim>    components/trunk doesn't compile.  
maven-core depends on maven-tools (which got removed)
Mar 02 15:41:13 <jvanzyl>    doesn't need it anymore
Mar 02 15:41:51 <jvanzyl>    grep -r MavenTools *   yields nada
Mar 02 15:41:57 <jvanzyl>    in maven-core
Mar 02 15:42:37 <jvanzyl>    we've been bootstrapping today
Mar 02 15:43:01 <jvanzyl>    joakim: you going to be at eclipsecon?
Mar 02 15:43:09 <joakim>    nope. sorry.
Mar 02 15:43:25 <joakim>    i thought it was going on right now. (to
show you how much i'm paying attention. heh)

--
- Joakim Erdfelt
  joakim@...
  Open Source Software (OSS) Developer


---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@...
For additional commands, e-mail: wagon-dev-help@...