Waypoint Mobility model

[Faker Moatamri]

Hi Phillip,
Did you apply the requested changes? Can you please proceed with the
merging of your code into the main stream ns-3-dev?
Best regards
Faker Moatamri

[Phillip Sitbon]

Hello,

> Did you apply the requested changes?

I just made one last change to address Mathieu's comments, and the
only things left are tests/examples which I am doing my best to make
time for.

> Can you please proceed with the merging
> of your code into the main stream ns-3-dev?

I'm not quite sure how to go about that; I'm new to mecrurial, so my
best guess would be that I can upload or commit it myself? Sorry if
I'm missing any helpful details on the website...

Cheers,

  - Phillip

[Faker Moatamri]

Phillip Sitbon wrote:

> Hello,
>
>  
>> Did you apply the requested changes?
>>    
>
> I just made one last change to address Mathieu's comments, and the
> only things left are tests/examples which I am doing my best to make
> time for.
>
>  

Ok, we have 9 days left for merging.
>> Can you please proceed with the merging
>> of your code into the main stream ns-3-dev?
>>    
>
> I'm not quite sure how to go about that; I'm new to mecrurial, so my
> best guess would be that I can upload or commit it myself? Sorry if
> I'm missing any helpful details on the website...
>  
Usually, you use your local mercurial repository, you commit your
changes (hg ci) with good comments.
You download the latest ns-3-dev code: hg pull
You merge if needed: hg merge
Then you push to the server if you have the right acces rights, do you?:
hg push ssh://code@...//home/code/repos/ns-3-dev
If you can't push, you just generate a patch after hg merge and send it
to me and I will upload it to the server.
Best regards
Faker Moatamri
> Cheers,
>
>   - Phillip
>  

[Faker Moatamri]

Hi Phillip,
I added your patch to the mainstream ns-3-dev, I changed the class
waypoint.h/cc to make the member variable names according to the
standard m_time and m_position instead of time and position and I made
them private. I added accessor functions. As I told you class member
variables should always be private or protected so that the class can
control the values that can be set to.
Please update your repo and keep on working on tests and examples.
Best regards
Faker Moatamri

[Phillip Sitbon]

Faker,

Please refer to my comments on that topic in Rietveld- Waypoint is
meant to be a data structure, and I was merely following the style of
many other object types by using the 'class' keyword. If you insist on
the changes, I'd rather pull the Waypoint type entirely and make it
internal to WaypointMobilityModel.

Also, please note that Time and Vector are the only things holding
data, Waypoint doesn't need to maintain anything about them; for this
reason, there is no error checking necessary in this class. I believe
private members & accessors are an unnecessary level of indirection
and don't fit with the design of other data structures in ns-3.

Hope this clarifies things a bit.


Cheers,

   Phillip

On Tue, Nov 10, 2009 at 4:39 AM, Faker Moatamri
<faker.moatamri@...> wrote:

> Hi Phillip,
> I added your patch to the mainstream ns-3-dev, I changed the class
> waypoint.h/cc to make the member variable names according to the standard
> m_time and m_position instead of time and position and I made them private.
> I added accessor functions. As I told you class member variables should
> always be private or protected so that the class can control the values that
> can be set to.
> Please update your repo and keep on working on tests and examples.
> Best regards
> Faker Moatamri
>

[Faker Moatamri]

> Faker,
>
> Please refer to my comments on that topic in Rietveld- Waypoint is
> meant to be a data structure, and I was merely following the style of
> many other object types by using the 'class' keyword. If you insist on
> the changes, I'd rather pull the Waypoint type entirely and make it
> internal to WaypointMobilityModel.
>
> Also, please note that Time and Vector are the only things holding
> data, Waypoint doesn't need to maintain anything about them; for this
> reason, there is no error checking necessary in this class. I believe
> private members & accessors are an unnecessary level of indirection
> and don't fit with the design of other data structures in ns-3.

Ok I will put it back as it was as soon as possible.
Regards
Faker Moatamri

>
> Hope this clarifies things a bit.
>
>
> Cheers,
>
>    Phillip
>
> On Tue, Nov 10, 2009 at 4:39 AM, Faker Moatamri
> <faker.moatamri@...> wrote:
>> Hi Phillip,
>> I added your patch to the mainstream ns-3-dev, I changed the class
>> waypoint.h/cc to make the member variable names according to the
>> standard
>> m_time and m_position instead of time and position and I made them
>> private.
>> I added accessor functions. As I told you class member variables should
>> always be private or protected so that the class can control the values
>> that
>> can be set to.
>> Please update your repo and keep on working on tests and examples.
>> Best regards
>> Faker Moatamri
>>
>

[Mathieu Lacage]

On Tue, 2009-11-10 at 08:11 -0800, Phillip Sitbon wrote:

> Also, please note that Time and Vector are the only things holding
> data, Waypoint doesn't need to maintain anything about them; for this
> reason, there is no error checking necessary in this class. I believe
> private members & accessors are an unnecessary level of indirection
> and don't fit with the design of other data structures in ns-3.

+1

[Faker Moatamri]

>>
>> Also, please note that Time and Vector are the only things holding
>> data, Waypoint doesn't need to maintain anything about them; for this
>> reason, there is no error checking necessary in this class. I believe
>> private members & accessors are an unnecessary level of indirection
>> and don't fit with the design of other data structures in ns-3.

> Ok I will put it back as it was as soon as possible.

Done

[Faker Moatamri]

> On Tue, 2009-11-10 at 08:11 -0800, Phillip Sitbon wrote:
>
>> Also, please note that Time and Vector are the only things holding
>> data, Waypoint doesn't need to maintain anything about them; for this
>> reason, there is no error checking necessary in this class. I believe
>> private members & accessors are an unnecessary level of indirection
>> and don't fit with the design of other data structures in ns-3.
>
> +1
>

Done