Weird error for the advapi32/eventlog tests on Vista+ when running winetest

[Paul Vriens-2]

Hi,

Just noticed that we have 1 test failure on Vista+ for the
advapi32/eventlog tests. I was sure I've tested these from Win95 up to Win7.

When I run tests I want to do this as Administrator, so on Vista+ I
select 'Run as Administrator' to start a command prompt, or to launch
winetest.

Running the mentioned crosscompiled tests is no problem unless you do
this from the actual home directory (or any subdirectory) of the user
that logged in.

Winetest runs most of it's test in the %TEMP% directory and hence we see
this failure. But I have no clue why (yet).

Anyone?

--
Cheers,

Paul.

[Reece Dunn-2]

2009/11/4 Paul Vriens <paul.vriens.wine@...>:

> Hi,
>
> Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog
> tests. I was sure I've tested these from Win95 up to Win7.
>
> When I run tests I want to do this as Administrator, so on Vista+ I select
> 'Run as Administrator' to start a command prompt, or to launch winetest.
>
> Running the mentioned crosscompiled tests is no problem unless you do this
> from the actual home directory (or any subdirectory) of the user that logged
> in.
>
> Winetest runs most of it's test in the %TEMP% directory and hence we see
> this failure. But I have no clue why (yet).
>
> Anyone?

What are the errors you are experiencing?

Are you getting access denied errors? If so, it may be due to the
different file access permissions. What happens when you create/delete
the files produced by winetest in the %TEMP% directory in the explorer
GUI?

Do you get/need a UAC prompt for it to work? Have you tried adding UAC
information to the manifest if this is the case?

Sorry I can't help out any further as I abandoned Vista a long time ago ^_^.

- Reece

[Reece Dunn-2]

2009/11/4 Paul Vriens <paul.vriens.wine@...>:

> Hi,
>
> Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog
> tests. I was sure I've tested these from Win95 up to Win7.
>
> When I run tests I want to do this as Administrator, so on Vista+ I select
> 'Run as Administrator' to start a command prompt, or to launch winetest.
>
> Running the mentioned crosscompiled tests is no problem unless you do this
> from the actual home directory (or any subdirectory) of the user that logged
> in.
>
> Winetest runs most of it's test in the %TEMP% directory and hence we see
> this failure. But I have no clue why (yet).
>
> Anyone?

Ah, I see. This is the failure on test.winehq.org, correct?

    eventlog.c:586: Test failed: Expected ERROR_INVALID_HANDLE, got 5

5 is ERROR_ACCESS_DENIED.

The create_backup function does not have any error checking -- what
happens when you put the return values for these calls, and the
GetLastError in ok checks, e.g.

    ok(DeleteFileA(filename), "error deleting the backup event log file");
    ok(GetLastError() == 0, "GetLastError -- expected ERROR_SUCCESS,
got %d", GetLastError());

- Reece

[Paul Vriens-2]

On 11/04/2009 09:45 PM, Reece Dunn wrote:

> 2009/11/4 Paul Vriens<paul.vriens.wine@...>:
>> Hi,
>>
>> Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog
>> tests. I was sure I've tested these from Win95 up to Win7.
>>
>> When I run tests I want to do this as Administrator, so on Vista+ I select
>> 'Run as Administrator' to start a command prompt, or to launch winetest.
>>
>> Running the mentioned crosscompiled tests is no problem unless you do this
>> from the actual home directory (or any subdirectory) of the user that logged
>> in.
>>
>> Winetest runs most of it's test in the %TEMP% directory and hence we see
>> this failure. But I have no clue why (yet).
>>
>> Anyone?
>

Hi Reece,

> Ah, I see. This is the failure on test.winehq.org, correct?

Yes. I'm in the process of writing loads of eventlog tests while keeping
track of possible failures on test.winehq.org.

>
>      eventlog.c:586: Test failed: Expected ERROR_INVALID_HANDLE, got 5
>
> 5 is ERROR_ACCESS_DENIED.
>
> The create_backup function does not have any error checking -- what
> happens when you put the return values for these calls, and the
> GetLastError in ok checks, e.g.
>
>      ok(DeleteFileA(filename), "error deleting the backup event log file");
>      ok(GetLastError() == 0, "GetLastError -- expected ERROR_SUCCESS,
> got %d", GetLastError());
>
> - Reece

Deleting the file works just fine. both in create_backup() and
test_clear().

What makes it even more weird is that I have the same error when I run
these tests as the user (not admin).

I also don't get any UAC prompts in either case. Turning UAC off doesn't
make a difference.

I don't see any logical explanation why the function returns a different
error. The fact that the function fails anyway makes me consider using a
second possible last error for that particular test.

--
Cheers,

Paul.

[Paul Vriens-2]

On 11/05/2009 10:11 AM, Paul Vriens wrote:

> On 11/04/2009 09:45 PM, Reece Dunn wrote:
>> 2009/11/4 Paul Vriens<paul.vriens.wine@...>:
>>> Hi,
>>>
>>> Just noticed that we have 1 test failure on Vista+ for the
>>> advapi32/eventlog
>>> tests. I was sure I've tested these from Win95 up to Win7.
>>>
>>> When I run tests I want to do this as Administrator, so on Vista+ I
>>> select
>>> 'Run as Administrator' to start a command prompt, or to launch winetest.
>>>
>>> Running the mentioned crosscompiled tests is no problem unless you do
>>> this
>>> from the actual home directory (or any subdirectory) of the user that
>>> logged
>>> in.
>>>
>>> Winetest runs most of it's test in the %TEMP% directory and hence we see
>>> this failure. But I have no clue why (yet).
>>>
>>> Anyone?
>>
>
> Hi Reece,
>
>> Ah, I see. This is the failure on test.winehq.org, correct?
>
> Yes. I'm in the process of writing loads of eventlog tests while keeping
> track of possible failures on test.winehq.org.
>
>>
>> eventlog.c:586: Test failed: Expected ERROR_INVALID_HANDLE, got 5
>>
>> 5 is ERROR_ACCESS_DENIED.
>>
>> The create_backup function does not have any error checking -- what
>> happens when you put the return values for these calls, and the
>> GetLastError in ok checks, e.g.
>>
>> ok(DeleteFileA(filename), "error deleting the backup event log file");
>> ok(GetLastError() == 0, "GetLastError -- expected ERROR_SUCCESS,
>> got %d", GetLastError());
>>
>> - Reece
>
> Deleting the file works just fine. both in create_backup() and
> test_clear().
>
> What makes it even more weird is that I have the same error when I run
> these tests as the user (not admin).
>
> I also don't get any UAC prompts in either case. Turning UAC off doesn't
> make a difference.
>
> I don't see any logical explanation why the function returns a different
> error. The fact that the function fails anyway makes me consider using a
> second possible last error for that particular test.
>

Found it.

The eventlog service runs under an account that doesn't have the
necessary rights for a users home directory. This account is the actual
one performing some of the actions.

--
Cheers,

Paul.