Where to post rotate brushes bugfix?

View: New views
5 Messages — Rating Filter:   Alert me  

Where to post rotate brushes bugfix?

by Tal-15 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I found and solved a new bug in the bilinear rotate transform algorithm that sometimes caused artifacting on brush edges for brushes rotated 90, -90, -180, 180 degrees.

Since the previous bugzilla report http://bugzilla.gnome.org/show_bug.cgi?id=520078 is marked as fixed, what is the best way to proceed and submit the patch?

Should I upload the patch to the existing 520078 bug report or is it worth creating a new bug report just for this bugfix?

Thanks,

Tal

____________________________________________________________
FREE 3D EARTH SCREENSAVER - Watch the Earth right on your desktop!
Check it out at http://www.inbox.com/earth
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Re: Where to post rotate brushes bugfix?

by Alexia Death-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Sep 25, 2009 at 11:42 PM, Tal <taltr@...> wrote:
> I found and solved a new bug in the bilinear rotate transform algorithm that sometimes caused artifacting on brush edges for brushes rotated 90, -90, -180, 180 degrees.
>
> Since the previous bugzilla report http://bugzilla.gnome.org/show_bug.cgi?id=520078 is marked as fixed, what is the best way to proceed and submit the patch?
>
> Should I upload the patch to the existing 520078 bug report or is it worth creating a new bug report just for this bugfix?
>
> Thanks,
>
> Tal
Creating a new bug wit the patch would be best I think ;)
--
--Alexia
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Re: Where to post rotate brushes bugfix?

by Michael Natterer :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, 2009-09-25 at 12:42 -0800, Tal wrote:
> I found and solved a new bug in the bilinear rotate transform algorithm that sometimes caused artifacting on brush edges for brushes rotated 90, -90, -180, 180 degrees.
>
> Since the previous bugzilla report http://bugzilla.gnome.org/show_bug.cgi?id=520078 is marked as fixed, what is the best way to proceed and submit the patch?
>
> Should I upload the patch to the existing 520078 bug report or is it worth creating a new bug report just for this bugfix?

That's good news, please open a new bug for it!

thanks,
--mitch


_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Re: Where to post rotate brushes bugfix?

by Martin Nordholts-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 09/28/2009 10:06 AM, Michael Natterer wrote:
> On Fri, 2009-09-25 at 12:42 -0800, Tal wrote:
>> I found and solved a new bug in the bilinear rotate transform algorithm that sometimes caused artifacting on brush edges for brushes rotated 90, -90, -180, 180 degrees.
>>
>> Since the previous bugzilla report http://bugzilla.gnome.org/show_bug.cgi?id=520078 is marked as fixed, what is the best way to proceed and submit the patch?
>>
>> Should I upload the patch to the existing 520078 bug report or is it worth creating a new bug report just for this bugfix?
>
> That's good news, please open a new bug for it!

There is one already:
https://bugzilla.gnome.org/show_bug.cgi?id=596472

 / Martin

--

My GIMP Blog:
http://www.chromecode.com/

_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Re: Where to post rotate brushes bugfix?

by Tal-15 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Thanks for the replies everyone. I've just uploaded to bugzilla a patch that fixes the remaining issue introduced by the first bugfix patch. This patch needs to be applied after the first one. It seems to work fine now. https://bugzilla.gnome.org/show_bug.cgi?id=596472

Regards,

Tal


> -----Original Message-----
> From: taltr@...
> Sent: Fri, 25 Sep 2009 12:42:29 -0800
> To: gimp-developer@...
> Subject: [Gimp-developer] Where to post rotate brushes bugfix?
>
> I found and solved a new bug in the bilinear rotate transform algorithm
> that sometimes caused artifacting on brush edges for brushes rotated 90,
> -90, -180, 180 degrees.
>
> Since the previous bugzilla report
> http://bugzilla.gnome.org/show_bug.cgi?id=520078 is marked as fixed, what
> is the best way to proceed and submit the patch?
>
> Should I upload the patch to the existing 520078 bug report or is it
> worth creating a new bug report just for this bugfix?
>
> Thanks,
>
> Tal
>
> ____________________________________________________________
> FREE 3D EARTH SCREENSAVER - Watch the Earth right on your desktop!
> Check it out at http://www.inbox.com/earth
> _______________________________________________
> Gimp-developer mailing list
> Gimp-developer@...
> https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

____________________________________________________________
FREE ONLINE PHOTOSHARING - Share your photos online with your friends and family!
Visit http://www.inbox.com/photosharing to find out more!
_______________________________________________
Gimp-developer mailing list
Gimp-developer@...
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer