Nabble - Wordpress Hackers

Re: custom Edit Pages screens

2009-11-09T12:34:41Z

Thanks. I was trying to stick with pure CSS to avoid the lag you
sometimes get altering CSS with JS. It might be the only option...

But out of curiosity, what are the CSS 3 selectors for this? I can't
find much out there to see if there's any browser support.

Steve

2009/11/9 Charles K. Clarkson <cclarkson@...>:

> Steve Taylor wrote:
>>
>> Only problem left is the annoying bold "Parent Page: ..." markers that
>> are output. I've been trying in vain to hide them with CSS, but
>> selecting inner text but not child elements seems impossible. This is
>> the markup:
>>
>> <strong><a title="Edit [page title]" href="[edit link]"
>> class="row-title">— — [page title]</a> | Parent Page: [parent
>> title]</strong>
>
> jQuery is CSS 3 compliant and has functions to target inner text and html.
>
>
>
> HTH,
>
> Charles Clarkson
> --
> Mobile Home Investor
> Free Market Advocate
> Programmer
>
> I'm not really a smart person. I just play one on the Internet.
>
> Stephenville, TX
> http://www.clarksonenergyhomes.com/wordpress/about/
> http://twitter.com/CharlesClarkson
> +1 (254) 968-8328
>
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers
>

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: SEO, How to turn off paged comments for search engine crawlers?

2009-11-09T12:30:46Z

or 7th: all comments on one page, use jQuery to collapse/psuedo-paginate
comments.
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: custom Edit Pages screens

2009-11-09T12:27:56Z

Steve Taylor wrote:
> Only problem left is the annoying bold "Parent Page: ..." markers that
> are output. I've been trying in vain to hide them with CSS, but
> selecting inner text but not child elements seems impossible. This is
> the markup:
>
> <strong><a title="Edit [page title]" href="[edit link]"
> class="row-title">— — [page title]</a> | Parent Page: [parent
> title]</strong>

jQuery is CSS 3 compliant and has functions to target inner text and html.

HTH,

Charles Clarkson
--
Mobile Home Investor
Free Market Advocate
Programmer

I'm not really a smart person. I just play one on the Internet.

Stephenville, TX
http://www.clarksonenergyhomes.com/wordpress/about/
http://twitter.com/CharlesClarkson
+1 (254) 968-8328

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: custom Edit Pages screens

2009-11-09T08:14:32Z

> You could manually get all the child page IDs and put them as 'post__in'.

That works! Wasn't familiar with these under-the-hood paramters for a
query that aren't exposed by get_pages() etc.

Only problem left is the annoying bold "Parent Page: ..." markers that
are output. I've been trying in vain to hide them with CSS, but
selecting inner text but not child elements seems impossible. This is
the markup:

<strong><a title="Edit [page title]" href="[edit link]"
class="row-title">— — [page title]</a> | Parent Page: [parent
title]</strong>

I tried:

table.page td.page-title strong { display: none; }
table.page td.page-title strong a { display: inline !important; }

But no luck. This kind of works:

table.page td.page-title strong { visibility: hidden; }
table.page td.page-title strong a { visibility: visible !important; }

But obviously there's random blank space everywhere.

Well, it probably would have taken less time by now to build my own
page from the ground up. Ah well! I have to leave this for now...
Thanks for the hints.

Steve
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: custom Edit Pages screens

2009-11-09T01:48:04Z

On Mon, Nov 9, 2009 at 1:53 AM, Steve Taylor <steve@...> wrote:

> scribu, thanks for the tip - I'm experimenting now. So far the major
> issue is that adding post_parent as a query_var returns *only*
> immediate children of that page - and none of the other descendents.
> Any ideas? I can't see an obvious query_var to set. I imagine the
> get_pages() parameters are irrelevent here?
>

You could manually get all the child page IDs and put them as 'post__in'.

--
http://scribu.net
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: body hook for add_filter ?

2009-11-08T23:37:21Z

>
> Is there a hook I can use in add_filter() that will return the entire
> contents within the body tags?
>

Check out PHP object buffering,
http://www.php.net/manual/en/ref.outcontrol.php. You can run ob_start (with
a callback) in wp_head.
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

body hook for add_filter ?

2009-11-08T23:24:48Z

Is there a hook I can use in add_filter() that will return the entire
contents within the body tags?

somthing like add_filter('entire_body_content', myfunc);

I didn't see anything in the codex, so thought I'd run it by you guys
first before I use a series of add_filter()'s for a variety of hooks.

Thanks

Matt

--
~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~
Matthew Kettlewell - aka "The Dominator"
~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~
http://www.BloggingEmergency.com/

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: SEO, How to turn off paged comments for search engine crawlers?

2009-11-08T17:23:13Z

On Nov 8, 2009, at 6:20 PM, scribu wrote:

> Mike, I think your suggestion is already implemented by the SEO Super
> Comments<http://www.prelovac.com/vladimir/wordpress-plugins/seo-super-comments
> >plugin.

Cool.

Be nice if the approach because a standard pattern vs. obscurely
implemented. I can't tell you how many times I've wanted to link to a
specific comment in a tweet, for example. Standard patterns would
empower many more blogs to enable that.

-Mike Schinkel
WordPress Custom Plugins
http://mikeschinkel.com/custom-wordpress-plugins/

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: custom Edit Pages screens

2009-11-08T15:53:55Z

Thanks Jeremy, the pageMash plugin is fantastic. Definitely a fine
replacement for My Page Order.

However, as you say, it's probably not ideal for me. The whole idea is
to be able to go to a list that only deals with a certain page's
descendents. pageMash makes it a little easier than WP's pagination,
but I assume it'll slow down when there's a lot of pages.

scribu, thanks for the tip - I'm experimenting now. So far the major
issue is that adding post_parent as a query_var returns *only*
immediate children of that page - and none of the other descendents.
Any ideas? I can't see an obvious query_var to set. I imagine the
get_pages() parameters are irrelevent here?

Steve

2009/11/8 Jeremy Clarke <jer@...>:

> On Sat, Nov 7, 2009 at 4:11 PM, Steve Taylor <steve@...> wrote:
>> After looking into edit-pages.php for a while, I can't see an obvious
>> way to use this code (hooks, includes, whatever). I'm heading towards
>> copying it wholesale and tweaking. Anyone got a better idea?
>
> I have to recommend the Pagemash plugin:
> http://wordpress.org/extend/plugins/pagemash/
>
> It might not be the best solution for your particular situation since
> it puts all pages on one screen, but if your browser can handle it its
> incredibly powerful. IMHO its 'the missing page management tool' for
> people who have a complex hierarchy, and if it ever breaks you're not
> really any worse off than before, it just gives you a better way to
> control things than Pages > Edit.
>
> --
> Jeremy Clarke | http://jeremyclarke.org
> Code and Design | http://globalvoicesonline.org
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers
>

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: SEO, How to turn off paged comments for search engine crawlers?

2009-11-08T15:20:30Z

Mike, I think your suggestion is already implemented by the SEO Super
Comments<http://www.prelovac.com/vladimir/wordpress-plugins/seo-super-comments>plugin.

--
http://scribu.net
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: Codex Question

2009-11-08T15:02:05Z

2009/11/9 Eric Marden <wp@...>

> I found a section of the codex that encourages a core hack to customize the
> Read More link:
>
> http://codex.wordpress.org/Customizing_the_Read_More#Link_Jumps_to_More_or_Top_of_Page
>
> Should I leave it for legacy reasons, or edit it out?
>

I'd remove it. There's information given on how to override the default in
the theme's functions.php (which should stay) but the Codex, IMO, should not
be encouraging core hacks. The core hacks are for WP 2.7.1 and lower and
WordPress has moved on from there. If you want to preserve it for legacy
purposes it would probably be better off being copied into a forum thread so
anyone searching for outdated info for some reason, can still find it.

Lynne
--
http://twitter.com/elpie/
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Codex Question

2009-11-08T14:09:45Z

I found a section of the codex that encourages a core hack to
customize the Read More link:
http://codex.wordpress.org/Customizing_the_Read_More#Link_Jumps_to_More_or_Top_of_Page

Should I leave it for legacy reasons, or edit it out?

- Eric Marden
__________________________________
http://xentek.net/code/wordpress/
tw: @xentek

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: SEO, How to turn off paged comments for search engine crawlers?

2009-11-08T13:31:01Z

On Nov 8, 2009, at 11:50 AM, Joost de Valk wrote:
> 6 is not going to work: canonical is meant to distinguish the one
> "true" (canonical) version of a document from copies of it. Giving
> each comment its own page would make each comment completely
> different from the original article, and thus wouldn't work with
> the canonical tag.

You misunderstood my suggestion. I apologize for not stating it
clearly enough. I'll use examples this time (these URLs are examples,
not exact):

Assume a post called "My Post" with 25 comments and 10 comments per
page. You'd potentially have URLs of:

http://www.example.com/my-post/
http://www.example.com/my-post/comments/page-1/
http://www.example.com/my-post/comments/page-2/

Each of these would have a rel=canoncial that pointed to:

http://www.example.com/my-post/

In addition, you'd have 25 URL that look like this:

http://www.example.com/my-post/comments/1/
http://www.example.com/my-post/comments/2/
http://www.example.com/my-post/comments/3/
...
http://www.example.com/my-post/comments/25/

These pages would each have just one comment and would have a title
being the first sentence of the comment and these pages would have
links back to the post and they would NOT use rel=canonical.

There is significant benefit to this approach:

-- More pages means more SEO surface area,

-- More comments mean more URLs pointing back to the main post each
passing a bit of page rank,

-- Unique pages for the comments so that really good comments can draw
search engine traffic of their own,

-- Unique comment pages allow people on social media and blogs to link
directly to specific comments without confusing the people following
the links with the other comments, and

-- In general, whenever possible, it's good to have a real link to
each unique piece of content and a comment is a unique piece of content.

I hope that clarifies why my 6th option was not invalid as it appeared
to be given my initial terse suggestion.

-Mike Schinkel
WordPress Custom Plugins
http://mikeschinkel.com/custom-wordpress-plugins/

P.S. We could also <IFRAME> the canonical URL (i.e. http://www.example.com/my-post/
) and use HTTP_REFERER to known when to serve up only the raw content
and thus allow all URLs shown above to have the content displayed for
context but not have it duplicated anywhere.

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: SEO, How to turn off paged comments for search engine crawlers?

2009-11-08T11:50:15Z

Both solution 5 & 6 won't work.

5 is cloaking, which is considered illegal by the search engines and
I'd highly advise against it.

6 is not going to work: canonical is meant to distinguish the one
"true" (canonical) version of a document from copies of it. Giving
each comment its own page would make each comment completely different
from the original article, and thus wouldn't work with the canonical
tag.

To be honest there's only one real solution: disabling paged comments
altogether. Even using the canonical tag on sub pages with other
comments is a lousy solution.

Cheers,
Joost

Joost de Valk

Sent from my iPhone

On Nov 8, 2009, at 20:29, Mike Schinkel <mikeschinkel@...>
wrote:

> Using rel="canonical" and then setting up a page that displays each
> comment by itself with a link back to its post to pass pagerank is a
> 6th solution.
>
> -Mike Schinkel
> WordPress Custom Plugins
> http://mikeschinkel.com/custom-wordpress-plugins/
>
>
> On Nov 8, 2009, at 11:17 AM, William Canino wrote:
>
>> Paged comments introduce two SEO problems:
>>
>> 1. the article appears as duplicate content across several URLs
>> 2. the pagerank is diluted across several URLs.
>>
>> Four people have suggested solutions to this:
>>
>> 1. have all but the main permalink show an excerpt of the post,
>> 2. add meta noindex nofollow to pages with older comments
>> 3. add " - comment page $cpage" to the titles of pages with paged
>> comments
>> 4. hack paginate_comments_links, previous_comments_link() and
>> next_comments_link() to add the nofollow tag
>>
>> Comments contain precious content sometimes. and it's a shame if the
>> search engines can't find and point to them.
>>
>> I am thinking of a fifth solution, and would like your opinion.
>>
>> 5. only if useragent is a search engine crawler,
>> a. turn off comment paging on the main permalink
>> a. 301 redirect the pages with older comments to the main permalink,
>> yet maintaining the #comment-id.
>>
>> Which one do you think would work best?
>>
>> W
>> _______________________________________________
>> wp-hackers mailing list
>> wp-hackers@...
>> http://lists.automattic.com/mailman/listinfo/wp-hackers
>
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: SEO, How to turn off paged comments for search engine crawlers?

2009-11-08T11:29:40Z

Using rel="canonical" and then setting up a page that displays each
comment by itself with a link back to its post to pass pagerank is a
6th solution.

-Mike Schinkel
WordPress Custom Plugins
http://mikeschinkel.com/custom-wordpress-plugins/

On Nov 8, 2009, at 11:17 AM, William Canino wrote:

> Paged comments introduce two SEO problems:
>
> 1. the article appears as duplicate content across several URLs
> 2. the pagerank is diluted across several URLs.
>
> Four people have suggested solutions to this:
>
> 1. have all but the main permalink show an excerpt of the post,
> 2. add meta noindex nofollow to pages with older comments
> 3. add " - comment page $cpage" to the titles of pages with paged
> comments
> 4. hack paginate_comments_links, previous_comments_link() and
> next_comments_link() to add the nofollow tag
>
> Comments contain precious content sometimes. and it's a shame if the
> search engines can't find and point to them.
>
> I am thinking of a fifth solution, and would like your opinion.
>
> 5. only if useragent is a search engine crawler,
> a. turn off comment paging on the main permalink
> a. 301 redirect the pages with older comments to the main permalink,
> yet maintaining the #comment-id.
>
> Which one do you think would work best?
>
> W
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

SEO, How to turn off paged comments for search engine crawlers?

2009-11-08T11:17:09Z

Paged comments introduce two SEO problems:

1. the article appears as duplicate content across several URLs
2. the pagerank is diluted across several URLs.

Four people have suggested solutions to this:

1. have all but the main permalink show an excerpt of the post,
2. add meta noindex nofollow to pages with older comments
3. add " - comment page $cpage" to the titles of pages with paged comments
4. hack paginate_comments_links, previous_comments_link() and
next_comments_link() to add the nofollow tag

Comments contain precious content sometimes. and it's a shame if the
search engines can't find and point to them.

I am thinking of a fifth solution, and would like your opinion.

5. only if useragent is a search engine crawler,
a. turn off comment paging on the main permalink
a. 301 redirect the pages with older comments to the main permalink,
yet maintaining the #comment-id.

Which one do you think would work best?

W
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: How to number the paged comments in theme Was: Tutorial for custom Walker_Comment ?

2009-11-08T10:48:39Z

Buggers! get_comment_pages_count() returns more than 1 even if the
get_option('page_comments') setting is off. Therefore I gotta check
both conditions.

Reference: See http://phpxref.ftwr.co.uk/wordpress/wp-includes/comment.php.source.html#l588
.

A tip to anyone who is off to number the paged comments, too: <ol
start> only works with the "older comments at the top" setting,
because this tag doesn't do reverse numbering.

2009/11/5 William Canino <william.canino@...>:

>>> It accepts echo=false without any problem.
>
> Yes it does. However, I may end up using ( get_comment_pages_count() >
> 1 ) as it is more good-looking. That leaves me with the other
> quandary:
>
>> 1. My theme has no nested comments, but uses <ol> instead of <ul>
>>
>> How do I number the paged comments (<ol start="?"> to maintain comment
>> numbering. For example, if I chose 10 comments per page, the comments
>> at page two will start at 11. How do I get that 11?
>
> Do you think
>
> <ol start="<?php echo ( get_query_var('cpage') - 1 ) *
> get_query_var('comments_per_page') + 1 ?>">
>
> is okay and wouldn't cause problems or fail later?
>
> I am just being careful about these undocumented functions.
>
>
> 2009/11/5 Mike Little <mike@...>:
>> 2009/11/5 Andrew Nacin <anacin@...>
>>
>>> >
>>> > I don't believe that will work: the default comment_walker *always*
>>> echoes.
>>> >
>>>
>>> #10948 is for wp_list_comments()... paginate_comments_links() only relies
>>> on
>>> the walker to determine the number of pages required (and even then only
>>> when threading is on, otherwise it uses $wp_query). It accepts echo=false
>>> without any problem.
>>>
>>>
>> Doh! That's what I get for not reading things properly, thanks for
>> clarifying that.
>>
>> Mike
>> --
>> Mike Little
>> http://zed1.com/
>> _______________________________________________
>> wp-hackers mailing list
>> wp-hackers@...
>> http://lists.automattic.com/mailman/listinfo/wp-hackers
>>
>

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: custom Edit Pages screens

2009-11-08T08:33:17Z

On Sat, Nov 7, 2009 at 4:11 PM, Steve Taylor <steve@...> wrote:
> After looking into edit-pages.php for a while, I can't see an obvious
> way to use this code (hooks, includes, whatever). I'm heading towards
> copying it wholesale and tweaking. Anyone got a better idea?

I have to recommend the Pagemash plugin:
http://wordpress.org/extend/plugins/pagemash/

It might not be the best solution for your particular situation since
it puts all pages on one screen, but if your browser can handle it its
incredibly powerful. IMHO its 'the missing page management tool' for
people who have a complex hierarchy, and if it ever breaks you're not
really any worse off than before, it just gives you a better way to
control things than Pages > Edit.

--
Jeremy Clarke | http://jeremyclarke.org
Code and Design | http://globalvoicesonline.org
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: Why strings aren't translated here?

2009-11-08T04:42:23Z

I solved this by placing another load_plugin_textdomain function in function
that is run on register_activation_hook. That way string is localized on
activation of plugin.

For second string I followed your advice and replaced variable with
function, and string is localized in function.

Thank you for your help.

2009/11/2 Otto <otto@...>

> On Fri, Oct 30, 2009 at 3:20 PM, Milan Dinić <liste@...> wrote:
> > Now I tried what you suggested ( $gse_options['tip_text'] =
> sprintf(__("It
> > seems that ... ) but it still doesn't translate that string. Maybe is
> > problem because it is run in register_activation_hook.
>
> Yes, that is indeed your problem. Or, rather, the lack of the init is
> your problem.
>
> When the activation hook fires, your plugin has just been included.
> Init occurred before that happened. So your init doesn't get run, and
> thus your text domain never gets loaded before you try to start
> translating things. You need to load the text domain before you use
> translation functions.
>
>
> -Otto
> Sent from Memphis, TN, United States
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers
>

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: custom Edit Pages screens

2009-11-07T14:01:06Z

You can add a ?page_parent=124 and then hook into 'pre_get_posts' and add
that as a query_var.

The only roadblock is displaying the filter links. You'll probably have to
use JS for that.

--
http://scribu.net
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

custom Edit Pages screens

2009-11-07T13:11:45Z

I'm working with a site with a lot of pages, some sectioned off into
distinct areas. It's becoming unmanageable to work with a specific
section, tabbing to the right page of the Edit Pages list all the time
- and it'd be unmanageable in a different way if I increased or
removed the pages-per-screen limit.

I thought it'd be good to add some custom Edit Pages screens to the
Pages menu in admin, each one only showing descendents of particular
pages that are the parents for separate sections of the site.

After looking into edit-pages.php for a while, I can't see an obvious
way to use this code (hooks, includes, whatever). I'm heading towards
copying it wholesale and tweaking. Anyone got a better idea?

thanks,

Steve Taylor
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: Bug in automatic/ftp plugin update

2009-11-06T09:31:16Z

> Better open a new ticket here (if not already submitted):
> http://core.trac.wordpress.org/
>
>> Hi,
>>
>> Sorry if this isn't the right place, or if it is already fixed.
>>
>> Just a minor spelling error ;-)

Meant to mention this earlier, But Andrew Ozz saw this message and
already committed the fix.

http://core.trac.wordpress.org/changeset/12152

--
Matt Martz
matt@...
http://sivel.net/
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: Bug in automatic/ftp plugin update

2009-11-06T09:20:16Z

Better open a new ticket here (if not already submitted):
http://core.trac.wordpress.org/

On 06.11.2009 10:24, Harald Nesland wrote:

> Hi,
>
> Sorry if this isn't the right place, or if it is already fixed.
>
> Just a minor spelling error ;-)
>
>
> Index: wp-admin/includes/file.php
> ===================================================================
> --- wp-admin/includes/file.php (revision 12151)
> +++ wp-admin/includes/file.php (working copy)
> @@ -840,8 +840,8 @@
> $disabled = defined('FTP_SSL') || defined('FTP_SSH') ? '' : '
> disabled="disabled"';
>
> foreach ( $types as $name => $text ) : ?>
> - <label for="<?php echo esc_atr($name) ?>">
> - <input type="radio" name="connection_type" id="<?php echo
> esc_atr($name) ?>" value="<?php echo esc_atr($name) ?>" <?php
> checked($name, $connection_type); echo $disabled; ?>/>
> + <label for="<?php echo esc_attr($name) ?>">
> + <input type="radio" name="connection_type" id="<?php echo
> esc_attr($name) ?>" value="<?php echo esc_attr($name) ?>" <?php
> checked($name, $connection_type); echo $disabled; ?>/>
> <?php echo $text ?>
> </label>
> <?php endforeach; ?>
>
>
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers
>

--
Regards,
Oliver Schlöbe

http://wpseek.com/
http://wpworldmap.net/
http://www.schloebe.de/firefox-extensions/wordpress-helper/#english

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Bug in automatic/ftp plugin update

2009-11-06T01:24:00Z

Hi,

Sorry if this isn't the right place, or if it is already fixed.

Just a minor spelling error ;-)

Index: wp-admin/includes/file.php
===================================================================
--- wp-admin/includes/file.php (revision 12151)
+++ wp-admin/includes/file.php (working copy)
@@ -840,8 +840,8 @@
$disabled = defined('FTP_SSL') || defined('FTP_SSH') ? '' : '
disabled="disabled"';

foreach ( $types as $name => $text ) : ?>
- <label for="<?php echo esc_atr($name) ?>">
- <input type="radio" name="connection_type" id="<?php
echo esc_atr($name) ?>" value="<?php echo esc_atr($name) ?>" <?php
checked($name, $connection_type); echo $disabled; ?>/>
+ <label for="<?php echo esc_attr($name) ?>">
+ <input type="radio" name="connection_type" id="<?php
echo esc_attr($name) ?>" value="<?php echo esc_attr($name) ?>" <?php
checked($name, $connection_type); echo $disabled; ?>/>
<?php echo $text ?>
</label>
<?php endforeach; ?>

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: plugin compatability

2009-11-05T15:43:09Z

On Nov 5, 2009, at 5:34 PM, Ade Walker wrote:

> you will see (at the time of writing this) that 4% of votes say
> "Broken". How am I,
> the "average plugin searcher" to interpret this? That the plugin is
> no good?

On Nov 5, 2009, at 5:50 PM, Ken Newman wrote:

> but as I understand it, Each version of wordpress, you get another
> fresh start! :) how great is that?

It seems to me that this was the exact reason it rolls to 0% on a new
version, is a good enough solution to the (valid) concerns raised by
Ade.

Besides, I'm not that attached to folks using my plugins... I release
them so that I can take advantage of the auto-update feature, else I'd
just leave them on my site and use my own source control server to
package them for download. So if less than 100% turns them off from
trying it, I won't be upset.

- Eric Marden
__________________________________
http://xentek.net/code/wordpress/

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: How to number the paged comments in theme Was: Tutorial for custom Walker_Comment ?

2009-11-05T15:11:29Z

>> It accepts echo=false without any problem.

Yes it does. However, I may end up using ( get_comment_pages_count() >
1 ) as it is more good-looking. That leaves me with the other
quandary:

> 1. My theme has no nested comments, but uses <ol> instead of <ul>
>
> How do I number the paged comments (<ol start="?"> to maintain comment
> numbering. For example, if I chose 10 comments per page, the comments
> at page two will start at 11. How do I get that 11?

Do you think

<ol start="<?php echo ( get_query_var('cpage') - 1 ) *
get_query_var('comments_per_page') + 1 ?>">

is okay and wouldn't cause problems or fail later?

I am just being careful about these undocumented functions.

2009/11/5 Mike Little <mike@...>:

> 2009/11/5 Andrew Nacin <anacin@...>
>
>> >
>> > I don't believe that will work: the default comment_walker *always*
>> echoes.
>> >
>>
>> #10948 is for wp_list_comments()... paginate_comments_links() only relies
>> on
>> the walker to determine the number of pages required (and even then only
>> when threading is on, otherwise it uses $wp_query). It accepts echo=false
>> without any problem.
>>
>>
> Doh! That's what I get for not reading things properly, thanks for
> clarifying that.
>
> Mike
> --
> Mike Little
> http://zed1.com/
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers
>

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: plugin compatability

2009-11-05T14:50:27Z

On 11/5/2009 5:34 PM, Ade Walker wrote:

> I have two problems with the new compatibility vote system:
>
> 1. What does a less than 100% "Works" compatibility rating actually mean to
> the average plugin "searcher"? For example, go to
> http://wordpress.org/extend/plugins/google-sitemap-generator/ and you will
> see (at the time of writing this) that 4% of votes say "Broken". How am I,
> the "average plugin searcher" to interpret this? That the plugin is no good?
> That the plugin may not work? That it only works 96% of the time? It doesn't
> mean any of these, of course, but I'm not sure that such a rating helps me
> (the less tech-savvy user) to decide whether to use the plugin or not.
>

1. Basically, your concern is one of display UI on the wordpress.org
site. You'd rather them make the consensus more obvious. OK, so switch
the display to read "Preliminary feedback: 96%" in small, then a big ol'
fat "Consensus: GOOD TO GO!"

That should solve that problem.

Seriously, WordPress users are a pretty competent and fairly intelligent
group. I'm sure that the 4% isn't turning many people off this plugin.

2. Undoing damage done. Yeah, this might be a concern, but as I
understand it, Each version of wordpress, you get another fresh start!
:) how great is that?
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: plugin compatability

2009-11-05T14:34:17Z

I have two problems with the new compatibility vote system:

1. What does a less than 100% "Works" compatibility rating actually mean to
the average plugin "searcher"? For example, go to
http://wordpress.org/extend/plugins/google-sitemap-generator/ and you will
see (at the time of writing this) that 4% of votes say "Broken". How am I,
the "average plugin searcher" to interpret this? That the plugin is no good?
That the plugin may not work? That it only works 96% of the time? It doesn't
mean any of these, of course, but I'm not sure that such a rating helps me
(the less tech-savvy user) to decide whether to use the plugin or not.

2. As mentioned by elflop, there is no way of knowing a voter's reason for
marking a plugin as Broken. Is it really broken, ie throws an error, or is
it just incompatible with another plugin? Or is the voter disatisfied with
the functionality? Or did he/she just get out of the wrong side of bed that
day? In other words, is the "customer" always right and, when he isn't, how
does the developer undo the damage which has been done?

On balance, I think it's a nice idea, with potential benefits of encouraging
authors of neglected plugins to resume development or, at least, to update
the readme.txt file. However, I think in reality there will be a large
number of plugins - including popular and generally well though-of plugins
(like the example I mentioned above) - having less than 100% compatibility
ratings. And I don't think anyone, whether end-user or developer, benefits
from this. :-/

2009/11/5 <elflop@...>

> Sorry for sending this to the list, not sure where it should go.
>
> The new plugin compatibility section on a plugin page. As suspected I have
> recently had someone mark mine as 'broken' with the latest version of WP.
> Luckily others have marked it as 'Works'. I knew that at some point this
> would happen, and feel that it isn't good for plugins authors.
>
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: plugin compatability

2009-11-05T14:01:38Z

I was thinking the same thing...

One thing to take a cue from the App Store on is suggested reviews at
> time of plugin deactivation. If you delete an app from your iPhone, a
> dialog pops up and says "Would you like to review this app before
> deleting?" or somesuch, giving users an opportunity to register their
> complaints in a 1-5 star fashion.
>

Lew Ayotte
Full Throttle Development, LLC
706.363.0688
478.246.4627
lew@...
http://fullthrottledevelopment.com
http://twitter.com/full_throttle
http://twitter.com/lewayotte

On Thu, Nov 5, 2009 at 2:21 PM, Doug Stewart <zamoose@...> wrote:

> This is the same set of problems developers with apps in the Apple App
> Store encounter, as well as Amazon. There's no real accountability
> for reviews in a direct sense. Amazon, at least, allows for 3rd
> parties to mark reviews "helpful" or "unhelpful" which seems to factor
> into which reviews the Amazon site presents as [semi-]authoritative.
>
> One thing to take a cue from the App Store on is suggested reviews at
> time of plugin deactivation. If you delete an app from your iPhone, a
> dialog pops up and says "Would you like to review this app before
> deleting?" or somesuch, giving users an opportunity to register their
> complaints in a 1-5 star fashion.
>
> I've actually seen a couple of WP plugins that seem to do something
> similar -- Woopra comes readily to mind as one, as does Intense
> Debate.
>
> So I guess I'm saying that the problems are not insurmountable but do
> bear some special consideration prior to implementation time,
> particularly in accounting for potential griefers.
>
> --
> -Doug
> http://literalbarrage.org/blog/
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers
>

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: Delete Plugin on SVN please

2009-11-05T13:57:23Z

I guess this is semi-related to cleanup...

We've had a developer who tried to submit a plugin on six different
occassions but it never seemed to work. I tried on his behalf (with my
account info) and it worked right off but it gave the plugin name a "-7"
appended as in (http://wordpress.org/extend/plugins/ft-facepress-7/)

I imagine 1 - 6 are in some DB somewhere and if someone were to create
another named "ft-facepress" it would be ft-facepress-8... I guess.

Lew Ayotte
Full Throttle Development, LLC
706.363.0688
478.246.4627
lew@...
http://fullthrottledevelopment.com
http://twitter.com/full_throttle
http://twitter.com/lewayotte

On Thu, Nov 5, 2009 at 11:44 AM, Eric Marden <wp@...> wrote:

> On Nov 4, 2009, at 4:19 PM, Chris Jean wrote:
>
> then invariably get something that swamps me: a big project at work, some
>> personal stuff is happening that takes away my time, etc. Then when I'm able
>> to come back to the project, days have gone by and I realize something.
>> Since the repo system lists new projects based upon the day that the repo
>> was approved and not based upon the first version being submitted, my great
>> new plugin idea will be quickly lost due to the lack of attention on the new
>> plugin list. In other words, if I wait 10 days from repo approval to push up
>> the first version, then people will have to go 10 days back in the new
>> plugin list to find my plugin. This realization has at times caused me to
>> lose interest in a project.
>>
>
>
> You need a better strategy. You can announce new plugins (and updated
> plugins) on Web Log Tools collection, which will get your plugin a lot more
> attention then I've ever got on the Plugin DB, even when I committed v1 as
> soon as I got access.
>
>
>
>
>
> - Eric Marden
> __________________________________
> http://xentek.net/code/wordpress/
>
>
>
>
>
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers
>

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: plugin compatability

2009-11-05T12:40:19Z

First of all.

It is possible that in-the-admin plugin compatibility voting will come
in a future version but it's not something for the current version of
WordPress.

We need to see how the voting goes and wait for us to get some data to
look at.

On 5 Nov 2009, at 19:21, Doug Stewart wrote:

> One thing to take a cue from the App Store on is suggested reviews at
> time of plugin deactivation. If you delete an app from your iPhone, a
> dialog pops up and says "Would you like to review this app before
> deleting?" or somesuch, giving users an opportunity to register their
> complaints in a 1-5 star fashion.

I think this is a really bad idea personally.

This is like only asking your unsatisfied customers for a review.

You will likely only get negative low scoring feedback - yes some of
it will be constructive and helpful.

The opportunity cost of installing a free app is so low that you are
much more likely to do it even if it in no way fits your needs and
therefore also much more likely to delete it as it cost you nothing.

westi
--
Peter Westwood
http://blog.ftwr.co.uk | http://westi.wordpress.com
C53C F8FC 8796 8508 88D6 C950 54F4 5DCD A834 01C5

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: plugin compatability

2009-11-05T12:13:51Z

On Nov 5, 2009, at 11:46 AM, Ken Newman wrote:

> We have to convince people that this resource is worth the effort of
> maintaining it. An optional comment box for developer messages is
> about the only useful thing suggested so far. Either crowd sourcing
> works here or it doesn't.

I agree with Ken here. I've been voting on both my own plugins and
those I use all the time. Put the effort in, and it will be useful.
Adding a comment box would be helpful at this point, but the real fun
will come when you can do this in wp-admin/plugins.php

- Eric Marden
__________________________________
http://xentek.net/code/wordpress/

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: Get authors for post category

2009-11-05T11:35:38Z

That's what I was afraid of :-). Thanks.

-Jeff

On Nov 5, 2009, at 10:16 AM, scribu wrote:

> There is no "easy" way:
>
> $post_ids = implode(',', get_objects_in_term($term_id, 'category'));
>
> $authors = $wpdb->get_results("
> SELECT DISTINCT *
> FROM $wpdb->users u
> JOIN $wpdb->posts p ON (p.author_id = u.ID)
> WHERE p.ID IN ('$post_ids')
> ");
>
>
> --
> http://scribu.net
> _______________________________________________
> wp-hackers mailing list
> wp-hackers@...
> http://lists.automattic.com/mailman/listinfo/wp-hackers

_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: plugin compatability

2009-11-05T11:21:09Z

This is the same set of problems developers with apps in the Apple App
Store encounter, as well as Amazon. There's no real accountability
for reviews in a direct sense. Amazon, at least, allows for 3rd
parties to mark reviews "helpful" or "unhelpful" which seems to factor
into which reviews the Amazon site presents as [semi-]authoritative.

One thing to take a cue from the App Store on is suggested reviews at
time of plugin deactivation. If you delete an app from your iPhone, a
dialog pops up and says "Would you like to review this app before
deleting?" or somesuch, giving users an opportunity to register their
complaints in a 1-5 star fashion.

I've actually seen a couple of WP plugins that seem to do something
similar -- Woopra comes readily to mind as one, as does Intense
Debate.

So I guess I'm saying that the problems are not insurmountable but do
bear some special consideration prior to implementation time,
particularly in accounting for potential griefers.

--
-Doug
http://literalbarrage.org/blog/
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers

Re: plugin compatability

2009-11-05T10:38:04Z

On Thu, Nov 5, 2009 at 5:58 PM, Mohammad Jangda <batmoo@...> wrote:

> +1. Ideally, we should give users the option to specify the versions of
> PHP,
> MySQL, browser, etc. that they're using. That would be an amazing help for
> plugin developers. But, at the very least, I think a free-form text field
> to
> provide some details about what's broken would also be a good alternative.
>

All the additional (non-sensitive) info could be collected automatically
when the voting is done from the user's install. That would be really neat.

--
http://scribu.net
_______________________________________________
wp-hackers mailing list
wp-hackers@...
http://lists.automattic.com/mailman/listinfo/wp-hackers